alpmestan (Alp Mestanogullari)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 5 2014, 10:16 AM (214 w, 6 d)
Roles
Administrator

Recent Activity

Tue, Jul 10

alpmestan accepted D4947: Run the renamed source plugin after each HsGroup.

Looks good.

Tue, Jul 10, 9:14 AM
alpmestan accepted D4946: Release notes about source plugins.
Tue, Jul 10, 9:14 AM

Mon, Jul 9

alpmestan added a comment to D4904: Add "make ghci-start", which runs a ghci that can load compiler + ghci.

Would we perhaps want the ghci scripts to live somewhere else than at the top level (say a scripts/ directory) ?

Mon, Jul 9, 12:47 PM
alpmestan accepted D4927: Export findImportUsage and ImportDeclUsage.
Mon, Jul 9, 12:43 PM

Fri, Jul 6

alpmestan added a comment to D4937: Plugin dependency information is stored separately.

Did you test this causes recompilation when the plugin module changes?

Fri, Jul 6, 11:04 AM

Thu, Jul 5

alpmestan accepted D4859: [WIP] testsuite: Add tests for #15270.
Thu, Jul 5, 6:01 AM
alpmestan requested changes to D4921: testsuite: Add test for #12449.

Don't we want to expect this test to be broken? This is otherwise makig CI fail.

Thu, Jul 5, 4:05 AM
alpmestan accepted D4933: Mark AutoDeriveTypeable as deprecated.
Thu, Jul 5, 1:31 AM

Wed, Jul 4

alpmestan accepted D4924: Add a strict version of foldMap to Foldable.

I was confused initially by the fact that the revision title talks about adding foldMap' while in fact this changes an existing implementation. LGTM.

Wed, Jul 4, 10:30 AM
alpmestan requested changes to D4927: Export findImportUsage and ImportDeclUsage.

Just one tiny request, to get rid of a warning we can easily avoid. Other than that, looks good to me.

Wed, Jul 4, 10:30 AM

Thu, Jun 28

alpmestan accepted D4897: circleci: Detect core count.

It looks like switching to the ghc-diffs repo you created as a "staging" one for the Circle CI builds did the trick. Not sure how important the core detection logic was in making this work, but I suppose it is anyway better not to just blindly run with -j9.

Thu, Jun 28, 4:48 PM

Wed, Jun 27

alpmestan added a comment to D4897: circleci: Detect core count.

The build got killed: https://circleci.com/gh/alpmestan/ghc/15

Wed, Jun 27, 1:33 AM

Tue, Jun 26

alpmestan added a comment to D4897: circleci: Detect core count.

I triggered a build against my circle ci integration, through phab's build step interface. Let's see how it goes: https://circleci.com/gh/alpmestan/ghc/15 (previously, it'd just blow up, trying to build and run things with -j9 on a 2 core box with 4GB of RAM).

Tue, Jun 26, 8:21 PM

Jun 16 2018

alpmestan added a comment to D4756: Use /usr/bin/env to get perl path instead of using a hardcoded path..

Thanks! This was quite annoying when I implemented a nofib rule in hadrian.

Jun 16 2018, 6:50 PM

Jun 3 2018

alpmestan accepted D4782: Provide `getWithUserData` and `putWithUserData`.

This is great. Hiding the whole symbol table / dictionary business from the user when he/she does not have to care about it certainly is an improvement from my point of view and I in fact could use this patch right now for a branch I'm working on.

Jun 3 2018, 6:16 PM

May 25 2018

alpmestan created D4735: Update repository sub-dir for ghc-heap in ghc-heap.cabal.in.
May 25 2018, 7:21 AM

May 23 2018

alpmestan created D4725: T14732 now passes with the profasm way.
May 23 2018, 12:25 PM

May 20 2018

alpmestan created D4712: Another batch of './validation --slow' tweaks.
May 20 2018, 5:13 PM

May 14 2018

alpmestan added a comment to D4636: Fix another batch of `./validate --slow` failures.

The reason that validate --slow might not be exactly the same as what we see in CI is that validate --slow enables DEBUG for stage 2, whereas we don't do that in CI because we're building binaries for distribution and DEBUG would make them slower. The warning messages you're seeing in the Cabal tests are only emitted when the compiler is built with DEBUG. (apologies if this was pointed out elsewhere, I haven't read all the surrounding tickets here)

May 14 2018, 3:06 AM

May 11 2018

alpmestan requested review of D4636: Fix another batch of `./validate --slow` failures.
May 11 2018, 11:06 PM
alpmestan created D4686: Expand $tooldir in ghc --info output.
May 11 2018, 6:39 AM
alpmestan requested changes to D4667: Fix testsuite runs by expanding tooldir.

OK, let's see what CI says with D4686. I will also run ./validate --fast in a Windows VM. I'm just using "changes requested" as an "on hold" tag.

May 11 2018, 6:39 AM
alpmestan accepted D4667: Fix testsuite runs by expanding tooldir.

I ended up writing a similar patch (that adds a field to Settings, to keep things pure), before stumbling on the phab notification for this diff (sorry). I don't mind this use of unsafePerformIO, even though I tend to prefer code that doesn't use it. This should regardless definitely fix the problem.

May 11 2018, 5:59 AM

Apr 18 2018

alpmestan accepted D4603: users-guide: Override mathjax_path.
Apr 18 2018, 5:18 AM

Apr 17 2018

alpmestan requested review of D4598: Introduce a $tooldir variable for nicer toolchain detection on Windows.
Apr 17 2018, 8:31 AM

Apr 16 2018

alpmestan added a comment to D4354: CircleCI: Run nightly validate --slow.

Yes, I can. I guess I can turn my attention to this as soon as I'm done with the unexpected failures I'm seeing when running ./validate --slow. We'll still have the stats failures left to handle.

Apr 16 2018, 11:27 AM

Apr 11 2018

alpmestan accepted D4585: Omit ways depending on rts flags for #12870 related tests..

Thanks! This will fix the failures I'm seeing.

Apr 11 2018, 11:22 PM
alpmestan added inline comments to D4546: tweak many test expectations, towards a green `./validate --slow`.
Apr 11 2018, 5:44 AM

Mar 31 2018

alpmestan accepted D4543: testsuite: Add test for negative sqrts (#10010).
Mar 31 2018, 2:00 PM
alpmestan requested review of D4546: tweak many test expectations, towards a green `./validate --slow`.
Mar 31 2018, 10:32 AM

Mar 27 2018

alpmestan accepted D4534: testsuite: Add test for #14965.

Quite intriguing. So, as Simon suggests in Trac #14965, this indeed got fixed between 8.4.1 and 8.4.2? (judging from the green CI here)

Mar 27 2018, 3:58 AM

Mar 21 2018

alpmestan accepted D4512: testsuite: Add test for #14925.

Looks good to me. I restarted the windows build as it was failing with what looks like a transient error:

Mar 21 2018, 6:11 AM
alpmestan accepted D4518: testsuite: Add test for #14931.

LGTM. This test _is_ executed by harbormaster right?

Mar 21 2018, 4:42 AM

Mar 2 2018

alpmestan added a comment to D4459: GHCi info: Use src file for cache invalidation.

Looks good. This should be a drastical improvement for situations like the one described in #12706.

Mar 2 2018, 5:51 AM

Feb 28 2018

alpmestan added a comment to D4453: 8.4: bump cabal to 2.2 (with ghc-cabal).

More details on why Herbert's fix is necessary in the ticket.

Feb 28 2018, 7:24 AM

Feb 27 2018

alpmestan added a comment to D4453: 8.4: bump cabal to 2.2 (with ghc-cabal).

hvr found that it's enough to build & run the following trivial program with stage 1:

Feb 27 2018, 9:51 AM

Feb 25 2018

alpmestan added a comment to D4447: Add Applicative, Semigroup, and Monoid instances in GHC.Generics.

Just for the record, this has been discussed on the libraries@ mailing list here. The patch looks good to me.

Feb 25 2018, 5:34 AM

Feb 14 2018

alpmestan created D4409: rts.cabal.in: advertise profiling flavours of libraries, behind a flag.
Feb 14 2018, 8:01 AM
alpmestan added a comment to D4403: Make accumArray and accum stricter.

Hmm, CI is now failing because of:

Feb 14 2018, 2:59 AM

Feb 13 2018

alpmestan added inline comments to D4403: Make accumArray and accum stricter.
Feb 13 2018, 11:40 AM
alpmestan added a comment to D4406: Update .cabal files for Cabal 2.1.

For the record, I was bitten by a parse error in utils/hp2ps/hp2ps.cabal when building with hadrian a little earlier and this patch fixed it.

Feb 13 2018, 7:55 AM

Jan 30 2018

alpmestan abandoned D4251: ship a Makefile to be used by hadrian-based bindists for 'make install'.

I think I'll be able to do without the need to ship this with ghc, which is in my opinion much, much better.

Jan 30 2018, 7:17 AM
alpmestan added a comment to D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.

Sorry for the lack of reactivity on this diff, I somehow didn't get the notifications for all the comments.

Jan 30 2018, 7:13 AM

Jan 16 2018

alpmestan updated the summary of D4317: tentative improvement to callstack docs.
Jan 16 2018, 11:02 AM
alpmestan created D4317: tentative improvement to callstack docs.
Jan 16 2018, 11:01 AM

Dec 6 2017

alpmestan added inline comments to D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
Dec 6 2017, 12:58 PM

Dec 5 2017

alpmestan added inline comments to D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
Dec 5 2017, 9:51 AM
alpmestan updated the summary of D4251: ship a Makefile to be used by hadrian-based bindists for 'make install'.
Dec 5 2017, 8:31 AM
alpmestan added a comment to D4251: ship a Makefile to be used by hadrian-based bindists for 'make install'.

We could however also just add the Makefile from this diff to master, and just use it in our hadrian branch to complete the binary dist work. But at least we can discuss it.

Dec 5 2017, 8:30 AM
alpmestan added a comment to D4251: ship a Makefile to be used by hadrian-based bindists for 'make install'.

The hadrian commit will have to be changed once https://github.com/angerman/hadrian/pull/1 is merged. This was meant as a diff against Moritz's branch though, not sure that's what happened.

Dec 5 2017, 8:26 AM
alpmestan created D4251: ship a Makefile to be used by hadrian-based bindists for 'make install'.
Dec 5 2017, 8:25 AM

Dec 1 2017

alpmestan updated the diff for D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
  • conditionals for redundant import warning
Dec 1 2017, 5:11 AM
alpmestan updated the diff for D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
  • redundant imports
Dec 1 2017, 3:12 AM

Nov 30 2017

alpmestan updated the diff for D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
  • fix the windows, base >= 4.11 implementation of getBaseDir
Nov 30 2017, 10:39 AM
alpmestan updated the diff for D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
  • SysTools.BaseDir: import getExecutablePath on Windows too, fix rootDir typo
Nov 30 2017, 2:50 AM

Nov 29 2017

alpmestan added a comment to D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.

I've addressed the feedback and rebased on top of master. Let's see if harbomaster is happy with that.

Nov 29 2017, 9:34 AM
alpmestan updated the diff for D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
  • factor out 'rootDir'
  • some explanatory comments
  • simplify rootDir
  • import getExecutable on Windows too, when when can use it
  • fix redundant imports
  • rebase on top of master
Nov 29 2017, 9:34 AM
alpmestan updated the diff for D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
  • fix redundant imports
Nov 29 2017, 6:50 AM
alpmestan updated the diff for D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
  • simplify rootDir
  • import getExecutablePath on Windows too
Nov 29 2017, 4:40 AM

Nov 24 2017

alpmestan added inline comments to D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
Nov 24 2017, 4:46 AM
alpmestan added a comment to D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.

Added some comments and asked a question to @Phyx about an opportunity for simplifying the code in SysTools.hs a little bit.

Nov 24 2017, 4:23 AM
alpmestan updated the diff for D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
  • some explanatory comments
Nov 24 2017, 4:18 AM
alpmestan added a comment to D4227: follow symlinks in the Win32 code for System.Environment.getExecutablePath.

Added a changelog entry for base.

Nov 24 2017, 3:57 AM
alpmestan updated the diff for D4227: follow symlinks in the Win32 code for System.Environment.getExecutablePath.
  • add changelog entry
Nov 24 2017, 3:55 AM
alpmestan added inline comments to D4227: follow symlinks in the Win32 code for System.Environment.getExecutablePath.
Nov 24 2017, 3:47 AM
alpmestan updated the diff for D4227: follow symlinks in the Win32 code for System.Environment.getExecutablePath.
  • address Phyx's comments
Nov 24 2017, 3:42 AM

Nov 23 2017

alpmestan updated the diff for D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
  • factor out 'rootDir'
Nov 23 2017, 10:46 AM
alpmestan created D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
Nov 23 2017, 10:39 AM
alpmestan added inline comments to D4227: follow symlinks in the Win32 code for System.Environment.getExecutablePath.
Nov 23 2017, 9:12 AM
alpmestan updated the diff for D4227: follow symlinks in the Win32 code for System.Environment.getExecutablePath.
  • document the new behaviour of 'getExecutablePath' on Windows
Nov 23 2017, 9:11 AM
alpmestan added reviewers for D4227: follow symlinks in the Win32 code for System.Environment.getExecutablePath: hvr, goldfire.
Nov 23 2017, 8:17 AM
alpmestan added inline comments to D4227: follow symlinks in the Win32 code for System.Environment.getExecutablePath.
Nov 23 2017, 7:57 AM
alpmestan removed reviewers for D4227: follow symlinks in the Win32 code for System.Environment.getExecutablePath: hvr, goldfire.
Nov 23 2017, 7:45 AM
alpmestan created D4227: follow symlinks in the Win32 code for System.Environment.getExecutablePath.
Nov 23 2017, 7:44 AM

Dec 5 2014

alpmestan committed rNIXPKGSed5349952a79: add a nix expression for the (haskell) 'managed' package (authored by alpmestan).
add a nix expression for the (haskell) 'managed' package
Dec 5 2014, 8:11 PM
alpmestan committed rNIXPKGSa501db1b7ec8: servant-scotty/default.nix: switch to version 0.1.1 which relaxes the bounds on… (authored by alpmestan).
servant-scotty/default.nix: switch to version 0.1.1 which relaxes the bounds on…
Dec 5 2014, 8:01 PM
alpmestan committed rNIXPKGS940a918825bc: fix a small typo (authored by alpmestan).
fix a small typo
Dec 5 2014, 8:01 PM
alpmestan committed rNIXPKGS47519e732b2d: use camelCase instead of dashes for servant package names in haskell-packages. (authored by alpmestan).
use camelCase instead of dashes for servant package names in haskell-packages.
Dec 5 2014, 8:01 PM
alpmestan committed rNIXPKGS9dd3963b4dbd: rename nix files to default.nix for all servant pkgs (authored by alpmestan).
rename nix files to default.nix for all servant pkgs
Dec 5 2014, 8:01 PM
alpmestan committed rNIXPKGS6e2e58ea2eae: add the servant (haskell) packages to nixpkgs (authored by alpmestan).
add the servant (haskell) packages to nixpkgs
Dec 5 2014, 8:01 PM