alpmestan (Alp Mestanogullari)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 5 2014, 10:16 AM (259 w, 1 d)
Roles
Administrator

Recent Activity

Yesterday

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC04b4b98447c3: add an --hadrian mode to ./validate (authored by alpmestan).
add an --hadrian mode to ./validate
Thu, May 23, 9:36 PM

Wed, May 22

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC2c15b85eb254: Hadrian: add --test-root-dirs, to only run specific directories of tests (authored by alpmestan).
Hadrian: add --test-root-dirs, to only run specific directories of tests
Wed, May 22, 3:56 PM

Tue, May 21

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCe32c30caf485: distrib/configure.ac.in: remove mention to 'settings', since settings.in is gone (authored by alpmestan).
distrib/configure.ac.in: remove mention to 'settings', since settings.in is gone
Tue, May 21, 4:19 PM

Tue, May 7

alpmestan committed rGHCba0aed2e7834: Hadrian: override $(ghc-config-mk), to prevent redundant config generation (authored by alpmestan).
Hadrian: override $(ghc-config-mk), to prevent redundant config generation
Tue, May 7, 5:36 AM

Mon, May 6

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCe172a6d127a6: Enable external interpreter when TH is requested but no internal interpreter is… (authored by alpmestan).
Enable external interpreter when TH is requested but no internal interpreter is…
Mon, May 6, 2:18 PM

Tue, Apr 30

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC37a4fd9715de: Build Hadrian with -Werror in the 'ghc-in-ghci' CI job (authored by alpmestan).
Build Hadrian with -Werror in the 'ghc-in-ghci' CI job
Tue, Apr 30, 7:41 PM

Apr 22 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC51655fd8a442: Hadrian: use the testsuite driver's config.haddock arg more correctly (authored by alpmestan).
Hadrian: use the testsuite driver's config.haddock arg more correctly
Apr 22 2019, 1:50 PM

Apr 18 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC5988f17a799b: Hadrian: fix the value we pass to the test driver for config.compiler_debugged (authored by alpmestan).
Hadrian: fix the value we pass to the test driver for config.compiler_debugged
Apr 18 2019, 9:52 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC4c8a67a4b025: Hadrian: fix ghcDebugged and document it (authored by alpmestan).
Hadrian: fix ghcDebugged and document it
Apr 18 2019, 7:24 AM

Apr 14 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC1825f50d1736: Hadrian: don't accept p_dyn for executables, to fix --flavour=prof (authored by alpmestan).
Hadrian: don't accept p_dyn for executables, to fix --flavour=prof
Apr 14 2019, 8:13 AM

Apr 12 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCf4b5a6c040ab: Hadrian: document -a/--test-accept (authored by alpmestan).
Hadrian: document -a/--test-accept
Apr 12 2019, 1:54 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC3c759ced1c89: Hadrian: add a --test-accept/-a flag, to mimic 'make accept' (authored by alpmestan).
Hadrian: add a --test-accept/-a flag, to mimic 'make accept'
Apr 12 2019, 1:54 PM

Apr 2 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCfb12f53c2779: Hadrian: introduce an easy way for users to build with -split-sections (authored by alpmestan).
Hadrian: introduce an easy way for users to build with -split-sections
Apr 2 2019, 3:54 PM

Mar 13 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCcb17c2da1774: Hadrian: build (and retrieve) binary distributions in CI (authored by alpmestan).
Hadrian: build (and retrieve) binary distributions in CI
Mar 13 2019, 6:44 PM

Mar 9 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC48927a9a1e6b: Hadrian: various improvements around the 'test' rule (authored by alpmestan).
Hadrian: various improvements around the 'test' rule
Mar 9 2019, 1:11 AM

Mar 4 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCf77229e3c30f: detect 'autoreconf' path during configure, and use it in hadrian (authored by alpmestan).
detect 'autoreconf' path during configure, and use it in hadrian
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC9aa27273afdd: use --docs=no-sphinx in both Hadrian CI jobs (authored by alpmestan).
use --docs=no-sphinx in both Hadrian CI jobs
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC8442103aa575: Hadrian: introduce ways to skip some documentation targets (authored by alpmestan).
Hadrian: introduce ways to skip some documentation targets
Mar 4 2019, 3:09 PM

Jan 7 2019

alpmestan added a comment to D5409: Hadrian: support extra libraries + OSX rpath.

Is the patch on gitlab too? (for CI)

Jan 7 2019, 1:32 PM

Dec 21 2018

alpmestan added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 21 2018, 6:39 AM

Dec 20 2018

alpmestan added a comment to D5458: Hadrian: Add support for building Stage3.

@mpickering Great! This look very encouraging.

Dec 20 2018, 1:24 PM
alpmestan added a comment to D5458: Hadrian: Add support for building Stage3.
So I think that is all the packages?
Dec 20 2018, 10:48 AM
alpmestan requested changes to D5458: Hadrian: Add support for building Stage3.

This is looking pretty good. Besides Andrey's outstanding question, I made a suggestion and have one request to add a TODO.

Dec 20 2018, 10:40 AM

Dec 17 2018

alpmestan updated the diff for D5446: hadrian: introduce make-user-oriented docs.
  • address Andrey's feedback
Dec 17 2018, 5:38 AM

Dec 15 2018

alpmestan added a comment to D5446: hadrian: introduce make-user-oriented docs.

Some of your comments apply to the contents that was already there, and I don't feel like using this diff to freshen up the README entirely. I did remove things that were obviously outdated though. In particular, we haven't migrated some of the issues yet and we therefore don't have a trac ticket to point to yet.

Dec 15 2018, 3:19 AM

Dec 14 2018

alpmestan added a comment to D5454: Hadrian: introduce userDefaultFlavour, making default flavour overridable.

Github and Gitlab both render hadrian's hadrian/README.md as well as the more specific documents under hadrian/doc/, e.g https://github.com/ghc/ghc/tree/master/hadrian#hadrian or https://gitlab.staging.haskell.org/ghc/ghc/tree/master/hadrian#hadrian.

Dec 14 2018, 11:18 AM
alpmestan added a comment to D5454: Hadrian: introduce userDefaultFlavour, making default flavour overridable.

Thanks Alp, this will be useful. Please can we update the wiki page as well when this is merged.

Dec 14 2018, 11:12 AM
alpmestan created D5454: Hadrian: introduce userDefaultFlavour, making default flavour overridable.
Dec 14 2018, 8:13 AM

Dec 13 2018

alpmestan created D5446: hadrian: introduce make-user-oriented docs.
Dec 13 2018, 9:25 AM

Dec 11 2018

alpmestan added a comment to D5434: Hadrian: simple targets for building libraries and executables.

Added some documentation for those new targets and the error reporting @snowleopard requested for "stage 0 executables".

Dec 11 2018, 5:51 AM
alpmestan updated the diff for D5434: Hadrian: simple targets for building libraries and executables.
  • document the simple package targets, handle stage0 exes
Dec 11 2018, 5:50 AM
alpmestan added inline comments to D5434: Hadrian: simple targets for building libraries and executables.
Dec 11 2018, 5:24 AM
alpmestan added a comment to D5431: Hadrian: ability to run a subset of the testsuite.

I just updated the patch with a new file, hadrian/doc/testsuite.md, with a bunch of illustrated examples for most of the testsuite options (all the important ones anyway). And hadrian's readme now links to it in the testing section.

Dec 11 2018, 5:14 AM
alpmestan updated the diff for D5431: Hadrian: ability to run a subset of the testsuite.
  • in-tree documentation for the testsuite rule and its options
Dec 11 2018, 5:11 AM
alpmestan added a comment to D5434: Hadrian: simple targets for building libraries and executables.

Also, this should be documented too.

Dec 11 2018, 3:27 AM
alpmestan added a comment to D5431: Hadrian: ability to run a subset of the testsuite.

Hmm, right, well the quickstart page being on trac and with the move to gitlab, I guess it's not such a great idea to focus the documentation effort there anyway. It's just absolutely not the direction I've been taking in the past few months. I'll add a few words about what this patch allows in the README and then perhaps start thinking about enhancing the README and doc/ directory with the contents that I ended up putting in the quickstart page. This latter part would be in another patch though of course.

Dec 11 2018, 1:23 AM

Dec 10 2018

alpmestan added a comment to D5431: Hadrian: ability to run a subset of the testsuite.

However, we certainly need to document it somewhere.

Dec 10 2018, 3:21 PM
alpmestan created D5434: Hadrian: simple targets for building libraries and executables.
Dec 10 2018, 3:04 PM
alpmestan accepted D5430: Revert dynamically linking ghc..

This will do for fixing the build and will give us time to fix this all properly, including making use of platformSupportsSharedLibs and dynamicGhcPrograms in requiresDynamic.

Dec 10 2018, 12:51 PM
alpmestan created D5431: Hadrian: ability to run a subset of the testsuite.
Dec 10 2018, 12:25 PM
alpmestan created D5429: circleci: ignore gitlab branches for all jobs in the validate workflow.
Dec 10 2018, 5:08 AM
alpmestan added a comment to D5423: Fix hadrian default build cannot find -lffi..

I think there's a bit of work to do to make this work nicely under all circumstances, but that should otherwise do the trick.

Dec 10 2018, 2:39 AM

Dec 7 2018

alpmestan updated the diff for D5422: hadrian: eliminate most of the remaining big rule enumerations.
  • oops, remove leftover
Dec 7 2018, 6:37 AM
alpmestan created D5422: hadrian: eliminate most of the remaining big rule enumerations.
Dec 7 2018, 5:18 AM
alpmestan committed rGHCeee1b61f85d9: hadrian: optimise Rules.Compile (authored by alpmestan).
hadrian: optimise Rules.Compile
Dec 7 2018, 3:43 AM
alpmestan closed D5412: hadrian: optimise Rules.Compile.
Dec 7 2018, 3:43 AM

Dec 6 2018

alpmestan created D5419: Hadrian: fix dynamicGhcPrograms value for the quickest flavour.
Dec 6 2018, 8:22 AM
alpmestan accepted D5417: Hadrian: support in-tree GMP.

The hadrian part looks good to me. I suggested a set of flags in the ticket, but making the choice through configure is sensible enough and would work for me if everyone's happy with that.

Dec 6 2018, 5:38 AM
alpmestan added a comment to D5412: hadrian: optimise Rules.Compile.

Alright, I think I addressed all of your feedback. How is this patch looking now?

Dec 6 2018, 4:53 AM
alpmestan updated the diff for D5412: hadrian: optimise Rules.Compile.
  • fix BuildPath docs
  • add a note about object files representation
Dec 6 2018, 4:52 AM
alpmestan added inline comments to D5412: hadrian: optimise Rules.Compile.
Dec 6 2018, 4:40 AM

Dec 5 2018

alpmestan updated the diff for D5412: hadrian: optimise Rules.Compile.
  • move common path parsing bits in Hadrian.BuildPath
Dec 5 2018, 5:01 AM
alpmestan added inline comments to D5412: hadrian: optimise Rules.Compile.
Dec 5 2018, 4:57 AM
alpmestan added inline comments to D5412: hadrian: optimise Rules.Compile.
Dec 5 2018, 4:40 AM
alpmestan added inline comments to D5412: hadrian: optimise Rules.Compile.
Dec 5 2018, 4:14 AM

Dec 4 2018

alpmestan added a comment to D5412: hadrian: optimise Rules.Compile.

Thanks for the quick feedback!

Dec 4 2018, 5:14 PM
alpmestan updated the diff for D5412: hadrian: optimise Rules.Compile.
  • doc improvement
Dec 4 2018, 5:14 PM
alpmestan added a comment to D5412: hadrian: optimise Rules.Compile.

I'm importing the existing "infrastructure" for parsing from Rules.Library but I suspect a refactoring might be nice, putting the common utilities in a dedicated module. I'm not inspired for the name/place of that module, so I went for the shortest route to a working patch.

Dec 4 2018, 3:00 PM
alpmestan created D5412: hadrian: optimise Rules.Compile.
Dec 4 2018, 2:59 PM
alpmestan added inline comments to D5409: Hadrian: support extra libraries + OSX rpath.
Dec 4 2018, 4:02 AM
alpmestan requested changes to D5409: Hadrian: support extra libraries + OSX rpath.

Very nice!

Dec 4 2018, 1:37 AM

Dec 3 2018

alpmestan requested changes to D5406: Hadrian: add -no-dead-strip-dylibs for dynamic GHC.

I only see a tiny problem with your patch, it otherwise looks good to me.

Dec 3 2018, 1:48 AM

Dec 2 2018

alpmestan accepted D5404: Hadrian: include 'findPtr' via find-ptr cabal flag.

All good then! :-)

Dec 2 2018, 3:32 PM
alpmestan committed rGHC93a3f9070d5d: update (CicleCI) CI script to work with ghc-ci (authored by alpmestan).
update (CicleCI) CI script to work with ghc-ci
Dec 2 2018, 5:39 AM
alpmestan added a reviewer for D5404: Hadrian: include 'findPtr' via find-ptr cabal flag: Phyx.

Looks good to me, but it'd be good to have @Phyx confirm that this doesn't cause any breakage on Windows. Tamar, any chance you can fire up a build in the upcoming week?

Dec 2 2018, 2:54 AM
alpmestan added a comment to rGHC79d5427e1f9d: Hadrian: support dynamically linking ghc.

This breaks the default ./hadrian/build.sh on OSX. :(

Dec 2 2018, 2:35 AM

Nov 29 2018

alpmestan committed rGHC79d5427e1f9d: Hadrian: support dynamically linking ghc (authored by DavidEichmann).
Hadrian: support dynamically linking ghc
Nov 29 2018, 11:23 AM
alpmestan closed D5281: Hadrian: support dynamically linking ghc.
Nov 29 2018, 11:23 AM
alpmestan committed rGHCfb9971607c5a: Hadrian: bump Cabal submodule, install extra dynamic flavours of RTS (authored by alpmestan).
Hadrian: bump Cabal submodule, install extra dynamic flavours of RTS
Nov 29 2018, 10:16 AM
alpmestan closed D5385: Hadrian: bump Cabal submodule, install extra dynamic flavours of libHSrts.
Nov 29 2018, 10:16 AM
alpmestan retitled D5385: Hadrian: bump Cabal submodule, install extra dynamic flavours of libHSrts from Hadrian: install extra dynamic flavours of libHSrts to Hadrian: bump Cabal submodule, install extra dynamic flavours of libHSrts.
Nov 29 2018, 10:14 AM
alpmestan accepted D5281: Hadrian: support dynamically linking ghc.

Looks great!

Nov 29 2018, 6:34 AM
alpmestan added a comment to D5390: Make ghc-in-ghci support Hadrian.

OK, it's indeed not that straightforward, we'll see what we can do about this in due time then. Thanks for the explanation, Ryan.

Nov 29 2018, 4:27 AM
alpmestan accepted D5390: Make ghc-in-ghci support Hadrian.

I'm marking this as accepted as this is a definite improvement.

Nov 29 2018, 1:45 AM

Nov 28 2018

alpmestan added a comment to D5385: Hadrian: bump Cabal submodule, install extra dynamic flavours of libHSrts.

I don't see a way, currently.

Nov 28 2018, 3:44 AM

Nov 27 2018

alpmestan committed rGHC8f52ab922354: Hadrian: improve bindist rule (authored by alpmestan).
Hadrian: improve bindist rule
Nov 27 2018, 6:19 AM
alpmestan closed D5371: Hadrian: improve bindist rule.
Nov 27 2018, 6:19 AM
alpmestan created D5385: Hadrian: bump Cabal submodule, install extra dynamic flavours of libHSrts.
Nov 27 2018, 4:43 AM

Nov 26 2018

alpmestan accepted D5381: hadrian/test: Don't depend upon iserv on Windows.

Yes, it is a bit fragile, I'm sure we will have a better picture of how to refactor it all once things settle down a little bit. In the meantime: LGTM.

Nov 26 2018, 10:15 AM

Nov 22 2018

alpmestan added inline comments to D5371: Hadrian: improve bindist rule.
Nov 22 2018, 8:41 PM
alpmestan updated the diff for D5371: Hadrian: improve bindist rule.
  • missing ~ in note
Nov 22 2018, 5:00 PM
alpmestan added a comment to D5371: Hadrian: improve bindist rule.

Done. I added one note about the way we generate bindists, and one note about wrapper scripts / relocatable GHCs, i.e about the way we consume them. Hopefully things are much clearer now.

Nov 22 2018, 4:59 PM
alpmestan updated the diff for D5371: Hadrian: improve bindist rule.
  • add notes about the bindists in general and the story for wrapper scripts
Nov 22 2018, 4:58 PM
alpmestan added a comment to D5371: Hadrian: improve bindist rule.

Like @bgamari, I'd like to have a note about wrappers somewhere in the code, as otherwise it's always a matter of googling for hours in order to find out more information about them.

Nov 22 2018, 3:43 PM
alpmestan added a comment to D5356: rts.cabal.in: force inclusion of findPtr/_findPtr symbol only with debug flag.

Wow, that's great!

Nov 22 2018, 3:32 PM
alpmestan added a comment to D5361: Hadrian: work around Cabal's/GHC's different Arch/OS strings.

It would certainly be ideal to eventually have the inverse functions live in the same place, to avoid "silent breakage" when definitions are changed in one place but not the other.

Nov 22 2018, 2:13 PM
alpmestan added a comment to D5356: rts.cabal.in: force inclusion of findPtr/_findPtr symbol only with debug flag.

@Phyx Great news, sorry for the initial breakage =)

Nov 22 2018, 1:58 PM
alpmestan updated the test plan for D5371: Hadrian: improve bindist rule.
Nov 22 2018, 11:20 AM
alpmestan created D5371: Hadrian: improve bindist rule.
Nov 22 2018, 11:10 AM
alpmestan accepted D5365: Clean more generated files.
Nov 22 2018, 5:36 AM
alpmestan accepted D5366: Add binary artifacts to .gitignore.
Nov 22 2018, 5:34 AM

Nov 21 2018

alpmestan added a comment to D5316: Hadrian: Misc. fixes in Haddock rules.

Looks good to me!

Nov 21 2018, 9:47 AM

Nov 19 2018

alpmestan committed rGHCcc615c697b54: hadrian: make it possible to run the testsuite with quickest and quick (authored by alpmestan).
hadrian: make it possible to run the testsuite with quickest and quick
Nov 19 2018, 9:15 AM
alpmestan closed D5355: hadrian: make it possible to run the testsuite with quickest and quick.
Nov 19 2018, 9:15 AM
alpmestan added a comment to D5355: hadrian: make it possible to run the testsuite with quickest and quick.

I confirm that with this patch, we can run the testsuite with quickest/quick/perf, building respectively the vanilla, vanilla+dynamic, vanilla+dynamic+profiling "ways" of the iserv program along the way.

Nov 19 2018, 9:12 AM
alpmestan created D5356: rts.cabal.in: force inclusion of findPtr/_findPtr symbol only with debug flag.
Nov 19 2018, 6:40 AM
alpmestan created D5355: hadrian: make it possible to run the testsuite with quickest and quick.
Nov 19 2018, 4:42 AM

Nov 17 2018

alpmestan added a comment to D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.

There's a diff that bumps the Cabal submodule off the 2.4 branch, to track master: https://phabricator.haskell.org/D5329

Nov 17 2018, 3:55 AM

Nov 16 2018

alpmestan created D5345: fix T15898.
Nov 16 2018, 2:25 PM

Nov 15 2018

alpmestan created D5341: bump haddock submodule.
Nov 15 2018, 4:24 PM