alpmestan (Alp Mestanogullari)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 5 2014, 10:16 AM (224 w, 3 d)
Roles
Administrator

Recent Activity

Thu, Sep 20

alpmestan added a comment to D4880: Fix for built-in Natural literals.

hadrian doesn't need this patch anymore indeed, and I believe this was the only motivation for this patch -- can you confirm @hsyl20?

Thu, Sep 20, 6:55 PM
alpmestan added a comment to D5168: Always check the relocation value for x86_64.

Great! I believe this would have helped me during my investigation from Trac #15570.

Thu, Sep 20, 10:42 AM
alpmestan created D5166: rts.cabal.in: add more flags to control the extra flavours (for hadrian).
Thu, Sep 20, 8:53 AM

Wed, Sep 12

alpmestan added a comment to D5146: ghc-bin.cabal.in: add a 'threaded' flag for hadrian.

I can confirm that T8242 passes now, with the accompanying hadrian PR (here):

Wed, Sep 12, 6:13 PM
alpmestan added a comment to D5146: ghc-bin.cabal.in: add a 'threaded' flag for hadrian.

I have a build running, and it'll run the test at the end. I'll report back once it's all over.

Wed, Sep 12, 5:00 PM
alpmestan created D5146: ghc-bin.cabal.in: add a 'threaded' flag for hadrian.
Wed, Sep 12, 4:56 PM

Tue, Sep 11

alpmestan added a comment to D5138: rts/Printer.c: always define the findPtr symbol.

Looks like that didn't break anything for the make build system either, judging from the harbormaster builds.

Tue, Sep 11, 3:45 AM

Mon, Sep 10

alpmestan created D5142: rts.cabal.in: advertise new default profiling ways (introduced in D5140) for hadrian.
Mon, Sep 10, 10:42 AM
alpmestan added a comment to D5138: rts/Printer.c: always define the findPtr symbol.

@simonmar I implemented both of your suggestions. Thanks!

Mon, Sep 10, 5:33 AM
alpmestan updated the diff for D5138: rts/Printer.c: always define the findPtr symbol.
  • remove findPtr hack in rts/package.conf.in, give an helpful error message when not running a debugged RTS
  • silence unused argument warning/error
Mon, Sep 10, 5:31 AM

Fri, Sep 7

alpmestan updated the diff for D5138: rts/Printer.c: always define the findPtr symbol.
  • address unused parameter error
Fri, Sep 7, 12:35 PM
alpmestan added a comment to D5138: rts/Printer.c: always define the findPtr symbol.

@simonmar Absolutely (see e.g the discussion here). In fact, you ended up "recommending" this approach yourself in D4846 , so I just went ahead and implemented it. :)

Fri, Sep 7, 11:43 AM
alpmestan created D5138: rts/Printer.c: always define the findPtr symbol.
Fri, Sep 7, 7:50 AM

Tue, Sep 4

alpmestan created D5127: testsuite/mk/boilerplate.mk: make CHECK_API_ANNOTATIONS and CHECK_PPR overridable.
Tue, Sep 4, 5:50 AM

Fri, Aug 31

alpmestan accepted D5119: Skip eventlog tests in GHCi way.
Fri, Aug 31, 4:57 AM

Mon, Aug 27

alpmestan updated the Trac tickets for D5103: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules.
Mon, Aug 27, 3:35 PM
alpmestan added a comment to D5103: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules.

Only T3171 left to fix (https://circleci.com/gh/ghc/ghc-diffs/270)

Mon, Aug 27, 3:35 PM
alpmestan updated the diff for D5103: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules.
  • bigger multiplier for MultiLayerModules
Mon, Aug 27, 1:13 PM
alpmestan added a comment to D5106: make iToBase62's inner loop stricter in one of its arguments.

And here's the ticket with the self-contaiend reproducer: https://ghc.haskell.org/trac/ghc/ticket/15570#ticket

Mon, Aug 27, 1:13 PM
alpmestan added a comment to D5103: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules.

I made some more tweaks and triggered a new Circle CI build for i386: https://phabricator.haskell.org/harbormaster/build/52342/

Mon, Aug 27, 6:29 AM
alpmestan updated the diff for D5103: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules.
  • tweak timeout multipliers for bkpcabal01 and T13701(again)
Mon, Aug 27, 6:27 AM

Aug 24 2018

alpmestan created D5106: make iToBase62's inner loop stricter in one of its arguments.
Aug 24 2018, 4:35 PM
alpmestan planned changes to D5103: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules.

https://circleci.com/gh/ghc/ghc-diffs/256#build-parameters/containers/0: MultiLayerModules passed but another one is failing, and T13701 is still not passing.

Aug 24 2018, 10:03 AM
alpmestan added a comment to D5103: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules.

We'll eventually get the CircleCI build log url and more.

Aug 24 2018, 7:04 AM
alpmestan created D5103: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules.
Aug 24 2018, 7:04 AM
alpmestan created D5102: fix -ddump-asm description.
Aug 24 2018, 5:50 AM

Aug 22 2018

alpmestan added a comment to D4990: Invert FP conditions to eliminate the explicit NaN check..

That was my suspicion, thanks for clarifying!

Aug 22 2018, 12:00 PM
alpmestan accepted D5083: base: showEFloat: Handle negative precisions the same of zero precision.
Aug 22 2018, 11:20 AM
alpmestan accepted D4990: Invert FP conditions to eliminate the explicit NaN check..

Out of curiosity, if this is a _performance_ optimisation, do we have any numbers we can leave here for posterity?

Aug 22 2018, 10:44 AM
alpmestan requested changes to D4717: [WIP] CoreToStg: Try treating String unpackings as single-entry.

The patch looks good, but Note [String unpack closures are non-updateable] has yet to be written.

Aug 22 2018, 8:28 AM
alpmestan added a comment to D4739: Fix "redundant constraint" warnings when meets functional dependencies.

The only CI failures are on OS X and they're stats failures. I'm no typechecker expert but the feedback got addressed and the test included with this patch is indeed passing. Any objection to merging this fix?

Aug 22 2018, 5:50 AM

Aug 4 2018

alpmestan accepted D5043: circleci: Force BUILD_SPHINX_*=YES.
Aug 4 2018, 12:27 AM

Aug 2 2018

alpmestan accepted D5037: circleci: Don't build validate-x86_64-linux-debug unregisterised.

Ha! That explains why I was seeing so many common failures between the unreg and debug validation jobs in Trac #15466 and Trac #15467. Thanks!

Aug 2 2018, 10:23 AM
alpmestan added a comment to D5034: Fix precision of asinh/acosh/atanh by making them primops.

Can you checkout 2a3175f886b86697194256f55c9487b7cfb4dc92 in libraries/Cabal/, make sure you don't have dirty files in that sub-directory, and then from the top of the GHC source tree git add libraries/Cabal && git commit ... && arc diff ?

Aug 2 2018, 1:30 AM
alpmestan added a comment to D5034: Fix precision of asinh/acosh/atanh by making them primops.

It should be enough to checkout whatever commits master points to for those two submodules, git add libraries/Cabal libraries/terminfo and then git commit -m ... and arc diff.

Aug 2 2018, 1:16 AM

Aug 1 2018

alpmestan created D5033: use *test instead of *slowtest for llvm validation on Circle CI.
Aug 1 2018, 1:03 PM
alpmestan abandoned D5024: bump Cabal submodule for hadrian issue #634.

Done in another commit.

Aug 1 2018, 11:26 AM
alpmestan created D5031: fix timeout related i686 validation issues.
Aug 1 2018, 10:53 AM

Jul 31 2018

alpmestan accepted D5027: users-guide: Document default +RTS -I value.
Jul 31 2018, 1:43 AM
alpmestan accepted D5026: base: Fix documentation of System.Environment.Blank.
Jul 31 2018, 1:33 AM

Jul 30 2018

alpmestan created D5024: bump Cabal submodule for hadrian issue #634.
Jul 30 2018, 10:50 AM
alpmestan accepted D5015: Use -fobject-code in the GHCi script for loading GHC.

LGTM. Yeah -fobject-code seems to be a better default. Just make sur you document the most efficient/handy (but more complicated) workflow somewhere visible like one of the "building ghc" pages on trac eventually, so that people can pick it up.

Jul 30 2018, 7:04 AM

Jul 27 2018

alpmestan updated the diff for D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.
  • Merge branch 'master' into wip/alp/14483-getexecutablepath-windows
Jul 27 2018, 4:34 AM

Jul 26 2018

alpmestan added a comment to D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.

I didn't get around to figuring out the source of the Windows CI troubles. I can put this patch back on my radar and look into this in the upcoming days.

Jul 26 2018, 6:04 PM
alpmestan accepted D4986: Modifications to support loading GHC into GHCi.
Jul 26 2018, 5:35 PM

Jul 25 2018

alpmestan added a comment to D4904: Add a script for running a ghci that can load and run ghc.

testsuite/tests/ghci/ would be a good place I suppose.

Jul 25 2018, 4:41 AM
alpmestan added a comment to D4986: Modifications to support loading GHC into GHCi.

And CI will indeed tell us whether a full make succeeds.

Jul 25 2018, 4:20 AM
alpmestan requested changes to D4986: Modifications to support loading GHC into GHCi.

One last typo and we're good. OK for the Prelude imports, I see the reasoning.

Jul 25 2018, 4:20 AM
alpmestan requested changes to D4986: Modifications to support loading GHC into GHCi.

Looks great, except for the typos in the extension's name =)

Jul 25 2018, 4:10 AM

Jul 24 2018

alpmestan accepted D4989: Adjust normal runtimes for nofib along with related changes..

Alright, since there aren't any particularly obvious recommendations to give for the other two, I stand corrected and accept this patch as-is.

Jul 24 2018, 4:04 PM
alpmestan accepted D4981: Add an expect_broken test for #14185.
Jul 24 2018, 11:11 AM
alpmestan accepted D4983: Remove dead code in TcUnify.
Jul 24 2018, 11:09 AM
alpmestan accepted D4904: Add a script for running a ghci that can load and run ghc.

This looks good to me. I'd love to have something that makes sure this is not broken (a test that just runs your script?), but I don't think we necessarily want to hold this patch on that.

Jul 24 2018, 11:01 AM
alpmestan added a comment to D4986: Modifications to support loading GHC into GHCi.

Maybe I'm not seeing it because I'm tired, but how come you needed to add all those NoImplicitPreludes and import Preludes ?

Jul 24 2018, 10:53 AM
alpmestan requested changes to D4989: Adjust normal runtimes for nofib along with related changes..

Just a minor request, but otherwise looks good to me and will be very handy (if anything, our plots will look nice & balanced).

Jul 24 2018, 10:48 AM
alpmestan accepted D4999: rts: More forceful cc debugging flags.
Jul 24 2018, 8:26 AM

Jul 20 2018

alpmestan accepted D4952: Don't warn about tabs.

That bothered me as well in the past. Thanks!

Jul 20 2018, 4:01 AM

Jul 10 2018

alpmestan accepted D4947: Run the renamed source plugin after each HsGroup.

Looks good.

Jul 10 2018, 9:14 AM
alpmestan accepted D4946: Release notes about source plugins.
Jul 10 2018, 9:14 AM

Jul 9 2018

alpmestan added a comment to D4904: Add a script for running a ghci that can load and run ghc.

Would we perhaps want the ghci scripts to live somewhere else than at the top level (say a scripts/ directory) ?

Jul 9 2018, 12:47 PM
alpmestan accepted D4927: Export findImportUsage and ImportDeclUsage.
Jul 9 2018, 12:43 PM

Jul 6 2018

alpmestan added a comment to D4937: Plugin dependency information is stored separately.

Did you test this causes recompilation when the plugin module changes?

Jul 6 2018, 11:04 AM

Jul 5 2018

alpmestan accepted D4859: [WIP] testsuite: Add tests for #15270.
Jul 5 2018, 6:01 AM
alpmestan requested changes to D4921: testsuite: Add test for #12449.

Don't we want to expect this test to be broken? This is otherwise makig CI fail.

Jul 5 2018, 4:05 AM
alpmestan accepted D4933: Mark AutoDeriveTypeable as deprecated.
Jul 5 2018, 1:31 AM

Jul 4 2018

alpmestan accepted D4924: Add a strict version of foldMap to Foldable.

I was confused initially by the fact that the revision title talks about adding foldMap' while in fact this changes an existing implementation. LGTM.

Jul 4 2018, 10:30 AM
alpmestan requested changes to D4927: Export findImportUsage and ImportDeclUsage.

Just one tiny request, to get rid of a warning we can easily avoid. Other than that, looks good to me.

Jul 4 2018, 10:30 AM

Jun 28 2018

alpmestan accepted D4897: circleci: Detect core count.

It looks like switching to the ghc-diffs repo you created as a "staging" one for the Circle CI builds did the trick. Not sure how important the core detection logic was in making this work, but I suppose it is anyway better not to just blindly run with -j9.

Jun 28 2018, 4:48 PM

Jun 27 2018

alpmestan added a comment to D4897: circleci: Detect core count.

The build got killed: https://circleci.com/gh/alpmestan/ghc/15

Jun 27 2018, 1:33 AM

Jun 26 2018

alpmestan added a comment to D4897: circleci: Detect core count.

I triggered a build against my circle ci integration, through phab's build step interface. Let's see how it goes: https://circleci.com/gh/alpmestan/ghc/15 (previously, it'd just blow up, trying to build and run things with -j9 on a 2 core box with 4GB of RAM).

Jun 26 2018, 8:21 PM

Jun 16 2018

alpmestan added a comment to D4756: Use /usr/bin/env to get perl path instead of using a hardcoded path..

Thanks! This was quite annoying when I implemented a nofib rule in hadrian.

Jun 16 2018, 6:50 PM

Jun 3 2018

alpmestan accepted D4782: Provide `getWithUserData` and `putWithUserData`.

This is great. Hiding the whole symbol table / dictionary business from the user when he/she does not have to care about it certainly is an improvement from my point of view and I in fact could use this patch right now for a branch I'm working on.

Jun 3 2018, 6:16 PM

May 25 2018

alpmestan created D4735: Update repository sub-dir for ghc-heap in ghc-heap.cabal.in.
May 25 2018, 7:21 AM

May 23 2018

alpmestan created D4725: T14732 now passes with the profasm way.
May 23 2018, 12:25 PM

May 20 2018

alpmestan created D4712: Another batch of './validation --slow' tweaks.
May 20 2018, 5:13 PM

May 14 2018

alpmestan added a comment to D4636: Fix another batch of `./validate --slow` failures.

The reason that validate --slow might not be exactly the same as what we see in CI is that validate --slow enables DEBUG for stage 2, whereas we don't do that in CI because we're building binaries for distribution and DEBUG would make them slower. The warning messages you're seeing in the Cabal tests are only emitted when the compiler is built with DEBUG. (apologies if this was pointed out elsewhere, I haven't read all the surrounding tickets here)

May 14 2018, 3:06 AM

May 11 2018

alpmestan requested review of D4636: Fix another batch of `./validate --slow` failures.
May 11 2018, 11:06 PM
alpmestan created D4686: Expand $tooldir in ghc --info output.
May 11 2018, 6:39 AM
alpmestan requested changes to D4667: Fix testsuite runs by expanding tooldir.

OK, let's see what CI says with D4686. I will also run ./validate --fast in a Windows VM. I'm just using "changes requested" as an "on hold" tag.

May 11 2018, 6:39 AM
alpmestan accepted D4667: Fix testsuite runs by expanding tooldir.

I ended up writing a similar patch (that adds a field to Settings, to keep things pure), before stumbling on the phab notification for this diff (sorry). I don't mind this use of unsafePerformIO, even though I tend to prefer code that doesn't use it. This should regardless definitely fix the problem.

May 11 2018, 5:59 AM

Apr 18 2018

alpmestan accepted D4603: users-guide: Override mathjax_path.
Apr 18 2018, 5:18 AM

Apr 17 2018

alpmestan requested review of D4598: Introduce a $tooldir variable for nicer toolchain detection on Windows.
Apr 17 2018, 8:31 AM

Apr 16 2018

alpmestan added a comment to D4354: CircleCI: Run nightly validate --slow.

Yes, I can. I guess I can turn my attention to this as soon as I'm done with the unexpected failures I'm seeing when running ./validate --slow. We'll still have the stats failures left to handle.

Apr 16 2018, 11:27 AM

Apr 11 2018

alpmestan accepted D4585: Omit ways depending on rts flags for #12870 related tests..

Thanks! This will fix the failures I'm seeing.

Apr 11 2018, 11:22 PM
alpmestan added inline comments to D4546: tweak many test expectations, towards a green `./validate --slow`.
Apr 11 2018, 5:44 AM

Mar 31 2018

alpmestan accepted D4543: testsuite: Add test for negative sqrts (#10010).
Mar 31 2018, 2:00 PM
alpmestan requested review of D4546: tweak many test expectations, towards a green `./validate --slow`.
Mar 31 2018, 10:32 AM

Mar 27 2018

alpmestan accepted D4534: testsuite: Add test for #14965.

Quite intriguing. So, as Simon suggests in Trac #14965, this indeed got fixed between 8.4.1 and 8.4.2? (judging from the green CI here)

Mar 27 2018, 3:58 AM

Mar 21 2018

alpmestan accepted D4512: testsuite: Add test for #14925.

Looks good to me. I restarted the windows build as it was failing with what looks like a transient error:

Mar 21 2018, 6:11 AM
alpmestan accepted D4518: testsuite: Add test for #14931.

LGTM. This test _is_ executed by harbormaster right?

Mar 21 2018, 4:42 AM

Mar 2 2018

alpmestan added a comment to D4459: GHCi info: Use src file for cache invalidation.

Looks good. This should be a drastical improvement for situations like the one described in #12706.

Mar 2 2018, 5:51 AM

Feb 28 2018

alpmestan added a comment to D4453: 8.4: bump cabal to 2.2 (with ghc-cabal).

More details on why Herbert's fix is necessary in the ticket.

Feb 28 2018, 7:24 AM

Feb 27 2018

alpmestan added a comment to D4453: 8.4: bump cabal to 2.2 (with ghc-cabal).

hvr found that it's enough to build & run the following trivial program with stage 1:

Feb 27 2018, 9:51 AM

Feb 25 2018

alpmestan added a comment to D4447: Add Applicative, Semigroup, and Monoid instances in GHC.Generics.

Just for the record, this has been discussed on the libraries@ mailing list here. The patch looks good to me.

Feb 25 2018, 5:34 AM

Feb 14 2018

alpmestan created D4409: rts.cabal.in: advertise profiling flavours of libraries, behind a flag.
Feb 14 2018, 8:01 AM
alpmestan added a comment to D4403: Make accumArray and accum stricter.

Hmm, CI is now failing because of:

Feb 14 2018, 2:59 AM

Feb 13 2018

alpmestan added inline comments to D4403: Make accumArray and accum stricter.
Feb 13 2018, 11:40 AM
alpmestan added a comment to D4406: Update .cabal files for Cabal 2.1.

For the record, I was bitten by a parse error in utils/hp2ps/hp2ps.cabal when building with hadrian a little earlier and this patch fixed it.

Feb 13 2018, 7:55 AM

Jan 30 2018

alpmestan abandoned D4251: ship a Makefile to be used by hadrian-based bindists for 'make install'.

I think I'll be able to do without the need to ship this with ghc, which is in my opinion much, much better.

Jan 30 2018, 7:17 AM
alpmestan added a comment to D4229: ghc, ghc-pkg: use getExecutablePath on Windows when base >= 4.11.0.

Sorry for the lack of reactivity on this diff, I somehow didn't get the notifications for all the comments.

Jan 30 2018, 7:13 AM