alanz (Alan Zimmerman)
User

User Details

User Since
Jul 27 2014, 11:13 AM (228 w, 1 d)

Recent Activity

Mon, Nov 26

alanz added a comment to D5330: Introduce map from RdrName to Name for GHC API.

@simonpj see https://ghc.haskell.org/trac/ghc/wiki/ApiNameMap

Mon, Nov 26, 9:39 AM

Sun, Nov 25

alanz updated the diff for D5330: Introduce map from RdrName to Name for GHC API.

Update for @bgamari comment, add test

Sun, Nov 25, 4:50 AM
alanz accepted D5239: Support generating HIE files.

LGTM. Not sure if there is any intention to fix the long lines before landing?

Sun, Nov 25, 2:17 AM

Sat, Nov 24

alanz committed rGHC509d5be69c75: [TTG: Handling Source Locations] Foundation and Pat (authored by shayan-najd).
[TTG: Handling Source Locations] Foundation and Pat
Sat, Nov 24, 4:30 AM
alanz added inline comments to D5239: Support generating HIE files.
Sat, Nov 24, 4:20 AM

Thu, Nov 22

alanz added inline comments to D5239: Support generating HIE files.
Thu, Nov 22, 3:29 PM
alanz added inline comments to D5239: Support generating HIE files.
Thu, Nov 22, 1:31 PM
alanz added inline comments to D5239: Support generating HIE files.
Thu, Nov 22, 6:09 AM

Wed, Nov 21

alanz added inline comments to D5239: Support generating HIE files.
Wed, Nov 21, 1:16 AM
alanz added inline comments to D5239: Support generating HIE files.
Wed, Nov 21, 12:47 AM

Tue, Nov 20

alanz added inline comments to D5239: Support generating HIE files.
Tue, Nov 20, 3:26 PM
alanz added a comment to D5239: Support generating HIE files.

I have made some comments, and can look in more detail at the overlapping spans thing, but only tomorrow.

Tue, Nov 20, 2:47 PM
alanz added a comment to D5239: Support generating HIE files.

If there is anything I can do to help getting this into 8.8, let me know.

Tue, Nov 20, 1:46 PM

Wed, Nov 14

alanz updated the Trac tickets for D5330: Introduce map from RdrName to Name for GHC API.
Wed, Nov 14, 3:02 PM

Tue, Nov 13

alanz added a comment to D5330: Introduce map from RdrName to Name for GHC API.

The GlobalRdrEnv is such a mapping.

I'm not sure what the goal is here. Would it be worth a ticket and/or wiki page to explain the problem you are trying to solve?

Tue, Nov 13, 1:43 PM
alanz updated subscribers of D5330: Introduce map from RdrName to Name for GHC API.

Comment on ghc-devs from @simonpj

Tue, Nov 13, 8:36 AM

Mon, Nov 12

alanz added a comment to D5330: Introduce map from RdrName to Name for GHC API.

I have not added any tests (yet) as I first want an idea of whether this is acceptable or not. It came about
from discussions on IRC with people needing this kind of function, and not knowing that it already existed
in HaRe.

Mon, Nov 12, 12:38 PM
alanz created D5330: Introduce map from RdrName to Name for GHC API.
Mon, Nov 12, 12:34 PM

Nov 10 2018

alanz updated the diff for D5036: [TTG: Handling Source Locations] Foundation and Pat.

Updating for shayan-najd based on his https://github.com/shayan-najd/ghc/tree/wip/shnajd-TTG-SrcLocs

Nov 10 2018, 3:36 AM

Oct 5 2018

alanz added inline comments to D4894: More explicit foralls (GHC Proposal 0007).
Oct 5 2018, 8:53 AM

Sep 25 2018

alanz added inline comments to D5180: Parse the (!) type operator and allow type operators in existential context.
Sep 25 2018, 2:35 PM

Sep 24 2018

alanz added inline comments to D5173: Allow (unparenthesized) kind signatures.
Sep 24 2018, 9:28 AM
alanz added a comment to D5173: Allow (unparenthesized) kind signatures.

Nested parens are generally a mess, particularly in type definitions. I will take a look.

Sep 24 2018, 7:46 AM

Jul 30 2018

alanz added a comment to D5023: Parse the ~ and ! type operators consistently.

Looks symmetrical, so should be fine for me in terms of API Annotations.

Jul 30 2018, 10:29 AM

Jul 15 2018

alanz added a comment to D4960: [TTG - SrcLocs] The Initial Setting and Implementing for HsPat.

Some initial comments.

Jul 15 2018, 3:21 PM
alanz committed rGHC926954196f9f: TTG typo: XFieldOcc should be XCFieldOcc (authored by alanz).
TTG typo: XFieldOcc should be XCFieldOcc
Jul 15 2018, 12:48 PM

Jun 29 2018

alanz committed rGHC6e4e6d1c674a: Fix mkGadtDecl does not set con_forall correctly (authored by alanz).
Fix mkGadtDecl does not set con_forall correctly
Jun 29 2018, 2:13 PM
alanz added inline comments to D4894: More explicit foralls (GHC Proposal 0007).
Jun 29 2018, 4:12 AM

Jun 26 2018

alanz committed rGHCe53c113dcfec: API Annotations when parsing typapp (authored by alanz).
API Annotations when parsing typapp
Jun 26 2018, 4:11 AM

Jun 24 2018

alanz committed rGHC5db9f9129e75: Tweak API Annotations for ConDeclGADT (authored by alanz).
Tweak API Annotations for ConDeclGADT
Jun 24 2018, 3:45 PM

Jun 22 2018

alanz committed rGHC5f06cf6b6199: TTG for IPBind had wrong extension name (authored by alanz).
TTG for IPBind had wrong extension name
Jun 22 2018, 2:35 PM

Jun 19 2018

alanz committed rGHC676c5754e3f9: Fix API Annotations for GADT constructors (authored by alanz).
Fix API Annotations for GADT constructors
Jun 19 2018, 6:23 AM
alanz closed D4867: Fix API Annotations for GADT constructors.
Jun 19 2018, 6:23 AM

Jun 18 2018

alanz created D4867: Fix API Annotations for GADT constructors.
Jun 18 2018, 4:10 AM

Jun 14 2018

alanz accepted D4822: Preserve parenthesis in function application in typechecker.
Jun 14 2018, 2:50 AM

Jun 11 2018

alanz added inline comments to D4822: Preserve parenthesis in function application in typechecker.
Jun 11 2018, 1:09 PM

May 10 2018

alanz added a comment to D4684: DerivingVia.

The TTG and Api Annotations parts look fine, and I did not see anything else with my scan over it.

May 10 2018, 2:16 PM

Apr 27 2018

alanz committed rGHCc3823cba2147: TTG : complete for balance of hsSyn AST (authored by alanz).
TTG : complete for balance of hsSyn AST
Apr 27 2018, 8:39 AM
alanz closed D4625: TTG : complete for balance of hsSyn AST.
Apr 27 2018, 8:39 AM

Apr 23 2018

alanz requested review of D4625: TTG : complete for balance of hsSyn AST.
Apr 23 2018, 11:31 AM

Apr 13 2018

alanz committed rGHCb1386942e63b: TTG for HsBinds and Data instances Plan B (authored by alanz).
TTG for HsBinds and Data instances Plan B
Apr 13 2018, 6:41 AM
alanz closed D4581: TTG for HsBinds and Data instances Plan B.
Apr 13 2018, 6:41 AM
alanz added a comment to D4581: TTG for HsBinds and Data instances Plan B.

General question: about the choice of what to consider as an extension (both new fields and new constructors) does it follow wip/GrowableAST?

Apr 13 2018, 6:36 AM
alanz updated the diff for D4581: TTG for HsBinds and Data instances Plan B.

Rebase before landing

Apr 13 2018, 4:13 AM

Apr 10 2018

alanz updated the diff for D4581: TTG for HsBinds and Data instances Plan B.

Fix tests. The Haddock memory usage has *improved*. Odd.

Apr 10 2018, 1:57 AM

Apr 9 2018

alanz requested review of D4581: TTG for HsBinds and Data instances Plan B.
Apr 9 2018, 4:46 PM
alanz committed rGHC1aa1d405d821: Restore Trees That Grow reverted commits (authored by alanz).
Restore Trees That Grow reverted commits
Apr 9 2018, 2:29 PM
Herald updated subscribers of D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Apr 9 2018, 2:29 PM
Herald updated subscribers of D4177: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr.
Apr 9 2018, 2:29 PM
Herald updated subscribers of D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.
Apr 9 2018, 2:29 PM

Apr 7 2018

alanz committed rGHC5819ae2173d4: Remove HasSourceText and SourceTextX classes (authored by alanz).
Remove HasSourceText and SourceTextX classes
Apr 7 2018, 8:10 AM
alanz closed D4199: Remove HasSourceText and SourceTextX classes.
Apr 7 2018, 8:09 AM

Apr 3 2018

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

If there are no further comments I am going to rebase and land this.

Apr 3 2018, 10:03 AM

Apr 1 2018

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

@bgamari do I need to wait for the OSX build or can I just land this?

Apr 1 2018, 4:11 AM

Mar 31 2018

alanz updated the diff for D4199: Remove HasSourceText and SourceTextX classes.

Rebase

Mar 31 2018, 10:22 AM
alanz updated the diff for D4199: Remove HasSourceText and SourceTextX classes.

Get rid of FlexibleInstances

Mar 31 2018, 9:09 AM

Mar 30 2018

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

Experimenting, I find that

Mar 30 2018, 5:11 AM

Mar 29 2018

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

@dfeuer If I take out FlexibleInstances I get

Mar 29 2018, 9:42 AM

Mar 28 2018

alanz updated the diff for D4199: Remove HasSourceText and SourceTextX classes.

Update for current master

Mar 28 2018, 4:38 PM

Mar 19 2018

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

@bgamari I need to get back to this, and get it onto master.

Mar 19 2018, 1:16 PM

Jan 26 2018

alanz accepted D4344: Fix #14719 by using the setting the right SrcSpan.
Jan 26 2018, 7:29 AM

Jan 15 2018

alanz accepted D4298: Parenthesize forall-type args in cvtTypeKind.
Jan 15 2018, 9:48 AM

Dec 13 2017

alanz accepted D4266: Fix #14578 by checking isCompoundHsType in more places.

Concept LGTM, when the build passes.

Dec 13 2017, 1:44 PM

Nov 27 2017

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

If you have time, go for it.

Nov 27 2017, 2:43 PM
alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

The original motivation was to allow an arbitrary extension value to be used, which could then still be pretty printed.

Nov 27 2017, 1:39 PM
alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

Basically waiting for review. Dropped out of site during all the other feverish activity.

Nov 27 2017, 8:55 AM

Nov 15 2017

alanz created D4199: Remove HasSourceText and SourceTextX classes.
Nov 15 2017, 3:25 AM

Nov 14 2017

alanz committed rGHC47ad6578ea46: TTG3 Combined Step 1 and 3 for Trees That Grow (authored by alanz).
TTG3 Combined Step 1 and 3 for Trees That Grow
Nov 14 2017, 3:55 PM
alanz closed D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.
Nov 14 2017, 3:55 PM
alanz added inline comments to D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.
Nov 14 2017, 1:57 PM
alanz added a comment to D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.

I propose landing this, and then moving on to Plan E as per https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow/Instances

Nov 14 2017, 7:56 AM

Nov 13 2017

alanz added a comment to D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.

According to https://perf.haskell.org/ghc/#revision/56bd9bfc1c81cc304a00221be5bb91344f662a78 this patch adds a further 94 seconds to the build time

Nov 13 2017, 3:02 PM
alanz created D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.
Nov 13 2017, 1:51 AM

Nov 12 2017

alanz added inline comments to D4177: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr.
Nov 12 2017, 2:39 AM

Nov 11 2017

alanz committed rGHCe3ec2e7ae945: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr (authored by alanz).
WIP on combined Step 1 and 3 for Trees That Grow, HsExpr
Nov 11 2017, 3:59 PM
alanz closed D4177: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr.
Nov 11 2017, 3:59 PM

Nov 10 2017

alanz added a comment to D4177: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr.

Note that his patch introduces quite a large bump in the haddock memory usage

Nov 10 2017, 3:16 PM
alanz created D4177: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr.
Nov 10 2017, 3:06 PM

Nov 8 2017

alanz committed rGHC438dd1cbba13: WIP on Doing a combined Step 1 and 3 for Trees That Grow (authored by alanz).
WIP on Doing a combined Step 1 and 3 for Trees That Grow
Nov 8 2017, 10:01 AM

Nov 7 2017

alanz committed rGHC0ff152c9e633: WIP on combining Step 1 and 3 of Trees That Grow (authored by alanz).
WIP on combining Step 1 and 3 of Trees That Grow
Nov 7 2017, 12:54 AM
alanz closed D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Nov 7 2017, 12:54 AM

Nov 6 2017

alanz added inline comments to D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Nov 6 2017, 1:12 PM

Nov 5 2017

alanz updated the diff for D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.

Updating from comments on phabricator

Nov 5 2017, 2:21 PM
alanz added inline comments to D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Nov 5 2017, 1:58 PM

Nov 3 2017

alanz added inline comments to D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Nov 3 2017, 11:01 AM

Nov 2 2017

alanz added inline comments to D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Nov 2 2017, 1:19 PM

Nov 1 2017

Herald added a reviewer for D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow: austin.
Nov 1 2017, 10:01 AM

Oct 11 2017

alanz committed rGHC6869864eac21: Pretty-printing of derived multi-parameter classes omits parentheses (authored by alanz).
Pretty-printing of derived multi-parameter classes omits parentheses
Oct 11 2017, 9:47 AM
alanz closed D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 11 2017, 9:47 AM
alanz updated the diff for D4056: Pretty-printing of derived multi-parameter classes omits parentheses.

Rename typeNeedsParens to isCompoundHsType, add note

Oct 11 2017, 6:23 AM

Oct 4 2017

alanz added inline comments to D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 4 2017, 3:49 PM
alanz added inline comments to D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 4 2017, 3:16 PM
alanz updated the diff for D4056: Pretty-printing of derived multi-parameter classes omits parentheses.

Introduce utility function to decide on parens for compound types

Oct 4 2017, 3:16 PM

Oct 3 2017

alanz updated the diff for D4056: Pretty-printing of derived multi-parameter classes omits parentheses.

Fix some additional cases

Oct 3 2017, 4:37 AM

Oct 2 2017

alanz committed rGHC0e9681268a38: Pretty-printer missing parens for infix class declaration (authored by alanz).
Pretty-printer missing parens for infix class declaration
Oct 2 2017, 2:59 PM
alanz added inline comments to D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 2 2017, 9:08 AM
alanz added inline comments to D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 2 2017, 2:58 AM

Oct 1 2017

alanz created D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 1 2017, 2:37 PM

Sep 28 2017

alanz added inline comments to D4046: Work in Progress.
Sep 28 2017, 3:49 PM

Sep 14 2017

alanz created D3968: Renamer now preserves location for IEThingWith list items.
Sep 14 2017, 4:59 PM