alanz (Alan Zimmerman)
User

User Details

User Since
Jul 27 2014, 11:13 AM (203 w, 3 d)

Recent Activity

Tue, Jun 19

alanz committed rGHC676c5754e3f9: Fix API Annotations for GADT constructors (authored by alanz).
Fix API Annotations for GADT constructors
Tue, Jun 19, 6:23 AM
alanz closed D4867: Fix API Annotations for GADT constructors.
Tue, Jun 19, 6:23 AM

Mon, Jun 18

alanz created D4867: Fix API Annotations for GADT constructors.
Mon, Jun 18, 4:10 AM

Thu, Jun 14

alanz accepted D4822: Preserve parenthesis in function application in typechecker.
Thu, Jun 14, 2:50 AM

Mon, Jun 11

alanz added inline comments to D4822: Preserve parenthesis in function application in typechecker.
Mon, Jun 11, 1:09 PM

May 10 2018

alanz added a comment to D4684: DerivingVia.

The TTG and Api Annotations parts look fine, and I did not see anything else with my scan over it.

May 10 2018, 2:16 PM

Apr 27 2018

alanz committed rGHCc3823cba2147: TTG : complete for balance of hsSyn AST (authored by alanz).
TTG : complete for balance of hsSyn AST
Apr 27 2018, 8:39 AM
alanz closed D4625: TTG : complete for balance of hsSyn AST.
Apr 27 2018, 8:39 AM

Apr 23 2018

alanz requested review of D4625: TTG : complete for balance of hsSyn AST.
Apr 23 2018, 11:31 AM

Apr 13 2018

alanz committed rGHCb1386942e63b: TTG for HsBinds and Data instances Plan B (authored by alanz).
TTG for HsBinds and Data instances Plan B
Apr 13 2018, 6:41 AM
alanz closed D4581: TTG for HsBinds and Data instances Plan B.
Apr 13 2018, 6:41 AM
alanz added a comment to D4581: TTG for HsBinds and Data instances Plan B.

General question: about the choice of what to consider as an extension (both new fields and new constructors) does it follow wip/GrowableAST?

Apr 13 2018, 6:36 AM
alanz updated the diff for D4581: TTG for HsBinds and Data instances Plan B.

Rebase before landing

Apr 13 2018, 4:13 AM

Apr 10 2018

alanz updated the diff for D4581: TTG for HsBinds and Data instances Plan B.

Fix tests. The Haddock memory usage has *improved*. Odd.

Apr 10 2018, 1:57 AM

Apr 9 2018

alanz requested review of D4581: TTG for HsBinds and Data instances Plan B.
Apr 9 2018, 4:46 PM
alanz committed rGHC1aa1d405d821: Restore Trees That Grow reverted commits (authored by alanz).
Restore Trees That Grow reverted commits
Apr 9 2018, 2:29 PM
Herald updated subscribers of D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Apr 9 2018, 2:29 PM
Herald updated subscribers of D4177: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr.
Apr 9 2018, 2:29 PM
Herald updated subscribers of D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.
Apr 9 2018, 2:29 PM

Apr 7 2018

alanz committed rGHC5819ae2173d4: Remove HasSourceText and SourceTextX classes (authored by alanz).
Remove HasSourceText and SourceTextX classes
Apr 7 2018, 8:10 AM
alanz closed D4199: Remove HasSourceText and SourceTextX classes.
Apr 7 2018, 8:09 AM

Apr 3 2018

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

If there are no further comments I am going to rebase and land this.

Apr 3 2018, 10:03 AM

Apr 1 2018

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

@bgamari do I need to wait for the OSX build or can I just land this?

Apr 1 2018, 4:11 AM

Mar 31 2018

alanz updated the diff for D4199: Remove HasSourceText and SourceTextX classes.

Rebase

Mar 31 2018, 10:22 AM
alanz updated the diff for D4199: Remove HasSourceText and SourceTextX classes.

Get rid of FlexibleInstances

Mar 31 2018, 9:09 AM

Mar 30 2018

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

Experimenting, I find that

Mar 30 2018, 5:11 AM

Mar 29 2018

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

@dfeuer If I take out FlexibleInstances I get

Mar 29 2018, 9:42 AM

Mar 28 2018

alanz updated the diff for D4199: Remove HasSourceText and SourceTextX classes.

Update for current master

Mar 28 2018, 4:38 PM

Mar 19 2018

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

@bgamari I need to get back to this, and get it onto master.

Mar 19 2018, 1:16 PM

Jan 26 2018

alanz accepted D4344: Fix #14719 by using the setting the right SrcSpan.
Jan 26 2018, 7:29 AM

Jan 15 2018

alanz accepted D4298: Parenthesize forall-type args in cvtTypeKind.
Jan 15 2018, 9:48 AM

Dec 13 2017

alanz accepted D4266: Fix #14578 by checking isCompoundHsType in more places.

Concept LGTM, when the build passes.

Dec 13 2017, 1:44 PM

Nov 27 2017

alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

If you have time, go for it.

Nov 27 2017, 2:43 PM
alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

The original motivation was to allow an arbitrary extension value to be used, which could then still be pretty printed.

Nov 27 2017, 1:39 PM
alanz added a comment to D4199: Remove HasSourceText and SourceTextX classes.

Basically waiting for review. Dropped out of site during all the other feverish activity.

Nov 27 2017, 8:55 AM

Nov 15 2017

alanz created D4199: Remove HasSourceText and SourceTextX classes.
Nov 15 2017, 3:25 AM

Nov 14 2017

alanz committed rGHC47ad6578ea46: TTG3 Combined Step 1 and 3 for Trees That Grow (authored by alanz).
TTG3 Combined Step 1 and 3 for Trees That Grow
Nov 14 2017, 3:55 PM
alanz closed D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.
Nov 14 2017, 3:55 PM
alanz added inline comments to D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.
Nov 14 2017, 1:57 PM
alanz added a comment to D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.

I propose landing this, and then moving on to Plan E as per https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow/Instances

Nov 14 2017, 7:56 AM

Nov 13 2017

alanz added a comment to D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.

According to https://perf.haskell.org/ghc/#revision/56bd9bfc1c81cc304a00221be5bb91344f662a78 this patch adds a further 94 seconds to the build time

Nov 13 2017, 3:02 PM
alanz created D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.
Nov 13 2017, 1:51 AM

Nov 12 2017

alanz added inline comments to D4177: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr.
Nov 12 2017, 2:39 AM

Nov 11 2017

alanz committed rGHCe3ec2e7ae945: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr (authored by alanz).
WIP on combined Step 1 and 3 for Trees That Grow, HsExpr
Nov 11 2017, 3:59 PM
alanz closed D4177: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr.
Nov 11 2017, 3:59 PM

Nov 10 2017

alanz added a comment to D4177: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr.

Note that his patch introduces quite a large bump in the haddock memory usage

Nov 10 2017, 3:16 PM
alanz created D4177: WIP on combined Step 1 and 3 for Trees That Grow, HsExpr.
Nov 10 2017, 3:06 PM

Nov 8 2017

alanz committed rGHC438dd1cbba13: WIP on Doing a combined Step 1 and 3 for Trees That Grow (authored by alanz).
WIP on Doing a combined Step 1 and 3 for Trees That Grow
Nov 8 2017, 10:01 AM

Nov 7 2017

alanz committed rGHC0ff152c9e633: WIP on combining Step 1 and 3 of Trees That Grow (authored by alanz).
WIP on combining Step 1 and 3 of Trees That Grow
Nov 7 2017, 12:54 AM
alanz closed D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Nov 7 2017, 12:54 AM

Nov 6 2017

alanz added inline comments to D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Nov 6 2017, 1:12 PM

Nov 5 2017

alanz updated the diff for D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.

Updating from comments on phabricator

Nov 5 2017, 2:21 PM
alanz added inline comments to D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Nov 5 2017, 1:58 PM

Nov 3 2017

alanz added inline comments to D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Nov 3 2017, 11:01 AM

Nov 2 2017

alanz added inline comments to D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.
Nov 2 2017, 1:19 PM

Nov 1 2017

Herald added a reviewer for D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow: austin.
Nov 1 2017, 10:01 AM

Oct 11 2017

alanz committed rGHC6869864eac21: Pretty-printing of derived multi-parameter classes omits parentheses (authored by alanz).
Pretty-printing of derived multi-parameter classes omits parentheses
Oct 11 2017, 9:47 AM
alanz closed D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 11 2017, 9:47 AM
alanz updated the diff for D4056: Pretty-printing of derived multi-parameter classes omits parentheses.

Rename typeNeedsParens to isCompoundHsType, add note

Oct 11 2017, 6:23 AM

Oct 4 2017

alanz added inline comments to D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 4 2017, 3:49 PM
alanz added inline comments to D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 4 2017, 3:16 PM
alanz updated the diff for D4056: Pretty-printing of derived multi-parameter classes omits parentheses.

Introduce utility function to decide on parens for compound types

Oct 4 2017, 3:16 PM

Oct 3 2017

alanz updated the diff for D4056: Pretty-printing of derived multi-parameter classes omits parentheses.

Fix some additional cases

Oct 3 2017, 4:37 AM

Oct 2 2017

alanz committed rGHC0e9681268a38: Pretty-printer missing parens for infix class declaration (authored by alanz).
Pretty-printer missing parens for infix class declaration
Oct 2 2017, 2:59 PM
alanz added inline comments to D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 2 2017, 9:08 AM
alanz added inline comments to D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 2 2017, 2:58 AM

Oct 1 2017

alanz created D4056: Pretty-printing of derived multi-parameter classes omits parentheses.
Oct 1 2017, 2:37 PM

Sep 28 2017

alanz added inline comments to D4046: Work in Progress.
Sep 28 2017, 3:49 PM

Sep 14 2017

alanz created D3968: Renamer now preserves location for IEThingWith list items.
Sep 14 2017, 4:59 PM

Sep 13 2017

alanz committed rGHC2fe6f6baba70: Option "-ddump-rn-ast" dumps imports and exports too (authored by alanz).
Option "-ddump-rn-ast" dumps imports and exports too
Sep 13 2017, 1:04 PM
alanz closed D3949: Option "-ddump-rn-ast" dumps imports and exports too by committing rGHC2fe6f6baba70: Option "-ddump-rn-ast" dumps imports and exports too.
Sep 13 2017, 1:04 PM
alanz updated the diff for D3949: Option "-ddump-rn-ast" dumps imports and exports too.

Update for @bgamari comments

Sep 13 2017, 1:03 PM
alanz added inline comments to D3949: Option "-ddump-rn-ast" dumps imports and exports too.
Sep 13 2017, 12:34 PM
alanz created D3949: Option "-ddump-rn-ast" dumps imports and exports too.
Sep 13 2017, 7:48 AM

Aug 28 2017

alanz added a comment to D3894: Make parsed AST dump stream.

I'm glad too see this. I knew the original was a hack, but was not sure how to convert it to produce Doc directly. Thanks,

Aug 28 2017, 4:59 AM

Jul 10 2017

alanz committed rGHCc506f8353755: Pretty-printer no longer butchers function arrow fixity (authored by alanz).
Pretty-printer no longer butchers function arrow fixity
Jul 10 2017, 6:08 AM

Jun 30 2017

alanz accepted D3686: Improve Wmissing-home-modules warning under Cabal.

Thanks, that was quick.

Jun 30 2017, 2:29 AM

Jun 25 2017

alanz added inline comments to D3670: Treat banged bindings as FunBinds.
Jun 25 2017, 11:25 AM

Jun 21 2017

alanz added inline comments to D3661: Treat banged bindings as FunBinds.
Jun 21 2017, 1:20 AM

Jun 5 2017

alanz committed rGHC8e6ec0fa7431: Udate hsSyn AST to use Trees that Grow (authored by alanz).
Udate hsSyn AST to use Trees that Grow
Jun 5 2017, 5:16 PM
alanz closed D3609: Update hsSyn AST to use Trees that Grow by committing rGHC8e6ec0fa7431: Udate hsSyn AST to use Trees that Grow.
Jun 5 2017, 5:16 PM
alanz updated the diff for D3609: Update hsSyn AST to use Trees that Grow.

Rebase

Jun 5 2017, 5:11 PM

Jun 4 2017

alanz updated the diff for D3609: Update hsSyn AST to use Trees that Grow.

Update per @bgamari comments

Jun 4 2017, 2:56 PM
alanz added a comment to D3609: Update hsSyn AST to use Trees that Grow.

I have updated ghc-exactprint to use the GHC from this patch.

Jun 4 2017, 1:59 PM
alanz added a comment to D3609: Update hsSyn AST to use Trees that Grow.

On the whole this seems fine but I would really like to see the comments finished up before we move ahead with merging. In fact, I think it would be reasonable to write the beginning of a release notes entry (under the "GHC API" section) describing the change, it's motivations, and generally how this will affect API users. In general I fear that this change may make it quite tricky for API users (think ghc-mod) to support GHC releases pre- and post-growable trees. Have you tried porting such a package to this new scheme?

Jun 4 2017, 3:15 AM

Jun 3 2017

alanz updated the diff for D3609: Update hsSyn AST to use Trees that Grow.

rebase (again)

Jun 3 2017, 2:15 PM

May 31 2017

alanz updated the diff for D3609: Update hsSyn AST to use Trees that Grow.

Rename GHC to GhcPass, clean lint warnings, rebase

May 31 2017, 3:26 PM

May 30 2017

alanz added a comment to D3609: Update hsSyn AST to use Trees that Grow.

So: is there anything in here you think is controversial? Design decisions you weren't sure of? Do we have any performance measurements?

May 30 2017, 1:26 PM

May 28 2017

alanz updated the diff for D3609: Update hsSyn AST to use Trees that Grow.

Rebase

May 28 2017, 8:26 AM
alanz committed rGHC3b23f680c2b1: Remove HsContext from ppr_mono_ty, and remove ppParendHsType (authored by alanz).
Remove HsContext from ppr_mono_ty, and remove ppParendHsType
May 28 2017, 5:54 AM

May 25 2017

alanz updated the diff for D3609: Update hsSyn AST to use Trees that Grow.

Rename ClassX to ForallX, clean up, rebase

May 25 2017, 4:15 PM

May 24 2017

alanz created D3609: Update hsSyn AST to use Trees that Grow.
May 24 2017, 4:43 PM

Apr 23 2017

alanz committed rGHC1f4fd37efac4: Export function for use in GHC API (authored by alanz).
Export function for use in GHC API
Apr 23 2017, 11:58 AM

Apr 9 2017

alanz committed rGHC5282bb1772ba: Parenthesize type/data families correctly for -ddump-splices (authored by alanz).
Parenthesize type/data families correctly for -ddump-splices
Apr 9 2017, 2:19 PM

Mar 8 2017

alanz abandoned D3145: Add HsEmbellished type to hsSyn.
Mar 8 2017, 2:58 PM

Feb 27 2017

alanz committed rGHCc0af206f26b9: Explicitly capture whether a splice has a dollar prefix (authored by alanz).
Explicitly capture whether a splice has a dollar prefix
Feb 27 2017, 3:47 AM

Feb 26 2017

alanz committed rGHCcae1a7125522: Bring in unicode variants of API Annotations for HsBracket (authored by alanz).
Bring in unicode variants of API Annotations for HsBracket
Feb 26 2017, 7:46 AM

Feb 25 2017

alanz committed rGHC8f20844d3435: Correctly pretty print a wild card in infix position (authored by alanz).
Correctly pretty print a wild card in infix position
Feb 25 2017, 7:45 AM

Feb 24 2017

alanz committed rGHC9b859ef00779: Make SCCFunSig tag Located for ghc-exactprint (authored by alanz).
Make SCCFunSig tag Located for ghc-exactprint
Feb 24 2017, 10:59 AM
alanz committed rGHC67c2e076c615: Add API Annotation AnnSignature for backpack signature modules (authored by alanz).
Add API Annotation AnnSignature for backpack signature modules
Feb 24 2017, 6:23 AM