alanz (Alan Zimmerman)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 27 2014, 11:13 AM (147 w, 1 d)
Availability
Available

Recent Activity

Sun, Apr 23

alanz committed rGHC1f4fd37efac4: Export function for use in GHC API (authored by alanz).
Export function for use in GHC API
Sun, Apr 23, 11:58 AM

Apr 9 2017

alanz committed rGHC5282bb1772ba: Parenthesize type/data families correctly for -ddump-splices (authored by alanz).
Parenthesize type/data families correctly for -ddump-splices
Apr 9 2017, 2:19 PM

Mar 8 2017

alanz abandoned D3145: Add HsEmbellished type to hsSyn.
Mar 8 2017, 2:58 PM

Feb 27 2017

alanz committed rGHCc0af206f26b9: Explicitly capture whether a splice has a dollar prefix (authored by alanz).
Explicitly capture whether a splice has a dollar prefix
Feb 27 2017, 3:47 AM

Feb 26 2017

alanz committed rGHCcae1a7125522: Bring in unicode variants of API Annotations for HsBracket (authored by alanz).
Bring in unicode variants of API Annotations for HsBracket
Feb 26 2017, 7:46 AM

Feb 25 2017

alanz committed rGHC8f20844d3435: Correctly pretty print a wild card in infix position (authored by alanz).
Correctly pretty print a wild card in infix position
Feb 25 2017, 7:45 AM

Feb 24 2017

alanz committed rGHC9b859ef00779: Make SCCFunSig tag Located for ghc-exactprint (authored by alanz).
Make SCCFunSig tag Located for ghc-exactprint
Feb 24 2017, 10:59 AM
alanz committed rGHC67c2e076c615: Add API Annotation AnnSignature for backpack signature modules (authored by alanz).
Add API Annotation AnnSignature for backpack signature modules
Feb 24 2017, 6:23 AM

Feb 23 2017

alanz committed rGHC8a6b8c5fb964: Export commentToAnnotation from Lexer.x (authored by alanz).
Export commentToAnnotation from Lexer.x
Feb 23 2017, 5:39 AM

Feb 20 2017

alanz added a comment to D3145: Add HsEmbellished type to hsSyn.

I will do some experiments.

Feb 20 2017, 2:10 PM

Feb 19 2017

alanz committed rGHCdae50032c1f1: Remove ghc-api/landmine tests (authored by alanz).
Remove ghc-api/landmine tests
Feb 19 2017, 5:45 AM

Feb 18 2017

alanz updated the diff for D3145: Add HsEmbellished type to hsSyn.

Rebase against master

Feb 18 2017, 2:27 PM

Feb 17 2017

alanz created D3145: Add HsEmbellished type to hsSyn.
Feb 17 2017, 9:53 AM

Feb 10 2017

alanz committed rGHC258c719599f7: TH-spliced class instances are pretty-printed incorrectly post-#3384 (authored by alanz).
TH-spliced class instances are pretty-printed incorrectly post-#3384
Feb 10 2017, 4:43 AM
alanz closed D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384 by committing rGHC258c719599f7: TH-spliced class instances are pretty-printed incorrectly post-#3384.
Feb 10 2017, 4:43 AM
alanz updated the diff for D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.

Update expected test results for new master

Feb 10 2017, 4:42 AM

Feb 9 2017

alanz added a comment to D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.

Ping @RyanGlScott, please review this

Feb 9 2017, 1:17 PM

Feb 8 2017

alanz added inline comments to D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.
Feb 8 2017, 1:27 PM
alanz committed rGHC7e4e6a7309b2: Add dump flags for the renamed and typechecked hsSyn ASTs (authored by alanz).
Add dump flags for the renamed and typechecked hsSyn ASTs
Feb 8 2017, 12:48 PM
alanz closed D3107: Add dump flags for the renamed and typechecked hsSyn ASTs by committing rGHC7e4e6a7309b2: Add dump flags for the renamed and typechecked hsSyn ASTs.
Feb 8 2017, 12:48 PM
alanz created D3107: Add dump flags for the renamed and typechecked hsSyn ASTs.
Feb 8 2017, 6:29 AM

Feb 7 2017

alanz updated the diff for D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.

Deal with pprParend for HsExpr, add note for ParPat and HsParTy

Feb 7 2017, 2:03 PM

Feb 5 2017

alanz added a comment to D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.

I will write a note explaining why this change exists, and then wrap it
up. The essence is to try and always have an hsSyn AST that reflects
source code, so that the fact that ppr can now round-trip source can be
relied on in all cases.

Feb 5 2017, 3:20 PM
alanz added a comment to D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.

I have updated the patch to do away with pprParendExpr and pprParendLExpr, to ensure that any hsSyn AST generation does actually insert parens in the right place. Doing the same for pprParendPat is also trivial.

Feb 5 2017, 2:59 PM
alanz updated the diff for D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.
  • Remove pprParend*Expr
  • rebase
Feb 5 2017, 12:28 PM

Jan 30 2017

alanz added a comment to D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.
In particular, converted expressions still aren't wrapped up in `HsPar`s, and they're only pretty-printed correctly because the `Outputable` instance for `HsExpr` behaves differently from those of `HsType` and `Pat`.
Jan 30 2017, 3:02 PM
alanz added a comment to D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.

I will look into getting expressions to work the same as types and patterns, as I would prefer a consistent hsSyn AST representation.

Jan 30 2017, 12:14 PM

Jan 29 2017

alanz retitled D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384 from to TH-spliced class instances are pretty-printed incorrectly post-#3384.
Jan 29 2017, 4:22 PM

Jan 26 2017

alanz added inline comments to D1778: Defining open kinds and closed kinds without an associated datatype.
Jan 26 2017, 8:06 AM
alanz committed rGHC0d1cb1574dd5: Make type import/export API Annotation friendly (authored by alanz).
Make type import/export API Annotation friendly
Jan 26 2017, 7:20 AM
alanz closed D3016: Make type import/export API Annotation friendly by committing rGHC0d1cb1574dd5: Make type import/export API Annotation friendly.
Jan 26 2017, 7:20 AM
alanz updated D3016: Make type import/export API Annotation friendly.
Jan 26 2017, 7:19 AM

Jan 25 2017

alanz accepted D3018: Don't unnecessarily qualify TH-converted instances with empty contexts.
Jan 25 2017, 5:20 AM

Jan 24 2017

alanz updated the diff for D3016: Make type import/export API Annotation friendly.

Remove some debug code

Jan 24 2017, 3:43 PM
alanz updated D3016: Make type import/export API Annotation friendly.
Jan 24 2017, 3:39 PM
alanz updated D3016: Make type import/export API Annotation friendly.
Jan 24 2017, 3:35 PM
alanz retitled D3016: Make type import/export API Annotation friendly from to Make type import/export API Annotation friendly.
Jan 24 2017, 3:07 PM

Jan 17 2017

alanz committed rGHC38f289fa2a87: Fix API Annotations for unboxed sums (authored by alanz).
Fix API Annotations for unboxed sums
Jan 17 2017, 12:16 PM
alanz closed D2968: Fix API Annotations for unboxed sums by committing rGHC38f289fa2a87: Fix API Annotations for unboxed sums.
Jan 17 2017, 12:15 PM

Jan 15 2017

alanz committed rGHC1ff3c5882427: Add dump-parsed-ast flag and functionality (authored by alanz).
Add dump-parsed-ast flag and functionality
Jan 15 2017, 1:38 PM
alanz closed D2958: Add dump-parsed-ast flag and functionality by committing rGHC1ff3c5882427: Add dump-parsed-ast flag and functionality.
Jan 15 2017, 1:38 PM

Jan 14 2017

alanz updated the diff for D2958: Add dump-parsed-ast flag and functionality.

Rebase and make @mpickering happy

Jan 14 2017, 7:57 AM

Jan 13 2017

alanz added a comment to D2958: Add dump-parsed-ast flag and functionality.

@bgamari Are you happy with my changes? I would like to land this.

Jan 13 2017, 1:46 AM

Jan 12 2017

alanz retitled D2968: Fix API Annotations for unboxed sums from to Fix API Annotations for unboxed sums.
Jan 12 2017, 5:57 AM
alanz added inline comments to D2958: Add dump-parsed-ast flag and functionality.
Jan 12 2017, 12:13 AM

Jan 11 2017

alanz updated the diff for D2958: Add dump-parsed-ast flag and functionality.

Fixing according to @bgamari comments. And rebase.

Jan 11 2017, 2:20 PM
alanz added inline comments to D2958: Add dump-parsed-ast flag and functionality.
Jan 11 2017, 12:57 PM
alanz updated subscribers of D2958: Add dump-parsed-ast flag and functionality.
Jan 11 2017, 12:24 PM
mpickering awarded D2958: Add dump-parsed-ast flag and functionality a Like token.
Jan 11 2017, 11:44 AM
alanz retitled D2958: Add dump-parsed-ast flag and functionality from to Add dump-parsed-ast flag and functionality.
Jan 11 2017, 4:18 AM

Jan 10 2017

alanz committed rGHC1a6bdca01b7a: Make HsIParamTy have a Located HsIPName (authored by alanz).
Make HsIParamTy have a Located HsIPName
Jan 10 2017, 9:05 AM

Jan 7 2017

alanz accepted D2669: Exhaustiveness checking for pattern synonyms.

The annotations parts seem ok, by eyeballing it

Jan 7 2017, 9:44 AM

Dec 22 2016

alanz accepted D2893: Refactor importdecls/topdecls parsing..

I see the tests did pass

Dec 22 2016, 1:35 AM
alanz added a comment to D2893: Refactor importdecls/topdecls parsing..

In the description, in the sentence "This is because the *_semi parsers always require a semicolon,
but we're allowed to omit that last newline." I think newline should be semi.

Dec 22 2016, 1:32 AM

Dec 20 2016

alanz added inline comments to D2887: Rewrite Note [Api annotations] for clarity..
Dec 20 2016, 1:50 PM

Dec 17 2016

alanz accepted D2873: Fix Pretty printer tests on Windows.
Dec 17 2016, 11:32 AM
alanz added a comment to D2873: Fix Pretty printer tests on Windows.

Is this needed because the original file is in \r\n format, and the reparsed ppr one is in \n format?

Dec 17 2016, 10:55 AM

Dec 15 2016

alanz added a comment to D2851: check-ppr: Add a --dump flag to aid in debugging.

Perhaps make this the default, the makes it much easier to diff. In which case the flag is unnecessary.

Dec 15 2016, 12:34 AM

Dec 14 2016

alanz accepted D2836: Fix pretty printing of MINIMAL signatures.
Dec 14 2016, 1:54 PM

Dec 12 2016

alanz added a comment to D2836: Fix pretty printing of MINIMAL signatures.

Ppr023 tests this pragma.

Dec 12 2016, 1:01 PM
alanz accepted D2834: Fix pretty printing of top level SCC pragmas.
Dec 12 2016, 12:55 PM
alanz committed rGHC8f6d241a74ef: Add infix flag for class and data declarations (authored by alanz).
Add infix flag for class and data declarations
Dec 12 2016, 12:51 PM
alanz closed D2828: Add infix flag for class and data declarations by committing rGHC8f6d241a74ef: Add infix flag for class and data declarations.
Dec 12 2016, 12:51 PM
alanz updated D2828: Add infix flag for class and data declarations.
Dec 12 2016, 12:50 PM
alanz updated the diff for D2828: Add infix flag for class and data declarations.

Rebase

Dec 12 2016, 12:11 PM

Dec 11 2016

alanz retitled D2828: Add infix flag for class and data declarations from to Add infix flag for class and data declarations.
Dec 11 2016, 4:11 PM

Dec 8 2016

alanz added a comment to D2808: Ensure each test inherits the TEST_HC_OPTS.

Neither the API annotations tests nor the printer ones care about stderr.

Dec 8 2016, 1:33 PM
alanz committed rGHCc5fbbac9fdf8: Ignore stderr of all printer tests (authored by alanz).
Ignore stderr of all printer tests
Dec 8 2016, 3:22 AM

Dec 7 2016

alanz committed rGHC9bcc4e335b34: Remove stray commented out line in all.T (authored by alanz).
Remove stray commented out line in all.T
Dec 7 2016, 3:38 PM
alanz committed rGHC58d78dc0c522: Fix pretty printer test to nog generate stdout (authored by alanz).
Fix pretty printer test to nog generate stdout
Dec 7 2016, 3:26 PM
alanz committed rGHC499e43824bda: Add HsSyn prettyprinter tests (authored by alanz).
Add HsSyn prettyprinter tests
Dec 7 2016, 1:31 PM
alanz closed D2752: Add HsSyn prettyprinter tests by committing rGHC499e43824bda: Add HsSyn prettyprinter tests.
Dec 7 2016, 1:31 PM
alanz updated the diff for D2752: Add HsSyn prettyprinter tests.

Remove trailing whitespace in ppr-check.cabal

Dec 7 2016, 1:29 PM
alanz updated the diff for D2752: Add HsSyn prettyprinter tests.

Removed SourceText Monad, and rebase

Dec 7 2016, 1:17 PM
alanz updated the diff for D2752: Add HsSyn prettyprinter tests.

Update for @bgamari comments and rebase

Dec 7 2016, 2:37 AM
alanz abandoned D2683: Replace placeHolderPunRhs with a PlaceHolder value.

The amount of noise this patch generates is not worth the (small) gain

Dec 7 2016, 1:28 AM
alanz added inline comments to D2752: Add HsSyn prettyprinter tests.
Dec 7 2016, 12:40 AM

Dec 3 2016

alanz updated the diff for D2752: Add HsSyn prettyprinter tests.

Rebase and update for @simonpj comment

Dec 3 2016, 4:21 AM

Dec 1 2016

alanz updated the diff for D2752: Add HsSyn prettyprinter tests.

Rebase, all tests should now pass.

Dec 1 2016, 2:56 PM

Nov 29 2016

alanz committed rGHC36e36227e438: Store string as parsed in SourceText for CImport (authored by alanz).
Store string as parsed in SourceText for CImport
Nov 29 2016, 1:08 PM

Nov 27 2016

alanz updated D2752: Add HsSyn prettyprinter tests.
Nov 27 2016, 2:52 PM
alanz added inline comments to D2752: Add HsSyn prettyprinter tests.
Nov 27 2016, 2:12 PM
alanz updated the diff for D2752: Add HsSyn prettyprinter tests.

Fix remaining tests. There are allocation performance stats issues with Cabal,
tests need to be updated, I presume.

Nov 27 2016, 1:52 PM
alanz updated the diff for D2752: Add HsSyn prettyprinter tests.

Replacing Bool with more meaningful types

Nov 27 2016, 1:04 PM
alanz updated the diff for D2752: Add HsSyn prettyprinter tests.

Rebase and more fixing from comments

Nov 27 2016, 3:02 AM

Nov 25 2016

alanz updated the diff for D2752: Add HsSyn prettyprinter tests.

Introduce 'Promoted' flag to indicate an explict promotion in the source text.

Nov 25 2016, 7:53 AM
alanz updated the diff for D2752: Add HsSyn prettyprinter tests.

Turn SourceText into a data type, similar to Maybe

Nov 25 2016, 5:04 AM

Nov 23 2016

alanz added a comment to D2752: Add HsSyn prettyprinter tests.

Initial responses to @mpickering comments. Thanks for looking at this so quickly.

Nov 23 2016, 2:47 PM
alanz added a comment to D2752: Add HsSyn prettyprinter tests.

Note about why HasOccNameId has proliferated everywhere.

Nov 23 2016, 1:55 PM
alanz added a comment to D2752: Add HsSyn prettyprinter tests.

Added my own comments.

Nov 23 2016, 1:28 PM
alanz retitled D2752: Add HsSyn prettyprinter tests from to Add HsSyn prettyprinter tests.
Nov 23 2016, 12:54 PM

Nov 17 2016

alanz added a comment to D2718: Add caret diagnostics.

FYI, I am currently working on https://ghc.haskell.org/trac/ghc/ticket/3384. The intention once the full-fidelity AST pretty printer is in place is to see if the API Annotations can also be used to generate code layout identical to the original.

Nov 17 2016, 11:41 AM

Nov 13 2016

alanz committed rGHCc1fe13d32322: Adding parens into generically generated code (authored by alanz).
Adding parens into generically generated code
Nov 13 2016, 3:07 PM
alanz committed rGHC8ff63e728299: ppr of RuleDecls can now reparse (authored by alanz).
ppr of RuleDecls can now reparse
Nov 13 2016, 3:07 PM
alanz committed rGHC379da5809e8b: Use SourceText to ppr Overlap Pragma (authored by alanz).
Use SourceText to ppr Overlap Pragma
Nov 13 2016, 3:07 PM
alanz committed rGHCd6f3f5cc9af8: Pretty printing HsCoreAnn properly (authored by alanz).
Pretty printing HsCoreAnn properly
Nov 13 2016, 3:07 PM
alanz committed rGHC75cbaf584cca: FFI static keyword, hang OpApp for infix case (authored by alanz).
FFI static keyword, hang OpApp for infix case
Nov 13 2016, 3:07 PM
alanz committed rGHC7363a540251a: No parens around HsSpliceE (authored by alanz).
No parens around HsSpliceE
Nov 13 2016, 3:07 PM
alanz committed rGHC5e7f233a64e7: No braces/semis for a do statement (authored by alanz).
No braces/semis for a do statement
Nov 13 2016, 3:07 PM
alanz committed rGHC660bb54189b2: Add HsSyn prettyprinter tests (authored by alanz).
Add HsSyn prettyprinter tests
Nov 13 2016, 3:07 PM