alanasp (Alanas Plascinskas)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2018, 2:53 PM (24 w, 6 d)

Recent Activity

Fri, Nov 2

alanasp added a comment to D4953: Support for deprecating exports.

@DavidEichmann The case that you pointed out indeed works as intended. I've made sure that if there is a non-deprecating way a symbol can be brought into context then that way will be used.

Fri, Nov 2, 2:13 PM
alanasp updated the diff for D4953: Support for deprecating exports.

Additional test cases added as per @DavidEichmann request

Fri, Nov 2, 12:51 PM

Tue, Oct 30

alanasp added a comment to D4953: Support for deprecating exports.

@DavidEichmann Ok, it's actually self-export rather than self import. The example is here /libraries/base/GHC/Num.hs
I agree that the self-import wouldn't make sense but the self-export here is useful and to me using loadSrcInterface_maybe seemed like the most straightforward if not the best solution.

Tue, Oct 30, 9:15 AM

Mon, Oct 29

alanasp added a comment to D4953: Support for deprecating exports.

@DavidEichmann Yeah, the self-referencing import is used in some GHC native modules.
Also, I am getting this error when Phab attempts Linux build:
configure: error: GHC 8.2.1 is known to be buggy and cannot bootstrap this GHC release (See Trac 15281); please use GHC 8.2.2 or later.
I am not getting it on my own machine and the other builds seem to succeed. Is it something to do with Phab or something that I'd have to look into?

Mon, Oct 29, 3:41 PM

Sat, Oct 27

alanasp added a comment to D4953: Support for deprecating exports.

I've addressed and/or fixed the issues raised, please let me know if there's anything else you'd like changing.

Sat, Oct 27, 2:36 PM
alanasp updated the diff for D4953: Support for deprecating exports.
  • Occurence name added to warning messages for deprecated imports
Sat, Oct 27, 2:34 PM

Sep 2 2018

alanasp added a comment to D4953: Support for deprecating exports.

@tdammers Thanks for your suggestions. I think I've addressed most of them. Let me know what you think about some of the issues that I asked about in the comments.

Sep 2 2018, 3:15 PM
alanasp updated the diff for D4953: Support for deprecating exports.

lint and other small fixes

Sep 2 2018, 3:11 PM

Aug 26 2018

alanasp added a comment to D4953: Support for deprecating exports.

@bgamari I've adressed all the issues that you raised by now except for the rebasing. There were some issues when I tried to rebase onto the tip of ghc master and I am wondering if that is necessary as the only thing this was necessary in the first place are the release notes and it's just the addition of "- Export deprecation is now supported. Please refer to GHC proposal #28 <https://github.com/ghc-proposals/ghc-proposals/blob/master/proposals/0028-deprecating-exports-proposal.rst>__ and the updated user guide <https://downloads.haskell.org/~ghc/latest/docs/html/users_guide/glasgow_exts.html#warning-and-deprecated-pragmas>__" under Language.

Aug 26 2018, 10:26 AM
alanasp updated the diff for D4953: Support for deprecating exports.

T14189.stderr updated to reflect ie constructor changes

Aug 26 2018, 4:02 AM

Aug 25 2018

alanasp updated the diff for D4953: Support for deprecating exports.

swap args in ie constructor, update dependencies

Aug 25 2018, 2:25 PM

Aug 24 2018

alanasp updated the diff for D4953: Support for deprecating exports.

Fixes to testsuite and parser

Aug 24 2018, 9:09 AM

Aug 22 2018

alanasp added a comment to D4953: Support for deprecating exports.

@bgamari Thanks for the review, I'll aim to fix these as soon as possible. The constructor changes and the rebase are likely to break things here and there, so it might take a little more time

Aug 22 2018, 5:32 AM

Aug 13 2018

alanasp updated the diff for D4953: Support for deprecating exports.

@thomie I have added a release notes file from ghc master since my base didn't have it.

Aug 13 2018, 9:15 AM

Aug 10 2018

alanasp updated the diff for D4953: Support for deprecating exports.
  • Some comments added to the code
  • User guide updated
Aug 10 2018, 8:31 AM

Aug 6 2018

thomie awarded D4953: Support for deprecating exports a Mountain of Wealth token.
Aug 6 2018, 5:01 PM

Aug 1 2018

alanasp updated the diff for D4953: Support for deprecating exports.
  • undo changes to T13168.stderr
Aug 1 2018, 9:31 AM

Jul 31 2018

alanasp updated the diff for D4953: Support for deprecating exports.

testsuite error fixes

Jul 31 2018, 11:16 AM

Jul 30 2018

alanasp updated the diff for D4953: Support for deprecating exports.
  • Module reexport deprecation support
  • Fix for Num.hs self-export issue
Jul 30 2018, 8:35 AM

Jul 19 2018

alanasp updated the diff for D4953: Support for deprecating exports.

resolved issue with submodules, now builds fine from a clean state on my Linux machine

Jul 19 2018, 7:27 AM

Jul 18 2018

alanasp updated the diff for D4953: Support for deprecating exports.

fix ie constructors in submodules

Jul 18 2018, 6:36 AM

Jul 16 2018

alanasp updated the diff for D4953: Support for deprecating exports.

I've changed the base commit, the build is still expected to fail because of some dependencies using the modified code

Jul 16 2018, 3:39 PM

Jul 11 2018

alanasp updated the summary of D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning.
Jul 11 2018, 3:30 AM
alanasp added a comment to D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning.

I have forked the bytestring library and added a pragma {-# OPTIONS_GHC -fno-warn-warnings-deprecations #-} to Char8.hs file, so it wouldn't complain. It seems that now, after a few more fixes, it is finally able to build.

Jul 11 2018, 3:28 AM
alanasp updated the diff for D4953: Support for deprecating exports.

fixed issue with ieName

Jul 11 2018, 3:21 AM

Jul 10 2018

alanasp updated the diff for D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning.
  • warning fixes
Jul 10 2018, 3:32 PM
alanasp updated the diff for D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning.
  • changed .gitmodules libraries/bytestring url
  • libraries/bytestring updated
Jul 10 2018, 1:06 PM
alanasp updated the Trac tickets for D4953: Support for deprecating exports.
Jul 10 2018, 12:26 PM
alanasp created D4953: Support for deprecating exports.
Jul 10 2018, 12:26 PM

Jul 6 2018

alanasp added a comment to D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning.

I am not sure why this is failing a Linux build, it works fine on my machine

Jul 6 2018, 8:24 AM

Jul 5 2018

alanasp retitled D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning from The change makes deprecated symbols that are explicitly imported throw a warning to Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning.
Jul 5 2018, 8:31 AM
alanasp retitled D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning from compiler: fix trac issue 15337 to The change makes deprecated symbols that are explicitly imported throw a warning.
Jul 5 2018, 8:31 AM
alanasp updated the diff for D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning.
  • compiler: fix trac issue 15337
Jul 5 2018, 8:16 AM

Jul 3 2018

alanasp retitled D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning from compiler: add tests to issue 15337 to compiler: fix trac issue 15337.
Jul 3 2018, 3:02 PM
alanasp updated the diff for D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning.
  • compiler: fix trac issue 15337
Jul 3 2018, 2:59 PM
alanasp created D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning.
Jul 3 2018, 2:36 PM

May 25 2018

alanasp retitled D4732: tcExtendTyVarEnv2 changed to tcExtendNameTyVarEnv from compiler: fix trac issue #15017 to tcExtendTyVarEnv2 changed to tcExtendNameTyVarEnv.
May 25 2018, 4:04 AM

May 24 2018

alanasp created D4732: tcExtendTyVarEnv2 changed to tcExtendNameTyVarEnv.
May 24 2018, 4:28 PM