akio (Takano Akio)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2015, 8:45 PM (180 w, 1 d)

Recent Activity

Jul 25 2018

Ian Lynagh <ian@well-typed.com> committed rGHCDIFF525740436c97: Update GHC.ForeignPtr to use addCFinalizerToWeak# (authored by akio).
Update GHC.ForeignPtr to use addCFinalizerToWeak#
Jul 25 2018, 11:12 AM
Ian Lynagh <ian@well-typed.com> committed rGHCDIFF48951557d503: Update fptr01 (authored by akio).
Update fptr01
Jul 25 2018, 9:58 AM
Ian Lynagh <ian@well-typed.com> committed rGHCDIFFfe652a8b56c8: Maintain per-generation lists of weak pointers (#7847) (authored by akio).
Maintain per-generation lists of weak pointers (#7847)
Jul 25 2018, 8:03 AM
Ian Lynagh <ian@well-typed.com> committed rGHCDIFFd61c623ed6b2: Allow multiple C finalizers to be attached to a Weak# (authored by akio).
Allow multiple C finalizers to be attached to a Weak#
Jul 25 2018, 8:03 AM

Apr 23 2018

akio added a comment to D4244: Nested CPR.

I'm really sorry to getting here so late, and making people (in particular @sgraf) decipher code I wrote. I needed some energy to come back to this problem, which I basically abondoned because it overwhelmed me.

Apr 23 2018, 1:32 AM

Jan 21 2018

akio added a comment to D4260: Implement BlockArguments (#10843).

@mpickering Any comments on the latest version? (I believe this differential revision is waiting for an action from you. Apologies if I'm mistaken)

Jan 21 2018, 6:40 PM

Dec 24 2017

akio added a comment to D4260: Implement BlockArguments (#10843).

Is there something that needs to be done on my side? Or is this revision waiting for review?

Dec 24 2017, 7:52 PM
akio updated the diff for D4260: Implement BlockArguments (#10843).
  • Rebase
  • This is not making it in 8.4
Dec 24 2017, 7:48 PM

Dec 14 2017

akio updated the diff for D4260: Implement BlockArguments (#10843).
  • Clean up test cases
Dec 14 2017, 5:36 PM
akio added inline comments to D4260: Implement BlockArguments (#10843).
Dec 14 2017, 2:45 AM

Dec 11 2017

akio updated the summary of D4260: Implement BlockArguments (#10843).
Dec 11 2017, 6:48 AM
akio updated the diff for D4260: Implement BlockArguments (#10843).
  • Record a perf regression in parsing001
Dec 11 2017, 6:45 AM
akio added a comment to D4260: Implement BlockArguments (#10843).

@mpickering Updated the commit message to mention shift/reduce conflicts.

Dec 11 2017, 5:03 AM
akio updated the diff for D4260: Implement BlockArguments (#10843).
  • Parser.y: typo
Dec 11 2017, 5:02 AM
akio updated the summary of D4260: Implement BlockArguments (#10843).
Dec 11 2017, 5:01 AM
akio updated the diff for D4260: Implement BlockArguments (#10843).
  • Better error message for LambdaCase
Dec 11 2017, 3:19 AM
akio created D4260: Implement BlockArguments (#10843).
Dec 11 2017, 3:12 AM

Nov 23 2017

akio created D4226: rts/Printer: add closure name entries for small arrays (Fixes #14513).
Nov 23 2017, 1:22 AM

Jan 10 2017

akio added a comment to D2951: Mark *FB functions INLINE[0] (Fixes #13001).

@simonpj I've updated the note. I didn't include actual numbers because I thought it might be misleading (the inline pragma turns the allocation for T13001 from O(n) to O(1), where n is the length of the list, so the ratio of the two allocation numbers heavily depends on the choice of n.)

Jan 10 2017, 7:39 AM
akio updated the diff for D2951: Mark *FB functions INLINE[0] (Fixes #13001).
  • Add comment
Jan 10 2017, 7:36 AM
akio retitled D2951: Mark *FB functions INLINE[0] (Fixes #13001) from to Mark *FB functions INLINE[0] (Fixes #13001).
Jan 10 2017, 5:30 AM

Jan 9 2017

akio updated the diff for D2605: Allow top-level string literals in Core (#8472).
  • Add a reference to a Note
Jan 9 2017, 4:14 AM
akio added inline comments to D2605: Allow top-level string literals in Core (#8472).
Jan 9 2017, 4:13 AM

Jan 6 2017

akio added a comment to D2605: Allow top-level string literals in Core (#8472).

@simonpj I've updated the code to simplify the invariant. Thank you for your help!

Jan 6 2017, 6:16 PM
akio updated the diff for D2605: Allow top-level string literals in Core (#8472).
  • Disallow Addr# variables in the RHS of top-level bindings
Jan 6 2017, 6:11 PM

Dec 28 2016

akio retitled D2901: Add specialization rules for realToFrac on Complex from to Add specialization rules for realToFrac on Complex.
Dec 28 2016, 2:06 AM

Dec 26 2016

akio updated the diff for D2605: Allow top-level string literals in Core (#8472).
  • Remove duplicate comment
Dec 26 2016, 12:42 AM
akio added a comment to D2605: Allow top-level string literals in Core (#8472).

Could you make a Note (maybe in CoreSyn or Literal that gives an overview of all the moving parts. Much as the summary, perhaps with an example or two

Dec 26 2016, 12:40 AM
akio updated the diff for D2605: Allow top-level string literals in Core (#8472).
  • ghci: allocate one RemotePtr for each top-level Addr# binding
  • More comments
Dec 26 2016, 12:35 AM

Dec 22 2016

akio added a comment to D2605: Allow top-level string literals in Core (#8472).

@simonpj Sorry about being slow. I think I know what to do about the GHCi issue. I'm hoping that I can finish implementing this and address the other comments in a few days.

Dec 22 2016, 12:49 AM

Dec 5 2016

akio added a comment to D2605: Allow top-level string literals in Core (#8472).

@simonpj

I've gotten lost on this patch. Can we reset and summarise?

Our goal is simply to allow top-level string literal bindings. But the patch is quite long. Could you give a list summarising the knock-on consequences of this apparently simple decision?

Dec 5 2016, 1:23 AM
akio updated D2605: Allow top-level string literals in Core (#8472).
Dec 5 2016, 1:18 AM
akio updated the diff for D2605: Allow top-level string literals in Core (#8472).
  • Revert a change to preInlineUnconditionally
Dec 5 2016, 1:14 AM

Nov 20 2016

akio added a comment to D2605: Allow top-level string literals in Core (#8472).

@simonmar

If it can't happen, what's the reasoning? Couldn't the simplifier lift out a string to the top level, then duplicate the reference to it by inlining?

Nov 20 2016, 10:49 PM

Nov 14 2016

akio added a comment to D2605: Allow top-level string literals in Core (#8472).

@simonmar

This worries me quite a bit, because we use GHCi on very large codebases with a lot of strings.

That sounds like a fair concern, but I can't think of an actual case where this leads to a bad runtime behavior on GHCi.

Nov 14 2016, 5:53 PM

Nov 13 2016

akio added a comment to D2605: Allow top-level string literals in Core (#8472).

@simonmar

I wonder, how does GHCi handle top-level Addr# bindings? Does it just work? (If so, how/why?)

Before the generation of the byte code, all Addr# variables are inlined into their use sites. Actually this may not be ideal because (1) this won't work if the source language had an Addr# variable, and (2) it potentially duplicates data.

Nov 13 2016, 10:50 PM
akio updated the diff for D2605: Allow top-level string literals in Core (#8472).
  • mention the comment 16 on Trac #8472 in perf/compiler/all.T
Nov 13 2016, 10:48 PM
akio updated the diff for D2605: Allow top-level string literals in Core (#8472).
  • Fix rules that were broken by the top-level string change
  • add Note about _bytes label
  • 80 chars
Nov 13 2016, 10:25 PM

Oct 23 2016

akio added a comment to D2605: Allow top-level string literals in Core (#8472).

@simonmar Thank you for reviewing this!

Oct 23 2016, 10:39 PM
akio updated the diff for D2605: Allow top-level string literals in Core (#8472).
  • Use a new type of labels (_bytes) for top-level string literals
Oct 23 2016, 10:19 PM

Oct 20 2016

akio added a comment to D2605: Allow top-level string literals in Core (#8472).

I updated the diff again to accept more perf regressions. (I didn't realize that validate --slow skipped some compiler perf tests).

Oct 20 2016, 6:28 AM
akio updated the diff for D2605: Allow top-level string literals in Core (#8472).
  • Accept compiler residency regressions
Oct 20 2016, 6:26 AM

Oct 19 2016

akio added a comment to D2605: Allow top-level string literals in Core (#8472).

@bgamari I update test cases. Unfortunately I had to increase the perf number for T4029, I hope it is acceptable.

Oct 19 2016, 7:26 AM
akio updated the diff for D2605: Allow top-level string literals in Core (#8472).
  • Update test case for T3234
  • accept perf regression for T4029
  • Reword Note [CoreSyn top-level string literals]
Oct 19 2016, 7:21 AM

Oct 18 2016

thomie awarded D2605: Allow top-level string literals in Core (#8472) a Like token.
Oct 18 2016, 11:25 AM

Oct 17 2016

akio updated subscribers of D2605: Allow top-level string literals in Core (#8472).

Some code and most of the documentation comments are by @gridaphobe.

Oct 17 2016, 4:10 AM
akio updated D2605: Allow top-level string literals in Core (#8472).
Oct 17 2016, 4:03 AM
akio retitled D2605: Allow top-level string literals in Core (#8472) from to Allow top-level string literals in Core (#8472).
Oct 17 2016, 4:00 AM

Oct 2 2016

akio abandoned D2554: Float primitive string literals to the top.

@gridaphobe Sure I will.

Oct 2 2016, 11:25 PM
akio added a comment to D2554: Float primitive string literals to the top.

I've fixed the above issue. The patch is at https://github.com/takano-akio/ghc/commit/bc02b52f7e27fd9b51c61d159c7be544022abc0e.

Oct 2 2016, 11:11 PM

Sep 30 2016

akio added a comment to D2554: Float primitive string literals to the top.

This version causes test failures in validate --slow. A typical error message is

Sep 30 2016, 8:51 PM

Sep 4 2016

akio retitled D2512: Make the test for #11108 less fragile from to Make the test for #11108 less fragile.
Sep 4 2016, 9:53 PM

Sep 2 2016

akio added a comment to D2486: Turn divInt# and modInt# into bitwise operations when possible.

I've added comments about the undefined behavior in primops.txt.pp. Also I checked that these commits add no errors in validate --slow.

Sep 2 2016, 3:23 AM
akio updated the diff for D2486: Turn divInt# and modInt# into bitwise operations when possible.
  • Document undefined behavior of quotInt# and remInt# when the devisor is 0
Sep 2 2016, 3:22 AM

Aug 30 2016

akio added inline comments to D2486: Turn divInt# and modInt# into bitwise operations when possible.
Aug 30 2016, 6:42 PM

Aug 29 2016

akio added inline comments to D2486: Turn divInt# and modInt# into bitwise operations when possible.
Aug 29 2016, 2:58 PM
akio retitled D2486: Turn divInt# and modInt# into bitwise operations when possible from to Turn divInt# and modInt# into bitwise operations when possible.
Aug 29 2016, 1:51 AM

May 12 2016

akio retitled D2202: Fix comments about scavenging WEAK objects from to Fix comments about scavenging WEAK objects.
May 12 2016, 4:48 AM

May 10 2016

akio updated the diff for D2189: Handle promotion failures when scavenging a WEAK (#11108).

Apply lint suggestion

May 10 2016, 7:30 AM
akio retitled D2189: Handle promotion failures when scavenging a WEAK (#11108) from to Handle promotion failures when scavenging a WEAK (#11108).
May 10 2016, 7:28 AM

Aug 4 2015

akio retitled D1126: Make sure that `all`, `any`, `and`, and `or` fuse (#9848) from to Make sure that `all`, `any`, `and`, and `or` fuse (#9848).
Aug 4 2015, 4:38 AM

May 5 2015

akio updated subscribers of D849: Fix dropped event registrations.
May 5 2015, 9:16 PM