adamse (Adam Sandberg Ericsson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 6 2014, 6:07 AM (280 w, 4 d)

Recent Activity

Mon, Sep 23

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC74631bbcc9cd: base: add newtypes for socklen_t and ndfs_t to System.Posix.Types #16568 (authored by adamse).
base: add newtypes for socklen_t and ndfs_t to System.Posix.Types #16568
Mon, Sep 23, 4:58 PM

Aug 2 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC5e960287b74c: docs: fixs -prof links in rts-flags section (authored by adamse).
docs: fixs -prof links in rts-flags section
Aug 2 2019, 7:20 AM

Jul 26 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC7c9fb2f0eb7d: ghc-heap: implement WEAK closure type #16974 (authored by adamse).
ghc-heap: implement WEAK closure type #16974
Jul 26 2019, 8:49 AM

Apr 2 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC18d1555d6e8d: configure: document the use of the LD variable (authored by adamse).
configure: document the use of the LD variable
Apr 2 2019, 3:54 PM

Dec 30 2018

adamse abandoned D5307: Add --with-alex and --with-happy to ./configure script.

Moved to gitlab: https://gitlab.haskell.org/ghc/ghc/merge_requests/61

Dec 30 2018, 2:39 PM
adamse abandoned D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

Moved to gitlab: https://gitlab.haskell.org/ghc/ghc/merge_requests/60

Dec 30 2018, 1:13 PM

Dec 14 2018

adamse updated the Trac tickets for D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.
Dec 14 2018, 2:23 PM

Dec 10 2018

adamse added inline comments to D5428: Add +RTS -F to the --help output.
Dec 10 2018, 4:20 AM

Dec 6 2018

adamse added a comment to D5417: Hadrian: support in-tree GMP.

The make buildsystem doesn't require me to re-run ./configure to use intree-gmp. I'm not sure on the build time impact rerunning ./configure has but maybe it should be taken into account?

Dec 6 2018, 9:34 AM

Nov 27 2018

adamse added a comment to D5307: Add --with-alex and --with-happy to ./configure script.

To me it sounds quite weird to "hide" the most important programs behind env vars (making them harder to discover and pass). I'd also like to note that I learned how to write this ac code by looking at how --with-ghc was implemented (which certainly is not optional :)).

Nov 27 2018, 1:07 PM

Nov 8 2018

adamse retitled D5307: Add --with-alex and --with-happy to ./configure script from Teach ./configure about --with-alex and --with-happy to Add --with-alex and --with-happy to ./configure script.
Nov 8 2018, 4:50 PM

Nov 7 2018

adamse added inline comments to D5281: Hadrian: support dynamically linking ghc.
Nov 7 2018, 4:17 PM
adamse updated the summary of D5307: Add --with-alex and --with-happy to ./configure script.
Nov 7 2018, 2:36 PM
adamse updated the summary of D5307: Add --with-alex and --with-happy to ./configure script.
Nov 7 2018, 2:33 PM
adamse updated the diff for D5307: Add --with-alex and --with-happy to ./configure script.

Update FPTOOLS_(ALEX|HAPPY)

Nov 7 2018, 2:30 PM
adamse added a comment to D5307: Add --with-alex and --with-happy to ./configure script.

Not sure if changes to FPTOOLS_ALEX in aclocal.m4 are necessary.

Nov 7 2018, 2:01 PM
adamse updated the test plan for D5307: Add --with-alex and --with-happy to ./configure script.
Nov 7 2018, 1:58 PM
adamse retitled D5307: Add --with-alex and --with-happy to ./configure script from Attempt to teach ./configure about --with-alex and --with-happy to Teach ./configure about --with-alex and --with-happy.
Nov 7 2018, 1:57 PM
adamse updated the diff for D5307: Add --with-alex and --with-happy to ./configure script.

HAPPY variable

Nov 7 2018, 1:54 PM
adamse created D5307: Add --with-alex and --with-happy to ./configure script.
Nov 7 2018, 1:53 PM

Oct 18 2018

adamse added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

@dfeuer any chance of a re-review?

Oct 18 2018, 9:38 AM

Aug 26 2018

adamse added a comment to D5079: Make GHC (the library) flexible in the choice of integer library.

I think the sumarry has diverged from the code: "The trick is to use integer as the -this-unit-id" should be "use integer-wired-in".

Aug 26 2018, 10:39 AM

Aug 16 2018

adamse awarded D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files a Mountain of Wealth token.
Aug 16 2018, 5:12 PM

May 20 2018

adamse updated the diff for D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.
  • Revert "Mention where to find IOMode"
  • Revert "Mention removal in changelog"
  • Revert "Unexpose GHC.IO.IOMode in base"
May 20 2018, 5:13 PM

May 15 2018

adamse added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

Related to the "community work", has someone put all code on hackage in a searchable database somewhere?

May 15 2018, 3:01 PM
adamse added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

Pr to process: https://github.com/haskell/process/pull/129

May 15 2018, 3:01 PM
adamse updated the diff for D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.
  • Mention where to find IOMode
May 15 2018, 2:43 PM
adamse added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

Looks like process imports GHC.IO.IOMode, what's the process here? PR to process to import it from System.IO?

May 15 2018, 2:35 PM
adamse updated the diff for D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.
  • Unexpose GHC.IO.IOMode in base
  • Mention removal in changelog
May 15 2018, 1:30 PM
adamse added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

@dfeuer can you clarify: I will leave GHC.IntWord64 (ghc-prim) as is currently (ie not-home) and remove GHC.IO.IOMode from exposed-modules?

May 15 2018, 11:03 AM
adamse added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

@dfeuer, GHC.IntWord64 is from ghc-prim, that one should certainly not be removed from exposed-modules? (base imports it)

May 15 2018, 3:02 AM

May 14 2018

adamse updated the diff for D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.
  • Remove OPTIONS_HADDOCK hide in favour for not-home (compiler)
May 14 2018, 5:23 PM
adamse added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

(Gave the same treatment to ghc-prim)

May 14 2018, 3:30 PM
adamse updated the diff for D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.
  • Remove HADDOCK_OPTIONS hide in favour for not-home
May 14 2018, 3:30 PM
adamse added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

My rationale for this change is that hide limits exploration of base and therefore learning. Using not-home instead of hide we will generate documentation and there will be clickable links on the package homepage on hackage, while letting the home of ie CallStack be GHC.Stack and not GHC.Stack.Types.

May 14 2018, 2:26 PM
adamse retitled D4692: Remove OPTIONS_HADDOCK hide in favour for not-home from Remove HADDOCK_OPTIONS hide in favour for not-home to Remove OPTIONS_HADDOCK hide in favour for not-home.
May 14 2018, 2:26 PM
adamse created D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.
May 14 2018, 2:26 PM

Feb 1 2018

adamse added inline comments to D4350: Raise parse error for `data T where`..
Feb 1 2018, 5:04 PM
adamse updated the diff for D4368: Remove doubled words.
  • Another double word
Feb 1 2018, 5:04 PM
adamse updated the diff for D4368: Remove doubled words.
  • More doubles
Feb 1 2018, 5:04 PM
adamse created D4368: Remove doubled words.
Feb 1 2018, 4:23 PM

Jul 18 2017

adamse updated the diff for D3750: Add Haddocks for Eq (STRef a) and Eq (IORef a).
  • Fix Haddock notation
Jul 18 2017, 12:12 PM

Jul 17 2017

adamse updated the diff for D3750: Add Haddocks for Eq (STRef a) and Eq (IORef a).
  • Correct spelling
Jul 17 2017, 4:15 PM
Herald added a reviewer for D3750: Add Haddocks for Eq (STRef a) and Eq (IORef a): austin.
Jul 17 2017, 4:14 PM

Apr 25 2017

adamse retitled D3500: Add instances `Num`, `Functor`, `Applicative`, `Monad`, `Semigroup` and `Monoid` for `Data.Ord.Down` (#13097). from Add instances `Num`, `Functor`, `Applicative`, `Monad` and `Monoid` for `Data.Ord.Down` (#13097). to Add instances `Num`, `Functor`, `Applicative`, `Monad`, `Semigroup` and `Monoid` for `Data.Ord.Down` (#13097)..
Apr 25 2017, 4:55 PM
adamse updated the diff for D3500: Add instances `Num`, `Functor`, `Applicative`, `Monad`, `Semigroup` and `Monoid` for `Data.Ord.Down` (#13097)..
  • Add Semigroup instance, move haddocks around
Apr 25 2017, 4:54 PM
adamse updated the Trac tickets for D3500: Add instances `Num`, `Functor`, `Applicative`, `Monad`, `Semigroup` and `Monoid` for `Data.Ord.Down` (#13097)..
Apr 25 2017, 4:14 PM
Herald added a reviewer for D3500: Add instances `Num`, `Functor`, `Applicative`, `Monad`, `Semigroup` and `Monoid` for `Data.Ord.Down` (#13097).: austin.
Apr 25 2017, 4:13 PM

Apr 4 2017

adamse added a comment to D3416: Add Alternative instance for ZipList (fix #13520)..

I saw this suggestion in the original thread: https://mail.haskell.org/pipermail/libraries/2015-July/025978.html, perhaps something to consider?

Apr 4 2017, 12:44 PM

Jan 22 2016

adamse retitled D1828: Small doc fix from to Small doc fix.
Jan 22 2016, 4:23 PM

Dec 14 2015

adamse retitled D1612: Make binds in do-blocks strict when -XStrict (#11193) from Make all bindings strict when -XStrict (#11193) to Make binds in do-blocks strict when -XStrict (#11193).
Dec 14 2015, 7:40 AM
adamse updated the diff for D1612: Make binds in do-blocks strict when -XStrict (#11193).
  • Remove linebreak
  • Make sure that a lazy bind does what it should
Dec 14 2015, 7:33 AM
adamse planned changes to D1612: Make binds in do-blocks strict when -XStrict (#11193).

I might want to add to the testcase that lazy binds work as they should.

Dec 14 2015, 7:14 AM
adamse updated the diff for D1612: Make binds in do-blocks strict when -XStrict (#11193).
  • Add testcase
Dec 14 2015, 4:21 AM
adamse added a comment to D1612: Make binds in do-blocks strict when -XStrict (#11193).

Thanks @thomie, that seems like it will do the trick!

Dec 14 2015, 4:16 AM
adamse added a comment to D1612: Make binds in do-blocks strict when -XStrict (#11193).

Not sure how to test this. Is core stable enough to inspect in tests? But that doesn't seem particularly easy to do anyway...

Dec 14 2015, 4:06 AM
adamse retitled D1612: Make binds in do-blocks strict when -XStrict (#11193) from to Make all bindings strict when -XStrict (#11193).
Dec 14 2015, 3:59 AM

Dec 8 2015

adamse updated the Trac tickets for D1592: Make -XStrict imply -XStrictData (#11182).
Dec 8 2015, 2:53 PM
adamse retitled D1592: Make -XStrict imply -XStrictData (#11182) from to Make -XStrict imply -XStrictData (#11182).
Dec 8 2015, 2:43 PM

Nov 26 2015

adamse updated D1534: ghc-pkg: print version when verbose.
Nov 26 2015, 2:08 PM
adamse retitled D1534: ghc-pkg: print version when verbose from to ghc-pkg: print version when verbose.
Nov 26 2015, 2:05 PM

Nov 17 2015

adamse retitled D1485: Update Cabal submodule for new known extension from to Update Cabal submodule for new known extension.
Nov 17 2015, 5:29 AM

Nov 13 2015

adamse added inline comments to D1142: Implement the Strict language extension.
Nov 13 2015, 10:11 AM
adamse retitled D1142: Implement the Strict language extension from Implement Strict language extension to Implement the Strict language extension.
Nov 13 2015, 10:07 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • Strict: refer to note
Nov 13 2015, 9:59 AM

Nov 12 2015

adamse added inline comments to D1142: Implement the Strict language extension.
Nov 12 2015, 11:26 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • Update expected GHC extensions
Nov 12 2015, 9:58 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • make warnings on non-exhaustive pattern matches in let work
Nov 12 2015, 9:05 AM

Nov 6 2015

adamse added a comment to D1142: Implement the Strict language extension.

@bgamari, @tibbe, @simonpj: T5455 checks that we don't warn for inexhaustive pattern matches in let binds if we never demand the pattern:

Nov 6 2015, 8:31 AM

Oct 29 2015

adamse added a comment to D1142: Implement the Strict language extension.

Todo: fix new error

Oct 29 2015, 4:48 PM
adamse updated the diff for D1142: Implement the Strict language extension.
..
Oct 29 2015, 3:18 PM
adamse updated the diff for D1142: Implement the Strict language extension.
  • rebase again
Oct 29 2015, 3:01 PM
adamse updated the diff for D1142: Implement the Strict language extension.
  • fix rebase
Oct 29 2015, 11:03 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • strict: fix compilation
  • strict: beautify users guide entry
  • rebase
Oct 29 2015, 10:46 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • Rebase
Oct 29 2015, 8:53 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • Strict: Use IdEnv to find corresponding global vars
  • strict: fix patterns with no binders
  • strict: add some examples to comment
  • strict: share some code
  • strict: add comments
  • strict: expand note
Oct 29 2015, 8:45 AM

Oct 16 2015

adamse added a comment to D1142: Implement the Strict language extension.

I'm feeling pretty happy with the patch, can I get a round of reviews @bgamari, @tibbe, @simonpj?

Oct 16 2015, 9:44 AM
adamse retitled D1142: Implement the Strict language extension from WIP: Implement Strict language extension to Implement Strict language extension.
Oct 16 2015, 6:00 AM
adamse added a comment to D1142: Implement the Strict language extension.

Mark a bunch of comments as done.

Oct 16 2015, 5:51 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • Strict: update comments here and there
  • Rebase
Oct 16 2015, 5:50 AM

Oct 6 2015

adamse updated the diff for D1142: Implement the Strict language extension.
  • Strict: fix T4437
Oct 6 2015, 1:03 PM
adamse updated the diff for D1142: Implement the Strict language extension.
  • Update users guide entry to rst
  • Rebase
Oct 6 2015, 12:11 PM
adamse added a comment to D1142: Implement the Strict language extension.

@adamse, how is progress going? It appears this needs to be rebased on the ReST user-guide change.

Oct 6 2015, 10:00 AM

Sep 27 2015

adamse updated the diff for D1142: Implement the Strict language extension.
  • Strict: OrdList -> []
  • Strict: add regression test for let-like binders
Sep 27 2015, 4:00 PM

Sep 23 2015

adamse accepted D1269: Update Cabal to recognize DeriveLift (#1830).

You're welcome. It was nice to be able to help!

Sep 23 2015, 9:59 AM
adamse added a comment to D1269: Update Cabal to recognize DeriveLift (#1830).

It seems the testsuite was fixed in rGHC79f57325dca4d1ce4601d01c4fab50f7bcfc9b9b.

Sep 23 2015, 6:01 AM

Sep 22 2015

adamse requested changes to D1269: Update Cabal to recognize DeriveLift (#1830).

Also this line still appears

Sep 22 2015, 11:16 AM
adamse added a comment to D1269: Update Cabal to recognize DeriveLift (#1830).

It seems output was changed by https://github.com/haskell/cabal/commit/6661945754d62fc6ad5e9fd68d17f472adfb44d0.

Sep 22 2015, 11:15 AM
adamse added a comment to D1269: Update Cabal to recognize DeriveLift (#1830).

Both failing test-cases (https://phabricator.haskell.org/harbormaster/build/6301/) seem to be related to Cabal in some way...

Sep 22 2015, 11:10 AM
adamse added a comment to D1168: DeriveLift extension (#1830).

@RyanGlScott: Since it has been merged a new Diff is probably the way to go, but perhaps it is a simple enough fix that @austin or @bgamari can make a quick fix?

Sep 22 2015, 9:58 AM
adamse added a comment to D1168: DeriveLift extension (#1830).

This patch breaks the build:

Sep 22 2015, 9:50 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • Strict: Accept new error output T6078
Sep 22 2015, 8:40 AM
adamse updated D1142: Implement the Strict language extension.
Sep 22 2015, 7:58 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • Add Strict to expected GHC language extensions test
  • add Strict to users guide
  • add literal tags to docs
  • strict toEnum error currently
  • Strict: Desugar strict bindings working
  • Strict: fix T9140
  • add back opt_strict
Sep 22 2015, 7:46 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • rebase
Sep 22 2015, 3:50 AM
adamse updated the diff for D1142: Implement the Strict language extension.
  • Working desugaring?
  • Rebase
Sep 22 2015, 2:48 AM
adamse updated D1142: Implement the Strict language extension.
Sep 22 2015, 2:16 AM

Sep 21 2015

adamse added a comment to D1142: Implement the Strict language extension.
In D1142#35454, @tibbe wrote:

Adam, do you think you'll still have time to look into this now when your studies have started?

Sep 21 2015, 9:41 AM

Aug 21 2015

adamse added a comment to D1142: Implement the Strict language extension.

An observation, allowing polymorphic bang patterns might break some code:

Aug 21 2015, 5:17 AM

Aug 19 2015

adamse updated D1142: Implement the Strict language extension.
Aug 19 2015, 8:09 AM