Yuras (Yuras Shumovich)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 6 2014, 2:56 AM (235 w, 6 d)

Recent Activity

Mon, Dec 10

Yuras added a comment to D5285: Warn about unused packages.

Throw a warning if -Wunused-packages is used without -fforce-recomp.

Mon, Dec 10, 11:28 AM
Yuras updated the diff for D5285: Warn about unused packages.
  • Mention -fforce-recomp in the user guide
Mon, Dec 10, 11:24 AM

Mon, Dec 3

Yuras added a comment to D5285: Warn about unused packages.

Oops, I missed notifications for this Diff somehow, sorry.
@bgamari so what actions should I perform to get it merged? Suggest -fforce-recomp in user guide? Anything else?

Mon, Dec 3, 9:14 AM

Nov 8 2018

Yuras added a comment to D5285: Warn about unused packages.

@mpickering On other hand, why should we force user to recompile all the code if she can get results immediately, even if less occurate? So I'm -0.5 for enabling -fforce-recomp by default, I think it is enough to suggest it in the user guide. @bgamari, what do you think about that?

Nov 8 2018, 5:25 AM

Nov 7 2018

Yuras added a comment to D5285: Warn about unused packages.

@mpickering I understand your concern, but IMO it is completely clear what the patch does in case of a clean build. It is not clear why GHC loads all packages when doing partial recompilation, and I need someone's help to figure it out. Do you have any idea? My best guess is that packages are necessary for linking executable/library, but I'm not familiar with this part of GHC. As you probably know, I contribute only occasionally, and my knowledges are sparse.

Nov 7 2018, 2:07 PM

Nov 6 2018

Yuras added a comment to D5285: Warn about unused packages.

@bgamari I added a release note.

Nov 6 2018, 12:09 PM
Yuras updated the diff for D5285: Warn about unused packages.
  • Add release note
Nov 6 2018, 12:02 PM

Nov 1 2018

Yuras added a comment to D5285: Warn about unused packages.

Ok, I fixed the issue with wired-in packages. I inlined the matching function from Packages and modified it. Not sure whether the original function should be fixed instead.

Nov 1 2018, 11:51 AM
Yuras updated the diff for D5285: Warn about unused packages.
  • Fix wired-in package handling
Nov 1 2018, 11:45 AM
Yuras planned changes to D5285: Warn about unused packages.

I wasn't able to quickly find the reason for the false positivities, so lets change status to prevent accidental merge.

Nov 1 2018, 8:35 AM
Yuras added a comment to D5285: Warn about unused packages.

@simonpj I added a test and reworded the message:

The following packages were specified via -package or -package-id flags, but were not needed for compilation:

Nov 1 2018, 7:22 AM
Yuras updated the diff for D5285: Warn about unused packages.
  • Change message, add test
Nov 1 2018, 7:09 AM

Oct 30 2018

hvr awarded D5285: Warn about unused packages a Like token.
Oct 30 2018, 11:31 AM
Yuras added a comment to D5285: Warn about unused packages.

@mpickering To my surprice, it seems to work when run the second time. I'm not sure why. Anyway, the idea is to use this flag on a clean code base.

Oct 30 2018, 11:24 AM
Yuras updated the diff for D5285: Warn about unused packages.
  • Fix the check
Oct 30 2018, 11:21 AM
Yuras added a comment to D5285: Warn about unused packages.

This probably requires tests yet.

Oct 30 2018, 10:53 AM
Yuras created D5285: Warn about unused packages.
Oct 30 2018, 10:51 AM

May 22 2017

Yuras accepted D3598: Handle file targets in missing home modules warning.

LGTM. @hvr, thank you for taking care of of this patch!

May 22 2017, 5:52 AM

May 19 2017

Yuras updated the diff for D3598: Handle file targets in missing home modules warning.
  • Handle also file targets, converted from module targets
May 19 2017, 7:05 AM
hvr awarded D3598: Handle file targets in missing home modules warning a Party Time token.
May 19 2017, 6:16 AM
Yuras added a reviewer for D3598: Handle file targets in missing home modules warning: hvr.
May 19 2017, 5:30 AM
Yuras created D3598: Handle file targets in missing home modules warning.
May 19 2017, 5:29 AM

Jan 18 2017

Yuras updated the diff for D2977: Warn on missing home modules.

Formatting

Jan 18 2017, 4:01 AM
Yuras updated the diff for D2977: Warn on missing home modules.

Wording

Jan 18 2017, 3:57 AM

Jan 16 2017

Yuras added a comment to D2977: Warn on missing home modules.

@simonpj My English writing skills are relatively poor, sorry. Please let me know if the Note is not clear enough.

Jan 16 2017, 6:51 AM
Yuras updated the diff for D2977: Warn on missing home modules.

Add a Note

Jan 16 2017, 6:48 AM
Yuras updated the diff for D2977: Warn on missing home modules.

Fix typos

Jan 16 2017, 1:48 AM

Jan 15 2017

Yuras added a comment to D2977: Warn on missing home modules.

T12234 failure looks unrelated for me, I see it in other builds. But recomp001 failure on osx is puzzling, does anyone has an idea what is going here? I can't reproduce it locally (linux).

Jan 15 2017, 12:28 PM
Yuras added a comment to D2976: Unbreak build with ghc-7.10.1.

T12234 failure looks unrelated for me, I see it in other builds. Everything else is OK.

Jan 15 2017, 12:26 PM
Yuras updated the diff for D2977: Warn on missing home modules.

Retry

Jan 15 2017, 9:53 AM
Yuras updated the diff for D2976: Unbreak build with ghc-7.10.1.

Retry

Jan 15 2017, 9:51 AM
Yuras retitled D2977: Warn on missing home modules from to Warn on missing home modules.
Jan 15 2017, 6:11 AM
Yuras retitled D2976: Unbreak build with ghc-7.10.1 from to Unbreak build with ghc-7.10.1.
Jan 15 2017, 6:00 AM

Feb 27 2016

Yuras accepted D1953: rts: drop unused global 'blackhole_queue'.

Thank you, such left-overs are confusing when reading code the first time.

Feb 27 2016, 7:33 AM

Feb 15 2016

Yuras retitled D1919: Suggest candidate instances in error message from to Suggest candidate instances in error message.
Feb 15 2016, 2:35 PM

Dec 8 2015

Yuras added a comment to D1264: Merge Compacts into GHC.

The following program crashes for me:

Dec 8 2015, 2:01 PM

Aug 26 2015

Yuras added a comment to D1175: Fix identifier parsing in hp2ps.

I didn't find a way to make a test for hp2ps. Probably it doesn't worth it.

Aug 26 2015, 2:30 PM
Yuras updated the test plan for D1175: Fix identifier parsing in hp2ps.
Aug 26 2015, 2:30 PM
Yuras updated the diff for D1175: Fix identifier parsing in hp2ps.

Don't use a global variable

Aug 26 2015, 2:28 PM
Yuras planned changes to D1175: Fix identifier parsing in hp2ps.

I just found that the test case is not suitable for the issue because package key for 'random' package (used in the test case) may change in future, so it will not start with a digit any more. We need a special test case for the issue.

Aug 26 2015, 4:51 AM
Yuras added a comment to D1175: Fix identifier parsing in hp2ps.
  • Your commit message is difficult to parse.
Aug 26 2015, 4:46 AM
Yuras updated D1175: Fix identifier parsing in hp2ps.
Aug 26 2015, 4:38 AM

Aug 25 2015

Yuras retitled D1175: Fix identifier parsing in hp2ps from to Fix identifier parsing in hp2ps.
Aug 25 2015, 11:10 AM

Feb 15 2015

Yuras retitled D660: Add configurable verbosity level to hpc from to Add configurable verbosity level to hpc.
Feb 15 2015, 12:47 PM

Feb 12 2015

Yuras abandoned D252: Support C structure as return value of ccall in cmm.
Feb 12 2015, 7:11 AM · GHC

Dec 8 2014

Yuras updated D556: fix misleading error message regarding function arity.
Dec 8 2014, 4:08 PM
Yuras updated D556: fix misleading error message regarding function arity.
Dec 8 2014, 4:07 PM
Yuras abandoned D563: make integer_gmp_mpn_import1 static.

@thomie Oh, I see. Thanks. @hvr decided to remove "inline" completely, that makes sense too.

Dec 8 2014, 7:09 AM

Dec 7 2014

Yuras retitled D563: make integer_gmp_mpn_import1 static from to make integer_gmp_mpn_import1 static.
Dec 7 2014, 7:53 PM
Yuras updated the diff for D556: fix misleading error message regarding function arity.

update test output

Dec 7 2014, 6:57 AM
Yuras updated the diff for D556: fix misleading error message regarding function arity.

add both the original and specialized types into error context

Dec 7 2014, 6:52 AM

Dec 6 2014

Yuras added a comment to D556: fix misleading error message regarding function arity.

@austin what about the next:

Dec 6 2014, 6:39 AM
Yuras added a comment to D556: fix misleading error message regarding function arity.

@austin are you sure but is necessary here? It suggests that there is a mismatch between number of arguments and function arity, but that is not true. This two lines provide an additional context in case the inferred is specialized in unexpected way, e.g. when user missed do or parenthesis.

Dec 6 2014, 4:59 AM

Dec 4 2014

Yuras retitled D556: fix misleading error message regarding function arity from to fix misleading error message regarding function arity.
Dec 4 2014, 7:18 PM

Nov 15 2014

Yuras updated subscribers of D181: Don't allowInterrupt inside uninterruptibleMask.
Nov 15 2014, 12:01 PM
Yuras retitled D478: Remove outdated TODO in TimeManager from to Remove outdated TODO in TimeManager.
Nov 15 2014, 10:46 AM

Oct 24 2014

Yuras updated the diff for D252: Support C structure as return value of ccall in cmm.

comments only

Oct 24 2014, 5:34 AM · GHC

Oct 22 2014

Yuras retitled D368: fix a typo in comments: normaliseFfiType from to fix a typo in comments: normaliseFfiType.
Oct 22 2014, 4:42 PM

Oct 20 2014

Yuras retitled D358: reflect ForeignType constructore removal from to reflect ForeignType constructore removal.
Oct 20 2014, 8:20 PM
Yuras retitled D357: remove old .NET related code from to remove old .NET related code.
Oct 20 2014, 7:09 PM

Oct 19 2014

Yuras added a comment to D252: Support C structure as return value of ccall in cmm.
In D252#8304, @tibbe wrote:

Regarding the manual, didn't you extend the foreign import syntax to allow users to specify a struct return type?

Oct 19 2014, 4:39 AM · GHC

Oct 18 2014

Yuras updated the diff for D252: Support C structure as return value of ccall in cmm.

Address (most of) issues @tibbe raised

Oct 18 2014, 8:28 AM · GHC
Yuras added a comment to D252: Support C structure as return value of ccall in cmm.

@tibbe Thanks you for you comments!

Oct 18 2014, 8:27 AM · GHC

Oct 16 2014

Yuras updated the Trac tickets for D252: Support C structure as return value of ccall in cmm.
Oct 16 2014, 3:18 PM · GHC

Oct 13 2014

Yuras added a comment to rGHC3575109bebf4: Update more performance numbers due to stricter seqDmdType.

@nomeata do you mean rGHCf3ae936e04dda1b28b0fa8f4c65a99407164ee99?
Hmm... it doesn't seem to touch T4801, at least in master the values are still different: https://phabricator.haskell.org/diffusion/GHC/browse/master/testsuite/tests/perf/compiler/all.T;f3ae936e04dda1b28b0fa8f4c65a99407164ee99$184

Oct 13 2014, 2:16 PM
Yuras added inline comments to rGHC3575109bebf4: Update more performance numbers due to stricter seqDmdType.
Oct 13 2014, 12:40 PM

Oct 8 2014

Yuras updated the diff for D252: Support C structure as return value of ccall in cmm.

32bit mac os support

Oct 8 2014, 2:00 PM · GHC

Oct 7 2014

Yuras added a comment to D252: Support C structure as return value of ccall in cmm.

Sorry I incidentally pressed submit before the comment finished.
Not the code doesn't use red zone (which) is linux specific.

Oct 7 2014, 10:22 AM · GHC
Yuras updated the diff for D252: Support C structure as return value of ccall in cmm.

Don't use red zone when

Oct 7 2014, 10:16 AM · GHC
Yuras added a comment to D252: Support C structure as return value of ccall in cmm.

Does this support structures with non-standard packing?

Oct 7 2014, 1:20 AM · GHC

Oct 6 2014

Yuras planned changes to D252: Support C structure as return value of ccall in cmm.

I tested it on mac os X x86_64 -- just works. Mac os on x86 is probably dead, I don't have access to it.

Oct 6 2014, 2:40 PM · GHC
Yuras updated D252: Support C structure as return value of ccall in cmm.
Oct 6 2014, 2:35 PM · GHC

Oct 3 2014

Yuras updated the diff for D252: Support C structure as return value of ccall in cmm.

Implement windows x86 support

Oct 3 2014, 6:36 PM · GHC
Yuras retitled D305: configure in base: add msys to windows check from to configure in base: add msys to windows check.
Oct 3 2014, 6:00 AM · GHC
Yuras retitled D304: Fix configure check for 9439 bug from to Fix configure check for 9439 bug.
Oct 3 2014, 5:19 AM · GHC

Sep 27 2014

Yuras updated the diff for D252: Support C structure as return value of ccall in cmm.

oops, I messed up with arc...

Sep 27 2014, 7:03 PM · GHC
Yuras updated the diff for D252: Support C structure as return value of ccall in cmm.

Add Notes re calling convention, few haddock comments, reorder functions, typo

Sep 27 2014, 6:59 PM · GHC
Yuras retitled D252: Support C structure as return value of ccall in cmm from to Support C structure as return value of ccall in cmm.
Sep 27 2014, 4:04 AM · GHC