Tarrasch (Arash Rouhani)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2014, 4:11 PM (235 w, 3 h)

Recent Activity

Apr 20 2016

Tarrasch added a comment to D1196: Libdw: Add libdw-based stack unwinding.

To see the bigger picture of this changeset. Check out this wiki page: https://ghc.haskell.org/trac/ghc/wiki/DWARF/80Status

Apr 20 2016, 3:03 AM

Nov 4 2015

Tarrasch abandoned D963: Add Stack Traces in Haskell land based on symtab.

Abandoning. As far as I understand, D1196 together with D1198 strictly supersedes this. Also see https://ghc.haskell.org/trac/ghc/wiki/DWARF/80Status for clearer status page.

Nov 4 2015, 4:12 AM
Tarrasch added a comment to rGHC52c6e3d608ee: Libdw: Fix symbol naming.

Awesome that you fixed the code style to @bgamari! :)

Nov 4 2015, 4:03 AM

Oct 27 2015

Tarrasch added a comment to D1198: Provide DWARF-based backtraces to Haskell-land.

Cool! Looked through a bit. Did not read every line in detail though. Do you plan to migrate the test cases from my patch too? Would for sure boost my confidence in the correctness of the good.

Oct 27 2015, 8:27 AM

Oct 17 2015

Tarrasch added a comment to D1197: Signals: Print backtrace on SIGUSR2.

Sweet! :D

Oct 17 2015, 11:36 AM
Tarrasch added a comment to D1196: Libdw: Add libdw-based stack unwinding.

Wohoo! Great job @bgamari!!!

Oct 17 2015, 11:35 AM

Sep 6 2015

Tarrasch added a comment to D1196: Libdw: Add libdw-based stack unwinding.

Finally had time to go through this in detail. It looks really good and exciting!

Sep 6 2015, 5:09 AM

Sep 1 2015

Tarrasch added a comment to D1197: Signals: Print backtrace on SIGUSR2.

Nice!

Sep 1 2015, 4:21 PM
Tarrasch added a comment to D1198: Provide DWARF-based backtraces to Haskell-land.

Looks good!

Sep 1 2015, 4:20 PM
Tarrasch added a comment to D1196: Libdw: Add libdw-based stack unwinding.
Sep 1 2015, 4:03 PM
Tarrasch added a comment to D1196: Libdw: Add libdw-based stack unwinding.

Looks good! :)

Sep 1 2015, 4:03 PM

Aug 29 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

@scpmw and @bgamari, did the experimentation done in D1156 bring any conclusions related to this patch? If not I would like us to continue to see if this patch can be merged. What needs to be done?

Aug 29 2015, 6:43 AM

Aug 26 2015

Tarrasch added a comment to D1172: Dwarf: Fix DW_AT_use_UTF8 attribute.

LGTM. But somebody who knows dwarf have to review this! :)

Aug 26 2015, 10:43 AM

Aug 23 2015

Tarrasch added a comment to D1156: [RFC] Add libdw-based backtraces.

Nice that you build upon D963 so that patch doesn't get lost. ^^

Aug 23 2015, 11:23 AM

Aug 21 2015

Tarrasch added a comment to D1156: [RFC] Add libdw-based backtraces.

Cool! Awesome progress @bgamari, such productivity! :)

Aug 21 2015, 4:18 PM

Aug 19 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

@bgamari, actually Codemap is just a shrink-down of the old Dwarf.c, which was Codemap.c + dwarf-parts. I had a prototype in D662 even. So I guess current Codemap.c can be expanded to incorporate Dwarf in the future. It used libdwarf and not libdw, not sure if that matters.

Aug 19 2015, 10:03 AM

Aug 9 2015

Tarrasch updated subscribers of D963: Add Stack Traces in Haskell land based on symtab.

@bgamari, nice. I updated some documentation. Now I'll try to ping our other colleagues. :)

Aug 9 2015, 7:01 AM
Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.
Aug 9 2015, 6:36 AM
Tarrasch updated D963: Add Stack Traces in Haskell land based on symtab.
Aug 9 2015, 6:33 AM
Tarrasch updated D963: Add Stack Traces in Haskell land based on symtab.
Aug 9 2015, 6:32 AM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.

Update docs and comments

Aug 9 2015, 6:25 AM

Aug 4 2015

Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.

Rebase so patch can be applied (and validate)

Aug 4 2015, 9:39 AM

Jul 27 2015

Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.

Add (c) notices to rts files

Jul 27 2015, 1:47 PM
Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

Alright, the 'dyn' tests pass now as well. Let me know it there's anything more to fix for this patch. Otherwise what needs to be done in order to get this to land?

Jul 27 2015, 1:16 PM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.

Make tests run with 'dyn' as well

Jul 27 2015, 1:01 PM

Jul 23 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

Cool. Seems like this patch is looking ready then. I'll just have to look at the segfault. Hopefully a minor fix. :)

Jul 23 2015, 4:39 PM

Jul 21 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

I'll iterate on this again because of the core dumped issue in executionStack002 test. Anyway, I think this patch can be reviewed still. :)

Jul 21 2015, 12:16 PM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.

Remove extra whitespace in testlib.py

Jul 21 2015, 12:16 PM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.

Small fixes

Jul 21 2015, 12:09 PM

Jul 20 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

For some very weird reason I have started to get this error locally now. I'm pushing my changes to see if the build machine also suddenly have started to fail or not.

Jul 20 2015, 6:05 PM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.
  • Fix @bgmari's comments. Remove unused Codemap-code
Jul 20 2015, 6:04 PM
Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

Thanks for the review @bgamari! I'll try to iterate on it early this week. :)

Jul 20 2015, 10:21 AM

Jul 19 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

I would really appreciate another round of review guys. :)

Jul 19 2015, 2:26 PM
Tarrasch changed the image for Image Macro "prettypleasecat".
Jul 19 2015, 2:24 PM
Tarrasch updated the test plan for D963: Add Stack Traces in Haskell land based on symtab.
Jul 19 2015, 7:38 AM
Tarrasch updated the test plan for D963: Add Stack Traces in Haskell land based on symtab.
Jul 19 2015, 7:36 AM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.

Make it ./validate with elf as well.

Jul 19 2015, 7:15 AM

Jul 11 2015

Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.
  • Only run tests when GHC has libelf
Jul 11 2015, 4:37 PM
Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

Hmm, I have a couple of questions. I would appreciate any help:

Jul 11 2015, 4:31 PM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.
  • Whoups, ELF not DWARF :)
  • Only run tests when GHC has libelf
Jul 11 2015, 4:31 PM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.
  • Mark *ip as UNUSED for no USE_ELF
  • Remove redundant import
Jul 11 2015, 8:45 AM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.
  • Mark *ip as UNUSED for no USE_ELF
Jul 11 2015, 8:40 AM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.
  • Mark *ip as UNUSED for no USE_ELF
Jul 11 2015, 8:39 AM

Jul 4 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

Ok, so the validation errors is basically part of this build step: make binary-dist-prep && make test_bindist TEST_PREP=YES.

Jul 4 2015, 7:37 AM
Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

Hmm, there's some new ./validate errors locally I'll have to fix. But please review the code in itself. :)

Jul 4 2015, 2:31 AM
Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

Okay. I'll be happy to receive another round of review. :)

Jul 4 2015, 1:55 AM
Tarrasch updated D963: Add Stack Traces in Haskell land based on symtab.
Jul 4 2015, 1:54 AM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.

Updated the arc patch description

Jul 4 2015, 1:53 AM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.

Moved testing stuff to Internal. Minimized public interface.

Jul 4 2015, 1:49 AM

Jun 27 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

Hmm, @scpmw, what do you think about exporting getCurrentStackFrames :: IO [StackFrame] and printStackFrames :: [StackFrames] -> IO ()? Then I hide the rest of the exports under -- * Internal. I still need to test the code somehow so I do need to export stuff under -- * Internal. Besides, GHC.Stack exports stuff like that at the moment. So it can't be that bad if @simonmar does it! ;)

Jun 27 2015, 7:34 AM

Jun 24 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

@scpmw, I like your comments. it gives very good perspective. Allow me to say how I reason around this.

Jun 24 2015, 3:14 PM
Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

@scpmw, do you have any thoughts on what to do with the Haskell modules? I would really appreciate your comments on this. If you're not sure, I can start just playing around and move stuff around until I think it looks sensible and upload a new patch.

Jun 24 2015, 1:12 PM

Jun 20 2015

Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.
  • Update comments in Codemap.h
Jun 20 2015, 6:13 AM
Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

So I fixed the "easy" parts of what you guys commented on. However, I do need some advice on how to proceed with the whole GHC.Stack vs GHC.ExecutionStack story.

Jun 20 2015, 6:01 AM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.
  • Remove file ".env" commited by mistake
Jun 20 2015, 5:52 AM
Tarrasch updated the diff for D963: Add Stack Traces in Haskell land based on symtab.

Some code fixes:

Jun 20 2015, 5:49 AM

Jun 14 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

Thanks for the comments. I'll try to iterate on a new patch early this coming week. :)

Jun 14 2015, 7:21 AM

Jun 9 2015

Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

Good point @austin, can that be a follow-up commit (If we just say people to not use GHC.ExecutionStack)? Or should it be in this commit? I thought of doing some reconciliation a long time ago, but @scpmw discouraged me in order to keep it simple to begin with (get something working first, basically). But maybe now is the time?

Jun 9 2015, 3:18 AM

Jun 7 2015

Tarrasch updated subscribers of D963: Add Stack Traces in Haskell land based on symtab.

Adding @simonmar as a reviewer. :)

Jun 7 2015, 11:29 AM

Jun 6 2015

Tarrasch updated subscribers of D963: Add Stack Traces in Haskell land based on symtab.

Seems like the build environment does not have libelf. And I would like to have some help on how to proceed.

Jun 6 2015, 10:47 AM
Tarrasch added a comment to D963: Add Stack Traces in Haskell land based on symtab.

I'll add the reviewers and subscribers from D662 once I see that validation passes (so people don't get spammed by my tiny code amendments).

Jun 6 2015, 10:10 AM
Tarrasch retitled D963: Add Stack Traces in Haskell land based on symtab from to Add Stack Traces in Haskell land based on symtab.
Jun 6 2015, 10:09 AM

May 31 2015

Tarrasch abandoned D662: Haskell land Stack Traces proposal.

Abandoning to clear reviewers watch list. I just opened this diff to show a "direction" for Haskell land stack traces and I think this diff did that. Look forward to a new patch as I described in D661. :)

May 31 2015, 10:55 AM
Tarrasch abandoned D661: rts: Add Stack.c and accompanying rtsflags.

Not really this particular patch. I'm working on a new patch, which tries to provide some actual value like D662 does, but tries to stay "minimal" like this Diff.

May 31 2015, 10:53 AM

Apr 21 2015

Tarrasch added a comment to D661: rts: Add Stack.c and accompanying rtsflags.

@scpmw, So I'm not sure exactly what I will be needing. I noticed that in Dwarf.c, you do a lot of the libelf stuff as well. I figured I should trim down that Dwarf.c to just do the libelf stuff. More precisely, I should use the Elf information in the binary to look up symbol names, using the instruction pointers that reside on the Haskell stack. Does that "plan" make sense @scpmw? It wouldn't use any of the dwarf information, but we can still retrieve names from the symbol table. Is that correct?

Apr 21 2015, 4:00 AM

Apr 19 2015

Tarrasch added a comment to D661: rts: Add Stack.c and accompanying rtsflags.

@scpmw, Did you have time to look anything at a minified version of Dwarf.c?

Apr 19 2015, 1:48 PM

Mar 6 2015

Tarrasch added a comment to D661: rts: Add Stack.c and accompanying rtsflags.

Anyway, starting tomorrow. I'll be on vacation for 3 weeks. I'll continue to iterate on this patch after that. :)

Mar 6 2015, 7:30 AM

Mar 2 2015

Tarrasch added a comment to D661: rts: Add Stack.c and accompanying rtsflags.

@simonmar, should I send the ENTRY_CODE implementations in their own diff so the diffs I send are as small as possible (while still being valuable on their own)?

Mar 2 2015, 3:44 PM
Tarrasch updated the diff for D661: rts: Add Stack.c and accompanying rtsflags.

Fix comments from @simonmar

Mar 2 2015, 3:41 PM

Mar 1 2015

Tarrasch added a comment to D661: rts: Add Stack.c and accompanying rtsflags.

Thanks for your comments Simon! I just stumbled upon a small road-block on GET_ENTRY. I'm about to submit my patch once it validates. :)

Mar 1 2015, 3:35 PM

Feb 26 2015

Tarrasch added a comment to D662: Haskell land Stack Traces proposal.

I'm still reading through the patch

Feb 26 2015, 4:30 PM

Feb 25 2015

Tarrasch added a comment to D662: Haskell land Stack Traces proposal.

I was about to answer you @tibbe, but I see that @scpmw already gave a very good and complete answer (as always :)). I would just like to say that I think that it would be very hard to implement freezing efficiently. I'm not even sure it's possible. If it's a GC safe data structure, doesn't it need to traversed during GC anyway? I wrote a lot about efficient stack reification in my master thesis. http://www.arashrouhani.com/papers/master-thesis.pdf, I think the tl;dr is to stick with the simplest solution (O(n) copy).

Feb 25 2015, 4:10 AM

Feb 22 2015

Tarrasch added a comment to D661: rts: Add Stack.c and accompanying rtsflags.

I agree that this patch can be hard to argue about since it doesn't provide any value on it's own.

Feb 22 2015, 1:18 PM

Feb 21 2015

Tarrasch added a comment to D662: Haskell land Stack Traces proposal.

Actually, once D661 is out of the way. I think I could submit this as another partial yet compilable patch by splitting out the stack-reification part of this into it's own patch set. The thing is that stack-reification (even when in Haskell land) does not require the dwarf parts. Would that make sense?

Feb 21 2015, 5:24 PM

Feb 20 2015

Tarrasch updated the diff for D662: Haskell land Stack Traces proposal.

Fixed test cases and amended stuff

Feb 20 2015, 5:50 PM
Tarrasch updated the diff for D662: Haskell land Stack Traces proposal.
  • Validation fixes
Feb 20 2015, 1:54 PM

Feb 17 2015

Tarrasch updated the diff for D661: rts: Add Stack.c and accompanying rtsflags.

fix validation error in countStackSize

Feb 17 2015, 4:32 PM

Feb 16 2015

Tarrasch added inline comments to D661: rts: Add Stack.c and accompanying rtsflags.
Feb 16 2015, 2:56 AM
Tarrasch updated the diff for D661: rts: Add Stack.c and accompanying rtsflags.

Set default limit 100 on max stack reification size

Feb 16 2015, 2:52 AM

Feb 15 2015

Tarrasch updated the diff for D661: rts: Add Stack.c and accompanying rtsflags.

Fix unsigned/signed bug. Thanks Harbormaster and static analysis!

Feb 15 2015, 6:04 PM
Tarrasch added parent revisions for D662: Haskell land Stack Traces proposal: D661: rts: Add Stack.c and accompanying rtsflags, D169: Source Note Core Infrastructure.

Hmm, Peter, how did you get Phabricator to understand that D396 depends on D169? I can't get this one to understand that this diff depends on D661. Hmm :-/

Feb 15 2015, 5:33 PM
Tarrasch added a child revision for D169: Source Note Core Infrastructure: D662: Haskell land Stack Traces proposal.
Feb 15 2015, 5:33 PM
Tarrasch added a child revision for D661: rts: Add Stack.c and accompanying rtsflags: D662: Haskell land Stack Traces proposal.
Feb 15 2015, 5:33 PM
Tarrasch updated the diff for D662: Haskell land Stack Traces proposal.

Just append to summary

Feb 15 2015, 5:30 PM
Tarrasch added a comment to D661: rts: Add Stack.c and accompanying rtsflags.

Ok, uploaded D662 now which should show how this patch can be used.

Feb 15 2015, 5:24 PM
Tarrasch retitled D662: Haskell land Stack Traces proposal from to Haskell land Stack Traces proposal.
Feb 15 2015, 5:22 PM
Tarrasch added a comment to D661: rts: Add Stack.c and accompanying rtsflags.

Hi guys, I started with a small patch towards stack traces. I plan to very soon upload a bigger diff which shows the direction as a whole I'm thinking about.

Feb 15 2015, 5:04 PM
Tarrasch retitled D661: rts: Add Stack.c and accompanying rtsflags from to rts: Add Stack.c and accompanying rtsflags.
Feb 15 2015, 4:59 PM

Dec 17 2014

Tarrasch added a comment to D396: DWARF generation.

Awesome job on landing this. Hehe, will do a lot of rebasing during the christmas holidays then! :)

Dec 17 2014, 6:45 AM

Dec 16 2014

Tarrasch added a comment to D169: Source Note Core Infrastructure.

Cool! :D

Dec 16 2014, 4:13 PM
Tarrasch added a comment to D396: DWARF generation.

Oh my, I can't believe I missed this patch set! Fantastic that this patch set is also reviewed and underway, good job!

Dec 16 2014, 2:56 AM

Nov 17 2014

Tarrasch added a comment to D169: Source Note Core Infrastructure.

Thanks for the update. Keep them coming. :)

Nov 17 2014, 3:43 AM

Oct 29 2014

Tarrasch added a comment to D169: Source Note Core Infrastructure.

Cool! What is remaining for this patch set to be merged now?

Oct 29 2014, 4:25 AM

Oct 15 2014

Tarrasch added a comment to D169: Source Note Core Infrastructure.

Nice to see all this progress! Have you considered to also just fix the lint warnings that were introduced in your patches?

Oct 15 2014, 3:40 PM

Oct 4 2014

Tarrasch added a comment to D169: Source Note Core Infrastructure.

Yea, I also heard about the GHC freeze. Also note that this patch set does not include the DWARF stuff yet, am I correct?

Oct 4 2014, 4:13 PM

Sep 26 2014

Tarrasch added a comment to D169: Source Note Core Infrastructure.

@scpmw, are you still on this? It would be nice to continue to see the nice progress on this! :)

Sep 26 2014, 3:47 PM

Sep 1 2014

Tarrasch added a comment to D189: Refactor stack squeezing logic.

Perfect, thanks Austin! :)

Sep 1 2014, 2:24 PM
Tarrasch added a comment to D189: Refactor stack squeezing logic.

Hmm, I tried to land my change but couldn't (I told arc to ignore the build failure). I get this error:

Sep 1 2014, 1:16 PM
Tarrasch added a comment to D189: Refactor stack squeezing logic.

Cool! It's awesome that it builds it for me, but the failure I got is not due to me right? It seems like all the 90 builds prior to mine failed as well.

Sep 1 2014, 1:06 PM
Tarrasch retitled D189: Refactor stack squeezing logic from to Refactor stack squeezing logic.
Sep 1 2014, 12:28 PM