RyanGlScott (Ryan Scott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 8 2015, 11:07 PM (183 w, 2 d)

Recent Activity

Today

RyanGlScott created D4968: Fix #15385 by using addDictsDs in matchGuards.
Sun, Jul 15, 3:51 PM

Yesterday

RyanGlScott added a comment to D4966: Fixed "Memory Model" example..

My two cents: I'm quite fine with including these explicit imports, especially since it uses functionality from outside Data.IORef itself.

Sat, Jul 14, 7:45 PM
RyanGlScott updated the diff for D4965: Fix parse errors in core-spec.pdf.
  • Wibble
Sat, Jul 14, 3:03 PM
RyanGlScott updated the diff for D4965: Fix parse errors in core-spec.pdf.
  • Final suggestions
Sat, Jul 14, 3:03 PM

Fri, Jul 13

RyanGlScott added a comment to D4965: Fix parse errors in core-spec.pdf.

Thank you for bailing me out :)

Fri, Jul 13, 11:08 AM
RyanGlScott updated the diff for D4965: Fix parse errors in core-spec.pdf.
  • Bring sanity back to the submodules
Fri, Jul 13, 11:08 AM
RyanGlScott added inline comments to D4965: Fix parse errors in core-spec.pdf.
Fri, Jul 13, 10:13 AM
RyanGlScott updated the diff for D4965: Fix parse errors in core-spec.pdf.
  • Take three
Fri, Jul 13, 10:13 AM
RyanGlScott updated the diff for D4965: Fix parse errors in core-spec.pdf.
  • Take two
Fri, Jul 13, 9:50 AM
RyanGlScott added inline comments to D4965: Fix parse errors in core-spec.pdf.
Fri, Jul 13, 9:50 AM
RyanGlScott created D4965: Fix parse errors in core-spec.pdf.
Fri, Jul 13, 9:00 AM

Wed, Jul 11

RyanGlScott accepted D4865: Do not imply NoStarIsType by TypeOperators/TypeInType.

The GHC steering committee just approved https://github.com/ghc-proposals/ghc-proposals/pull/146, so I suppose it's time to land this in master proper.

Wed, Jul 11, 11:36 AM
RyanGlScott committed rGHC1c3536239cb5: Use IfaceAppArgs to store an IfaceAppTy's arguments (authored by RyanGlScott).
Use IfaceAppArgs to store an IfaceAppTy's arguments
Wed, Jul 11, 11:31 AM
RyanGlScott closed D4938: Use IfaceAppArgs to store an IfaceAppTy's arguments.
Wed, Jul 11, 11:31 AM
RyanGlScott updated the diff for D4938: Use IfaceAppArgs to store an IfaceAppTy's arguments.

Rebase on top of master

Wed, Jul 11, 7:25 AM
RyanGlScott added a comment to D4938: Use IfaceAppArgs to store an IfaceAppTy's arguments.

Are there any other things that need to be addressed here?

Wed, Jul 11, 6:03 AM

Sun, Jul 8

RyanGlScott committed rGHC6595bee749dd: Define an Outputable MCoercion instance (authored by RyanGlScott).
Define an Outputable MCoercion instance
Sun, Jul 8, 11:28 AM
RyanGlScott closed D4944: Define an Outputable MCoercion instance.
Sun, Jul 8, 11:28 AM
RyanGlScott added a comment to D4938: Use IfaceAppArgs to store an IfaceAppTy's arguments.

I think we could use an overview Note, explaining the dual role of IfaceType, for pretty printing and for binary serialisation.

Sun, Jul 8, 7:00 AM
RyanGlScott updated the diff for D4938: Use IfaceAppArgs to store an IfaceAppTy's arguments.
  • Simon and Richard's suggestions
Sun, Jul 8, 7:00 AM
RyanGlScott created D4944: Define an Outputable MCoercion instance.
Sun, Jul 8, 6:29 AM

Fri, Jul 6

RyanGlScott committed rGHC18cedbb55c7a: Make a variant of mkCastErr for kind coercions (authored by RyanGlScott).
Make a variant of mkCastErr for kind coercions
Fri, Jul 6, 9:59 AM
RyanGlScott closed D4940: Make a variant of mkCastErr for kind coercions.
Fri, Jul 6, 9:59 AM
RyanGlScott added a comment to D4941: Mark ForeignPtr as representational.

I'm not sure if Phabricator is a good place to have this discussion—I'd recommend bringing this up on Trac #9163, where this was originally decided.

Fri, Jul 6, 9:56 AM
RyanGlScott added a comment to D4941: Mark ForeignPtr as representational.

I'm confused. Ptr is definitely not representationally roled in its argument, as explained here.

Fri, Jul 6, 9:47 AM
RyanGlScott created D4940: Make a variant of mkCastErr for kind coercions.
Fri, Jul 6, 7:58 AM

Thu, Jul 5

RyanGlScott created D4938: Use IfaceAppArgs to store an IfaceAppTy's arguments.
Thu, Jul 5, 3:27 PM
RyanGlScott added a comment to rGHC45f002681840: Accept new stdout for tcrun045.

Thank you! Will you commit?

Thu, Jul 5, 10:10 AM
RyanGlScott committed rGHC45f002681840: Accept new stdout for tcrun045 (authored by RyanGlScott).
Accept new stdout for tcrun045
Thu, Jul 5, 9:09 AM
RyanGlScott committed rGHC9b26aa09036e: Comment out a pprTrace (authored by RyanGlScott).
Comment out a pprTrace
Thu, Jul 5, 9:09 AM
RyanGlScott committed rGHCdbdcacfc55f2: Make ppr_tc_args aware of -fprint-explicit-kinds (authored by RyanGlScott).
Make ppr_tc_args aware of -fprint-explicit-kinds
Thu, Jul 5, 9:09 AM
RyanGlScott closed D4932: Make ppr_tc_args aware of -fprint-explicit-kinds.
Thu, Jul 5, 9:09 AM
RyanGlScott committed rGHCb6a3386186b7: Fix #15331 with careful blasts of parenthesizeHsType (authored by RyanGlScott).
Fix #15331 with careful blasts of parenthesizeHsType
Thu, Jul 5, 9:09 AM
RyanGlScott closed D4920: Fix #15331 with careful blasts of parenthesizeHsType.
Thu, Jul 5, 9:09 AM
RyanGlScott committed rGHC57733978482d: Parenthesize rank-n contexts in Convert (authored by RyanGlScott).
Parenthesize rank-n contexts in Convert
Thu, Jul 5, 9:09 AM
RyanGlScott closed D4910: Parenthesize rank-n contexts in Convert.
Thu, Jul 5, 9:09 AM
RyanGlScott committed rGHC927518668111: Fix newtype instance GADTs (authored by RyanGlScott).
Fix newtype instance GADTs
Thu, Jul 5, 9:09 AM
RyanGlScott closed D4902: Fix newtype instance GADTs.
Thu, Jul 5, 9:08 AM
RyanGlScott committed rGHC132273f34e39: Instantiate GND bindings with an explicit type signature (authored by RyanGlScott).
Instantiate GND bindings with an explicit type signature
Thu, Jul 5, 9:08 AM
RyanGlScott closed D4895: Instantiate GND bindings with an explicit type signature.
Thu, Jul 5, 9:08 AM
RyanGlScott committed rGHC93b7ac8d7388: Fix #15308 by suppressing invisble args more rigorously (authored by RyanGlScott).
Fix #15308 by suppressing invisble args more rigorously
Thu, Jul 5, 9:08 AM
RyanGlScott closed D4891: Fix #15308 by suppressing invisble args more rigorously.
Thu, Jul 5, 9:08 AM
RyanGlScott committed rGHC59a15a56e180: Fix #15307 by making nlHsFunTy parenthesize more (authored by RyanGlScott).
Fix #15307 by making nlHsFunTy parenthesize more
Thu, Jul 5, 9:08 AM
RyanGlScott closed D4890: Fix #15307 by making nlHsFunTy parenthesize more.
Thu, Jul 5, 9:08 AM
RyanGlScott added inline comments to rGHC45f44e2c9d5d: Refactor validity checking for constraints.
Thu, Jul 5, 9:01 AM
RyanGlScott added a comment to rGHC45f44e2c9d5d: Refactor validity checking for constraints.

This commit appears to have broken the tcrun045 test:

Thu, Jul 5, 9:01 AM
RyanGlScott updated the diff for D4932: Make ppr_tc_args aware of -fprint-explicit-kinds.
  • Accept new test output for T7939
Thu, Jul 5, 7:29 AM
RyanGlScott added a comment to D4895: Instantiate GND bindings with an explicit type signature.

I believe this patch is ready to go.

Thu, Jul 5, 5:17 AM

Wed, Jul 4

RyanGlScott created D4932: Make ppr_tc_args aware of -fprint-explicit-kinds.
Wed, Jul 4, 11:47 AM

Tue, Jul 3

RyanGlScott accepted D4926: Add a broken test for lingering state from TH unique names #9693.

LGTM, assuming it validates.

Tue, Jul 3, 4:01 AM

Mon, Jul 2

RyanGlScott added a reviewer for D4920: Fix #15331 with careful blasts of parenthesizeHsType: alanz.
Mon, Jul 2, 1:03 PM
RyanGlScott created D4920: Fix #15331 with careful blasts of parenthesizeHsType.
Mon, Jul 2, 8:45 AM

Sat, Jun 30

RyanGlScott added a comment to D4865: Do not imply NoStarIsType by TypeOperators/TypeInType.

What is the status of this? It looks like this patch landed in the ghc-8.6 branch in abd6622324733c67b05e0cbd0c8c3d12c6332f61, but it is not present on master.

Sat, Jun 30, 5:08 PM
RyanGlScott updated the diff for D4891: Fix #15308 by suppressing invisble args more rigorously.
Sat, Jun 30, 4:14 PM

Fri, Jun 29

RyanGlScott created D4910: Parenthesize rank-n contexts in Convert.
Fri, Jun 29, 3:20 PM
RyanGlScott added a comment to D4902: Fix newtype instance GADTs.

The patch is missing the test now.

Fri, Jun 29, 9:41 AM
RyanGlScott updated the diff for D4902: Fix newtype instance GADTs.
  • Add back the test I accidentally deleted
  • Expand a Note
Fri, Jun 29, 9:41 AM
RyanGlScott added a comment to D4902: Fix newtype instance GADTs.

@simonpj, like this?

Fri, Jun 29, 8:55 AM
RyanGlScott updated the diff for D4902: Fix newtype instance GADTs.

@simonpj's suggestion

Fri, Jun 29, 8:55 AM
RyanGlScott commandeered D4902: Fix newtype instance GADTs.

Macro imcommandeeringthisdiff:

Fri, Jun 29, 8:55 AM
RyanGlScott added a comment to D1979: Add support for ImplicitParams and RecursiveDo in TH.

Thanks so much for picking this back up, @mgsloan! This looks really solid, so my suggestions are mostly minor. (Some of them are in the form of comments which don't necessarily require any action from you.)

Fri, Jun 29, 8:38 AM

Tue, Jun 26

RyanGlScott updated the diff for D4895: Instantiate GND bindings with an explicit type signature.
Tue, Jun 26, 7:24 AM

Mon, Jun 25

RyanGlScott added a comment to D4865: Do not imply NoStarIsType by TypeOperators/TypeInType.

Mmm, so it looks to me like there's little chance that these will be doable in a three-release-policy-compliant manner.

Mon, Jun 25, 3:48 PM
RyanGlScott created D4895: Instantiate GND bindings with an explicit type signature.
Mon, Jun 25, 11:50 AM

Sun, Jun 24

RyanGlScott added a comment to D4865: Do not imply NoStarIsType by TypeOperators/TypeInType.

Also, have you checked what issues remain when building head.hackage?

Sun, Jun 24, 5:31 PM
RyanGlScott updated the summary of D4891: Fix #15308 by suppressing invisble args more rigorously.
Sun, Jun 24, 2:57 PM
RyanGlScott created D4891: Fix #15308 by suppressing invisble args more rigorously.
Sun, Jun 24, 9:41 AM
RyanGlScott created D4890: Fix #15307 by making nlHsFunTy parenthesize more.
Sun, Jun 24, 7:09 AM

Thu, Jun 21

RyanGlScott committed rGHC50a35e59034c: Drop redundant Note (authored by RyanGlScott).
Drop redundant Note
Thu, Jun 21, 10:31 AM

Tue, Jun 19

RyanGlScott created D4877: Allow :info for (~) in GHCi.
Tue, Jun 19, 6:35 PM
RyanGlScott retitled D4876: Remove HsEqTy and XEqTy from Remove HsEqTy to Remove HsEqTy and XEqTy.
Tue, Jun 19, 6:15 PM
RyanGlScott updated the diff for D4876: Remove HsEqTy and XEqTy.
  • Remove XEqTy, too
Tue, Jun 19, 6:14 PM
RyanGlScott created D4876: Remove HsEqTy and XEqTy.
Tue, Jun 19, 2:43 PM

Mon, Jun 18

RyanGlScott accepted D4870: base: Add missing instances for Data.Ord.Down.

I'm not sure why the Harbormaster build is failing (is the parent commit present in master?), but otherwise this LGTM.

Mon, Jun 18, 7:43 PM
RyanGlScott added a comment to D4870: base: Add missing instances for Data.Ord.Down.

Ah, that second edit does fix a good number of my comments.

Mon, Jun 18, 2:34 PM
RyanGlScott requested changes to D4870: base: Add missing instances for Data.Ord.Down.
Mon, Jun 18, 2:31 PM

Sun, Jun 17

RyanGlScott committed rGHC50d7b2ac2fcf: Remove accidentally checked-in T14845.stderr (authored by RyanGlScott).
Remove accidentally checked-in T14845.stderr
Sun, Jun 17, 2:49 PM

Sat, Jun 16

RyanGlScott updated the diff for D4728: Provide a better error message for unpromotable data constructor contexts.

Rebase yet again

Sat, Jun 16, 8:11 AM

Jun 15 2018

RyanGlScott updated the diff for D4728: Provide a better error message for unpromotable data constructor contexts.
  • Accept new test output
Jun 15 2018, 8:48 AM
RyanGlScott updated the diff for D4728: Provide a better error message for unpromotable data constructor contexts.

Rebase on top of master

Jun 15 2018, 8:48 AM
RyanGlScott added a comment to D4728: Provide a better error message for unpromotable data constructor contexts.

...did you read the discussion earlier on this Diff? We had agreed that Richard should do this separately, since I haven't the slightest clue how to write up such a Note. As it stands, this ticket will remain in limbo forever if I'm required to write it.

Jun 15 2018, 5:36 AM
RyanGlScott added a comment to D4728: Provide a better error message for unpromotable data constructor contexts.

Agreed. Should I just land this, then?

Jun 15 2018, 5:15 AM

Jun 14 2018

RyanGlScott added inline comments to D4845: Quantify unfixed kind variables in CUSKs.
Jun 14 2018, 1:59 PM

Jun 12 2018

RyanGlScott added a comment to D4834: Warn about implicit kind variables with -Wcompat.

Current formatting is the result of many tests and rewrites.

Jun 12 2018, 6:54 AM
RyanGlScott requested changes to D4834: Warn about implicit kind variables with -Wcompat.

This deserves at least one test to ensure that the error message is formatted properly.

Jun 12 2018, 6:38 AM

Jun 7 2018

RyanGlScott created D4809: Fix #15243 by fixing incorrect uses of NotPromoted.
Jun 7 2018, 10:25 AM

Jun 6 2018

RyanGlScott added inline comments to D4803: Document #15079 in the users' guide.
Jun 6 2018, 2:25 PM
RyanGlScott updated the diff for D4803: Document #15079 in the users' guide.
Jun 6 2018, 2:25 PM
RyanGlScott created D4803: Document #15079 in the users' guide.
Jun 6 2018, 1:10 PM
RyanGlScott created D4801: Don't expose (~#), (~R#), (~P#) from GHC.Prim.
Jun 6 2018, 10:24 AM
RyanGlScott created D4799: Fix #15236 by removing parentheses from funTyConName.
Jun 6 2018, 9:05 AM

Jun 3 2018

RyanGlScott accepted D4746: Fix unparseable pretty-printing of promoted data cons.

This looks great. Thanks, @aherrmann!

Jun 3 2018, 4:52 PM
RyanGlScott committed rGHC90e99c4cfd60: Add tests for #8128 and #8740 (authored by RyanGlScott).
Add tests for #8128 and #8740
Jun 3 2018, 7:41 AM
RyanGlScott updated the diff for D4728: Provide a better error message for unpromotable data constructor contexts.
  • Remove unused function
Jun 3 2018, 7:41 AM
RyanGlScott abandoned D1454: Convert 'inaccessible code' errors into warnings..

This approach was abandoned in favor of D4744.

Jun 3 2018, 7:13 AM

Jun 2 2018

RyanGlScott added a comment to D4728: Provide a better error message for unpromotable data constructor contexts.

Alright, this should be good to go now.

Jun 2 2018, 6:12 PM
RyanGlScott updated the diff for D4728: Provide a better error message for unpromotable data constructor contexts.
  • Don't special-case Coercible
Jun 2 2018, 6:12 PM
RyanGlScott added a comment to D4771: Fix #13777 by improving the underdetermined CUSK error message.

I would much rather print notice that k0 is free in forall (k :: k0). Proxy k -> Type and then report that whole kind somehow.

Jun 2 2018, 3:13 PM
RyanGlScott retitled D4771: Fix #13777 by improving the underdetermined CUSK error message from Report underdetermined, bound variables in CUSK return kinds to Fix #13777 by improving the underdetermined CUSK error message.
Jun 2 2018, 3:12 PM
RyanGlScott updated the diff for D4771: Fix #13777 by improving the underdetermined CUSK error message.

Rewrite the whole thing

Jun 2 2018, 3:08 PM