RyanGlScott (Ryan Scott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 8 2015, 11:07 PM (210 w, 1 d)

Recent Activity

Thu, Jan 17

RyanGlScott committed rGHC36e3e7472fd1: @simonpj's suggested refactor (authored by RyanGlScott).
@simonpj's suggested refactor
Thu, Jan 17, 11:50 AM
RyanGlScott committed rGHC3429ec8d65ca: Bump Cabal submodule (authored by RyanGlScott).
Bump Cabal submodule
Thu, Jan 17, 11:50 AM
RyanGlScott committed rGHC9dc56b61ae10: Control validity-checking of type synonym applications more carefully (authored by RyanGlScott).
Control validity-checking of type synonym applications more carefully
Thu, Jan 17, 11:50 AM
RyanGlScott committed rGHC83a22066fbe1: Fix #16114 by adding a validity check to rnClsInstDecl (authored by RyanGlScott).
Fix #16114 by adding a validity check to rnClsInstDecl
Thu, Jan 17, 11:50 AM
RyanGlScott committed rGHCe63518f5d6a9: Fix #16116 by removing badAssocRhs (authored by RyanGlScott).
Fix #16116 by removing badAssocRhs
Thu, Jan 17, 11:50 AM
RyanGlScott committed rGHC076f5862a9e4: Don't invoke dataConSrcToImplBang on newtypes (authored by RyanGlScott).
Don't invoke dataConSrcToImplBang on newtypes
Thu, Jan 17, 11:50 AM

Wed, Jan 16

RyanGlScott committed rGHC6b70cf611e5d: Be pickier about unsaturated synonyms in :kind (authored by RyanGlScott).
Be pickier about unsaturated synonyms in :kind
Wed, Jan 16, 12:24 AM

Wed, Jan 9

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

but it sounds like Ryan knows.

Wed, Jan 9, 12:30 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

That mkTyConKindRepBinds panic is bizarre. This suggests that GHC is trying to create Typeable bindings for the kind of Foo. But Typeable doesn't support type families (like Interpret), so it shouldn't be attempting to create those bindings in the first place! Perhaps the issue is GHC simply not recognizing this fact. (I've observed similar issues here, although I haven't managed to get that exact mkTyConKindRepBinds panic before.)

Wed, Jan 9, 11:05 AM

Tue, Jan 8

RyanGlScott abandoned D5471: Be pickier about unsaturated synonyms in :kind.

I've migrated this over to GitLab in https://gitlab.haskell.org/ghc/ghc/merge_requests/90 (once it validates, I'll merge).

Tue, Jan 8, 7:57 AM
RyanGlScott added a comment to D5471: Be pickier about unsaturated synonyms in :kind.

Sorry to be so slow.

Tue, Jan 8, 5:37 AM

Mon, Jan 7

RyanGlScott added inline comments to D5471: Be pickier about unsaturated synonyms in :kind.
Mon, Jan 7, 3:10 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

@andrewthad, you've added Trac #15883 as a related Trac ticket in the Diff description, but is there a corresponding test case for it? (I can't find one.)

Mon, Jan 7, 2:46 PM
RyanGlScott abandoned D5451: add -Wmissing-deriving-strategies.

This was migrated to GitLab in https://gitlab.haskell.org/ghc/ghc/merge_requests/48 and later merged in c121e33f9b039acf2ac6939af8bfafe593560039.

Mon, Jan 7, 8:55 AM

Sat, Jan 5

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

Sorry to add to your pile of TODOs, but I just noticed that this patch actually fixes a Trac ticket that's not listed in the Diff description: Trac #15883. Specifically, this test case:

Sat, Jan 5, 10:28 AM
RyanGlScott abandoned D5229: Visible kind application.

This was landed in 17bd163566153babbf51adaff8397f948ae363ca.

Sat, Jan 5, 9:35 AM

Mon, Dec 31

RyanGlScott added inline comments to D5471: Be pickier about unsaturated synonyms in :kind.
Mon, Dec 31, 10:24 AM

Fri, Dec 28

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

Oops, ignore what I said in https://phabricator.haskell.org/D4777#151228. That isn't a bug at all. The reason that it's defaulting to LiftedRep with GHC 8.6+ is because I didn't enable -fprint-explicit-runtime-reps, and GHC's RuntimeRep defaulting became smarter in GHC 8.6.

Fri, Dec 28, 6:24 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I'm now 100% convinced this is due to a pre-existing bug in tcHsDeriv. Consider the following program:

Fri, Dec 28, 10:06 AM

Thu, Dec 27

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I'm not sure what exactly is going on here. Perhaps @RyanGlScott knows.

Thu, Dec 27, 10:04 PM

Mon, Dec 24

RyanGlScott added inline comments to D5471: Be pickier about unsaturated synonyms in :kind.
Mon, Dec 24, 3:02 PM

Fri, Dec 21

RyanGlScott created D5471: Be pickier about unsaturated synonyms in :kind.
Fri, Dec 21, 8:39 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I don't have a strong opinion on whether coerce should be levity polymorphic. I'd be fine with the more general type signature, but I'd also be fine with just making a copy of coerce with a levity polymorphic type (something like coerceLevPoly) and exporting it from Data.Coerce alongside coerce. Either way, I think we should have something levity polymorphic in Data.Coerce, especially since people are asking for this in Trac #13595.

Fri, Dec 21, 10:48 AM

Thu, Dec 20

RyanGlScott added inline comments to D5420: Fix #16002 by moving a validity check to the renamer.
Thu, Dec 20, 10:29 PM
RyanGlScott committed rGHC28f41f1a7a0e: Fix #16002 by moving a validity check to the renamer (authored by RyanGlScott).
Fix #16002 by moving a validity check to the renamer
Thu, Dec 20, 10:29 PM
RyanGlScott closed D5420: Fix #16002 by moving a validity check to the renamer.
Thu, Dec 20, 10:29 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I'm reviewing this patch rather late it seems, but things appear to be progressing quite nicely! Some requests:

Thu, Dec 20, 6:56 PM

Dec 20 2018

RyanGlScott added inline comments to D5420: Fix #16002 by moving a validity check to the renamer.
Dec 20 2018, 12:32 PM
RyanGlScott added a comment to D5420: Fix #16002 by moving a validity check to the renamer.

I think I've resolved all of @simonpj's concerns here—if no one says otherwise, I'll land this some time next week.

Dec 20 2018, 8:43 AM

Dec 18 2018

RyanGlScott added inline comments to D5420: Fix #16002 by moving a validity check to the renamer.
Dec 18 2018, 2:16 PM
RyanGlScott updated the diff for D5420: Fix #16002 by moving a validity check to the renamer.
Dec 18 2018, 2:15 PM
RyanGlScott added a comment to D5229: Visible kind application.

To be perfectly honest, the error message regressions related to wildcards aren't as bad as I thought there were going to be. For the most part, we're just swapping uses of w with _, and although that can look odd in certain places, I don't think it's necessarily wrong. Personally speaking, I'd be quite fine with this state of affairs (even if it ends up making it into the final 8.8 release), as long as we make a ticket tracking how we could make small improvements.

Dec 18 2018, 11:19 AM
RyanGlScott updated the Trac tickets for D5229: Visible kind application.
Dec 18 2018, 11:14 AM
RyanGlScott added inline comments to D5420: Fix #16002 by moving a validity check to the renamer.
Dec 18 2018, 6:07 AM

Dec 17 2018

RyanGlScott added a comment to D5455: add -Wderiving-defaults for enabling/suppressing strategy defaulting warnings.

Don't forget to add an entry for this flag in docs/users_guide/using-warnings.rst!

Dec 17 2018, 11:34 AM
RyanGlScott added inline comments to D5451: add -Wmissing-deriving-strategies.
Dec 17 2018, 11:29 AM

Dec 15 2018

RyanGlScott requested changes to D5451: add -Wmissing-deriving-strategies.

The CI is failing for reasons unrelated to this Diff. I'd recommend rebasing on top of master, since the issue has been fixed upstream.

Dec 15 2018, 9:00 AM
RyanGlScott requested changes to D5455: add -Wderiving-defaults for enabling/suppressing strategy defaulting warnings.
Dec 15 2018, 8:29 AM
RyanGlScott added a comment to D5455: add -Wderiving-defaults for enabling/suppressing strategy defaulting warnings.

Make sure to add an entry for this flag in docs/users_guide/using-warnings.rst (see Note [Documenting warning flags]).

Dec 15 2018, 8:29 AM

Dec 14 2018

RyanGlScott added a comment to D5452: Fix ghci crash when starting with -fno-implicit-import-qualified.

Looks good (aside from one quibble about grammar)

Dec 14 2018, 8:45 AM

Dec 13 2018

RyanGlScott accepted D5447: don't suggest Rank2Types in error messages (Fixed #16000).

Assuming it validates, LGTM.

Dec 13 2018, 4:24 PM
RyanGlScott updated the Trac tickets for D5447: don't suggest Rank2Types in error messages (Fixed #16000).
Dec 13 2018, 11:00 AM
RyanGlScott requested changes to D5447: don't suggest Rank2Types in error messages (Fixed #16000).

Have you ran the test suite? Some tests' expected stderr files are almost certainly going to change as a result of this, so you need to accept the new stderr.

Dec 13 2018, 10:57 AM
RyanGlScott updated the diff for D5440: Fix #16030 by refactoring IfaceSyn's treatment of GADT constructors.
Dec 13 2018, 10:18 AM

Dec 11 2018

RyanGlScott created D5440: Fix #16030 by refactoring IfaceSyn's treatment of GADT constructors.
Dec 11 2018, 11:41 AM
RyanGlScott committed rGHC3899966e4613: Fix #16008 with a pinch of addConsistencyConstraints (authored by RyanGlScott).
Fix #16008 with a pinch of addConsistencyConstraints
Dec 11 2018, 5:26 AM
RyanGlScott closed D5435: Fix #16008 with a pinch of addConsistencyConstraints.
Dec 11 2018, 5:26 AM
RyanGlScott added inline comments to D5420: Fix #16002 by moving a validity check to the renamer.
Dec 11 2018, 5:18 AM

Dec 10 2018

RyanGlScott updated the diff for D5435: Fix #16008 with a pinch of addConsistencyConstraints.
Dec 10 2018, 5:48 PM
RyanGlScott created D5435: Fix #16008 with a pinch of addConsistencyConstraints.
Dec 10 2018, 3:04 PM
RyanGlScott added inline comments to D5229: Visible kind application.
Dec 10 2018, 1:30 PM
RyanGlScott requested changes to D5229: Visible kind application.

Actually, I did notice one more thing as I tried to adapt some code to this patch.

Dec 10 2018, 12:44 PM
RyanGlScott accepted D5229: Visible kind application.

As far as the parts of the code that I'm qualified to review go, everything looks quite lovely. One minor comment inline.

Dec 10 2018, 11:36 AM

Dec 7 2018

RyanGlScott committed rGHC73cce63f33ee: Fix #12102/#15872 by removing outdated users' guide prose (authored by RyanGlScott).
Fix #12102/#15872 by removing outdated users' guide prose
Dec 7 2018, 9:13 AM
RyanGlScott closed D5397: Fix #12102/#15872 by removing outdated users' guide prose.
Dec 7 2018, 9:13 AM

Dec 6 2018

RyanGlScott added inline comments to D5420: Fix #16002 by moving a validity check to the renamer.
Dec 6 2018, 4:28 PM
RyanGlScott created D5420: Fix #16002 by moving a validity check to the renamer.
Dec 6 2018, 9:54 AM

Dec 5 2018

RyanGlScott abandoned D5413: Add regression test for #11621.

This issue wasn't really fixed at all—see https://ghc.haskell.org/trac/ghc/ticket/11621#comment:8. In light of this, adding a test case is premature, since the fact that that particular program typechecks is a coincidence.

Dec 5 2018, 5:40 PM
RyanGlScott created D5413: Add regression test for #11621.
Dec 5 2018, 4:43 AM
RyanGlScott added a comment to D5229: Visible kind application.

Everything seems to work now, except bug
#15795 (which I secretly hope noone would ever run into)

Dec 5 2018, 4:31 AM

Dec 4 2018

RyanGlScott added inline comments to D5229: Visible kind application.
Dec 4 2018, 10:21 AM
RyanGlScott requested changes to D5229: Visible kind application.

I've made a sweep of some minor code and documentation issues.

Dec 4 2018, 9:28 AM
RyanGlScott added a comment to D5229: Visible kind application.

I'll do another sweep of the template-haskell-specific code in a bit, but first, let me respond to the test failures:

Dec 4 2018, 9:15 AM
RyanGlScott added a comment to D5397: Fix #12102/#15872 by removing outdated users' guide prose.

In that case, is this patch ready to be merged?

Dec 4 2018, 5:09 AM

Dec 3 2018

RyanGlScott committed rGHCaef5d82543bb: Add test cases for #7503, #14451 (authored by RyanGlScott).
Add test cases for #7503, #14451
Dec 3 2018, 10:35 AM
RyanGlScott committed rGHC89d80921d932: Fix embarrassing infinite loop in pprParendType (authored by RyanGlScott).
Fix embarrassing infinite loop in pprParendType
Dec 3 2018, 6:48 AM
RyanGlScott committed rGHC2e6cc3d08f84: Fix #15954 by rejigging check_type's order (authored by RyanGlScott).
Fix #15954 by rejigging check_type's order
Dec 3 2018, 6:48 AM
RyanGlScott committed rGHC75a8349b2a7d: Warn on all out-of-range literals in pats/exprs (authored by harpocrates).
Warn on all out-of-range literals in pats/exprs
Dec 3 2018, 6:48 AM
RyanGlScott closed D5403: Fix embarrassing infinite loop in pprParendType.
Dec 3 2018, 6:48 AM
RyanGlScott closed D5402: Fix #15954 by rejigging check_type's order.
Dec 3 2018, 6:48 AM
RyanGlScott closed D5181: Warn on all out-of-range literals in pats/exprs.
Dec 3 2018, 6:48 AM

Dec 1 2018

RyanGlScott created D5403: Fix embarrassing infinite loop in pprParendType.
Dec 1 2018, 6:34 PM
RyanGlScott added inline comments to D5402: Fix #15954 by rejigging check_type's order.
Dec 1 2018, 2:37 PM
RyanGlScott updated the diff for D5402: Fix #15954 by rejigging check_type's order.
Dec 1 2018, 2:37 PM
RyanGlScott added a comment to D5181: Warn on all out-of-range literals in pats/exprs.

My apologies for forgetting about this patch! We should indeed land this soon.

Dec 1 2018, 1:45 PM
RyanGlScott updated the diff for D5402: Fix #15954 by rejigging check_type's order.
Dec 1 2018, 1:39 PM
RyanGlScott created D5402: Fix #15954 by rejigging check_type's order.
Dec 1 2018, 8:33 AM

Nov 30 2018

RyanGlScott created D5397: Fix #12102/#15872 by removing outdated users' guide prose.
Nov 30 2018, 9:04 AM
RyanGlScott committed rGHC47875bd4d79c: Add 'Lift' instances for 'NonEmpty' and 'Void' (authored by harpocrates).
Add 'Lift' instances for 'NonEmpty' and 'Void'
Nov 30 2018, 8:48 AM
RyanGlScott closed D5391: Add 'Lift' instances for 'NonEmpty' and 'Void'.
Nov 30 2018, 8:48 AM
RyanGlScott accepted D5391: Add 'Lift' instances for 'NonEmpty' and 'Void'.

There we go.

Nov 30 2018, 8:05 AM
RyanGlScott added inline comments to rGHC2257a86daa72: Taming the Kind Inference Monster.
Nov 30 2018, 7:58 AM

Nov 29 2018

RyanGlScott added inline comments to rGHC2257a86daa72: Taming the Kind Inference Monster.
Nov 29 2018, 7:00 PM
RyanGlScott committed rGHCb1af0aed08c7: Accept T15828 test output (authored by RyanGlScott).
Accept T15828 test output
Nov 29 2018, 6:46 PM
RyanGlScott committed rGHC8d7496c42f04: Add a test case for #15962 (authored by ckoparkar).
Add a test case for #15962
Nov 29 2018, 6:46 PM
RyanGlScott closed D5393: Add a test case for #15962.
Nov 29 2018, 6:46 PM
RyanGlScott committed rGHC30a363ae4cbb: Make ghc-in-ghci support Hadrian (authored by RyanGlScott).
Make ghc-in-ghci support Hadrian
Nov 29 2018, 6:46 PM
RyanGlScott committed rGHC8bffd58009ba: Allow containers-0.6, QuickCheck-2.12 in Hadrian (authored by RyanGlScott).
Allow containers-0.6, QuickCheck-2.12 in Hadrian
Nov 29 2018, 6:46 PM
RyanGlScott added inline comments to D5283: Fix #15828, from `More explicit foralls`.
Nov 29 2018, 6:46 PM
RyanGlScott closed D5390: Make ghc-in-ghci support Hadrian.
Nov 29 2018, 6:46 PM
RyanGlScott closed D5389: Allow containers-0.6, QuickCheck-2.12 in Hadrian.
Nov 29 2018, 6:46 PM
RyanGlScott committed rGHCdcf1f9268f6b: Fix #15953 by consistently using dumpIfSet_dyn to print debug output (authored by ckoparkar).
Fix #15953 by consistently using dumpIfSet_dyn to print debug output
Nov 29 2018, 6:46 PM
RyanGlScott closed D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.
Nov 29 2018, 6:45 PM
RyanGlScott committed rGHCfe57a5bae3f8: Fix #15828, from `More explicit foralls` (authored by mayac).
Fix #15828, from `More explicit foralls`
Nov 29 2018, 6:45 PM
RyanGlScott committed rGHC9e3aaf8b58d0: Add missing since annotations (authored by dminuoso).
Add missing since annotations
Nov 29 2018, 6:45 PM
RyanGlScott closed D5283: Fix #15828, from `More explicit foralls`.
Nov 29 2018, 6:45 PM
RyanGlScott closed D5379: Add missing since annotations.
Nov 29 2018, 6:45 PM
RyanGlScott requested changes to D5391: Add 'Lift' instances for 'NonEmpty' and 'Void'.

It looks like there's one test case that needs to be updated, per Harbormaster:

Nov 29 2018, 5:49 PM
RyanGlScott raised a concern with rGHC2257a86daa72: Taming the Kind Inference Monster.
Nov 29 2018, 11:39 AM
RyanGlScott accepted D5393: Add a test case for #15962.

Macro awesometothemax:

Nov 29 2018, 7:34 AM