RyanGlScott (Ryan Scott)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 8 2015, 11:07 PM (128 w, 13 h)
Availability
Available

Recent Activity

Yesterday

RyanGlScott created D3666: Add fixity declaration for Data.List.NonEmpty.!!.
Thu, Jun 22, 6:05 PM

Wed, Jun 21

RyanGlScott added a comment to D3664: Fix pretty-printing of zero-argument lambda expressions.

It turned out to be more involved than I thought to tweak the GHC pretty-printer to be aware of zero-argument lambdas. I opted for the simpler solution for just converting TH LamEs with zero patterns to their underly body Exp instead, which avoids that problem entirely.

Wed, Jun 21, 12:35 PM
RyanGlScott updated the diff for D3664: Fix pretty-printing of zero-argument lambda expressions.
  • Actually check for -ddump-splices output
  • Just convert zero-arg lambdas to their bodies
Wed, Jun 21, 12:34 PM
RyanGlScott planned changes to D3664: Fix pretty-printing of zero-argument lambda expressions.

This isn't quite right yet - the GHC pretty-printer still prints out an arrow (->) needlessly. Also, the test isn't checking for this.

Wed, Jun 21, 12:09 PM
RyanGlScott created D3664: Fix pretty-printing of zero-argument lambda expressions.
Wed, Jun 21, 12:03 PM
RyanGlScott planned changes to D3662: WIP: Roles for closed type families.
Wed, Jun 21, 12:26 AM
RyanGlScott created D3662: WIP: Roles for closed type families.
Wed, Jun 21, 12:23 AM

Sun, Jun 18

RyanGlScott committed rGHCdf3288000e86: Typofix in Data.Type.Equality comments (authored by RyanGlScott).
Typofix in Data.Type.Equality comments
Sun, Jun 18, 1:32 PM
RyanGlScott committed rGHC85731000d8b1: Look through type synonyms in existential contexts when deriving Functor (authored by RyanGlScott).
Look through type synonyms in existential contexts when deriving Functor
Sun, Jun 18, 1:32 PM
RyanGlScott closed D3635: Look through type synonyms in existential contexts when deriving Functor by committing rGHC85731000d8b1: Look through type synonyms in existential contexts when deriving Functor.
Sun, Jun 18, 1:31 PM
RyanGlScott added a comment to D3657: Add fixity declaration for :~~:.

This ought to be merged into 8.2.

Sun, Jun 18, 1:23 PM
RyanGlScott created D3657: Add fixity declaration for :~~:.
Sun, Jun 18, 1:22 PM
RyanGlScott committed rGHC559a0c5d5458: Fix out-of-date comments in TyCoRep (authored by RyanGlScott).
Fix out-of-date comments in TyCoRep
Sun, Jun 18, 11:02 AM

Tue, Jun 13

RyanGlScott added a reviewer for D3641: change filtering of variables in extract_hs_tv_bndrs (fixes #13782): goldfire.
Tue, Jun 13, 8:47 PM
RyanGlScott updated the diff for D3635: Look through type synonyms in existential contexts when deriving Functor.
  • Add Note, per SPJ's suggestion
Tue, Jun 13, 2:07 PM

Mon, Jun 12

RyanGlScott planned changes to D3635: Look through type synonyms in existential contexts when deriving Functor.
Mon, Jun 12, 6:44 PM

Sat, Jun 10

RyanGlScott created D3635: Look through type synonyms in existential contexts when deriving Functor.
Sat, Jun 10, 5:33 PM

Thu, Jun 8

RyanGlScott updated the diff for D3632: Add perf test for #12545.
  • Accurate numbers
Thu, Jun 8, 11:32 PM
RyanGlScott planned changes to D3632: Add perf test for #12545.

Awaiting a Harbormaster run to tell me how many bytes to use (since my machine gives unreliable numbers).

Thu, Jun 8, 10:53 PM
RyanGlScott created D3632: Add perf test for #12545.
Thu, Jun 8, 10:51 PM

Mon, Jun 5

RyanGlScott updated the diff for D3627: Support signatures at the kind level in Template Haskell.

Rebase (post-Trees-That-Grow)

Mon, Jun 5, 10:11 PM
RyanGlScott planned changes to D3337: Make standalone DeriveAnyClass as permissive as empty instances.
Mon, Jun 5, 7:11 PM
RyanGlScott updated the diff for D3337: Make standalone DeriveAnyClass as permissive as empty instances.

Rebase (post-Trees-That-Grow)

Mon, Jun 5, 7:11 PM
RyanGlScott planned changes to D3337: Make standalone DeriveAnyClass as permissive as empty instances.
Mon, Jun 5, 12:13 PM
RyanGlScott updated the diff for D3337: Make standalone DeriveAnyClass as permissive as empty instances.

Rebase

Mon, Jun 5, 12:13 PM
RyanGlScott added a comment to D3627: Support signatures at the kind level in Template Haskell.

Trac #11785 seems to encompass the idea of merging Type and Kind TH functionality together, so I mentioned this business about repLTy and repLKind on that ticket. I also updated the comments to refer to Trac #11785.

Mon, Jun 5, 11:08 AM
RyanGlScott updated the diff for D3627: Support signatures at the kind level in Template Haskell.
Mon, Jun 5, 11:07 AM

Sun, Jun 4

RyanGlScott added a comment to D3627: Support signatures at the kind level in Template Haskell.

Why does DsMeta differentiate between types and kinds? In other words, does anything go wrong if we replace repLKind with repLTy?

Sun, Jun 4, 8:12 PM

Fri, Jun 2

RyanGlScott added inline comments to D3627: Support signatures at the kind level in Template Haskell.
Fri, Jun 2, 5:49 PM
RyanGlScott created D3627: Support signatures at the kind level in Template Haskell.
Fri, Jun 2, 5:43 PM

Thu, Jun 1

Herald added a reviewer for D3625: GHC.Stats cleanup: austin.
Thu, Jun 1, 11:18 AM
RyanGlScott added a comment to D3622: Use lengthIs and friends in more places.

Does it make any difference to the perf tests?

Thu, Jun 1, 7:45 AM

Wed, May 31

RyanGlScott added a comment to D3622: Use lengthIs and friends in more places.

I'll put this on Phab in case this has any effect on the performance tests.

Wed, May 31, 1:53 PM
Herald added a reviewer for D3622: Use lengthIs and friends in more places: goldfire.
Wed, May 31, 1:52 PM

Tue, May 30

RyanGlScott added inline comments to D3609: Update hsSyn AST to use Trees that Grow.
Tue, May 30, 4:20 PM
RyanGlScott created D3621: Make GHCi work when RebindableSyntax is enabled.
Tue, May 30, 1:49 PM

Sat, May 27

RyanGlScott added inline comments to D3615: Remove references to static flags in flag reference.
Sat, May 27, 4:03 PM
RyanGlScott created D3615: Remove references to static flags in flag reference.
Sat, May 27, 4:02 PM
RyanGlScott created D3614: Add a flag reference entry for -XTypeInType.
Sat, May 27, 3:55 PM

Fri, May 26

RyanGlScott committed rGHC27f6f388ef1a: Add regression test for #12648 (authored by RyanGlScott).
Add regression test for #12648
Fri, May 26, 8:29 PM
RyanGlScott committed rGHCc82314085f27: Add regression test for #13758 (authored by RyanGlScott).
Add regression test for #13758
Fri, May 26, 5:49 PM

May 24 2017

RyanGlScott added a comment to D3608: Extend the Quasi Monad.

This sadly would not work. As we'd still have a way too generic IO action. With a cross compiler we do not have access to the same libraries we have on the host. qRunIO can run an arbitrary IO action and by extension call
any arbitrary function. This in turn requires those functions to be available on the build, which they are not necessarily are, unless we start to build each and every library for the build machine (but the cross compiler can't do this),
and for the host. The ultimate plan is to eventually make ghc multi-target aware, once we have that (though this is *far* out of the scope of this diff), this could become feasible.

May 24 2017, 10:10 AM
RyanGlScott added a comment to D3608: Extend the Quasi Monad.

Depending on what kind of IO we do, we might be fine. (if the IO doesn't touch processes or files, I do not (yet) see any issue with that kind of IO). When running ghc with -fexternal-interpreter the qXXX are evaluated in GHCiQ (see libraries/ghci/GHCi/TH.hs). Which running on the host has the capability to query the ghc instance on the build machine.

May 24 2017, 8:42 AM
RyanGlScott added a comment to D3608: Extend the Quasi Monad.

Thank you for the detailed explanation. But I'm not clearer than before on my second question: why are the file/process opesrtions you just added not subject to the same issues that qRunIO has? After all, they're also IO operations. Where specifically in the GHC codebase does a cross compiler make the decision to, e.g., look up executables on the build machine instead of the host machine when running qFindExecutables?

May 24 2017, 8:04 AM
RyanGlScott added a comment to D3608: Extend the Quasi Monad.

My apologies for not being familiar with the previous work on this front, but I don't see why this is necessary. Why does adding a bunch of hardcoded IO operations to Quasi resolve this issue, but qRunIO alone does not? Where in the code are cross compilers making the distinction between files on the build machine and files on the host machine when running, e.g., qFindExecutables?

May 24 2017, 7:38 AM

May 14 2017

RyanGlScott updated the diff for D3587: Pretty-print strict record fields from ifaces correctly.
  • Include test output
May 14 2017, 9:27 PM
RyanGlScott created D3587: Pretty-print strict record fields from ifaces correctly.
May 14 2017, 8:47 PM

May 12 2017

RyanGlScott committed rGHCa13adcf8cfc6: Add regression test for #11964 (authored by RyanGlScott).
Add regression test for #11964
May 12 2017, 8:08 AM
RyanGlScott committed rGHCba5114e310e9: Add regression test for #11966 (authored by RyanGlScott).
Add regression test for #11966
May 12 2017, 8:08 AM
RyanGlScott committed rGHC01af8aee30c7: Add regression tests for #12083 (authored by RyanGlScott).
Add regression tests for #12083
May 12 2017, 8:08 AM
RyanGlScott closed D3573: Add regression tests for #12083 by committing rGHC01af8aee30c7: Add regression tests for #12083.
May 12 2017, 8:08 AM

May 11 2017

RyanGlScott updated the summary of D3573: Add regression tests for #12083.
May 11 2017, 4:11 PM
RyanGlScott created D3573: Add regression tests for #12083.
May 11 2017, 4:09 PM
RyanGlScott created D3572: Fix collect_lpat's treatment of HsSplicedPats.
May 11 2017, 1:02 PM
RyanGlScott created D3570: Parenthesize pretty-printed equalities when necessary.
May 11 2017, 9:57 AM
RyanGlScott committed rGHC2316ee1c42d7: Add regression test for #12850 (authored by RyanGlScott).
Add regression test for #12850
May 11 2017, 8:43 AM

May 6 2017

RyanGlScott committed rGHCed0c7f8b1f91: Add regression test for #13651 (authored by RyanGlScott).
Add regression test for #13651
May 6 2017, 11:39 AM
RyanGlScott committed rGHC4a6cb5efe8e5: Add testsuite/timeout/TimeMe to .gitignore (authored by RyanGlScott).
Add testsuite/timeout/TimeMe to .gitignore
May 6 2017, 11:39 AM
RyanGlScott closed D3536: Add testsuite/timeout/TimeMe to .gitignore by committing rGHC4a6cb5efe8e5: Add testsuite/timeout/TimeMe to .gitignore.
May 6 2017, 11:39 AM
RyanGlScott committed rGHC38a381912f67: Add regression tests for #12947, #13640 (authored by RyanGlScott).
Add regression tests for #12947, #13640
May 6 2017, 11:39 AM
RyanGlScott closed D3528: Add regression tests for #12947, #13640 by committing rGHC38a381912f67: Add regression tests for #12947, #13640.
May 6 2017, 11:39 AM

May 4 2017

RyanGlScott created D3536: Add testsuite/timeout/TimeMe to .gitignore.
May 4 2017, 9:36 AM

May 3 2017

RyanGlScott created D3531: Add regression test for #11616.
May 3 2017, 2:34 PM
RyanGlScott created D3528: Add regression tests for #12947, #13640.
May 3 2017, 7:57 AM

Apr 27 2017

RyanGlScott updated the diff for D3505: Make the tyvars in TH-reified data family instances uniform.
  • Remove errant runIO
Apr 27 2017, 5:58 AM
RyanGlScott planned changes to D3505: Make the tyvars in TH-reified data family instances uniform.
Apr 27 2017, 5:39 AM

Apr 26 2017

RyanGlScott created D3505: Make the tyvars in TH-reified data family instances uniform.
Apr 26 2017, 7:49 PM

Apr 25 2017

RyanGlScott accepted D3500: Add instances `Num`, `Functor`, `Applicative`, `Monad`, `Semigroup` and `Monoid` for `Data.Ord.Down` (#13097)..

LGTM.

Apr 25 2017, 4:59 PM
RyanGlScott requested changes to D3500: Add instances `Num`, `Functor`, `Applicative`, `Monad`, `Semigroup` and `Monoid` for `Data.Ord.Down` (#13097)..

Thanks for doing this, @adamse! I've left some inline remarks.

Apr 25 2017, 4:37 PM
RyanGlScott updated the diff for D3497: Don't pretty-print binders in closed type families without -fprint-explicit-foralls.
  • Accept new test output
Apr 25 2017, 11:07 AM
RyanGlScott added inline comments to D3498: Document mkWeak#.
Apr 25 2017, 10:55 AM
RyanGlScott created D3497: Don't pretty-print binders in closed type families without -fprint-explicit-foralls.
Apr 25 2017, 10:09 AM
RyanGlScott added a comment to D3496: Ignore ANN pragmas with no TH and no external interpreter..

See testsuite/tests/stage1.

Apr 25 2017, 9:20 AM
RyanGlScott requested changes to D3496: Ignore ANN pragmas with no TH and no external interpreter..

We should add the program in Trac #13609 as a test case, no?

Apr 25 2017, 9:16 AM
RyanGlScott created D3495: Add regression test for #12104.
Apr 25 2017, 8:54 AM

Apr 24 2017

RyanGlScott committed rGHCab27fdcfe267: Add regression test for #13603 (authored by RyanGlScott).
Add regression test for #13603
Apr 24 2017, 9:49 AM
RyanGlScott closed D3489: Add regression test for #13603 by committing rGHCab27fdcfe267: Add regression test for #13603.
Apr 24 2017, 9:49 AM
RyanGlScott updated the diff for D3489: Add regression test for #13603.

Oops, grabbed too many commits

Apr 24 2017, 8:44 AM
RyanGlScott updated the diff for D3489: Add regression test for #13603.

Rebase (and cross fingers for a green Harbormaster build)

Apr 24 2017, 7:48 AM

Apr 23 2017

RyanGlScott added a comment to D3398: Don't setProgramDynFlags on every :load.
In D3398#99480, @Phyx wrote:

why does the module content need quotes? Doesn't the semantics of echo make it print everything up to a control character?

:! echo module A where {} >A.hs
:! echo module B where { import A } >B.hs

Should work for both all. (works fine on Windows).

Apr 23 2017, 2:01 PM
RyanGlScott updated subscribers of D3398: Don't setProgramDynFlags on every :load.

ghci063 (as currently written) does not pass on Windows. Here is the error that I get:

Apr 23 2017, 1:22 PM
RyanGlScott created D3489: Add regression test for #13603.
Apr 23 2017, 10:39 AM

Apr 20 2017

RyanGlScott updated the diff for D3472: Document the kind generalization behavior observed in #13555.
  • simonpj's suggestions
Apr 20 2017, 8:31 PM

Apr 19 2017

RyanGlScott created D3472: Document the kind generalization behavior observed in #13555.
Apr 19 2017, 3:44 PM

Apr 6 2017

RyanGlScott updated the summary of D3426: Add regression test for #13538.
Apr 6 2017, 1:41 PM
RyanGlScott created D3426: Add regression test for #13538.
Apr 6 2017, 1:37 PM

Apr 4 2017

RyanGlScott accepted D3422: base: Mark unfold as deprecated.

That was some quite impressive turnaround time.

Apr 4 2017, 5:55 PM
RyanGlScott added a comment to D3422: base: Mark unfold as deprecated.

Ought the title of this Diff be "Mark unfold as deprecated"?

Apr 4 2017, 5:52 PM
RyanGlScott accepted D3416: Add Alternative instance for ZipList (fix #13520)..

Great! LGTM.

Apr 4 2017, 12:18 PM
RyanGlScott requested changes to D3416: Add Alternative instance for ZipList (fix #13520)..

We definitely need to point out this change in libraries/base/changelog.md. Note that the deadline for base-4.10.0.0 (which will be shipped with GHC 8.2 soon) has already passed, so this would be incorporated into the base-4.11.0.0 release. At the moment, however, libraries/base/changelog.md doesn't have a section for base-4.11.0.0—do you mind making this change yourself? Just put a new section at the top like:

Apr 4 2017, 10:03 AM

Apr 1 2017

RyanGlScott accepted D3402: Derive the definition of null.

Looks good overall. Make sure to mention this in the 8.4 release notes!

Apr 1 2017, 11:33 AM

Mar 31 2017

RyanGlScott created D3404: Add regression test for #7944.
Mar 31 2017, 5:48 PM
RyanGlScott added inline comments to D3403: Don't derive showList.
Mar 31 2017, 10:46 AM
RyanGlScott added inline comments to D3403: Don't derive showList.
Mar 31 2017, 5:52 AM

Mar 30 2017

RyanGlScott requested changes to D3402: Derive the definition of null.

It's not terribly clear to me how this works. This needs

Mar 30 2017, 8:43 PM
RyanGlScott accepted D3374: Optimize deriving for phantom types.

Fantastic work, @dfeuer!

Mar 30 2017, 8:10 AM

Mar 29 2017

RyanGlScott added inline comments to D3397: unique: fix UNIQUE_BITS crosscompilation (Trac #13491).
Mar 29 2017, 3:36 PM
RyanGlScott requested changes to D3374: Optimize deriving for phantom types.

Looking better.

Mar 29 2017, 8:34 AM

Mar 25 2017

RyanGlScott added a comment to D3379: Allow operators as record pattern synonym fields.

I don't think this example makes sense as in the builder for MkOp (·) is not (·) but an argument which shadows (·).

Mar 25 2017, 6:13 PM
RyanGlScott added a comment to D3379: Allow operators as record pattern synonym fields.

It is the same as any other infix operator. You can set it with infix declarations.

Mar 25 2017, 9:43 AM