RyanGlScott (Ryan Scott)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

Badges

User Since
Jan 8 2015, 11:07 PM (115 w, 4 d)
Availability
Available

Recent Activity

Sat, Mar 25

RyanGlScott added a comment to D3379: Allow operators as record pattern synonym fields.

I don't think this example makes sense as in the builder for MkOp (·) is not (·) but an argument which shadows (·).

Sat, Mar 25, 6:13 PM
RyanGlScott added a comment to D3379: Allow operators as record pattern synonym fields.

It is the same as any other infix operator. You can set it with infix declarations.

Sat, Mar 25, 9:43 AM

Fri, Mar 24

RyanGlScott added a comment to D3379: Allow operators as record pattern synonym fields.

One thing I'm not clear on is how the fixity of record pattern synonym field operators work. Is there a default fixity? Can it be configured? Is whatever the current behavior is documented in the users' guide?

Fri, Mar 24, 7:50 PM

Thu, Mar 23

RyanGlScott added a comment to D3374: Optimize deriving for phantom types.

Ah, I see. It's because mk_FunBind (which Eq and Ord use) had its behavior changed by modifying mkRdrFunBind. I'm fine with either leaving things the way they are for Eq/Ord, or changing it to generate the "correct" number of wildcard patterns. If you do opt for the latter route, make sure that other classes behave properly as well! For instance, Data, Lift, and Show, which also use mk_FunBind.

Thu, Mar 23, 8:06 PM
RyanGlScott added a comment to D3374: Optimize deriving for phantom types.
In D3374#96925, @dfeuer wrote:

The change to Eq and Ord wasn't intentional, but I think we actually do want to change them.

Thu, Mar 23, 6:49 PM
RyanGlScott requested changes to D3374: Optimize deriving for phantom types.

Some TODOs:

Thu, Mar 23, 8:38 AM

Wed, Mar 22

RyanGlScott abandoned D3332: Make instance declarations recognize named wildcards.
Wed, Mar 22, 10:03 AM

Thu, Mar 16

RyanGlScott planned changes to D3337: Make standalone DeriveAnyClass as permissive as empty instances.

I don't like the distinction between the Rep and NoRep versions of DataConInstArgs. Can we not look up the rep stuff right away?

Thu, Mar 16, 9:20 AM

Wed, Mar 15

RyanGlScott added a comment to D3337: Make standalone DeriveAnyClass as permissive as empty instances.
In D3337#96183, @dfeuer wrote:

Does allowing unconventional derived instances *itself* simplify any internal story?

Wed, Mar 15, 11:11 AM

Tue, Mar 14

RyanGlScott committed rGHC67345ccf5153: Allow associated types to pattern-match in non-class-bound variables (authored by RyanGlScott).
Allow associated types to pattern-match in non-class-bound variables
Tue, Mar 14, 10:31 AM
RyanGlScott closed D3302: Allow associated types to pattern-match in non-class-bound variables by committing rGHC67345ccf5153: Allow associated types to pattern-match in non-class-bound variables.
Tue, Mar 14, 10:31 AM
RyanGlScott committed rGHCb335f506f1d3: Further document :type +v's role in analyzing -XTypeApplications in GHCi (authored by RyanGlScott).
Further document :type +v's role in analyzing -XTypeApplications in GHCi
Tue, Mar 14, 10:31 AM
RyanGlScott closed D3310: Further document :type +v's role in analyzing -XTypeApplications in GHCi by committing rGHCb335f506f1d3: Further document :type +v's role in analyzing -XTypeApplications in GHCi.
Tue, Mar 14, 10:31 AM

Mon, Mar 13

RyanGlScott created D3337: Make standalone DeriveAnyClass as permissive as empty instances.
Mon, Mar 13, 3:51 PM

Sun, Mar 12

RyanGlScott updated the diff for D3332: Make instance declarations recognize named wildcards.
  • Point Haddock submodule to my fork
Sun, Mar 12, 5:21 PM
RyanGlScott added a comment to D3332: Make instance declarations recognize named wildcards.

Note: this requires a change to haddock. Currently, it's only available at https://github.com/RyanGlScott/haddock/commit/661d33cae917ab4dca9e4a87e56542769b0fa109 (my GitHub fork of haddock), since I don't know how to push these changes to git.haskell.org/haddock.git itself.

Sun, Mar 12, 3:43 PM
RyanGlScott updated the Trac tickets for D3332: Make instance declarations recognize named wildcards.
Sun, Mar 12, 3:42 PM
RyanGlScott created D3332: Make instance declarations recognize named wildcards.
Sun, Mar 12, 3:41 PM
RyanGlScott added inline comments to D3309: Make exports from Data.Typeable and Type.Reflection consistent.
Sun, Mar 12, 1:36 PM

Sat, Mar 11

RyanGlScott added a comment to D3309: Make exports from Data.Typeable and Type.Reflection consistent.

By the way, this change was motivated by the fact that if you currently import typeRepFingerprint from Data.Typeable and try using it on a TypeRep, it'll fail with a type error, since you're not using the type-indexed variant from Type.Reflection. So this is equally a bugfix and a code cleanup.

Sat, Mar 11, 7:08 PM
RyanGlScott added a comment to D3327: Define ZipList's Semigroup.

A quick Google search reveals this: https://mail.haskell.org/pipermail/libraries/2015-July/026039.html

Sat, Mar 11, 7:01 PM
RyanGlScott accepted D3325: Don't reference elSupremum in haddock for Lifetime Monoid.

LGTM.

Sat, Mar 11, 6:53 PM
RyanGlScott requested changes to D3327: Define ZipList's Semigroup.

Has this proposed change been discussed on the libraries mailing list? I'm quite reluctant to add new instances to base without some semblance of community consensus that they should go in.

Sat, Mar 11, 6:52 PM
RyanGlScott committed rGHC740ecda32116: Observe #13267 in release notes (authored by RyanGlScott).
Observe #13267 in release notes
Sat, Mar 11, 2:50 PM

Fri, Mar 10

RyanGlScott added a comment to D3317: Foreign.C.Types: Add conversions to CTime and friends.

This was originally motivated by a recent change in time.

Fri, Mar 10, 2:12 PM
RyanGlScott added a comment to D3317: Foreign.C.Types: Add conversions to CTime and friends.

I feel like I need some more context here. Is there a reason you're targeting these four types in particular? What is the intended use case for these functions?

Fri, Mar 10, 1:40 PM
RyanGlScott requested changes to D3305: template-haskell: Remove FamFlavour, family[No]KindD, closedTypeFamily[No]KindD.

@bgamari indicated that we might want to hold off on this for another release cycle, since these were only deprecated very recently (GHC 8.0). Bumping out of the accepted state for now.

Fri, Mar 10, 10:35 AM
RyanGlScott updated the Trac tickets for D3315: Fix #13337..
Fri, Mar 10, 9:20 AM
RyanGlScott added a comment to D3315: Fix #13337..

Cool! One minor comment inline.

Fri, Mar 10, 9:20 AM
RyanGlScott updated the Trac tickets for D3310: Further document :type +v's role in analyzing -XTypeApplications in GHCi.
Fri, Mar 10, 9:12 AM
RyanGlScott updated the diff for D3302: Allow associated types to pattern-match in non-class-bound variables.
  • Simon's suggestions
Fri, Mar 10, 9:11 AM
RyanGlScott updated the Trac tickets for D3302: Allow associated types to pattern-match in non-class-bound variables.
Fri, Mar 10, 9:09 AM
RyanGlScott updated the Trac tickets for D3302: Allow associated types to pattern-match in non-class-bound variables.
Fri, Mar 10, 9:09 AM

Thu, Mar 9

RyanGlScott updated the diff for D3310: Further document :type +v's role in analyzing -XTypeApplications in GHCi.
  • Richard's suggestions
Thu, Mar 9, 9:02 PM
RyanGlScott created D3310: Further document :type +v's role in analyzing -XTypeApplications in GHCi.
Thu, Mar 9, 8:48 PM
RyanGlScott created D3309: Make exports from Data.Typeable and Type.Reflection consistent.
Thu, Mar 9, 7:59 PM
RyanGlScott committed rGHC2b5b9dc69e5d: Fix typo in base changelog (authored by RyanGlScott).
Fix typo in base changelog
Thu, Mar 9, 5:12 PM
RyanGlScott accepted D3305: template-haskell: Remove FamFlavour, family[No]KindD, closedTypeFamily[No]KindD.

Looks good. Make sure to include a note in the changelog. (Currently, the notes for the 2.11 release claim that FamFlavour was removed, which technically isn't true... maybe we should fix that retroactively? :) )

Thu, Mar 9, 2:06 PM
RyanGlScott added a comment to D3302: Allow associated types to pattern-match in non-class-bound variables.

BTW, the tweaks I made to various files in the testsuite are just reverting changes that Simon made in 8136a5cbfcd24647f897a2fae9fcbda0b1624035 to make them compile under the associated types restriction that this commit reverts.

Thu, Mar 9, 12:53 PM
RyanGlScott created D3302: Allow associated types to pattern-match in non-class-bound variables.
Thu, Mar 9, 10:40 AM

Tue, Mar 7

RyanGlScott added a comment to D3294: Data.Typeable: Export splitTyConApp, typeRepArgs, and typeRepTyCon.

OK. Can you put a blurb in the base changelog stating that these functions have been removed? In practice, I have encountered a Hackage library (dynamic-state) that uses them, so we should have a migration story.

Tue, Mar 7, 11:13 PM
RyanGlScott requested changes to D3294: Data.Typeable: Export splitTyConApp, typeRepArgs, and typeRepTyCon.

What about tyConFingerprint? mkTyCon3? mkTyConApp? mkAppTy? mkFunTy?

Tue, Mar 7, 8:02 PM
RyanGlScott added a comment to D3292: Update crt to latest..

@Phyx, I'm confused about what issue(s) this is fixing. You marked the Trac issue on this Diff as Trac #13384, but didn't change the Differential status on the corresponding Trac page. Moreover, you did change the Differential on the Trac page for Trac #13359, but you didn't mark this Diff as fixing it. Does it fix both? Or just one of them?

Tue, Mar 7, 5:36 PM

Mon, Mar 6

RyanGlScott abandoned D3245: Refactor CompleteMatch to contain Names, not type-checked things.

This was (stealthily) landed in 8ca4bb1ce9d94bb9f519f620c1f5ed8063007d33.

Mon, Mar 6, 4:56 PM
RyanGlScott added a comment to D3257: Read COMPLETE sets from external packages.

No worries! I'm just glad we finally landed the darn thing. :)

Mon, Mar 6, 4:49 PM
RyanGlScott added a comment to D3257: Read COMPLETE sets from external packages.

@bgamari: The required changes were merged into binary in https://github.com/kolmodin/binary/commit/0147456b11c38d1121fd84a2b53effefde111240, so reapplying this patch with binary bumped to that commit should work. Should I open another Diff, or should we just commit it directly?

Mon, Mar 6, 10:55 AM
RyanGlScott updated the Trac tickets for D3285: Fix #13382: Put join ceiling underneath lambdas.
Mon, Mar 6, 8:18 AM

Fri, Mar 3

RyanGlScott updated the diff for D3272: Reexport CmpNat and friends (defined in GHC.TypeNats) from GHC.TypeLits.

Rebase on top of master

Fri, Mar 3, 6:16 PM
RyanGlScott added inline comments to D3272: Reexport CmpNat and friends (defined in GHC.TypeNats) from GHC.TypeLits.
Fri, Mar 3, 1:36 PM
RyanGlScott created D3272: Reexport CmpNat and friends (defined in GHC.TypeNats) from GHC.TypeLits.
Fri, Mar 3, 1:35 PM

Thu, Mar 2

RyanGlScott added a comment to D3257: Read COMPLETE sets from external packages.

As observed here, this requires a binary submodule update. I've opened a PR against binary here: https://github.com/kolmodin/binary/pull/132

Thu, Mar 2, 10:37 PM
RyanGlScott updated the summary of D3257: Read COMPLETE sets from external packages.
Thu, Mar 2, 10:36 PM
RyanGlScott updated the diff for D3257: Read COMPLETE sets from external packages.
  • Bump binary submodule
Thu, Mar 2, 10:36 PM
RyanGlScott updated the diff for D3257: Read COMPLETE sets from external packages.

Rebase on top of master (again?!?)

Thu, Mar 2, 7:13 PM
RyanGlScott updated the diff for D3257: Read COMPLETE sets from external packages.

Rebase on top of master

Thu, Mar 2, 5:28 PM
RyanGlScott requested changes to D3262: Changed parser message for RankNTypes (#12811).

Thanks for the contribution!

Thu, Mar 2, 11:42 AM
RyanGlScott updated the diff for D3257: Read COMPLETE sets from external packages.
  • Fix the build, add a Note per simonpj's request
Thu, Mar 2, 11:10 AM

Wed, Mar 1

RyanGlScott added a comment to D3019: Fixes a spaceleak in `maximumBy` and `minimumBy` (#10830)..

I've added a Note summarizing the consensus reached in Trac #10830.

Wed, Mar 1, 5:56 PM
RyanGlScott updated the diff for D3019: Fixes a spaceleak in `maximumBy` and `minimumBy` (#10830)..
  • Add a Note
Wed, Mar 1, 5:54 PM
RyanGlScott planned changes to D3257: Read COMPLETE sets from external packages.

Thanks @simonpj, I'll update the comments once D3245 (on which this depends, and which also modifies the functionality of COMPLETE sets) is merged.

Wed, Mar 1, 5:32 PM
RyanGlScott commandeered D3019: Fixes a spaceleak in `maximumBy` and `minimumBy` (#10830)..
Wed, Mar 1, 5:17 PM
RyanGlScott added a dependency for D3257: Read COMPLETE sets from external packages: D3245: Refactor CompleteMatch to contain Names, not type-checked things.
Wed, Mar 1, 9:09 AM
RyanGlScott added a dependent revision for D3245: Refactor CompleteMatch to contain Names, not type-checked things: D3257: Read COMPLETE sets from external packages.
Wed, Mar 1, 9:09 AM
RyanGlScott created D3257: Read COMPLETE sets from external packages.
Wed, Mar 1, 9:07 AM

Tue, Feb 28

RyanGlScott added a comment to D3231: Add COMPLETE pragmas for TypeRep and ErrorCall pattern synonyms.

Sadly, I realized that these don't work as well as I though they would yet, since GHC doesn't read COMPLETE sets from external packages, so any package that depends on base won't benefit from this yet. Still, it won't harm anything to merge this now, and the external package issue can be fixed separately.

Tue, Feb 28, 10:14 AM

Mon, Feb 27

RyanGlScott created D3231: Add COMPLETE pragmas for TypeRep and ErrorCall pattern synonyms.
Mon, Feb 27, 10:02 PM

Feb 26 2017

RyanGlScott added a comment to D3019: Fixes a spaceleak in `maximumBy` and `minimumBy` (#10830)..

@dalaing, any objects if I commandeer this Diff and implement the change I suggested in https://phabricator.haskell.org/D3019#92518? It'd be nice to get this in time for 8.2.1.

Feb 26 2017, 12:06 PM
RyanGlScott added a comment to D3082: Extend Windows runtime loader libsearch.

Since no one's given this a review, I'll give it a shot.

Feb 26 2017, 11:15 AM

Feb 23 2017

RyanGlScott created D3181: Add instances for (:~~:) mirroring those for (:~:).
Feb 23 2017, 1:12 PM

Feb 22 2017

RyanGlScott added a comment to D3019: Fixes a spaceleak in `maximumBy` and `minimumBy` (#10830)..

Sorry for responding so late on this. I'll also give my 👍 on this to provide one more vote of confidence from a CLC member.

Feb 22 2017, 8:48 AM
RyanGlScott added a comment to D3152: Bump process version in GHC [skip ci].

Well that was fast... process-1.6 is now released, so this is technically out of date.

Feb 22 2017, 8:27 AM

Feb 21 2017

RyanGlScott added a comment to D3153: Bump win32 version in GHC.

This has been superseded by http://git.haskell.org/ghc.git/commit/240b43e4969595418bb3c0d1519111be59572672, no?

Feb 21 2017, 9:33 AM
RyanGlScott committed rGHC611f998fd545: Replace some pushTcLevelM's with pushTcLevelM_ (authored by RyanGlScott).
Replace some pushTcLevelM's with pushTcLevelM_
Feb 21 2017, 8:54 AM
RyanGlScott committed rGHC4080a63c510f: Minor spelling, grammar, and formatting fixes (authored by RyanGlScott).
Minor spelling, grammar, and formatting fixes
Feb 21 2017, 8:54 AM

Feb 10 2017

RyanGlScott committed rGHC639e702b6129: Refactor DeriveAnyClass's instance context inference (authored by RyanGlScott).
Refactor DeriveAnyClass's instance context inference
Feb 10 2017, 3:24 PM
RyanGlScott closed D2961: Refactor DeriveAnyClass's instance context inference by committing rGHC639e702b6129: Refactor DeriveAnyClass's instance context inference.
Feb 10 2017, 3:24 PM
RyanGlScott committed rGHC283a346586e5: Prevent Template Haskell splices from throwing a spurious TypeInType error (authored by RyanGlScott).
Prevent Template Haskell splices from throwing a spurious TypeInType error
Feb 10 2017, 9:35 AM
RyanGlScott closed D3022: Prevent Template Haskell splices from throwing a spurious TypeInType error by committing rGHC283a346586e5: Prevent Template Haskell splices from throwing a spurious TypeInType error.
Feb 10 2017, 9:35 AM
RyanGlScott updated the diff for D2961: Refactor DeriveAnyClass's instance context inference.
  • Accept improved error messages
Feb 10 2017, 9:19 AM

Feb 9 2017

RyanGlScott updated the diff for D3022: Prevent Template Haskell splices from throwing a spurious TypeInType error.
  • Address Richard's comment
Feb 9 2017, 7:42 PM
RyanGlScott accepted D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.

Template Haskell pretty-printing is fixed, so this looks good to me.

Feb 9 2017, 7:35 PM
RyanGlScott updated the diff for D2961: Refactor DeriveAnyClass's instance context inference.

Rebase on top of master

Feb 9 2017, 7:32 PM
RyanGlScott added a comment to D2961: Refactor DeriveAnyClass's instance context inference.

Thanks, @simonpj! We took a winding path to get here, but I think this finally does what it advertised. I've updated the comments and Note accordingly.

Feb 9 2017, 7:30 PM
RyanGlScott updated the diff for D2961: Refactor DeriveAnyClass's instance context inference.
  • It works!
Feb 9 2017, 7:20 PM
RyanGlScott added a comment to D2961: Refactor DeriveAnyClass's instance context inference.

Unfortunately, removing checkNoErrs doesn't change anything. I tried with and without the insolubleWC check. For posterity's sake, I've uploaded a Diff without checkNoErrs.

Feb 9 2017, 10:02 AM
RyanGlScott updated the diff for D2961: Refactor DeriveAnyClass's instance context inference.
  • Don't use checkNoErrs
Feb 9 2017, 10:02 AM
RyanGlScott added a comment to D2961: Refactor DeriveAnyClass's instance context inference.

Well I'm happy that we can delete a bunch of code, but sadly, doing so does not fix the testsuite failures (in fact, even more tests fail now).

Feb 9 2017, 9:50 AM
RyanGlScott updated the diff for D2961: Refactor DeriveAnyClass's instance context inference.
  • Simon's suggestions
Feb 9 2017, 9:48 AM

Feb 8 2017

RyanGlScott added a comment to D2961: Refactor DeriveAnyClass's instance context inference.

Sorry, I meant arc patch D2961.

Feb 8 2017, 10:19 AM
RyanGlScott added a comment to D2961: Refactor DeriveAnyClass's instance context inference.

Four error messages; that's strange. Is there a branch I can build. Or some way to repro?

Feb 8 2017, 10:18 AM
RyanGlScott added a comment to D2961: Refactor DeriveAnyClass's instance context inference.

@simonpj, I feel I'm stuck again. I've tried two different things:

Feb 8 2017, 9:05 AM
RyanGlScott updated the diff for D2961: Refactor DeriveAnyClass's instance context inference.
  • in re simonpj
Feb 8 2017, 9:05 AM

Feb 7 2017

RyanGlScott planned changes to D2961: Refactor DeriveAnyClass's instance context inference.
Feb 7 2017, 10:39 AM
RyanGlScott updated the diff for D2961: Refactor DeriveAnyClass's instance context inference.
  • Latest attempt
Feb 7 2017, 10:07 AM

Feb 6 2017

RyanGlScott accepted D3072: Derive <$.

Looks great @dfeuer! One minor comment inline.

Feb 6 2017, 4:28 PM
RyanGlScott committed rGHCa28a55211d6f: Remove unnecessary use of -DGENERICS flag (authored by RyanGlScott).
Remove unnecessary use of -DGENERICS flag
Feb 6 2017, 1:34 PM

Feb 5 2017

RyanGlScott accepted D3031: Add liftA2 to Applicative class.

Assuming it validates, LGTM.

Feb 5 2017, 5:04 PM
RyanGlScott added a comment to D3043: TH-spliced class instances are pretty-printed incorrectly post-#3384.
In D3043#90517, @alanz wrote:

I have updated the patch to do away with pprParendExpr and pprParendLExpr, to ensure that any hsSyn AST generation does actually insert parens in the right place. Doing the same for pprParendPat is also trivial.

Before tackling pprParendHsType I am looking for some feedback as to whether this makes sense, in particular whether there are any debug features that require a heavily parenthesised output that will be broken by this.

Feb 5 2017, 3:12 PM
RyanGlScott requested changes to D3072: Derive <$.

Thanks for working on this, @dfeuer!

Feb 5 2017, 9:19 AM
RyanGlScott requested changes to D3031: Add liftA2 to Applicative class.

Looks generally good. What about @rwbarton's comment which asks to add a performance test?

Feb 5 2017, 9:09 AM