RyanGlScott (Ryan Scott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 8 2015, 11:07 PM (201 w, 2 d)

Recent Activity

Today

RyanGlScott updated the diff for D5301: Special-case kind-checking single type synonyms.

Rebase on top of master

Sun, Nov 18, 7:38 AM
RyanGlScott updated the diff for D5314: Overhaul -fprint-explicit-kinds to use VKA.
  • Fix parsing
Sun, Nov 18, 7:36 AM
RyanGlScott updated the diff for D5328: Fix #15852 by eta expanding data family instance RHSes, too.
  • Fix warning
Sun, Nov 18, 7:13 AM
RyanGlScott updated the diff for D5328: Fix #15852 by eta expanding data family instance RHSes, too.

Rebase on top of master

Sun, Nov 18, 5:52 AM
RyanGlScott added inline comments to D5328: Fix #15852 by eta expanding data family instance RHSes, too.
Sun, Nov 18, 5:41 AM
RyanGlScott updated the diff for D5328: Fix #15852 by eta expanding data family instance RHSes, too.
Sun, Nov 18, 5:41 AM

Yesterday

RyanGlScott added inline comments to D5301: Special-case kind-checking single type synonyms.
Sat, Nov 17, 7:53 AM
RyanGlScott updated the diff for D5301: Special-case kind-checking single type synonyms.
  • Amend Note
Sat, Nov 17, 7:52 AM
RyanGlScott accepted D5338: Fix #12906: GHC fails to typecheck Main module without main.

LGTM.

Sat, Nov 17, 4:27 AM

Fri, Nov 16

RyanGlScott accepted D4726: NCG: New code layout algorithm..

These flag names look good to me. Great patch.

Fri, Nov 16, 9:59 AM
RyanGlScott added inline comments to D5314: Overhaul -fprint-explicit-kinds to use VKA.
Fri, Nov 16, 9:46 AM
RyanGlScott updated the diff for D5314: Overhaul -fprint-explicit-kinds to use VKA.
Fri, Nov 16, 9:45 AM
RyanGlScott requested changes to D5338: Fix #12906: GHC fails to typecheck Main module without main.

Thanks for doing this, @RolandSenn! This looks good to me, save for one thing.

Fri, Nov 16, 7:37 AM

Wed, Nov 14

RyanGlScott added a comment to D5282: Print explicit foralls in type family eqns when appropriate.

I think you mean Required here...

Wed, Nov 14, 8:55 AM
RyanGlScott added inline comments to D5314: Overhaul -fprint-explicit-kinds to use VKA.
Wed, Nov 14, 4:19 AM
RyanGlScott updated the diff for D5314: Overhaul -fprint-explicit-kinds to use VKA.
Wed, Nov 14, 4:19 AM
RyanGlScott planned changes to D5314: Overhaul -fprint-explicit-kinds to use VKA.

Bumping out of the accepted queue until I've addressed @simonpj's comments.

Wed, Nov 14, 1:59 AM
RyanGlScott added inline comments to D5328: Fix #15852 by eta expanding data family instance RHSes, too.
Wed, Nov 14, 1:58 AM
RyanGlScott added a comment to D5282: Print explicit foralls in type family eqns when appropriate.

Can you either make a new ticket, or leave the current one open, for the task of getting rid of the spurious visibilities?

Wed, Nov 14, 1:41 AM

Tue, Nov 13

RyanGlScott added a comment to D5282: Print explicit foralls in type family eqns when appropriate.

Does anything else need to be done here?

Tue, Nov 13, 2:05 PM
RyanGlScott added a comment to D5301: Special-case kind-checking single type synonyms.

Ping?

Tue, Nov 13, 2:04 PM
RyanGlScott added a comment to D5314: Overhaul -fprint-explicit-kinds to use VKA.

Ping?

Tue, Nov 13, 2:04 PM

Mon, Nov 12

RyanGlScott added inline comments to D5328: Fix #15852 by eta expanding data family instance RHSes, too.
Mon, Nov 12, 6:11 AM
RyanGlScott created D5328: Fix #15852 by eta expanding data family instance RHSes, too.
Mon, Nov 12, 6:10 AM

Fri, Nov 9

RyanGlScott added inline comments to D5314: Overhaul -fprint-explicit-kinds to use VKA.
Fri, Nov 9, 10:13 AM
RyanGlScott updated the diff for D5314: Overhaul -fprint-explicit-kinds to use VKA.
  • Yet another Note
Fri, Nov 9, 10:13 AM
RyanGlScott created D5314: Overhaul -fprint-explicit-kinds to use VKA.
Fri, Nov 9, 9:43 AM

Thu, Nov 8

RyanGlScott retitled D5302: Use autoconf to generate version numbers for libiserv and friends from Use autoconf to generate libiserv's version number to Use autoconf to generate version numbers for libiserv and friends.
Thu, Nov 8, 10:05 AM
RyanGlScott added inline comments to D5302: Use autoconf to generate version numbers for libiserv and friends.
Thu, Nov 8, 10:03 AM
RyanGlScott updated the diff for D5302: Use autoconf to generate version numbers for libiserv and friends.
  • Also handle iserv, iserv-proxy
Thu, Nov 8, 10:02 AM
RyanGlScott planned changes to D5302: Use autoconf to generate version numbers for libiserv and friends.

Eek, I now realize that iserv iserv-proxy also currently hard-code their version numbers, even though they should also be in sync with GHC's version. Give me a bit until I update this.

Thu, Nov 8, 9:49 AM
RyanGlScott accepted D5311: iserv: Fix typo in cabal file.

Macro applause:

Thu, Nov 8, 9:46 AM
RyanGlScott committed rGHC63a817074a8d: Fix #15845 by defining etaExpandFamInstLHS and using it (authored by RyanGlScott).
Fix #15845 by defining etaExpandFamInstLHS and using it
Thu, Nov 8, 9:39 AM
RyanGlScott closed D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.
Thu, Nov 8, 9:39 AM

Wed, Nov 7

RyanGlScott updated the diff for D5282: Print explicit foralls in type family eqns when appropriate.
  • Revise language in Note
Wed, Nov 7, 11:40 AM
RyanGlScott added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Wed, Nov 7, 11:38 AM

Tue, Nov 6

RyanGlScott added a comment to D5303: libiserv: Generate cabal file with autoconf.

This is a duplicate of D5302, no?

Tue, Nov 6, 4:42 PM
RyanGlScott created D5302: Use autoconf to generate version numbers for libiserv and friends.
Tue, Nov 6, 8:47 AM
RyanGlScott added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Tue, Nov 6, 4:49 AM
RyanGlScott updated the diff for D5282: Print explicit foralls in type family eqns when appropriate.
  • Fix typo
Tue, Nov 6, 4:49 AM

Mon, Nov 5

RyanGlScott accepted D5181: Warn on all out-of-range literals in pats/exprs.
Mon, Nov 5, 5:44 PM
RyanGlScott added inline comments to D5301: Special-case kind-checking single type synonyms.
Mon, Nov 5, 4:51 PM
RyanGlScott updated the diff for D5301: Special-case kind-checking single type synonyms.
  • When @simonpj says "jump", you say "how high?"
Mon, Nov 5, 4:51 PM
RyanGlScott created D5301: Special-case kind-checking single type synonyms.
Mon, Nov 5, 1:40 PM
RyanGlScott added a comment to D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.

I've commented on the ticket, as that seems a better place than here.

Mon, Nov 5, 11:55 AM
RyanGlScott added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Mon, Nov 5, 11:53 AM

Fri, Nov 2

RyanGlScott added a comment to D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.

I have a hunch that this might also fix Trac #15852.

Fri, Nov 2, 6:18 PM
RyanGlScott added inline comments to D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.
Fri, Nov 2, 12:36 PM
RyanGlScott updated the diff for D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.
Fri, Nov 2, 12:36 PM
RyanGlScott requested changes to D5181: Warn on all out-of-range literals in pats/exprs.

Alright, I'll try to give an actually in-depth review this time (I'm a bit out of my element here, so forgive me if I ask questions that don't make sense).

Fri, Nov 2, 9:58 AM
Herald added a reviewer for D5294: Fix #15845 by defining etaExpandFamInstLHS and using it: goldfire.
Fri, Nov 2, 9:40 AM

Thu, Nov 1

RyanGlScott added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Thu, Nov 1, 10:45 AM
RyanGlScott updated the diff for D5282: Print explicit foralls in type family eqns when appropriate.
Thu, Nov 1, 10:45 AM

Tue, Oct 30

RyanGlScott committed rGHC42faeb3bf0a1: Add second test case for #15592 (authored by RyanGlScott).
Add second test case for #15592
Tue, Oct 30, 9:51 AM
RyanGlScott resigned from D5280: Fix #15758 by making the RTS parse response file arguments.

I'm afraid that I feel woefully underqualified to review this.

Tue, Oct 30, 9:08 AM

Mon, Oct 29

RyanGlScott created D5282: Print explicit foralls in type family eqns when appropriate.
Mon, Oct 29, 5:42 PM
RyanGlScott committed rGHC331081b03f67: Add a test case for #15829 (authored by RyanGlScott).
Add a test case for #15829
Mon, Oct 29, 12:01 PM

Sun, Oct 28

RyanGlScott committed rGHCe8a652f65318: Bump template-haskell version to 2.15.0.0 (authored by RyanGlScott).
Bump template-haskell version to 2.15.0.0
Sun, Oct 28, 9:35 PM
RyanGlScott updated the diff for D5274: Fix #15815 by parenthesizing the arguments to infix ~.

Rebase on top of master

Sun, Oct 28, 9:26 PM
RyanGlScott added inline comments to D5274: Fix #15815 by parenthesizing the arguments to infix ~.
Sun, Oct 28, 4:08 PM
RyanGlScott updated the diff for D5274: Fix #15815 by parenthesizing the arguments to infix ~.
  • Use mkHsOpTy for consistency
Sun, Oct 28, 4:08 PM
RyanGlScott created D5274: Fix #15815 by parenthesizing the arguments to infix ~.
Sun, Oct 28, 12:29 PM
RyanGlScott committed rGHC32f47e33f75e: Bump template-haskell version to 2.15.0.0 (authored by RyanGlScott).
Bump template-haskell version to 2.15.0.0
Sun, Oct 28, 10:44 AM
RyanGlScott closed D5272: Bump template-haskell version to 2.15.0.0.
Sun, Oct 28, 10:44 AM

Sat, Oct 27

RyanGlScott created D5272: Bump template-haskell version to 2.15.0.0.
Sat, Oct 27, 6:07 PM

Thu, Oct 25

RyanGlScott added a comment to D5253: plugins: search for .a files if necessary.
In D5253#145045, @Phyx wrote:

Hmm are you sure that plugins can't contain a profiled version? That seems a bit odd. @RyanGlScott might you know if they support profiling?

Thu, Oct 25, 1:38 PM

Wed, Oct 24

RyanGlScott committed rGHCbfd93f90b6c6: Fix #15792 by not reifying invisible arguments in AppTys (authored by RyanGlScott).
Fix #15792 by not reifying invisible arguments in AppTys
Wed, Oct 24, 7:20 AM
RyanGlScott closed D5252: Fix #15792 by not reifying invisible arguments in AppTys.
Wed, Oct 24, 7:20 AM
RyanGlScott committed rGHCeaf159340cfa: Trigger multiline mode in GHCi on '\case' (#13087) (authored by harpocrates).
Trigger multiline mode in GHCi on '\case' (#13087)
Wed, Oct 24, 7:20 AM
RyanGlScott committed rGHC79c641de60f1: Fix #15781 by using ktypedocs on type synonym RHSes (authored by RyanGlScott).
Fix #15781 by using ktypedocs on type synonym RHSes
Wed, Oct 24, 7:20 AM
RyanGlScott committed rGHCbb835c96c3d9: Keep top-level names in typed TH quotes alive (authored by RyanGlScott).
Keep top-level names in typed TH quotes alive
Wed, Oct 24, 7:20 AM
RyanGlScott closed D5245: Fix #15781 by using ktypedocs on type synonym RHSes.
Wed, Oct 24, 7:19 AM
RyanGlScott closed D5248: Keep top-level names in typed TH quotes alive.
Wed, Oct 24, 7:19 AM
RyanGlScott closed D5236: Trigger multiline mode in GHCi on '\case' (#13087).
Wed, Oct 24, 7:19 AM

Mon, Oct 22

RyanGlScott updated the diff for D5252: Fix #15792 by not reifying invisible arguments in AppTys.
Mon, Oct 22, 5:49 PM
RyanGlScott created D5252: Fix #15792 by not reifying invisible arguments in AppTys.
Mon, Oct 22, 5:09 PM
RyanGlScott added a comment to D5250: Update hsc2hs submodule to work around bug in response file handling..

After talking to @ckoparkar, I've realized that there are currently no tests which ensure that the version of hsc2hs that is bundled with GHC can support response files. Might you add one here to ensure that this submodule bump actually does what it advertises?

Mon, Oct 22, 8:01 AM

Sat, Oct 20

RyanGlScott created D5248: Keep top-level names in typed TH quotes alive.
Sat, Oct 20, 9:58 AM

Oct 19 2018

RyanGlScott created D5245: Fix #15781 by using ktypedocs on type synonym RHSes.
Oct 19 2018, 7:53 AM

Oct 18 2018

RyanGlScott added a comment to D5229: Visible kind application.

@RyanGlScott I'm fairly sure [] is parsed as a HsVar:
How come we need this code for ExplicitList in tcApp? We don't have an ExplicitList here!

Oct 18 2018, 7:03 PM
RyanGlScott added a comment to D5229: Visible kind application.

To be clear, when I say "special-casing []", I'm referring to this hack in tcApp, which appears to be necessary regardless of how the (term-level) [] is parsed. (But perhaps I'm confusing different levels of hackery here.)

Oct 18 2018, 6:24 PM
RyanGlScott added a comment to D5229: Visible kind application.

5035a25c2020a04f124b05221b209c57403f1cab is the head commit on my local wip/kind-app after I rebased my utils/haddock to origin/ghc-head, so technically my local utils/haddock has diverged from my github fork. I don't see why it would matter, but seems like it does.

Oct 18 2018, 4:52 PM
RyanGlScott added a comment to D5229: Visible kind application.

OK, fine, you've convinced me. I still find it incredibly weird that you can refer to @sassafrass in type-level declarations when sassafrass hasn't been explicitly bound anywhere, but I can wait until later to try and address this wart.

Oct 18 2018, 9:12 AM
RyanGlScott added a comment to D5229: Visible kind application.

I think this is the same panic as I ran into here: https://phabricator.haskell.org/D5229#inline-41010

Oct 18 2018, 8:17 AM

Oct 17 2018

RyanGlScott added a comment to D5229: Visible kind application.

Amazing stuff, @mynguyen!

Oct 17 2018, 3:52 PM
RyanGlScott accepted D5236: Trigger multiline mode in GHCi on '\case' (#13087).

That was surprisingly easy!

Oct 17 2018, 3:08 PM
RyanGlScott updated the Trac tickets for D5236: Trigger multiline mode in GHCi on '\case' (#13087).
Oct 17 2018, 3:08 PM

Oct 15 2018

RyanGlScott added a comment to D5227: Add built-in syntax suggestions, and refactor to allow library use.

why has the error messaged started showing [Char] instead of String?

Oct 15 2018, 2:56 PM
RyanGlScott created D5228: Fix #12430 by expanding type synonyms in injTyVarsOfType.
Oct 15 2018, 12:34 PM
RyanGlScott added a comment to D5206: Move eta-reduced coaxiom compatibility handling quirks into FamInstEnv..

Sorry about the Haddock perf test failing; that was my bad. That test has been corrected upstream (in 4eeeb51d5f51083d0ae393009a7fd246223e9791), so rebasing this commit on top of master will fix that issue.

Oct 15 2018, 4:44 AM

Oct 12 2018

RyanGlScott accepted D5200: Enable -Wcompat=error in the testsuite.

LGTM. Thanks!

Oct 12 2018, 2:54 PM
RyanGlScott added inline comments to D5200: Enable -Wcompat=error in the testsuite.
Oct 12 2018, 9:09 AM
RyanGlScott added inline comments to D5217: Fix #15725 with an extra Sym.
Oct 12 2018, 7:53 AM
RyanGlScott updated the diff for D5217: Fix #15725 with an extra Sym.
  • Comments
Oct 12 2018, 7:53 AM

Oct 11 2018

RyanGlScott planned changes to D5217: Fix #15725 with an extra Sym.
Oct 11 2018, 9:13 PM
RyanGlScott created D5222: Fix #15738 by defining (and using) parenthesizeHsContext.
Oct 11 2018, 8:57 AM

Oct 10 2018

RyanGlScott added a comment to D5220: Make 'Lift'/'TExp' levity-polymorphic.

Is there a reason why we can't just make these instances levity polymorphic now?

Oct 10 2018, 7:21 PM
RyanGlScott added a comment to D5220: Make 'Lift'/'TExp' levity-polymorphic.

Ideally we would have levity-polymorphic _instances_ of unboxed tuples and sums.

Oct 10 2018, 6:24 PM
RyanGlScott added inline comments to D5217: Fix #15725 with an extra Sym.
Oct 10 2018, 9:43 AM
RyanGlScott updated the diff for D5217: Fix #15725 with an extra Sym.
  • Update documentation
Oct 10 2018, 9:43 AM