RyanGlScott (Ryan Scott)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 8 2015, 11:07 PM (236 w, 4 d)

Recent Activity

Fri, Jul 19

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC257d1fd86e6e: Don't maintainer-clean libraries/ghc-boot/ghc.mk (#16953) (authored by RyanGlScott).
Don't maintainer-clean libraries/ghc-boot/ghc.mk (#16953)
Fri, Jul 19, 5:12 PM

Thu, Jul 11

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCb507acebdc3d: Don't typecheck too much (or too little) in DerivingVia (#16923) (authored by RyanGlScott).
Don't typecheck too much (or too little) in DerivingVia (#16923)
Thu, Jul 11, 4:52 PM

Fri, Jul 5

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC62b82135a50b: More sensible SrcSpans for recursive pattern synonym errors (#16900) (authored by RyanGlScott).
More sensible SrcSpans for recursive pattern synonym errors (#16900)
Fri, Jul 5, 6:13 AM

Wed, Jul 3

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCa25f6f55eaca: Bump template-haskell version to 2.16.0.0 (authored by RyanGlScott).
Bump template-haskell version to 2.16.0.0
Wed, Jul 3, 8:40 AM

Sun, Jun 23

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC9bbcc3be5118: Refactor UnliftedNewtypes-relation kind signature validity checks (authored by RyanGlScott).
Refactor UnliftedNewtypes-relation kind signature validity checks
Sun, Jun 23, 4:26 PM

Jun 15 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC25ee60cdae6d: Synchronize ClsInst.doTyConApp with TcTypeable validity checks (#15862) (authored by RyanGlScott).
Synchronize ClsInst.doTyConApp with TcTypeable validity checks (#15862)
Jun 15 2019, 10:38 PM

May 31 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC76e5889017ee: Fix space leaks in dynLoadObjs (#16708) (authored by RyanGlScott).
Fix space leaks in dynLoadObjs (#16708)
May 31 2019, 11:02 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC45f88494293b: Reject nested foralls in foreign imports (#16702) (authored by RyanGlScott).
Reject nested foralls in foreign imports (#16702)
May 31 2019, 11:02 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCe32786dfc929: Put COMPLETE sigs into ModDetails with -fno-code (#16682) (authored by RyanGlScott).
Put COMPLETE sigs into ModDetails with -fno-code (#16682)
May 31 2019, 1:01 AM

May 23 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC6eedbd83a19c: Some forall-related cleanup in deriving code (authored by RyanGlScott).
Some forall-related cleanup in deriving code
May 23 2019, 9:52 PM

May 22 2019

RyanGlScott committed rGHC334dd6da4732: Fix #16603 by documenting some important changes in changelogs (authored by RyanGlScott).
Fix #16603 by documenting some important changes in changelogs
May 22 2019, 6:57 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC6efe04dee3f4: Use HsTyPats in associated type family defaults (authored by RyanGlScott).
Use HsTyPats in associated type family defaults
May 22 2019, 4:03 PM

May 21 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC4a6c8436f974: Fix #16666 by parenthesizing contexts in Convert (authored by RyanGlScott).
Fix #16666 by parenthesizing contexts in Convert
May 21 2019, 4:26 PM

May 8 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC0eeb4cfad732: Fix #16632 by using the correct SrcSpan in checkTyClHdr (authored by RyanGlScott).
Fix #16632 by using the correct SrcSpan in checkTyClHdr
May 8 2019, 1:08 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC786e665b8dac: Fix #16603 by documenting some important changes in changelogs (authored by RyanGlScott).
Fix #16603 by documenting some important changes in changelogs
May 8 2019, 1:02 AM

May 7 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC78a5c4ce6bae: Check for duplicate variables in associated default equations (authored by RyanGlScott).
Check for duplicate variables in associated default equations
May 7 2019, 4:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC961979617a3b: Add /includes/dist to .gitignore (authored by RyanGlScott).
Add /includes/dist to .gitignore
May 7 2019, 5:43 AM

Apr 13 2019

RyanGlScott committed rGHC6e254ee34e2e: Bump hpc submodule (authored by RyanGlScott).
Bump hpc submodule
Apr 13 2019, 8:38 AM

Apr 9 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCbe0dde8e3c27: Use ghc-prim < 0.7, not <= 0.6.1, as upper version bounds (authored by RyanGlScott).
Use ghc-prim < 0.7, not <= 0.6.1, as upper version bounds
Apr 9 2019, 10:30 PM

Apr 8 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCcf9e1837adc6: Bump hpc submodule (authored by RyanGlScott).
Bump hpc submodule
Apr 8 2019, 2:42 PM

Apr 6 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC33b0a291898b: Tweak error messages for narrowly-kinded assoc default decls (authored by RyanGlScott).
Tweak error messages for narrowly-kinded assoc default decls
Apr 6 2019, 11:47 AM
RyanGlScott committed rGHC86ce5718b18a: base: Remove `Monad(fail)` method and reexport `MonadFail(fail)` instead (authored by hvr).
base: Remove `Monad(fail)` method and reexport `MonadFail(fail)` instead
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHC3ab1b7868135: Update parallel submodule (authored by hvr).
Update parallel submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHC460eec60da3c: Update directory submodule (authored by hvr).
Update directory submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHCdd26d4933fea: Update filepath submodule (authored by hvr).
Update filepath submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHC94a576f39e05: Update hpc submodule (authored by hvr).
Update hpc submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHC8cb38504823b: Update terminfo submodule (authored by hvr).
Update terminfo submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHC47b1a718b0af: Update stm submodule (authored by hvr).
Update stm submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHC950d45b9996f: Update process submodule (authored by hvr).
Update process submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHCab97500f0bcf: Update parsec submodule (authored by hvr).
Update parsec submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHC9d228b7508e9: Update haskeline submodule (authored by hvr).
Update haskeline submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHC48989b499214: Update deepseq submodule (authored by hvr).
Update deepseq submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHC29e3898083fe: Update unix submodule (authored by hvr).
Update unix submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHC6ac90706be98: Update text submodule (authored by hvr).
Update text submodule
Apr 6 2019, 8:59 AM
RyanGlScott committed rGHCac12033a7a3a: Update binary submodule to latest master branch tip (authored by hvr).
Update binary submodule to latest master branch tip
Apr 6 2019, 8:59 AM

Apr 4 2019

RyanGlScott committed rGHCc0661417c9ba: Bump transformers to 0.5.6.2 (authored by bgamari).
Bump transformers to 0.5.6.2
Apr 4 2019, 3:44 PM
RyanGlScott committed rGHCd90dcd4ac41c: Bump array submodule (authored by RyanGlScott).
Bump array submodule
Apr 4 2019, 3:44 PM
RyanGlScott committed rGHCdb5a43a9511b: Correct duplicate 4.12.0.0 entry in base's changelog (authored by RyanGlScott).
Correct duplicate 4.12.0.0 entry in base's changelog
Apr 4 2019, 3:44 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC51fd357119b3: Use funPrec, not topPrec, to parenthesize GADT argument types (authored by RyanGlScott).
Use funPrec, not topPrec, to parenthesize GADT argument types
Apr 4 2019, 3:42 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC25c02ea172ef: Fix #16518 with some more kind-splitting smarts (authored by RyanGlScott).
Fix #16518 with some more kind-splitting smarts
Apr 4 2019, 3:35 AM

Apr 2 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC39282422afe5: Bump array submodule (authored by RyanGlScott).
Bump array submodule
Apr 2 2019, 3:54 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCb9da28680aa7: Correct duplicate 4.12.0.0 entry in base's changelog (authored by RyanGlScott).
Correct duplicate 4.12.0.0 entry in base's changelog
Apr 2 2019, 3:53 PM

Mar 21 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC1382d09efadc: Remove unused XArrApp and XArrForm extension points (authored by RyanGlScott).
Remove unused XArrApp and XArrForm extension points
Mar 21 2019, 12:03 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC8d18a873c5d7: Reject nested predicates in impredicativity checking (authored by RyanGlScott).
Reject nested predicates in impredicativity checking
Mar 21 2019, 12:02 PM

Mar 15 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC610ec224a49e: Update Trac ticket URLs to point to GitLab (authored by RyanGlScott).
Update Trac ticket URLs to point to GitLab
Mar 15 2019, 2:10 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC8162eab27101: Remove the GHCi debugger's panicking isUnliftedType check (authored by RyanGlScott).
Remove the GHCi debugger's panicking isUnliftedType check
Mar 15 2019, 2:10 PM

Mar 13 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC36546a43e490: Fix #16411 by making dataConCannotMatch aware of (~~) (authored by RyanGlScott).
Fix #16411 by making dataConCannotMatch aware of (~~)
Mar 13 2019, 6:44 PM

Mar 12 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC4db9bdd91549: Add regression test for #16347 (authored by RyanGlScott).
Add regression test for #16347
Mar 12 2019, 9:59 AM

Mar 7 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC068b7e983f4a: Fix #16391 by using occCheckExpand in TcValidity (authored by RyanGlScott).
Fix #16391 by using occCheckExpand in TcValidity
Mar 7 2019, 7:45 PM

Mar 6 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC78dd04f9126d: Fix #16385 by appending _maybe to a use of lookupGlobalOcc (authored by RyanGlScott).
Fix #16385 by appending _maybe to a use of lookupGlobalOcc
Mar 6 2019, 3:51 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCdb039a4a10fc: Add regression test for #15918 (authored by RyanGlScott).
Add regression test for #15918
Mar 6 2019, 3:51 PM

Mar 4 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCc26d299dc422: Visible dependent quantification (authored by RyanGlScott).
Visible dependent quantification
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCaa79f65c06fb: Bump ghc version to 8.9 (authored by RyanGlScott).
Bump ghc version to 8.9
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC012257c15f58: Fix #16293 by cleaning up Proxy# infelicities (authored by RyanGlScott).
Fix #16293 by cleaning up Proxy# infelicities
Mar 4 2019, 1:06 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC8b476d822e97: Fix #16299 by deleting incorrect code from IfaceSyn (authored by RyanGlScott).
Fix #16299 by deleting incorrect code from IfaceSyn
Mar 4 2019, 1:06 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCc07e7ecbdfc0: Fix #16287 by checking for more unsaturated synonym arguments (authored by RyanGlScott).
Fix #16287 by checking for more unsaturated synonym arguments
Mar 4 2019, 1:05 PM
RyanGlScott committed rGHCe88e083d6238: Fix #14579 by defining tyConAppNeedsKindSig, and using it (authored by RyanGlScott).
Fix #14579 by defining tyConAppNeedsKindSig, and using it
Mar 4 2019, 1:05 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCf0cd728fde9b: Reject oversaturated VKAs in type family equations (authored by RyanGlScott).
Reject oversaturated VKAs in type family equations
Mar 4 2019, 1:05 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCb1e569a54085: Use sigPrec in more places in Convert and HsUtils (authored by RyanGlScott).
Use sigPrec in more places in Convert and HsUtils
Mar 4 2019, 1:03 PM

Feb 14 2019

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

@dfeuer is correct. (You'll notice that if you comment out the deriving stock instance Eq (Foo LiftedRep) part of the program, then it compiles, as it should.)

Feb 14 2019, 12:40 PM

Feb 10 2019

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

While I'm in the neighborhood, I decided to file Trac #16300 about https://phabricator.haskell.org/D4777#151772, since there is also a path forward to fixing that bug independently of this patch.

Feb 10 2019, 9:28 AM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

This patch also exposes a dark corner in :info:

Feb 10 2019, 9:11 AM

Feb 9 2019

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

UnliftedNewtypes have a mildly unpleasant interaction with Template Haskell reification:

Feb 9 2019, 2:47 PM

Feb 8 2019

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I'm not sure if this should count as a bug or not, but you also can't use record selectors with levity polymorphic fields:

Feb 8 2019, 8:11 AM

Feb 7 2019

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

Another ticket to file after this patch lands: it seems that the symptoms of Trac #15883 aren't completely cured by this patch. In particular, this still panics:

Feb 7 2019, 9:25 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

Also, since it looks like most of the in-depth reviewing has quiesced, it would be worth migrating this patch over to GitLab, as it'll need to exist in MR format in order to be merged anyway.

Feb 7 2019, 7:21 PM

Feb 6 2019

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I certainly don't have any more feedback to give on the patch itself (@goldfire and @simonpj might).

Feb 6 2019, 12:03 PM

Jan 25 2019

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

On second thought, I think my comments in https://phabricator.haskell.org/D4777#151665 might be null and void, since kind-changing newtypes actually appear to be quite bogus. At the very least, permitting them allows me to write the following program, which segfaults:

Jan 25 2019, 9:01 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I've been trying out this patch recently, and one thing keeps nagging me at the back of my mind: should Coercible be heterogeneously kinded? The reason I ask is that the UnliftedNewtypes extension lets you define "kind-changing" newtypes like this one:

Jan 25 2019, 8:30 PM

Jan 17 2019

RyanGlScott committed rGHC36e3e7472fd1: @simonpj's suggested refactor (authored by RyanGlScott).
@simonpj's suggested refactor
Jan 17 2019, 11:50 AM
RyanGlScott committed rGHC3429ec8d65ca: Bump Cabal submodule (authored by RyanGlScott).
Bump Cabal submodule
Jan 17 2019, 11:50 AM
RyanGlScott committed rGHC9dc56b61ae10: Control validity-checking of type synonym applications more carefully (authored by RyanGlScott).
Control validity-checking of type synonym applications more carefully
Jan 17 2019, 11:50 AM
RyanGlScott committed rGHC83a22066fbe1: Fix #16114 by adding a validity check to rnClsInstDecl (authored by RyanGlScott).
Fix #16114 by adding a validity check to rnClsInstDecl
Jan 17 2019, 11:50 AM
RyanGlScott committed rGHCe63518f5d6a9: Fix #16116 by removing badAssocRhs (authored by RyanGlScott).
Fix #16116 by removing badAssocRhs
Jan 17 2019, 11:50 AM
RyanGlScott committed rGHC076f5862a9e4: Don't invoke dataConSrcToImplBang on newtypes (authored by RyanGlScott).
Don't invoke dataConSrcToImplBang on newtypes
Jan 17 2019, 11:50 AM

Jan 16 2019

RyanGlScott committed rGHC6b70cf611e5d: Be pickier about unsaturated synonyms in :kind (authored by RyanGlScott).
Be pickier about unsaturated synonyms in :kind
Jan 16 2019, 12:24 AM

Jan 9 2019

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

but it sounds like Ryan knows.

Jan 9 2019, 12:30 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

That mkTyConKindRepBinds panic is bizarre. This suggests that GHC is trying to create Typeable bindings for the kind of Foo. But Typeable doesn't support type families (like Interpret), so it shouldn't be attempting to create those bindings in the first place! Perhaps the issue is GHC simply not recognizing this fact. (I've observed similar issues here, although I haven't managed to get that exact mkTyConKindRepBinds panic before.)

Jan 9 2019, 11:05 AM

Jan 8 2019

RyanGlScott abandoned D5471: Be pickier about unsaturated synonyms in :kind.

I've migrated this over to GitLab in https://gitlab.haskell.org/ghc/ghc/merge_requests/90 (once it validates, I'll merge).

Jan 8 2019, 7:57 AM
RyanGlScott added a comment to D5471: Be pickier about unsaturated synonyms in :kind.

Sorry to be so slow.

Jan 8 2019, 5:37 AM

Jan 7 2019

RyanGlScott added inline comments to D5471: Be pickier about unsaturated synonyms in :kind.
Jan 7 2019, 3:10 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

@andrewthad, you've added Trac #15883 as a related Trac ticket in the Diff description, but is there a corresponding test case for it? (I can't find one.)

Jan 7 2019, 2:46 PM
RyanGlScott abandoned D5451: add -Wmissing-deriving-strategies.

This was migrated to GitLab in https://gitlab.haskell.org/ghc/ghc/merge_requests/48 and later merged in c121e33f9b039acf2ac6939af8bfafe593560039.

Jan 7 2019, 8:55 AM

Jan 5 2019

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

Sorry to add to your pile of TODOs, but I just noticed that this patch actually fixes a Trac ticket that's not listed in the Diff description: Trac #15883. Specifically, this test case:

Jan 5 2019, 10:28 AM
RyanGlScott abandoned D5229: Visible kind application.

This was landed in 17bd163566153babbf51adaff8397f948ae363ca.

Jan 5 2019, 9:35 AM

Dec 31 2018

RyanGlScott added inline comments to D5471: Be pickier about unsaturated synonyms in :kind.
Dec 31 2018, 10:24 AM

Dec 28 2018

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

Oops, ignore what I said in https://phabricator.haskell.org/D4777#151228. That isn't a bug at all. The reason that it's defaulting to LiftedRep with GHC 8.6+ is because I didn't enable -fprint-explicit-runtime-reps, and GHC's RuntimeRep defaulting became smarter in GHC 8.6.

Dec 28 2018, 6:24 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I'm now 100% convinced this is due to a pre-existing bug in tcHsDeriv. Consider the following program:

Dec 28 2018, 10:06 AM

Dec 27 2018

RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I'm not sure what exactly is going on here. Perhaps @RyanGlScott knows.

Dec 27 2018, 10:04 PM

Dec 24 2018

RyanGlScott added inline comments to D5471: Be pickier about unsaturated synonyms in :kind.
Dec 24 2018, 3:02 PM

Dec 21 2018

RyanGlScott created D5471: Be pickier about unsaturated synonyms in :kind.
Dec 21 2018, 8:39 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I don't have a strong opinion on whether coerce should be levity polymorphic. I'd be fine with the more general type signature, but I'd also be fine with just making a copy of coerce with a levity polymorphic type (something like coerceLevPoly) and exporting it from Data.Coerce alongside coerce. Either way, I think we should have something levity polymorphic in Data.Coerce, especially since people are asking for this in Trac #13595.

Dec 21 2018, 10:48 AM

Dec 20 2018

RyanGlScott added inline comments to D5420: Fix #16002 by moving a validity check to the renamer.
Dec 20 2018, 10:29 PM
RyanGlScott committed rGHC28f41f1a7a0e: Fix #16002 by moving a validity check to the renamer (authored by RyanGlScott).
Fix #16002 by moving a validity check to the renamer
Dec 20 2018, 10:29 PM
RyanGlScott closed D5420: Fix #16002 by moving a validity check to the renamer.
Dec 20 2018, 10:29 PM
RyanGlScott added a comment to D4777: Implement the Unlifted Newtypes proposal.

I'm reviewing this patch rather late it seems, but things appear to be progressing quite nicely! Some requests:

Dec 20 2018, 6:56 PM
RyanGlScott added inline comments to D5420: Fix #16002 by moving a validity check to the renamer.
Dec 20 2018, 12:32 PM
RyanGlScott added a comment to D5420: Fix #16002 by moving a validity check to the renamer.

I think I've resolved all of @simonpj's concerns here—if no one says otherwise, I'll land this some time next week.

Dec 20 2018, 8:43 AM

Dec 18 2018

RyanGlScott added inline comments to D5420: Fix #16002 by moving a validity check to the renamer.
Dec 18 2018, 2:16 PM
RyanGlScott updated the diff for D5420: Fix #16002 by moving a validity check to the renamer.
Dec 18 2018, 2:15 PM