Rufflewind (Phil Ruffwind)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2014, 8:23 PM (243 w, 1 h)

Recent Activity

Oct 29 2017

Rufflewind added a comment to D4110: Introduce with# as preferred alternative to touch#.

What is (State# s -> r)? It looks like the State# s token is being consumed by the callback, which seems a bit odd.

Oct 29 2017, 1:32 AM

May 21 2017

Rufflewind updated the diff for D3599: Add "header" to GHC_COLORS.

Improve docs + make inheritance actually work

May 21 2017, 10:38 AM

May 20 2017

Rufflewind updated the diff for D3599: Add "header" to GHC_COLORS.

Clarify docs

May 20 2017, 6:31 PM

May 19 2017

Rufflewind created D3599: Add "header" to GHC_COLORS.
May 19 2017, 8:56 AM

May 15 2017

Rufflewind added inline comments to D3578: Correctly expand lines with multiple tabs.
May 15 2017, 11:49 PM

May 12 2017

Rufflewind updated the diff for D3578: Correctly expand lines with multiple tabs.

Remove guards in favor of patterns

May 12 2017, 7:33 PM
Rufflewind created D3578: Correctly expand lines with multiple tabs.
May 12 2017, 7:23 PM
Rufflewind added inline comments to D3549: Render \t as 8 spaces in caret diagnostics.
May 12 2017, 7:23 PM

May 8 2017

Rufflewind abandoned D2875: Cache the files in StringBuffer to improve efficiency.
May 8 2017, 10:59 PM
Rufflewind added a comment to D3549: Render \t as 8 spaces in caret diagnostics.

I tweaked the testlib a little bit to allow changing the whitespace-normaliser.

May 8 2017, 6:16 PM
Rufflewind updated the diff for D3549: Render \t as 8 spaces in caret diagnostics.

Fix fixWhitespace and also the tests

May 8 2017, 6:12 PM
Rufflewind planned changes to D3549: Render \t as 8 spaces in caret diagnostics.

Hm, it seems testing is not as straightforward – I think the stderr normaliser turns tabs into 8 spaces? So it can't really tell the difference between the two…

May 8 2017, 5:08 PM
Rufflewind updated the diff for D3549: Render \t as 8 spaces in caret diagnostics.

Add test

May 8 2017, 5:08 PM
Rufflewind retitled D3549: Render \t as 8 spaces in caret diagnostics from Summary: Render \t as 8 spaces in caret diagnostics to Render \t as 8 spaces in caret diagnostics.
May 8 2017, 4:14 PM
Rufflewind created D3549: Render \t as 8 spaces in caret diagnostics.
May 8 2017, 4:12 PM

Apr 12 2017

Rufflewind accepted D3440: Caret diagnostics: Avoid decoding whole module if only specific line is needed.

Thanks!

Apr 12 2017, 5:08 PM

Apr 11 2017

Rufflewind added inline comments to D3440: Caret diagnostics: Avoid decoding whole module if only specific line is needed.
Apr 11 2017, 5:06 PM

Apr 9 2017

Rufflewind updated the diff for D2875: Cache the files in StringBuffer to improve efficiency.

Rebase

Apr 9 2017, 11:41 AM

Mar 18 2017

Rufflewind updated the diff for D3364: Allow colors to be customized.

Unhide 'bold' from Outputable

Mar 18 2017, 9:52 PM
Rufflewind added a reviewer for D3364: Allow colors to be customized: hvr.
Mar 18 2017, 7:56 PM
Rufflewind updated the diff for D3364: Allow colors to be customized.

Update docs

Mar 18 2017, 7:53 PM
Rufflewind created D3364: Allow colors to be customized.
Mar 18 2017, 7:51 PM

Mar 12 2017

Rufflewind updated the Trac tickets for D3333: unlit: replace the SHEBANG with an empty line.
Mar 12 2017, 6:16 PM
Rufflewind created D3333: unlit: replace the SHEBANG with an empty line.
Mar 12 2017, 6:15 PM

Mar 11 2017

Rufflewind updated the diff for D3313: Add COLUMN pragma.

Rebase

Mar 11 2017, 1:14 AM

Mar 10 2017

Rufflewind added a comment to D3313: Add COLUMN pragma.

I made some tweaks to hsc2hs to work around this problem. This means GHC will build fine even with an older GHC, albeit with warnings about missing pragmas.

Mar 10 2017, 12:57 PM
Rufflewind updated the diff for D3313: Add COLUMN pragma.

Disambiguate Read type as Integer

Mar 10 2017, 12:42 PM
Rufflewind added a comment to D3313: Add COLUMN pragma.

Heh, I was actually expecting more … critique here, considering this is the first time I have ever messed with a lexer :P

Mar 10 2017, 9:15 AM
Rufflewind updated the diff for D3313: Add COLUMN pragma.

Remove unrelated comment

Mar 10 2017, 8:02 AM
Rufflewind created D3313: Add COLUMN pragma.
Mar 10 2017, 7:58 AM

Jan 26 2017

Rufflewind updated the diff for D2807: Fix broken tests.

Unbashify timeout.py

Jan 26 2017, 8:30 PM
Rufflewind added inline comments to D2807: Fix broken tests.
Jan 26 2017, 7:39 PM
Rufflewind updated the diff for D2807: Fix broken tests.

re-ignore_stderr

Jan 26 2017, 7:38 PM
Rufflewind added inline comments to D2807: Fix broken tests.
Jan 26 2017, 4:45 PM

Jan 25 2017

Rufflewind updated the diff for D2807: Fix broken tests.

Commit to /bin/bash and re-enable stderr validation

Jan 25 2017, 6:26 PM
Rufflewind added a comment to D2807: Fix broken tests.
In D2807#88472, @dfeuer wrote:

What I mean is that you can run bash and specify that there shouldn't be any errors.

Jan 25 2017, 2:22 PM
Rufflewind added a comment to D2807: Fix broken tests.
In D2807#88447, @dfeuer wrote:

Since sh is meaningless, why do we use it? If we instead run a specific shell, then we should get much more consistent results. I'm not terribly comfortable with the idea of throwing away stderr output.

Jan 25 2017, 2:14 PM

Jan 16 2017

Rufflewind abandoned D2875: Cache the files in StringBuffer to improve efficiency.

I wrote this patch to preempt concerns regarding the performance impact of D2718. Given that the performance of GHC is trending concern, I felt I would doing a disfavor in having submitted D2718 that has the potential to worsen the status quo.

Jan 16 2017, 9:18 PM

Jan 10 2017

Rufflewind updated the diff for D2935: Unquote ‘import’ in bad import error message.

Update test stderrs

Jan 10 2017, 10:07 PM

Jan 9 2017

Rufflewind updated the diff for D2932: Fix terminal corruption bug and clean up SDoc interface..

Unfilter qualified imports of Pretty + try to improve docs of printForC

Jan 9 2017, 9:54 PM

Jan 6 2017

Rufflewind added a comment to D2875: Cache the files in StringBuffer to improve efficiency.

For the record, I'm not opposed to this but I would first like to see evidence that its complexity pulls its weight.

Jan 6 2017, 5:24 PM
Rufflewind added a comment to D2932: Fix terminal corruption bug and clean up SDoc interface..

Ok great! I love the caret's in error messages by the way, good job with that.

Jan 6 2017, 1:45 PM
Rufflewind updated D2932: Fix terminal corruption bug and clean up SDoc interface..
Jan 6 2017, 1:31 PM
Rufflewind updated the diff for D2932: Fix terminal corruption bug and clean up SDoc interface..

Restore withPprStyleDoc

Jan 6 2017, 1:31 PM
Rufflewind added a comment to D2932: Fix terminal corruption bug and clean up SDoc interface..

There are a lot of packages that use the GHC API which use SDoc! I am not a bit nervous that these changes in general are going to break all these packages which usually do not want to print to terminal.

Jan 6 2017, 1:31 PM
Rufflewind added a comment to D2932: Fix terminal corruption bug and clean up SDoc interface..

Wow, that was fast! Thanks a bunch for your work on this, @Rufflewind. I can confirm that this Diff fixes the issue reported in Trac #13076. (I have no idea how you'd put that into a reliable GHC test, though.)

Jan 6 2017, 1:20 PM
Rufflewind added a comment to D2932: Fix terminal corruption bug and clean up SDoc interface..

withPprStyleDoc is used in 3 downstream packages. Is there a good reason to remove it?

Jan 6 2017, 1:19 PM
Rufflewind retitled D2935: Unquote ‘import’ in bad import error message from to Unquote ‘import’ in bad import error message.
Jan 6 2017, 12:56 PM
Rufflewind retitled D2932: Fix terminal corruption bug and clean up SDoc interface. from to Fix terminal corruption bug and clean up SDoc interface..
Jan 6 2017, 12:43 PM
Rufflewind updated D2932: Fix terminal corruption bug and clean up SDoc interface..
Jan 6 2017, 12:43 PM

Dec 19 2016

Rufflewind added a comment to D2718: Add caret diagnostics.

Thanks everyone for reviewing this! :)

Dec 19 2016, 7:12 PM

Dec 17 2016

Rufflewind added a child revision for D2718: Add caret diagnostics: D2875: Cache the files in StringBuffer to improve efficiency.
Dec 17 2016, 3:43 PM
Rufflewind added a parent revision for D2875: Cache the files in StringBuffer to improve efficiency: D2718: Add caret diagnostics.
Dec 17 2016, 3:43 PM
Rufflewind updated D2718: Add caret diagnostics.
Dec 17 2016, 3:42 PM
Rufflewind updated D2718: Add caret diagnostics.
Dec 17 2016, 3:41 PM
Rufflewind added a comment to D2718: Add caret diagnostics.

I would really prefer if we could keep the core functionality separate from the caching in the commit history. Can you split this out into another diff?

Dec 17 2016, 3:40 PM
Rufflewind retitled D2875: Cache the files in StringBuffer to improve efficiency from to Cache the files in StringBuffer to improve efficiency.
Dec 17 2016, 3:40 PM
Rufflewind updated the diff for D2718: Add caret diagnostics.

Split caching into a separate differential

Dec 17 2016, 3:36 PM
Rufflewind added a comment to D2718: Add caret diagnostics.

@Rufflewind, what is your plan for this? Do you consider this patch finished?

Dec 17 2016, 1:46 AM
Rufflewind updated the diff for D2718: Add caret diagnostics.

Cache files in buffers to improve efficiency + Add margin and ellipsis

Dec 17 2016, 1:44 AM
Rufflewind updated the diff for D2809: Windows: Improve terminal detection mechanism.

Migrate to SysTools.Terminal

Dec 17 2016, 1:39 AM
Rufflewind added a comment to D2872: Improve StringBuffer and FastString docs.

I'm not quite sure what "must be explicitly allocated elsewhere" means.

Dec 17 2016, 1:36 AM
Rufflewind updated the diff for D2872: Improve StringBuffer and FastString docs.

Improve FastString docs

Dec 17 2016, 1:35 AM

Dec 16 2016

Rufflewind retitled D2872: Improve StringBuffer and FastString docs from to Improve StringBuffer and FastString docs.
Dec 16 2016, 10:36 PM
Rufflewind updated the diff for D2807: Fix broken tests.

ignore_stderr in topHandler03

Dec 16 2016, 10:11 PM
Rufflewind updated D2807: Fix broken tests.
Dec 16 2016, 10:11 PM
Rufflewind updated D2807: Fix broken tests.
Dec 16 2016, 10:11 PM
Rufflewind updated D2807: Fix broken tests.
Dec 16 2016, 10:11 PM
Rufflewind added a comment to D2807: Fix broken tests.

I tested this on an Ubuntu box and got the same result as yours.

Dec 16 2016, 9:43 PM

Dec 13 2016

Rufflewind added a comment to D2807: Fix broken tests.

@Rufflewind, I tried merging this but found that topHandler03 still produces Terminated on stderr. Are you certain about this change?

Dec 13 2016, 6:27 PM

Dec 10 2016

Rufflewind added a comment to D2718: Add caret diagnostics.

What is the CaretDiagnostic2 test trying to test?

Dec 10 2016, 5:41 PM
Rufflewind added a comment to D2718: Add caret diagnostics.

Had to coerce the arc linter scripts into playing nicely with the binary files.

Dec 10 2016, 3:36 PM
Rufflewind retitled D2809: Windows: Improve terminal detection mechanism from Windows: Disable colors if stderr is not a terminal to Windows: Improve terminal detection mechanism.
Dec 10 2016, 1:30 PM
Rufflewind updated D2809: Windows: Improve terminal detection mechanism.
Dec 10 2016, 10:51 AM

Dec 9 2016

Rufflewind updated the diff for D2807: Fix broken tests.

Unfix T10276

Dec 9 2016, 10:00 PM
Rufflewind updated the diff for D2718: Add caret diagnostics.

Ensure width is at least 1

Dec 9 2016, 4:11 PM
Rufflewind updated D2718: Add caret diagnostics.
Dec 9 2016, 2:11 PM
Rufflewind updated the diff for D2718: Add caret diagnostics.

Add tests and tweak style slightly

Dec 9 2016, 2:08 PM

Dec 8 2016

Rufflewind added a comment to D2807: Fix broken tests.

Perhaps you could open a ticket for these?

Dec 8 2016, 8:34 PM
Rufflewind added a comment to D2809: Windows: Improve terminal detection mechanism.

I went with the first approach. The code now should be able to detect MinTTY with little fear of false positives (assuming no-one would go out of their way to name their non-TTY pipes \msys-fake-pty0-to-master).

Dec 8 2016, 8:10 PM
Rufflewind updated the diff for D2809: Windows: Improve terminal detection mechanism.

Forgot to divide by sizeof(wchar_t)

Dec 8 2016, 8:06 PM
Rufflewind updated the diff for D2809: Windows: Improve terminal detection mechanism.

Use GetFileInformationByHandleEx to detect Cygwin/MSYS terminals

Dec 8 2016, 7:37 PM
Rufflewind updated D2808: Ensure each test inherits the TEST_HC_OPTS.
Dec 8 2016, 2:40 PM
Rufflewind updated D2808: Ensure each test inherits the TEST_HC_OPTS.
Dec 8 2016, 2:40 PM
Rufflewind updated the diff for D2808: Ensure each test inherits the TEST_HC_OPTS.

Ignore stderr for API annotations

Dec 8 2016, 2:39 PM
Rufflewind added a comment to D2809: Windows: Improve terminal detection mechanism.
In D2809#81910, @Phyx wrote:

So I don't completely follow why the need to detect if we have a true TTY or not.

Dec 8 2016, 2:33 PM
Rufflewind updated the diff for D2805: testsuite: make tests respond to SIGINT properly.

Remove basestring

Dec 8 2016, 2:13 PM
Rufflewind added a comment to D2809: Windows: Improve terminal detection mechanism.

Oh wait I found another one: https://fossies.org/linux/vim/src/iscygpty.c

Dec 8 2016, 1:57 PM
Rufflewind added a comment to D2809: Windows: Improve terminal detection mechanism.

After I finally got this to build on Windows, I discovered that moving the “is a TTY?” test before the environment variable tests means that on non-Windows terminals (such as MinTTY) the test will never succeed. This is because MinTTY does not implement a true Windows console, but a fake one using pipes. Therefore, Windows API has no idea that the pipe does indeed lead to a terminal.

Dec 8 2016, 1:46 PM
Rufflewind retitled D2809: Windows: Improve terminal detection mechanism from to Windows: Disable colors if stderr is not a terminal.
Dec 8 2016, 11:07 AM
Rufflewind retitled D2808: Ensure each test inherits the TEST_HC_OPTS from to Ensure each test inherits the TEST_HC_OPTS.
Dec 8 2016, 10:41 AM
Rufflewind added a comment to D2807: Fix broken tests.

Other broken tests that aren't fixed in this patch:

Dec 8 2016, 10:38 AM
Rufflewind retitled D2807: Fix broken tests from to Fix broken tests.
Dec 8 2016, 10:34 AM
Rufflewind updated D2805: testsuite: make tests respond to SIGINT properly.
Dec 8 2016, 7:38 AM
Rufflewind retitled D2805: testsuite: make tests respond to SIGINT properly from to testsuite: make tests respond to SIGINT properly.
Dec 8 2016, 7:37 AM

Dec 7 2016

Rufflewind updated the diff for D2718: Add caret diagnostics.

Remove accidental infinite loop

Dec 7 2016, 1:29 PM

Dec 6 2016

Rufflewind updated the diff for D2718: Add caret diagnostics.

Fix typo

Dec 6 2016, 11:00 AM
Rufflewind added a child revision for D2792: Disable colors unless printing to stderr: D2718: Add caret diagnostics.
Dec 6 2016, 10:54 AM
Rufflewind added a parent revision for D2718: Add caret diagnostics: D2792: Disable colors unless printing to stderr.
Dec 6 2016, 10:54 AM
Rufflewind updated the diff for D2718: Add caret diagnostics.

Highlight the offending code too + make caret color same color as severity

Dec 6 2016, 10:52 AM