RolandSenn (Roland Senn)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 1 2018, 2:58 AM (24 w, 22 h)

Recent Activity

Yesterday

RolandSenn updated the summary of D5338: Fix #12906: GHC fails to typecheck Main module without main.
Fri, Nov 16, 2:00 PM
RolandSenn updated the diff for D5338: Fix #12906: GHC fails to typecheck Main module without main.
  • Add suggestions of the reviewer.
Fri, Nov 16, 1:58 PM

Thu, Nov 15

RolandSenn created D5338: Fix #12906: GHC fails to typecheck Main module without main.
Thu, Nov 15, 4:07 AM

Mon, Nov 12

RolandSenn created D5331: Misleading msg with qualified imports "No module named X imported #14225.
Mon, Nov 12, 3:14 PM
RolandSenn added inline comments to D5326: Fix #12525: Remove derived bindings from the TyThings from getBindings.
Mon, Nov 12, 10:05 AM
RolandSenn updated the diff for D5326: Fix #12525: Remove derived bindings from the TyThings from getBindings.
Mon, Nov 12, 10:03 AM
RolandSenn updated the diff for D5326: Fix #12525: Remove derived bindings from the TyThings from getBindings.
Mon, Nov 12, 9:59 AM

Sun, Nov 11

RolandSenn updated the summary of D5326: Fix #12525: Remove derived bindings from the TyThings from getBindings.
Sun, Nov 11, 3:12 PM
RolandSenn created D5326: Fix #12525: Remove derived bindings from the TyThings from getBindings.
Sun, Nov 11, 3:07 PM

Fri, Nov 9

RolandSenn updated the diff for D5318: Calling gcc: Pass optc flags as last options (#14452).
Fri, Nov 9, 2:55 PM
RolandSenn added a comment to D5318: Calling gcc: Pass optc flags as last options (#14452).

A similar patch to change the order of LLVM parameters can be found in Phab:D4421

Fri, Nov 9, 2:48 PM
RolandSenn updated the summary of D5318: Calling gcc: Pass optc flags as last options (#14452).
Fri, Nov 9, 2:46 PM
RolandSenn created D5318: Calling gcc: Pass optc flags as last options (#14452).
Fri, Nov 9, 2:44 PM
RolandSenn added a comment to D5308: Respect naming conventions in module RnUnbound.hs in fix for #15611.

Thanks for the review.

Fri, Nov 9, 2:10 AM
RolandSenn updated the diff for D5308: Respect naming conventions in module RnUnbound.hs in fix for #15611.
  • Changes requested by code review (Trac #15611.Phab:5308)
Fri, Nov 9, 2:06 AM

Wed, Nov 7

RolandSenn updated the summary of D5308: Respect naming conventions in module RnUnbound.hs in fix for #15611.
Wed, Nov 7, 2:40 PM
RolandSenn created D5308: Respect naming conventions in module RnUnbound.hs in fix for #15611.
Wed, Nov 7, 2:35 PM
RolandSenn retitled D5162: GHCi does not need a main function from GHCi does not honour implicit `module Main (main) where` for re-exported `main`s to GHCi does not need a main function.
Wed, Nov 7, 3:19 AM

Sat, Nov 3

RolandSenn added inline comments to D5162: GHCi does not need a main function.
Sat, Nov 3, 11:13 AM
RolandSenn created D5296: Remove -Wamp flag (#11477).
Sat, Nov 3, 8:42 AM

Fri, Nov 2

RolandSenn added a comment to D4785: #11477 Remove -Wamp flag.

@bgamari: Ben, do you want a short line in the release notes about the removal of the -Wamp flag?

Fri, Nov 2, 5:22 AM

Tue, Oct 30

RolandSenn updated the summary of D5284: Fix for Trac #15611: Scope errors lie about what modules are imported..
Tue, Oct 30, 8:02 AM
RolandSenn created D5284: Fix for Trac #15611: Scope errors lie about what modules are imported..
Tue, Oct 30, 7:54 AM
RolandSenn added a comment to D5162: GHCi does not need a main function.

@mpickering After having read D5189#142767, I tested Trac #11567 with a version that included the patch D5189 but not this patch and found:
Patch D5189 does not fix Trac #11567. Therefore I kindly ask you to review the new version of this patch.

Tue, Oct 30, 4:06 AM

Sep 23 2018

RolandSenn added a comment to D5162: GHCi does not need a main function.

@mpickering Thank you for the hint about check_main. The patch is now much simpler. I also tested with the -fobject-code flag and switching between GHC and GHCi and I didn't get any error messages.

Sep 23 2018, 5:28 AM
RolandSenn updated the summary of D5162: GHCi does not need a main function.
Sep 23 2018, 5:26 AM
RolandSenn updated the diff for D5162: GHCi does not need a main function.
  • Merge branch 'master' into T11647
  • Improve patch for Trac #11647
Sep 23 2018, 5:15 AM

Sep 20 2018

RolandSenn added a comment to D5162: GHCi does not need a main function.

Thanks for this code review!
I'll rework this patch.

Sep 20 2018, 3:10 PM

Sep 19 2018

RolandSenn retitled D5162: GHCi does not need a main function from GHCi: A module without export list must re-export imported main (#11647) to GHCi does not honour implicit `module Main (main) where` for re-exported `main`s.
Sep 19 2018, 7:49 AM
RolandSenn created D5162: GHCi does not need a main function.
Sep 19 2018, 7:45 AM

Sep 16 2018

RolandSenn added a comment to D5122: Fix for #13862: Optional "-v" not allowed with :load in GHCi.

@osa1 I fixed the failing tests. Please note the changing version numbers for packages containers and ghc.

Sep 16 2018, 7:07 AM
RolandSenn updated the diff for D5122: Fix for #13862: Optional "-v" not allowed with :load in GHCi.
  • Merge branch 'master' into T13862
  • T13862 Fix failing tests due to new message
Sep 16 2018, 7:03 AM

Sep 13 2018

RolandSenn updated the summary of D5122: Fix for #13862: Optional "-v" not allowed with :load in GHCi.
Sep 13 2018, 2:58 AM
RolandSenn added a comment to D5122: Fix for #13862: Optional "-v" not allowed with :load in GHCi.

@osa1 Thanks for your comments.

Sep 13 2018, 2:55 AM
RolandSenn updated the diff for D5122: Fix for #13862: Optional "-v" not allowed with :load in GHCi.
  • T13862 Back out new DynFlag
  • T13862 Change text of error message.
Sep 13 2018, 2:31 AM

Sep 8 2018

RolandSenn added a comment to D5122: Fix for #13862: Optional "-v" not allowed with :load in GHCi.

Why not simply change the error message to:
Use -v (or :set -v` in ghci) to see a list of the files searched for. `

Sep 8 2018, 8:49 AM

Sep 3 2018

RolandSenn created D5125: Fix tests ghci057 and T9293. (#15071).
Sep 3 2018, 9:11 AM

Sep 2 2018

RolandSenn created D5122: Fix for #13862: Optional "-v" not allowed with :load in GHCi.
Sep 2 2018, 7:02 AM

Sep 1 2018

RolandSenn requested review of D5093: Compiler panic on invalid syntax (unterminated pragma).
Sep 1 2018, 2:47 PM
RolandSenn added a comment to D5093: Compiler panic on invalid syntax (unterminated pragma).

I now changed to the error message, that's more consistent with the error message issued on a LANGUAGE pragma error.

Sep 1 2018, 2:44 PM
RolandSenn added a reviewer for D5093: Compiler panic on invalid syntax (unterminated pragma): osa1.
Sep 1 2018, 2:43 PM
RolandSenn updated the diff for D5093: Compiler panic on invalid syntax (unterminated pragma).
  • Error msg more consistent with LANGUAGE pragma error (Trac #15053)
Sep 1 2018, 2:39 PM

Aug 30 2018

RolandSenn added a comment to D5093: Compiler panic on invalid syntax (unterminated pragma).

Ah so you wanted to update languagePragParseError too? Why?

Aug 30 2018, 2:52 AM
RolandSenn added a comment to D5093: Compiler panic on invalid syntax (unterminated pragma).

@osa1 I started with modifying the languagePragParseError message. But as an non native English speaker I obviously was not very successful... I'll wait 3 or 4 days for additional comments and then decide.
@Phyx Can you live with the message text proposed by Ömer?

Aug 30 2018, 2:11 AM

Aug 29 2018

RolandSenn added a comment to D5093: Compiler panic on invalid syntax (unterminated pragma).

@Phyx Thanks for your nice text. I changed to your version. I added a colon (:) after Input was. PLease inform me, if you dont like it.
@tdammers Thanks for your comment. In the new error message text, there is no more something like non-parasable.

Aug 29 2018, 3:10 AM
RolandSenn updated the diff for D5093: Compiler panic on invalid syntax (unterminated pragma).
Aug 29 2018, 3:01 AM

Aug 25 2018

RolandSenn updated the diff for D5093: Compiler panic on invalid syntax (unterminated pragma).
Aug 25 2018, 9:02 AM

Aug 23 2018

RolandSenn added a comment to D5093: Compiler panic on invalid syntax (unterminated pragma).

Agreed: white-space separated is much better! My version of the error message is just a first proposal.

Aug 23 2018, 3:34 PM
RolandSenn updated the summary of D5093: Compiler panic on invalid syntax (unterminated pragma).
Aug 23 2018, 9:23 AM
RolandSenn created D5093: Compiler panic on invalid syntax (unterminated pragma).
Aug 23 2018, 9:22 AM

Aug 18 2018

RolandSenn added a comment to D5038: CSE should deal with letrec.

For the changes requested by nomeata see: https://phabricator.haskell.org/D5076

Aug 18 2018, 7:03 AM
RolandSenn updated the summary of D5076: CSE should deal with letrec (#9441).
Aug 18 2018, 7:01 AM
RolandSenn created D5076: CSE should deal with letrec (#9441).
Aug 18 2018, 6:55 AM

Aug 13 2018

RolandSenn added a comment to D5038: CSE should deal with letrec.

@nomeata Thanks for your comment!

Aug 13 2018, 2:42 AM

Aug 12 2018

RolandSenn added a comment to D4861: Introduce flag -keep-hscpp-files (#10869).

@thomie Thanks for the hint. I have added a line to the 8.8.1 release notes.

Aug 12 2018, 6:32 AM
RolandSenn updated the diff for D4861: Introduce flag -keep-hscpp-files (#10869).
Aug 12 2018, 6:24 AM

Aug 9 2018

RolandSenn created D5053: Show -with-rtsopts options in runtime's --info (#15261).
Aug 9 2018, 11:13 AM

Aug 8 2018

RolandSenn added a comment to D4861: Introduce flag -keep-hscpp-files (#10869).

I guess specifying -E together with -keep-hscpp-files will write both files?

Aug 8 2018, 1:58 PM
RolandSenn added a comment to D4861: Introduce flag -keep-hscpp-files (#10869).

@thomie The patch is now much shorter. Thanks for your kind help.

Aug 8 2018, 8:40 AM
RolandSenn retitled D4861: Introduce flag -keep-hscpp-files (#10869) from Introduce flag -keep-hspp-files (#10869) to Introduce flag -keep-hscpp-files (#10869).
Aug 8 2018, 8:33 AM
RolandSenn updated the diff for D4861: Introduce flag -keep-hscpp-files (#10869).
  • Improve patch after code review (Trac #10869).
  • Rename flag form keep-hspp-files to kepp-hscpp-files.
  • Do not copy the file but reuse code from the keep-hc/s/llvm-files flags.
Aug 8 2018, 8:31 AM

Aug 7 2018

RolandSenn added a comment to D4861: Introduce flag -keep-hscpp-files (#10869).

@thomie: Many thanks for your code review and your kind hints to improve the patch.

Aug 7 2018, 9:22 AM

Aug 3 2018

RolandSenn added a comment to D5038: CSE should deal with letrec.

@dfeuer: I added 2 additonal tests. The first as you suggested with the same recursive function twice with 2 different names. The second one with 2 different functions with the same subfunction in the where clause. I also renamed the existing test.
Please inform me, if you see other possibilites to improve the tests for Trac #9441

Aug 3 2018, 4:23 AM
RolandSenn updated the summary of D5038: CSE should deal with letrec.
Aug 3 2018, 4:16 AM
RolandSenn updated the diff for D5038: CSE should deal with letrec.
Aug 3 2018, 4:14 AM

Aug 2 2018

RolandSenn created D5038: CSE should deal with letrec.
Aug 2 2018, 12:16 PM

Aug 1 2018

RolandSenn created D5030: Bad error message for flags with required but missing arguments (#12625).
Aug 1 2018, 8:50 AM

Jul 29 2018

RolandSenn added a comment to D5009: GHC doesn't handle ./ prefixed paths correctly (#12674).

Many thanks for your kind help. I have now fixed all your issues. Please inform me, if you see other necessary changes.

Jul 29 2018, 7:21 AM
RolandSenn updated the diff for D5009: GHC doesn't handle ./ prefixed paths correctly (#12674).
Jul 29 2018, 7:18 AM

Jul 28 2018

RolandSenn added a comment to D5009: GHC doesn't handle ./ prefixed paths correctly (#12674).

Thanks for the code review and your comments. Please look at my replies and feel free to take your decisions.
Roland

Jul 28 2018, 2:59 PM
RolandSenn updated the diff for D5009: GHC doesn't handle ./ prefixed paths correctly (#12674).
Jul 28 2018, 2:18 PM

Jul 26 2018

RolandSenn created D5009: GHC doesn't handle ./ prefixed paths correctly (#12674).
Jul 26 2018, 5:35 PM

Jul 21 2018

RolandSenn abandoned D4997: Fix for #12714: Test T9405 fails on Windows..

Uiuii! This is an intermittend problem! I tested under Windows: With backslash it worked, with forward slash it didin't, so I assumed the testcase was wrong. But obviously I didn't test enough!!
Thanks for your kind remarks and sorry for bothering you!

Jul 21 2018, 10:18 AM

Jul 20 2018

RolandSenn added a comment to D4997: Fix for #12714: Test T9405 fails on Windows..

Please inform me, if these 2 tests can be written with less redundandency. The only difference is in the Makefile: Run the program ./T9405 (Linux) vs .\T9405 (Windows).

Jul 20 2018, 11:07 AM
RolandSenn updated the diff for D4997: Fix for #12714: Test T9405 fails on Windows..

Reset filemodes back to 644

Jul 20 2018, 11:07 AM
RolandSenn created D4997: Fix for #12714: Test T9405 fails on Windows..
Jul 20 2018, 10:55 AM

Jul 6 2018

RolandSenn abandoned D4930: When -odir is specified, put the object file of a C-source file into the top level odir directory (#14025).

Oops, the failure of testcase cabal01is severe! To fix it, we would need to change Cabal: Cabal should be aware of the new location of the *.o file. However this gives a dependency between the versions of Cabal and GHC. The user of a GHC version with the patch for Trac Trac #14025 must also use a version of Cabal with a patch for Trac #14025 (and vice versa).
Considering, that Trac #14025 solves a very tiny problem, this is a too heavy burden on the user. Therefore I abandon this solution and I'll develop a new solution, just fixing the case with the absolute path.

Jul 6 2018, 9:52 AM

Jul 3 2018

RolandSenn updated the test plan for D4930: When -odir is specified, put the object file of a C-source file into the top level odir directory (#14025).
Jul 3 2018, 7:48 AM
RolandSenn updated the summary of D4930: When -odir is specified, put the object file of a C-source file into the top level odir directory (#14025).
Jul 3 2018, 7:45 AM
RolandSenn created D4930: When -odir is specified, put the object file of a C-source file into the top level odir directory (#14025).
Jul 3 2018, 7:35 AM

Jun 25 2018

RolandSenn updated the summary of D4861: Introduce flag -keep-hscpp-files (#10869).
Jun 25 2018, 12:32 PM

Jun 20 2018

RolandSenn added a comment to D4861: Introduce flag -keep-hscpp-files (#10869).

Hello Ben,
I'll do this. But this week I'm away from my desktop computer. So maybe
it will take till mid next week. 
Thanks and best wishes.   Roland

Jun 20 2018, 1:23 AM

Jun 17 2018

RolandSenn added a comment to D4861: Introduce flag -keep-hscpp-files (#10869).

@bgamari : You wrote:

Jun 17 2018, 2:58 PM
RolandSenn added a comment to D4861: Introduce flag -keep-hscpp-files (#10869).

I added the requested changes by bgamari and by the linter. Please feel free to request additional changes!

Jun 17 2018, 2:49 PM
RolandSenn updated the diff for D4861: Introduce flag -keep-hscpp-files (#10869).
Jun 17 2018, 2:49 PM
RolandSenn added a comment to D4861: Introduce flag -keep-hscpp-files (#10869).

This is my first contribution to GHC, where I wrote real Haskell code. Therefore this is just a draft version and it needs some additional improvments.

Jun 17 2018, 6:01 AM
RolandSenn created D4861: Introduce flag -keep-hscpp-files (#10869).
Jun 17 2018, 5:41 AM

Jun 4 2018

RolandSenn created D4785: #11477 Remove -Wamp flag.
Jun 4 2018, 10:53 AM