Phyx (Tamar Christina)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 5 2014, 3:01 PM (129 w, 3 d)
Availability
Available

Recent Activity

Today

Phyx updated the diff for D3383: Implement split-sections support for windows..
  • Finished split sections.
  • revert section labels.
  • Revert "Finished split sections."
  • Merge only sections with $
  • Fix linker scripts.
  • temporarily disable big-obj
  • Split: update for merge.
Sun, Apr 30, 11:28 AM
Phyx updated the summary of D3383: Implement split-sections support for windows..
Sun, Apr 30, 11:19 AM
Phyx created D3513: Better import library support for Windows.
Sun, Apr 30, 10:59 AM

Fri, Apr 28

Phyx added inline comments to D3509: get-win32-tarballs: Grab perl tarball from haskell.org, not GitHub.
Fri, Apr 28, 11:51 AM

Tue, Apr 25

Phyx added inline comments to D3383: Implement split-sections support for windows..
Tue, Apr 25, 11:36 AM

Sun, Apr 23

Phyx abandoned D3491: Fix the retry loop on Windows..
Sun, Apr 23, 5:32 PM
Phyx accepted D3492: testsuite/driver: Fix deletion retry logic on Windows.
Sun, Apr 23, 5:32 PM
Phyx created D3491: Fix the retry loop on Windows..
Sun, Apr 23, 4:00 PM
Phyx added a comment to D3398: Don't setProgramDynFlags on every :load.

why does the module content need quotes? Doesn't the semantics of echo make it print everything up to a control character?

Sun, Apr 23, 1:44 PM
Phyx created D3488: Add backup url and sync support for Win32 tarball script.
Sun, Apr 23, 10:21 AM
Phyx committed rGHCf446f6a3cff2: First update mingw-w64 packages for 8.4 (authored by Phyx).
First update mingw-w64 packages for 8.4
Sun, Apr 23, 5:36 AM
Phyx closed D3382: First update mingw-w64 packages for 8.4 by committing rGHCf446f6a3cff2: First update mingw-w64 packages for 8.4.
Sun, Apr 23, 5:36 AM
Phyx updated the diff for D3382: First update mingw-w64 packages for 8.4.
  • switch mirror
Sun, Apr 23, 5:24 AM
Phyx added a comment to D3382: First update mingw-w64 packages for 8.4.
In D3382#98588, @Phyx wrote:

@bgamari have you mirrored the packages? or should I just land it pointing to the msys2 repo?

I just did so.

Sun, Apr 23, 5:17 AM
Phyx committed rGHC8e93799418b8: skip T13525 when running on Windows. (authored by Phyx).
skip T13525 when running on Windows.
Sun, Apr 23, 4:59 AM

Tue, Apr 18

Phyx added a comment to D3464: Removed unused variable from dynwrapper.c (Part of #11777).

It's been rewritten because that patch re-enables dynamic linking. No it shouldn't be removed.

Tue, Apr 18, 1:14 AM

Mon, Apr 17

Phyx added a comment to D3464: Removed unused variable from dynwrapper.c (Part of #11777).

Note that dynwrapper.c is completely dead-code as dynamic linking has been disabled for Windows and only Windows uses this file.
Because dll-split also doesn't work, you'll never get far enough in stage2 to need this even if dynamic linking is forcibly turned on.

Mon, Apr 17, 2:46 PM
Phyx updated the diff for D3384: WIP: Implement string merging on Windows.
  • Add linkonce pragmas
  • revert tarbals downgrade.
  • Fix alignments
Mon, Apr 17, 7:27 AM

Wed, Apr 12

Phyx added inline comments to D3417: base: Track timer PSQ timeouts as Word64 instead of Double.
Wed, Apr 12, 9:50 AM
Phyx added a comment to D3449: configure: Introduce --with-gold flag.

By user here I assume you mean someone building GHC from source? but not end users? can they specify this easily? In the settings file I assume?

Wed, Apr 12, 9:47 AM
Phyx added a comment to D3382: First update mingw-w64 packages for 8.4.

@bgamari have you mirrored the packages? or should I just land it pointing to the msys2 repo?

Wed, Apr 12, 6:05 AM
alexbiehl awarded D3383: Implement split-sections support for windows. a Party Time token.
Wed, Apr 12, 1:55 AM
Phyx updated the diff for D3383: Implement split-sections support for windows..

Hopefully finally have a clean rebase.

Wed, Apr 12, 1:43 AM
Phyx updated the diff for D3382: First update mingw-w64 packages for 8.4.
  • rebase
Wed, Apr 12, 1:32 AM

Tue, Apr 11

Phyx updated the diff for D3383: Implement split-sections support for windows..
  • Finished split sections.
  • revert section labels.
  • Revert "Finished split sections."
  • Merge only sections with $
  • Fix linker scripts.
  • temporarily disable big-obj
Tue, Apr 11, 3:34 PM

Sat, Apr 1

Phyx planned changes to D3383: Implement split-sections support for windows..

Harbormaster seems to have some test failures. Will take a look.

Sat, Apr 1, 4:04 AM

Fri, Mar 31

Phyx updated the diff for D3383: Implement split-sections support for windows..
  • revert section labels.
Fri, Mar 31, 5:30 PM
Phyx retitled D3383: Implement split-sections support for windows. from WIP: Implement split-sections on windows. to Implement split-sections support for windows..
Fri, Mar 31, 5:24 PM
Phyx updated the diff for D3383: Implement split-sections support for windows..
  • Finished split sections.
Fri, Mar 31, 5:22 PM

Mar 29 2017

Phyx added a comment to D2592: WIP: Dynamic linking support for Windows (Part 1/2) [skip ci].

Almost there...

Mar 29 2017, 1:56 AM
Phyx updated the diff for D2592: WIP: Dynamic linking support for Windows (Part 1/2) [skip ci].
  • T5987: rebased.
  • T5987: fixing after rebase
  • T5987: Fixes after rebase.
  • T5987: reverted submodules.
  • DynLib: Fix ghc-cabal build errors and rts build error.
  • T5987: Reworking DLL building code.
  • T5987: Fix failure.
  • T5987: turn off lazy loading.
  • Dyn: remove assert code and other werr issues.
  • Disable CoreToStg asserts for DynWay for now.
  • Update submodules.
  • Shared: added gen-dll
  • Gen-Dll: Added better argument parsing
  • Calling Win32 args parser
  • GenDll: Fixed gen-dll I/O
  • Dll: Enable dynamic-too on Windows.
  • Fix some more rebase screwiness
  • Remove more dllsplit tstuff again
  • Fix execProc.
  • Disable CoreToStg warnings completely.
  • Fix -Werror
  • Correct ar script.
  • Dyn: disable import lib creation.
  • fix compile.
  • use lib instead.
  • Fix segfault.
  • Fix mri script.
  • Working using dll.a again
  • Dyn: Generate a DllMain by default unless -no-hs-main
Mar 29 2017, 1:37 AM
Phyx added inline comments to D3383: Implement split-sections support for windows..
Mar 29 2017, 1:35 AM

Mar 27 2017

Phyx added a comment to D3383: Implement split-sections support for windows..
In D3383#97145, @awson wrote:

But the scripts on trac are tailored to old section naming scheme. Those used for executables contain section merging logic for new scheme (since binutils supports it for quite a long time already), but .xr scripts don't contain it. This is what I've written about in previous comment. Thus you need to add it (things like *(SORT(.text$*)), *(SORT(.data$*)), *(SORT(.rdata$*))) to .xr files.

Mar 27 2017, 6:35 AM
Phyx added a comment to D3383: Implement split-sections support for windows..

Isn't that why we have $1_$2_LD_SCRIPT? to apply the custom linker scripts when making the GHCi objects?

Mar 27 2017, 5:42 AM
Phyx added a comment to D3383: Implement split-sections support for windows..

Guess the issue is with big-obj. I'll revert that from every call and instead add it only to the packages that need it for now while i modify GHCi.

Mar 27 2017, 4:51 AM

Mar 26 2017

Phyx updated the diff for D3384: WIP: Implement string merging on Windows.
  • Correct packages
Mar 26 2017, 5:35 PM
Phyx updated the diff for D3384: WIP: Implement string merging on Windows.

Correct base

Mar 26 2017, 5:29 PM
Phyx updated the diff for D3383: Implement split-sections support for windows..

correct base

Mar 26 2017, 5:25 PM
Phyx updated the diff for D3382: First update mingw-w64 packages for 8.4.

Correct patch

Mar 26 2017, 5:19 PM
Phyx added inline comments to D3318: GHC_STAGE1 isn't defined, use other form..
Mar 26 2017, 5:16 PM
Phyx updated the Trac tickets for D3384: WIP: Implement string merging on Windows.
Mar 26 2017, 3:28 PM
Phyx added a dependency for D3384: WIP: Implement string merging on Windows: D3383: Implement split-sections support for windows..
Mar 26 2017, 3:28 PM
Phyx added a dependent revision for D3383: Implement split-sections support for windows.: D3384: WIP: Implement string merging on Windows.
Mar 26 2017, 3:28 PM
Phyx created D3384: WIP: Implement string merging on Windows.
Mar 26 2017, 3:25 PM
Phyx updated the Trac tickets for D3382: First update mingw-w64 packages for 8.4.
Mar 26 2017, 3:02 PM
Phyx added a dependent revision for D3382: First update mingw-w64 packages for 8.4: D3383: Implement split-sections support for windows..
Mar 26 2017, 3:02 PM
Phyx added a dependency for D3383: Implement split-sections support for windows.: D3382: First update mingw-w64 packages for 8.4.
Mar 26 2017, 3:02 PM
Phyx updated the Trac tickets for D3383: Implement split-sections support for windows..
Mar 26 2017, 3:02 PM
Phyx added a comment to D3383: Implement split-sections support for windows..

This unfortunately increases the size of the GHCi libraries.
So much that memory can't be allocated to load them. Have to
figure that out first.

Mar 26 2017, 3:01 PM
Phyx created D3383: Implement split-sections support for windows..
Mar 26 2017, 3:01 PM
Phyx created D3382: First update mingw-w64 packages for 8.4.
Mar 26 2017, 2:41 PM
Phyx requested changes to D3278: Enable new warning for fragile/incorrect CPP #if usage.

Looking at these again, I suspect a lot of these aren't right. If you look at includes/stg/HaskellMachRegs.h it seems like these MACHREGS_ macros are always defined. just to either 0 or 1.
By switching these from #if to #if defined(..) they're now all trivially always true.

Mar 26 2017, 5:37 AM

Mar 20 2017

Phyx committed rGHC713ff9207e0f: Fix Windows x86 build (authored by Phyx).
Fix Windows x86 build
Mar 20 2017, 1:20 PM
Phyx closed D3362: Fix Windows x86 build by committing rGHC713ff9207e0f: Fix Windows x86 build.
Mar 20 2017, 1:20 PM
Phyx updated the summary of D3362: Fix Windows x86 build.
Mar 20 2017, 1:17 PM
Phyx updated the summary of D3362: Fix Windows x86 build.
Mar 20 2017, 1:14 PM

Mar 18 2017

Phyx updated the Trac tickets for D3362: Fix Windows x86 build.
Mar 18 2017, 10:24 AM
Phyx created D3362: Fix Windows x86 build.
Mar 18 2017, 10:23 AM

Mar 17 2017

Phyx added a comment to D3318: GHC_STAGE1 isn't defined, use other form..

This change potentially breaks tests such as the whitespace and tarball validation tests, as now STAGE1_GHC will always point to the inplace one instead of the ones extracted to the specific folders.

Mar 17 2017, 5:21 AM
Phyx added a comment to D3318: GHC_STAGE1 isn't defined, use other form..

Oops, forgot to press send.

Mar 17 2017, 5:20 AM

Mar 15 2017

Phyx added a comment to D3298: RFC: Always build GHCi libs.
In the second case, the `.o` is much faster to load than the `.a`, but we aren't building it by default.
Mar 15 2017, 4:12 AM

Mar 13 2017

Phyx added a comment to D3319: Fix Windows GCC driver.

I don't think I wrote this code, but my guess is that it has to do with proper handling of Ctrl-C. Can we still correctly interrupt compilation during the gcc phase without this?

Mar 13 2017, 3:25 PM
Phyx added a comment to D2592: WIP: Dynamic linking support for Windows (Part 1/2) [skip ci].
Mar 13 2017, 1:30 PM

Mar 12 2017

Phyx updated the diff for D3319: Fix Windows GCC driver.
  • Rebase
Mar 12 2017, 4:34 AM
Phyx retitled D3319: Fix Windows GCC driver from Fix dwCreationFlags in GCC driver to Fix Windows GCC driver.
Mar 12 2017, 4:16 AM

Mar 11 2017

Phyx updated the summary of D3319: Fix Windows GCC driver.
Mar 11 2017, 1:51 PM
Phyx updated the diff for D3319: Fix Windows GCC driver.
  • Actually fix it.
Mar 11 2017, 1:42 PM
Phyx updated the summary of D3319: Fix Windows GCC driver.
Mar 11 2017, 9:05 AM
Phyx planned changes to D3319: Fix Windows GCC driver.
Mar 11 2017, 8:49 AM
Phyx updated the Trac tickets for D3319: Fix Windows GCC driver.
Mar 11 2017, 4:52 AM
Phyx created D3319: Fix Windows GCC driver.
Mar 11 2017, 4:49 AM

Mar 9 2017

Phyx accepted D3304: configure.ac: Ensure that we handle case of non-present --target.

LGTM

Mar 9 2017, 1:44 PM
Phyx abandoned D3152: Bump process version in GHC [skip ci].
Mar 9 2017, 10:48 AM
Phyx added a comment to D3292: Update crt to latest..

Note to self. Should probably make these scripts smart enough to remove any existing older versions of libraries that it updated. So we prevent it from extracting multiple versions of the same tar to the same place.

Mar 9 2017, 10:48 AM

Mar 8 2017

Phyx committed rGHCa02b80fe5542: Bump haskeline submodule to fix Windows build. (authored by Phyx).
Bump haskeline submodule to fix Windows build.
Mar 8 2017, 5:34 PM
Phyx added a comment to D3298: RFC: Always build GHCi libs.

Fair enough, the behavior is a bit counter intuitive to me though. If I understand correctly this is saying that loading the .a is faster than loading the .so?
At least from the Windows point of view this seems odd since DLLs are fully relocated and have no dangling symbols.

Mar 8 2017, 1:31 PM
Phyx committed rGHCbd6681713a60: Win32: bump submodule to v2.5.2.0 (authored by Phyx).
Win32: bump submodule to v2.5.2.0
Mar 8 2017, 2:19 AM
Phyx closed D3293: Win32: bump submodule to v2.5.2.0 by committing rGHCbd6681713a60: Win32: bump submodule to v2.5.2.0.
Mar 8 2017, 2:19 AM

Mar 7 2017

Phyx added a comment to D3292: Update crt to latest..

It fixes Trac #13384

Mar 7 2017, 6:20 PM
Phyx created D3293: Win32: bump submodule to v2.5.2.0.
Mar 7 2017, 4:23 PM
Phyx added a comment to D3292: Update crt to latest..

Sort of, I've updated the script so mk/get-win32-tarballs.sh download mirror will get you most things. gcc-libs doesn't seem to have it's source available on the repo and mpc is split into different sources for x86 and x86_64. The script isn't setup to handle that.

Mar 7 2017, 4:05 PM
Phyx updated the diff for D3292: Update crt to latest..
  • update mirror script.
Mar 7 2017, 4:05 PM
Phyx added a comment to D3292: Update crt to latest..

@bgamari run

Mar 7 2017, 2:41 PM
Phyx updated the Trac tickets for D3292: Update crt to latest..
Mar 7 2017, 2:40 PM
Phyx created D3292: Update crt to latest..
Mar 7 2017, 2:39 PM

Mar 6 2017

Phyx added a comment to D3279: Add GCC bin folder to search path..

No, I don't believe so. The path containing libwinpthread-1.dll may contain other user installed dlls,
In the case of msys2 this is /mingw64/bin, so removing it would make you not pick up dependencies you should have.
The API used gives precedence to the paths specified over those in the PATH environment. So while it can get overridden
by e.g. spawning a call to ghc from your own program which uses the same APIs, at that point I have to assume that this is the behaviour
you desired.

Mar 6 2017, 7:00 AM
Phyx added a comment to D3279: Add GCC bin folder to search path..

No, we always want the one from the inplace gcc distro we provide.
Critically though this patch allows it to work when you don't have one in your environment.

Mar 6 2017, 2:37 AM

Mar 5 2017

Phyx updated the Trac tickets for D3279: Add GCC bin folder to search path..
Mar 5 2017, 5:47 AM
Phyx created D3279: Add GCC bin folder to search path..
Mar 5 2017, 5:46 AM
Phyx accepted D3278: Enable new warning for fragile/incorrect CPP #if usage.
Mar 5 2017, 5:35 AM

Feb 28 2017

Phyx committed rGHC990f182ad0cd: Fix windows build broken by D3080 (0d86aa5904e5a06c93632357122e57e4e118fd2a) (authored by Phyx).
Fix windows build broken by D3080 (0d86aa5904e5a06c93632357122e57e4e118fd2a)
Feb 28 2017, 12:22 AM
Phyx closed D3225: Get rid of unused import warning on Windows by committing rGHC990f182ad0cd: Fix windows build broken by D3080 (0d86aa5904e5a06c93632357122e57e4e118fd2a).
Feb 28 2017, 12:22 AM
Phyx raised a concern with rGHC0d86aa5904e5: Add support for concurrent package db access and updates.

This killed the windows build again. Harbormaster said so before the push: https://phabricator.haskell.org/harbormaster/build/21516/

Feb 28 2017, 12:15 AM

Feb 26 2017

Phyx added inline comments to D3082: Extend Windows runtime loader libsearch.
Feb 26 2017, 11:29 AM

Feb 23 2017

Phyx added a comment to D3152: Bump process version in GHC [skip ci].

It would be great if we could also lift the restriction on the boot packages somehow. Maybe by using cabal to first register the new packages in the stage0 compiler in as sandbox or something?

Feb 23 2017, 11:00 AM
Phyx added a comment to D3152: Bump process version in GHC [skip ci].

Yeah, having up upgrade the dependencies first is quite a pain..

Feb 23 2017, 2:13 AM

Feb 22 2017

Phyx added a comment to D3152: Bump process version in GHC [skip ci].

ugh, that's quite unfortunate...

Feb 22 2017, 9:39 PM

Feb 21 2017

Phyx abandoned D3153: Bump win32 version in GHC.

Looks like it.

Feb 21 2017, 9:40 AM

Feb 20 2017

Phyx added a comment to D3158: Correct Windows libdir assumptions..

Ah, that looks better...

Feb 20 2017, 3:17 PM
Phyx updated the diff for D3158: Correct Windows libdir assumptions..
  • fix linux build
Feb 20 2017, 3:14 PM