Phyx (Tamar Christina)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

Badges

User Since
Nov 5 2014, 3:01 PM (119 w, 6 d)
Availability
Available

Recent Activity

Yesterday

Phyx abandoned D3153: Bump win32 version in GHC.

Looks like it.

Tue, Feb 21, 9:40 AM

Mon, Feb 20

Phyx added a comment to D3158: Correct Windows libdir assumptions..

Ah, that looks better...

Mon, Feb 20, 3:17 PM
Phyx updated the diff for D3158: Correct Windows libdir assumptions..
  • fix linux build
Mon, Feb 20, 3:14 PM
Phyx added a comment to D3158: Correct Windows libdir assumptions..

It is possible, arc was being particularly difficult that day. But according to my tree

Mon, Feb 20, 3:03 PM

Sun, Feb 19

Phyx added a comment to D3160: Fix all broken perf tests on x64 Windows.

As can be seen https://phabricator.haskell.org/harbormaster/build/21193/

Sun, Feb 19, 10:51 AM
Phyx created D3160: Fix all broken perf tests on x64 Windows.
Sun, Feb 19, 10:37 AM
Phyx updated the diff for D3158: Correct Windows libdir assumptions..
  • fix linux build
Sun, Feb 19, 8:38 AM
Phyx added a comment to D3158: Correct Windows libdir assumptions..

https://phabricator.haskell.org/B14010 testsuite build

Sun, Feb 19, 7:25 AM
Phyx updated the Trac tickets for D3158: Correct Windows libdir assumptions..
Sun, Feb 19, 7:13 AM
Phyx created D3158: Correct Windows libdir assumptions..
Sun, Feb 19, 7:11 AM

Sat, Feb 18

Phyx updated the Trac tickets for D3155: Load `pthreads` by default on Windows.
Sat, Feb 18, 7:16 AM
Phyx added a dependency for D3155: Load `pthreads` by default on Windows: D3154: Make list of deprecated symbols on Windows weak..
Sat, Feb 18, 7:15 AM
Phyx added a dependent revision for D3154: Make list of deprecated symbols on Windows weak.: D3155: Load `pthreads` by default on Windows.
Sat, Feb 18, 7:15 AM
Phyx added a dependency for D3154: Make list of deprecated symbols on Windows weak.: D3028: Load dependent dlls..
Sat, Feb 18, 7:15 AM
Phyx added a dependent revision for D3028: Load dependent dlls.: D3154: Make list of deprecated symbols on Windows weak..
Sat, Feb 18, 7:15 AM
Phyx created D3155: Load `pthreads` by default on Windows.
Sat, Feb 18, 7:14 AM
Phyx updated the Trac tickets for D3154: Make list of deprecated symbols on Windows weak..
Sat, Feb 18, 7:07 AM
Phyx created D3154: Make list of deprecated symbols on Windows weak..
Sat, Feb 18, 7:06 AM
Phyx added inline comments to D3136: Add -fwhole-archive-hs-libs.
Sat, Feb 18, 3:38 AM
Phyx created D3153: Bump win32 version in GHC.
Sat, Feb 18, 3:25 AM
Phyx retitled D3152: Bump process version in GHC [skip ci] from Bump process version to Bump process version in GHC [skip ci].
Sat, Feb 18, 3:17 AM
Phyx created D3152: Bump process version in GHC [skip ci].
Sat, Feb 18, 3:16 AM
Phyx updated the Trac tickets for D3030: Fix nofib benchmarks on Windows..
Sat, Feb 18, 2:13 AM

Thu, Feb 16

Phyx added a comment to D3141: testsuite: Move echoing commands in make invocations to VERBOSE=5.

Passing --trace already makes a test fail, passing any flag to make that's used recursively can make the tests fail. I also don't see how getting the performance output in the output unconditionally is not making the test fail.

Thu, Feb 16, 2:26 AM

Wed, Feb 15

Phyx planned changes to D2592: WIP: Dynamic linking support for Windows (Part 1/2) [skip ci].

Just updating with current state. after rebasing I now get some random segfaults which need to be figured out. dlltool is also way too slow so a custom import lib writer needs to be written and will leverage that to write a custom loader to solve the remaining issue of how to correctly handle const data issue introduced by GHC's dynamic linking not having been designed to work cross platform.

Wed, Feb 15, 10:01 PM
Phyx updated the diff for D2592: WIP: Dynamic linking support for Windows (Part 1/2) [skip ci].
  • T5987: rebased.
  • T5987: fixing after rebase
  • T5987: Fixes after rebase.
  • T5987: reverted submodules.
  • DynLib: Fix ghc-cabal build errors and rts build error.
  • T5987: Reworking DLL building code.
  • T5987: Fix failure.
  • T5987: turn off lazy loading.
  • Dyn: remove assert code and other werr issues.
  • Disable CoreToStg asserts for DynWay for now.
  • Update submodules.
  • Shared: added gen-dll
  • Gen-Dll: Added better argument parsing
  • Calling Win32 args parser
  • GenDll: Fixed gen-dll I/O
  • Dll: Enable dynamic-too on Windows.
  • Fix some more rebase screwiness
  • Remove more dllsplit tstuff again
  • Fix execProc.
  • Disable CoreToStg warnings completely.
  • Fix -Werror
  • Correct ar script.
  • Dyn: disable import lib creation.
  • fix compile.
Wed, Feb 15, 9:54 PM
Phyx updated the diff for D3028: Load dependent dlls..
  • Inlined dependency resolving into addDllHandler
  • Rebased on master
Wed, Feb 15, 9:38 PM
Phyx accepted D3141: testsuite: Move echoing commands in make invocations to VERBOSE=5.

Lgtm

Wed, Feb 15, 7:24 PM
Phyx added a comment to D3028: Load dependent dlls..

arc seems to currently be broken, so I can't update the patch. Unless someone knows a way to do it without arc?

Wed, Feb 15, 12:38 PM

Tue, Feb 14

Phyx added inline comments to D3028: Load dependent dlls..
Tue, Feb 14, 9:34 AM
Phyx added inline comments to D3026: Fix ExtraSymbols jump table on Windows..
Tue, Feb 14, 9:20 AM

Sun, Feb 12

Phyx accepted D3129: Typecast covers entire expression to fix format warning..

Thanks @bollu !

Sun, Feb 12, 5:47 AM
Phyx requested changes to D3129: Typecast covers entire expression to fix format warning..

Thanks @bollu! Just some minor comments.

Sun, Feb 12, 4:52 AM

Tue, Feb 7

Phyx added inline comments to D3090: Add support for concurrent package db access and updates.
Tue, Feb 7, 4:51 AM

Mon, Feb 6

Phyx retitled D2592: WIP: Dynamic linking support for Windows (Part 1/2) [skip ci] from WIP: Dynamic linking support for Windows (Part 1/2) [ci skip] to WIP: Dynamic linking support for Windows (Part 1/2) [skip ci].
Mon, Feb 6, 11:41 AM

Sun, Feb 5

Phyx updated the test plan for D3028: Load dependent dlls..
Sun, Feb 5, 1:12 PM
Phyx updated the diff for D3028: Load dependent dlls..
  • make search recursive.
Sun, Feb 5, 12:58 PM
Phyx added a comment to D3028: Load dependent dlls..
In D3028#90491, @Phyx wrote:

The searching for dependencies isn't recursive, which was by design.

This surprises me. I'm already not really supposed to care about symbols defined in a dependency of the library I depend on, how could I care about the difference between a direct dependency and an indirect dependency?

Sun, Feb 5, 12:19 PM
Phyx updated the diff for D3028: Load dependent dlls..
  • use handle instead of filename in duplicate check
Sun, Feb 5, 11:55 AM
Phyx added inline comments to D3028: Load dependent dlls..
Sun, Feb 5, 11:41 AM
Phyx updated the diff for D3028: Load dependent dlls..
  • Dropping normalization.
Sun, Feb 5, 11:39 AM
Phyx added a comment to D3028: Load dependent dlls..

So without the normalization we get a slightly different result because now the system dll's names won't match.

Sun, Feb 5, 11:37 AM
Phyx updated the test plan for D3028: Load dependent dlls..
Sun, Feb 5, 11:33 AM
Phyx added a comment to D3028: Load dependent dlls..

Actually, if there's no particular harm to calling LoadLibraryExW on a library that was already loaded as a dependency as another library, then I think we can give the libraries added in loadModuleDependencies artificial o->name fields that won't match anything passed to addDLL_PEi386, and maintain the current semantics of o->name. Right?

Sun, Feb 5, 11:19 AM
Phyx retitled D2592: WIP: Dynamic linking support for Windows (Part 1/2) [skip ci] from Dynamic linking support for Windows (Part 1/4) to WIP: Dynamic linking support for Windows (Part 1/2) [ci skip].
Sun, Feb 5, 5:09 AM
Phyx retitled D3026: Fix ExtraSymbols jump table on Windows. from Extend libsearch and fixed jump table. to Fix ExtraSymbols jump table on Windows..
Sun, Feb 5, 5:04 AM
Phyx updated D3026: Fix ExtraSymbols jump table on Windows..
Sun, Feb 5, 5:02 AM
Phyx updated the diff for D3026: Fix ExtraSymbols jump table on Windows..
  • Second part of plit
Sun, Feb 5, 5:02 AM
Phyx added a comment to D3026: Fix ExtraSymbols jump table on Windows..

Split into this and D3082

Sun, Feb 5, 4:57 AM
Phyx retitled D3082: Extend Windows runtime loader libsearch from to Extend Windows runtime loaader libsearch..
Sun, Feb 5, 4:57 AM
Phyx added a comment to D3026: Fix ExtraSymbols jump table on Windows..

@simonmar Sorry, didn't see that you commented here. I'll split up the patch.

Sun, Feb 5, 4:50 AM
Phyx updated the diff for D3029: Expand list of always loaded Windows shared libs.
  • Remove old code that isn't needed.
Sun, Feb 5, 4:38 AM
Phyx retitled D3029: Expand list of always loaded Windows shared libs from Follow GCC initialization specs somewhat. to Expand list of always loaded Windows shared libs.
Sun, Feb 5, 4:36 AM
Phyx updated the diff for D3028: Load dependent dlls..
  • remove unneeded ifdef.
Sun, Feb 5, 4:34 AM
Phyx updated D3028: Load dependent dlls..
Sun, Feb 5, 4:28 AM
Phyx added a comment to D3028: Load dependent dlls..

After the update the behavior is now more consistent with the linux one

Sun, Feb 5, 4:25 AM
Phyx updated the diff for D3028: Load dependent dlls..
  • slight refactoring to be able to call dependencies resolving manually.'
Sun, Feb 5, 4:22 AM

Wed, Feb 1

Phyx added a comment to D3055: WIP Add HeapView functionality.

@erikd I personally think so, the use case I had in mind would have me call the methods from a C stub linked into the executable. It would be non-ideal to have to go through the haskell interface to do this. Ofcourse it's C, so I don't really need the header, so I'll leave it up to you :)

Wed, Feb 1, 8:26 PM
Phyx added a comment to D3055: WIP Add HeapView functionality.

This looks fine to me, Just have one question,

Wed, Feb 1, 7:34 AM
Phyx committed rGHCf66030656f47: Update output of failing 11223 tests (authored by Phyx).
Update output of failing 11223 tests
Wed, Feb 1, 3:04 AM
Phyx closed D3053: Update output of failing 11223 tests by committing rGHCf66030656f47: Update output of failing 11223 tests.
Wed, Feb 1, 3:04 AM
Phyx updated subscribers of D3054: Remove very broad ignore. [ci skip].

@simonpj I believe you currently use this to ignore test data? Maybe instead add it to .git/info/exclude?
This would be local and would have to be added in each clone but it won't give surprising behaviour to those not expecting it.

Wed, Feb 1, 12:56 AM
Phyx retitled D3054: Remove very broad ignore. [ci skip] from Remove very broad ignore. to Remove very broad ignore. [ci skip].
Wed, Feb 1, 12:52 AM
Phyx retitled D3054: Remove very broad ignore. [ci skip] from to Remove very broad ignore..
Wed, Feb 1, 12:52 AM
Phyx retitled D3053: Update output of failing 11223 tests from to Update output of failing 11223 tests.
Wed, Feb 1, 12:46 AM

Tue, Jan 31

Phyx added a comment to rGHCf41c27d3ffdd: Slighly clean up symbol loading error..

Sorry, this patch comes from a much larger patch which I split up and forgot to accept the new test output.

Tue, Jan 31, 1:14 PM

Sat, Jan 28

Phyx updated the diff for D3030: Fix nofib benchmarks on Windows..
  • Added mingw fft output
Sat, Jan 28, 11:52 PM
Phyx retitled D3028: Load dependent dlls. from Load dependent dlls [RFC]. to Load dependent dlls..
Sat, Jan 28, 10:46 AM
Phyx retitled D3029: Expand list of always loaded Windows shared libs from Follow GCC initialization specs somewhat [RFC]. to Follow GCC initialization specs somewhat..
Sat, Jan 28, 10:46 AM
Phyx updated the diff for D3029: Expand list of always loaded Windows shared libs.
  • Add missing function.
  • Add notes
Sat, Jan 28, 8:04 AM

Fri, Jan 27

Phyx committed rGHC1f366b8d15fe: Add delete retry loop. [ci skip] (authored by Phyx).
Add delete retry loop. [ci skip]
Fri, Jan 27, 10:23 PM
Phyx closed D2936: Add delete retry loop. [ci skip] by committing rGHC1f366b8d15fe: Add delete retry loop. [ci skip].
Fri, Jan 27, 10:23 PM
Phyx added a comment to D3028: Load dependent dlls..

Oh... git blame... the irony.. I'm the one who added the ifdef to begin with..

Fri, Jan 27, 3:24 PM
Phyx added a comment to D3028: Load dependent dlls..

oh, I didn't know about that ifdef in ghcilink003, that has been fixed a while ago in 8.0.1 with support for import libraries. just -lstdc++ is needed now. This will find libstdc++.dll.a which then resolves to libstdc++-6.dll on use. What this patch does is also bring into scope libgcc. Say if that test used a symbol from libgcc without adding -lgcc_eh_... it would have worked compiled before but GHCi wouldn't have worked. Now it would work both with GHC and GHCi.

Fri, Jan 27, 3:12 PM
Phyx planned changes to D3029: Expand list of always loaded Windows shared libs.

Oops, when I split the patch up into little chunks i must have missed something here. I'll fix the build.

Fri, Jan 27, 2:51 PM
Phyx added a comment to D3025: Fixes bug #11046.
In D3025#88862, @yav wrote:

I don't really know what is the status of the 8.2 release, so I am not sure if this will make it into it. Is there a separate branch for the 8.2 release? This just fixes the bug against HEAD. @bgamari what would you like me to update?

Fri, Jan 27, 1:48 PM
Phyx added a comment to D2807: Fix broken tests.
In D2807#88748, @dfeuer wrote:

Grosser and grosser. I suppose you can do that. I was hoping to figure out exactly where/how the timeout script was being called to see if we could just skip the shell altogether, but it turns out even that is not simple.

Fri, Jan 27, 8:01 AM

Thu, Jan 26

Phyx added a comment to D3030: Fix nofib benchmarks on Windows..

Yes, the else is everything else. e.g. linux :)

Thu, Jan 26, 6:08 PM
Phyx added a comment to D3030: Fix nofib benchmarks on Windows..

It requires msys, just because the shell detection is done using msys and because of the unix tools used. tr, sed, diff and perl. and of course make.

Thu, Jan 26, 5:53 PM
Phyx added a comment to D3028: Load dependent dlls..

-lstdc++ won't break in the future, but yeah I'm describing the opposite.

Thu, Jan 26, 5:49 PM
Phyx added a reviewer for D3030: Fix nofib benchmarks on Windows.: bgamari.
Thu, Jan 26, 5:45 PM
Phyx retitled D3030: Fix nofib benchmarks on Windows. from to Fix nofib benchmarks on Windows..
Thu, Jan 26, 5:44 PM
Phyx retitled D3029: Expand list of always loaded Windows shared libs from to Follow GCC initialization specs somewhat [RFC]..
Thu, Jan 26, 5:02 PM
Phyx updated the Trac tickets for D3028: Load dependent dlls..
Thu, Jan 26, 5:01 PM
Phyx retitled D3028: Load dependent dlls. from to Load dependent dlls [RFC]..
Thu, Jan 26, 4:51 PM
Phyx retitled D3027: Slighly clean up symbol loading error. from to Slighly clean up symbol loading error..
Thu, Jan 26, 4:39 PM
Phyx retitled D3026: Fix ExtraSymbols jump table on Windows. from to Extend libsearch and fixed jump table..
Thu, Jan 26, 4:32 PM
Phyx added a comment to D2936: Add delete retry loop. [ci skip].

https://phabricator.haskell.org/B13489
https://phabricator.haskell.org/B13490
https://phabricator.haskell.org/B13491
https://phabricator.haskell.org/B13514
https://phabricator.haskell.org/B13515

Thu, Jan 26, 4:16 PM
Phyx updated D2936: Add delete retry loop. [ci skip].
Thu, Jan 26, 4:14 PM
Phyx retitled D2936: Add delete retry loop. [ci skip] from Attempt fix for file removal errors from testsuite. [ci skip] to Add delete retry loop. [ci skip].
Thu, Jan 26, 4:13 PM
Phyx updated the diff for D2936: Add delete retry loop. [ci skip].
  • Add retry loop.
  • Fix retry loop.
Thu, Jan 26, 4:06 PM

Wed, Jan 25

Phyx updated subscribers of rGHC2aaafc8b9788: Bump Win32 version..

@bgamari can you update the submodule to 716c9a3e97611aea3a0a907ba80fe9c11e1afc7f for me? That would fix the build.

Wed, Jan 25, 6:56 AM
Phyx added a comment to rGHC2aaafc8b9788: Bump Win32 version..

I've updated the CI to build with -Werror to prevent this in the future. Still need to setup a reverse proxy before external users can see the error though.

Wed, Jan 25, 6:35 AM
Phyx added a comment to rGHC2aaafc8b9788: Bump Win32 version..

Hmm, It seems that this is generating a warning that my CI for Win32 didn't catch.
Should add the same build flags as validate to prevent this...

Wed, Jan 25, 6:10 AM
Phyx retitled D2936: Add delete retry loop. [ci skip] from Attempt fix for file removal errors from testsuite. [skip-ci] to Attempt fix for file removal errors from testsuite. [ci skip].
Wed, Jan 25, 6:02 AM

Tue, Jan 24

Phyx added a comment to D2938: Bump Win32 version..

Ah ok thanks, I had forgotten I moved try. So much changed in this release...

Tue, Jan 24, 2:12 PM

Jan 22 2017

Phyx added a comment to D2938: Bump Win32 version..

@bgamari process hasn't been mirrored since Dec 13. I'm stuck until it's updated. http://git.haskell.org/packages/process.git and https://github.com/haskell/process/commits/master

Jan 22 2017, 1:25 PM
Phyx planned changes to D2936: Add delete retry loop. [ci skip].

https://phabricator.haskell.org/B13344

Jan 22 2017, 8:44 AM
Phyx updated the diff for D2936: Add delete retry loop. [ci skip].
  • Just use a retry loop.
Jan 22 2017, 8:40 AM
Phyx planned changes to D2936: Add delete retry loop. [ci skip].

https://phabricator.haskell.org/B13342

Jan 22 2017, 6:50 AM