Phyx (Tamar Christina)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 5 2014, 3:01 PM (137 w, 2 d)
Availability
Available

Recent Activity

Wed, Jun 21

Phyx added a comment to D3523: Big-obj support for the Windows runtime linker.

Except for the error message wobble which I can fix on metge, looks good to me.

Wed, Jun 21, 2:36 PM

Sat, Jun 17

Phyx added inline comments to D3523: Big-obj support for the Windows runtime linker.
Sat, Jun 17, 12:36 PM

Fri, Jun 16

Phyx committed rGHCd6cecde585b0: Remove the Windows GCC driver. (authored by Phyx).
Remove the Windows GCC driver.
Fri, Jun 16, 7:22 PM
Phyx closed D3592: Remove the Windows GCC driver. by committing rGHCd6cecde585b0: Remove the Windows GCC driver..
Fri, Jun 16, 7:22 PM
Phyx updated the diff for D3592: Remove the Windows GCC driver..
  • Apply haddock fix.
Fri, Jun 16, 7:20 PM
Phyx committed rGHCfda094d000cf: Provide way to build using existing C compiler on Windows. (authored by Phyx).
Provide way to build using existing C compiler on Windows.
Fri, Jun 16, 6:49 PM
Phyx closed D3637: Provide way to build using existing C compiler on Windows. by committing rGHCfda094d000cf: Provide way to build using existing C compiler on Windows..
Fri, Jun 16, 6:49 PM

Sun, Jun 11

Phyx updated the diff for D3383: Implement split-sections support for windows..
  • Split: fix llvm codegen.
Sun, Jun 11, 7:38 AM
Phyx updated the diff for D3383: Implement split-sections support for windows..
  • rebase
  • split: disable x86 for now and updated llvm codegen.
Sun, Jun 11, 6:53 AM
Phyx requested review of D3523: Big-obj support for the Windows runtime linker.

@bgamari I've amended the summary and created a standalone feature request.

Sun, Jun 11, 6:01 AM
Phyx updated the summary of D3523: Big-obj support for the Windows runtime linker.
Sun, Jun 11, 5:57 AM
Phyx updated the summary of D3523: Big-obj support for the Windows runtime linker.
Sun, Jun 11, 5:55 AM
Herald added a reviewer for D3637: Provide way to build using existing C compiler on Windows.: austin.
Sun, Jun 11, 5:48 AM

Thu, Jun 8

Phyx committed rGHCbca56bd040de: Fix slash escaping in cwrapper.c (authored by Phyx).
Fix slash escaping in cwrapper.c
Thu, Jun 8, 1:16 AM
Phyx closed D3628: Fix slash escaping in cwrapper.c by committing rGHCbca56bd040de: Fix slash escaping in cwrapper.c.
Thu, Jun 8, 1:16 AM

Wed, Jun 7

Phyx updated the diff for D3592: Remove the Windows GCC driver..
  • rebase
  • add more comments.
Wed, Jun 7, 5:07 PM
Phyx added inline comments to D3592: Remove the Windows GCC driver..
Wed, Jun 7, 5:26 AM

Tue, Jun 6

Phyx retitled D3628: Fix slash escaping in cwrapper.c from Fix slash escaping. to Fix slash escaping in cwrapper.c.
Tue, Jun 6, 1:35 PM
Phyx created D3628: Fix slash escaping in cwrapper.c.
Tue, Jun 6, 10:19 AM
Phyx added inline comments to D3592: Remove the Windows GCC driver..
Tue, Jun 6, 3:09 AM

Mon, Jun 5

Phyx updated the diff for D3592: Remove the Windows GCC driver..
  • Escape topdir
Mon, Jun 5, 9:57 PM

Thu, May 25

Phyx added a comment to D3567: Rewrite boot in Python.

Ahhh, I see what is going on here. The issue appears to be that the mingw python doesn't find the autoreconf executable, while the msys python does. Hmmm...

I'm guessing this has to do with the fact that nsys python and auroreconf` are in the same folder and so on the search path. The process open likely spawns this new process without /usr/bin on the PATH. One solution would be to call it through bash as we do in the testsuite.

Thu, May 25, 8:44 PM

May 16 2017

Phyx added a comment to D3383: Implement split-sections support for windows..
In D3383#101408, @awson wrote:

Not quite so, updated binutils allow us to build 64-bit GHC (which is currently impossible because of template-haskell package being miscompiled).

32-bit build requires bigobj support for 32-bit COFF objects, which binutils has no.

May 16 2017, 5:27 PM
Phyx added inline comments to D3513: Better import library support for Windows.
May 16 2017, 5:19 PM
Phyx updated the diff for D3513: Better import library support for Windows.
  • import: under braces changes.
  • import: process feedback.
May 16 2017, 5:16 PM
Herald added a reviewer for D3592: Remove the Windows GCC driver.: austin.
May 16 2017, 4:34 PM

May 10 2017

Phyx planned changes to D3383: Implement split-sections support for windows..
May 10 2017, 4:47 PM
Phyx added a comment to D3383: Implement split-sections support for windows..

@bgamari yes, I need to make some minor adjustment to the patch (will do so this weekend) and also we need an updated binutils for the 32-bit build.
I'll see if I can't get them to back port the patch to msys2 quicker.

May 10 2017, 4:46 PM
Phyx updated the summary of D3513: Better import library support for Windows.
May 10 2017, 8:37 AM
Phyx updated the summary of D3513: Better import library support for Windows.
May 10 2017, 2:11 AM

May 8 2017

Phyx added a comment to D3383: Implement split-sections support for windows..
In D3383#100831, @awson wrote:

I've looked at the big-obj+prof problem and found that assembler is called with correct options but an extra phase is triggered, where ld -r is called to merge some auxiliary object files into the target object file.

And GNU ld is unable to generate extended COFF at all (I experimented with it a little bit, adding OUTPUT(pe-bigobj-x86-64) to the linker script used by ld when processing the files to merge, but ld completely ignores it).

May 8 2017, 1:48 PM
Phyx added a comment to D3383: Implement split-sections support for windows..
In D3383#100839, @awson wrote:

Well, I've solved the problem, but this requires a patch to ld to enable pe-bigobj-x86-64 output for ln -r. I'll make a binutils ticket with the patch.

May 8 2017, 1:47 PM

May 7 2017

Phyx added a comment to D3383: Implement split-sections support for windows..

Thanks @awson!, I'll update the diff and take a look at the 32-bit build.

May 7 2017, 5:00 AM
Phyx added a comment to D3383: Implement split-sections support for windows..
In D3383#100409, @awson wrote:

I don't quite understand the purpose of the last -Wa,-mbig-obj addition.

The general idea is that neither any exe/dll nor any prelinked object file (for GHCi consumption) should ever contain a large number of sections. These files are all generated by ld which should merge all relevant sections from all incoming files according to the linker script it is fed with. ld automatically recognizes if the COFF object is bigobj or not and need no any command line hints for this.

The only type of artifacts which could ever contain a large number of sections is an object file generated by gnu as, which should be supplied with -mbig-obj if a user want it to handle a lot of sections, and as I've already mentioned elsewhere in the current GHC we need this flag only once, when building template-haskell package with split-sections enabled.

May 7 2017, 4:56 AM

May 5 2017

Phyx added a comment to D3523: Big-obj support for the Windows runtime linker.

@bgamari Initially I thought it was needed for split-sections but as @awson correctly pointed out, it's not.

May 5 2017, 12:49 PM

May 2 2017

Phyx added a comment to D3383: Implement split-sections support for windows..

That should be all, I appreciate it if you have some time for a review @awson !

May 2 2017, 4:29 PM
Phyx updated the diff for D3383: Implement split-sections support for windows..
  • split: add big-obj for ghci files.
May 2 2017, 4:28 PM
Phyx updated the summary of D3523: Big-obj support for the Windows runtime linker.
May 2 2017, 7:49 AM
Phyx reclaimed D3523: Big-obj support for the Windows runtime linker.
In D3523#100283, @awson wrote:

But I think this use-case can happen pretty rarely, since when we create a library with GHC, we can *also* create a prelinked object file for GHCi, which should *not* have this problem.

Thus we should (perhaps) only handle a possibility of such a library (containing bigobj modules) going from another vendor.

May 2 2017, 7:49 AM
Phyx planned changes to D3384: WIP: Implement string merging on Windows.
May 2 2017, 4:03 AM
Phyx abandoned D3523: Big-obj support for the Windows runtime linker.
In D3523#100286, @awson wrote:

Btw, I use GHC built with --split-sections and all my packages are built with --split-sections, and I use mbig-obj on a couple of packages (at least haskell-src-exts and GHC's template-haskell require this).

And all this works for me for 1.5 years and I never needed big-obj support in the runtime linker.

May 2 2017, 2:45 AM
Phyx added a comment to D3523: Big-obj support for the Windows runtime linker.

Unless you're saying linker scripts can also be used to change object formats.

Prelinked object files for GHCi are produced by ld linker, not an assembler.

May 2 2017, 2:43 AM
Phyx added a comment to D3523: Big-obj support for the Windows runtime linker.
In D3523#100280, @awson wrote:

With the correct linker used, prelinked GHCi object files *should* have all "sub"-sections merged into their "parent" sections, and we don't need anything from this.

OTOH, IIRC, we still support handling of archives of "normal" object files, and this is the only use-case when we need bigobj handling in the runtime linker.

May 2 2017, 2:25 AM
Herald added a reviewer for D3523: Big-obj support for the Windows runtime linker: austin.
May 2 2017, 1:45 AM

Apr 30 2017

Phyx updated the diff for D3383: Implement split-sections support for windows..
  • Finished split sections.
  • revert section labels.
  • Revert "Finished split sections."
  • Merge only sections with $
  • Fix linker scripts.
  • temporarily disable big-obj
  • Split: update for merge.
Apr 30 2017, 11:28 AM
Phyx updated the summary of D3383: Implement split-sections support for windows..
Apr 30 2017, 11:19 AM
Phyx created D3513: Better import library support for Windows.
Apr 30 2017, 10:59 AM

Apr 28 2017

Phyx added inline comments to D3509: get-win32-tarballs: Grab perl tarball from haskell.org, not GitHub.
Apr 28 2017, 11:51 AM

Apr 25 2017

Phyx added inline comments to D3383: Implement split-sections support for windows..
Apr 25 2017, 11:36 AM

Apr 23 2017

Phyx abandoned D3491: Fix the retry loop on Windows..
Apr 23 2017, 5:32 PM
Phyx accepted D3492: testsuite/driver: Fix deletion retry logic on Windows.
Apr 23 2017, 5:32 PM
Phyx created D3491: Fix the retry loop on Windows..
Apr 23 2017, 4:00 PM
Phyx added a comment to D3398: Don't setProgramDynFlags on every :load.

why does the module content need quotes? Doesn't the semantics of echo make it print everything up to a control character?

Apr 23 2017, 1:44 PM
Phyx created D3488: Add backup url and sync support for Win32 tarball script.
Apr 23 2017, 10:21 AM
Phyx committed rGHCf446f6a3cff2: First update mingw-w64 packages for 8.4 (authored by Phyx).
First update mingw-w64 packages for 8.4
Apr 23 2017, 5:36 AM
Phyx closed D3382: First update mingw-w64 packages for 8.4 by committing rGHCf446f6a3cff2: First update mingw-w64 packages for 8.4.
Apr 23 2017, 5:36 AM
Phyx updated the diff for D3382: First update mingw-w64 packages for 8.4.
  • switch mirror
Apr 23 2017, 5:24 AM
Phyx added a comment to D3382: First update mingw-w64 packages for 8.4.
In D3382#98588, @Phyx wrote:

@bgamari have you mirrored the packages? or should I just land it pointing to the msys2 repo?

I just did so.

Apr 23 2017, 5:17 AM
Phyx committed rGHC8e93799418b8: skip T13525 when running on Windows. (authored by Phyx).
skip T13525 when running on Windows.
Apr 23 2017, 4:59 AM

Apr 18 2017

Phyx added a comment to D3464: Removed unused variable from dynwrapper.c (Part of #11777).

It's been rewritten because that patch re-enables dynamic linking. No it shouldn't be removed.

Apr 18 2017, 1:14 AM

Apr 17 2017

Phyx added a comment to D3464: Removed unused variable from dynwrapper.c (Part of #11777).

Note that dynwrapper.c is completely dead-code as dynamic linking has been disabled for Windows and only Windows uses this file.
Because dll-split also doesn't work, you'll never get far enough in stage2 to need this even if dynamic linking is forcibly turned on.

Apr 17 2017, 2:46 PM
Phyx updated the diff for D3384: WIP: Implement string merging on Windows.
  • Add linkonce pragmas
  • revert tarbals downgrade.
  • Fix alignments
Apr 17 2017, 7:27 AM

Apr 12 2017

Phyx added inline comments to D3417: base: Track timer PSQ timeouts as Word64 instead of Double.
Apr 12 2017, 9:50 AM
Phyx added a comment to D3449: configure: Introduce --with-gold flag.

By user here I assume you mean someone building GHC from source? but not end users? can they specify this easily? In the settings file I assume?

Apr 12 2017, 9:47 AM
Phyx added a comment to D3382: First update mingw-w64 packages for 8.4.

@bgamari have you mirrored the packages? or should I just land it pointing to the msys2 repo?

Apr 12 2017, 6:05 AM
alexbiehl awarded D3383: Implement split-sections support for windows. a Party Time token.
Apr 12 2017, 1:55 AM
Phyx updated the diff for D3383: Implement split-sections support for windows..

Hopefully finally have a clean rebase.

Apr 12 2017, 1:43 AM
Phyx updated the diff for D3382: First update mingw-w64 packages for 8.4.
  • rebase
Apr 12 2017, 1:32 AM

Apr 11 2017

Phyx updated the diff for D3383: Implement split-sections support for windows..
  • Finished split sections.
  • revert section labels.
  • Revert "Finished split sections."
  • Merge only sections with $
  • Fix linker scripts.
  • temporarily disable big-obj
Apr 11 2017, 3:34 PM

Apr 1 2017

Phyx planned changes to D3383: Implement split-sections support for windows..

Harbormaster seems to have some test failures. Will take a look.

Apr 1 2017, 4:04 AM

Mar 31 2017

Phyx updated the diff for D3383: Implement split-sections support for windows..
  • revert section labels.
Mar 31 2017, 5:30 PM
Phyx retitled D3383: Implement split-sections support for windows. from WIP: Implement split-sections on windows. to Implement split-sections support for windows..
Mar 31 2017, 5:24 PM
Phyx updated the diff for D3383: Implement split-sections support for windows..
  • Finished split sections.
Mar 31 2017, 5:22 PM

Mar 29 2017

Phyx added a comment to D2592: WIP: Dynamic linking support for Windows (Part 1/2) [skip ci].

Almost there...

Mar 29 2017, 1:56 AM
Phyx updated the diff for D2592: WIP: Dynamic linking support for Windows (Part 1/2) [skip ci].
  • T5987: rebased.
  • T5987: fixing after rebase
  • T5987: Fixes after rebase.
  • T5987: reverted submodules.
  • DynLib: Fix ghc-cabal build errors and rts build error.
  • T5987: Reworking DLL building code.
  • T5987: Fix failure.
  • T5987: turn off lazy loading.
  • Dyn: remove assert code and other werr issues.
  • Disable CoreToStg asserts for DynWay for now.
  • Update submodules.
  • Shared: added gen-dll
  • Gen-Dll: Added better argument parsing
  • Calling Win32 args parser
  • GenDll: Fixed gen-dll I/O
  • Dll: Enable dynamic-too on Windows.
  • Fix some more rebase screwiness
  • Remove more dllsplit tstuff again
  • Fix execProc.
  • Disable CoreToStg warnings completely.
  • Fix -Werror
  • Correct ar script.
  • Dyn: disable import lib creation.
  • fix compile.
  • use lib instead.
  • Fix segfault.
  • Fix mri script.
  • Working using dll.a again
  • Dyn: Generate a DllMain by default unless -no-hs-main
Mar 29 2017, 1:37 AM
Phyx added inline comments to D3383: Implement split-sections support for windows..
Mar 29 2017, 1:35 AM

Mar 27 2017

Phyx added a comment to D3383: Implement split-sections support for windows..
In D3383#97145, @awson wrote:

But the scripts on trac are tailored to old section naming scheme. Those used for executables contain section merging logic for new scheme (since binutils supports it for quite a long time already), but .xr scripts don't contain it. This is what I've written about in previous comment. Thus you need to add it (things like *(SORT(.text$*)), *(SORT(.data$*)), *(SORT(.rdata$*))) to .xr files.

Mar 27 2017, 6:35 AM
Phyx added a comment to D3383: Implement split-sections support for windows..

Isn't that why we have $1_$2_LD_SCRIPT? to apply the custom linker scripts when making the GHCi objects?

Mar 27 2017, 5:42 AM
Phyx added a comment to D3383: Implement split-sections support for windows..

Guess the issue is with big-obj. I'll revert that from every call and instead add it only to the packages that need it for now while i modify GHCi.

Mar 27 2017, 4:51 AM

Mar 26 2017

Phyx updated the diff for D3384: WIP: Implement string merging on Windows.
  • Correct packages
Mar 26 2017, 5:35 PM
Phyx updated the diff for D3384: WIP: Implement string merging on Windows.

Correct base

Mar 26 2017, 5:29 PM
Phyx updated the diff for D3383: Implement split-sections support for windows..

correct base

Mar 26 2017, 5:25 PM
Phyx updated the diff for D3382: First update mingw-w64 packages for 8.4.

Correct patch

Mar 26 2017, 5:19 PM
Phyx added inline comments to D3318: GHC_STAGE1 isn't defined, use other form..
Mar 26 2017, 5:16 PM
Phyx updated the Trac tickets for D3384: WIP: Implement string merging on Windows.
Mar 26 2017, 3:28 PM
Phyx added a dependency for D3384: WIP: Implement string merging on Windows: D3383: Implement split-sections support for windows..
Mar 26 2017, 3:28 PM
Phyx added a dependent revision for D3383: Implement split-sections support for windows.: D3384: WIP: Implement string merging on Windows.
Mar 26 2017, 3:28 PM
Phyx created D3384: WIP: Implement string merging on Windows.
Mar 26 2017, 3:25 PM
Phyx updated the Trac tickets for D3382: First update mingw-w64 packages for 8.4.
Mar 26 2017, 3:02 PM
Phyx added a dependent revision for D3382: First update mingw-w64 packages for 8.4: D3383: Implement split-sections support for windows..
Mar 26 2017, 3:02 PM
Phyx added a dependency for D3383: Implement split-sections support for windows.: D3382: First update mingw-w64 packages for 8.4.
Mar 26 2017, 3:02 PM
Phyx updated the Trac tickets for D3383: Implement split-sections support for windows..
Mar 26 2017, 3:02 PM
Phyx added a comment to D3383: Implement split-sections support for windows..

This unfortunately increases the size of the GHCi libraries.
So much that memory can't be allocated to load them. Have to
figure that out first.

Mar 26 2017, 3:01 PM
Phyx created D3383: Implement split-sections support for windows..
Mar 26 2017, 3:01 PM
Phyx created D3382: First update mingw-w64 packages for 8.4.
Mar 26 2017, 2:41 PM
Phyx requested changes to D3278: Enable new warning for fragile/incorrect CPP #if usage.

Looking at these again, I suspect a lot of these aren't right. If you look at includes/stg/HaskellMachRegs.h it seems like these MACHREGS_ macros are always defined. just to either 0 or 1.
By switching these from #if to #if defined(..) they're now all trivially always true.

Mar 26 2017, 5:37 AM

Mar 20 2017

Phyx committed rGHC713ff9207e0f: Fix Windows x86 build (authored by Phyx).
Fix Windows x86 build
Mar 20 2017, 1:20 PM
Phyx closed D3362: Fix Windows x86 build by committing rGHC713ff9207e0f: Fix Windows x86 build.
Mar 20 2017, 1:20 PM
Phyx updated the summary of D3362: Fix Windows x86 build.
Mar 20 2017, 1:17 PM
Phyx updated the summary of D3362: Fix Windows x86 build.
Mar 20 2017, 1:14 PM