Crazycolorz5 (Adam Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 22 2018, 10:20 PM (13 w, 3 d)

Recent Activity

Jul 29 2018

Crazycolorz5 added a comment to D4889: rts: Specialize hashing at call site rather than in struct..

Just the benchmarks. Could you run the benchmarks in nofib please? See https://ghc.haskell.org/trac/ghc/wiki/Building/RunningNoFib

Jul 29 2018, 6:34 PM

Jul 13 2018

Crazycolorz5 updated the summary of D4889: rts: Specialize hashing at call site rather than in struct..
Jul 13 2018, 8:53 PM
Crazycolorz5 added a comment to D4889: rts: Specialize hashing at call site rather than in struct..

Sorry for the delay. Aside from additional benchmarks (which I'll upload soon, after ghc builds), is there any additional work needed on this?

Jul 13 2018, 8:16 PM

Jul 6 2018

Crazycolorz5 added a comment to D4889: rts: Specialize hashing at call site rather than in struct..

What were you trying to measure here? This is a dynamically linked binary and so doesn't include the code of the RTS itself.

Jul 6 2018, 8:07 PM

Jul 2 2018

Crazycolorz5 updated the diff for D4889: rts: Specialize hashing at call site rather than in struct..
  • Fixed expand always using hashWord.

(Previous diff missed a change)

Jul 2 2018, 11:41 PM
Crazycolorz5 updated the diff for D4889: rts: Specialize hashing at call site rather than in struct..
  • Fixed expand always using hashWord.
Jul 2 2018, 11:17 PM

Jun 29 2018

Crazycolorz5 added a comment to D4889: rts: Specialize hashing at call site rather than in struct..

I'm unsure why the tests are failing. The logs seem to indicate library loading issues, but I haven't touched anything in the process of compilation to Core?

Jun 29 2018, 9:09 AM

Jun 28 2018

Crazycolorz5 updated the diff for D4889: rts: Specialize hashing at call site rather than in struct..
  • Lint fix changes.
Jun 28 2018, 8:36 PM
Crazycolorz5 retitled D4889: rts: Specialize hashing at call site rather than in struct. from rts: address trac issue #13165. to rts: address trac issue #13165; Specialize hashing at call site rather than in struct..
Jun 28 2018, 8:22 PM
Crazycolorz5 added a comment to D4889: rts: Specialize hashing at call site rather than in struct..

Seems like a sensible idea. What is the effect on code size?

Some nits:

  • Please update the diff title to say what the change is.
  • Please add the benchmark results (or a link to them) to the summary
  • Please fix the long lines (we have an 80-column policy in the RTS)
Jun 28 2018, 8:09 PM

Jun 24 2018

Crazycolorz5 added a comment to D4889: rts: Specialize hashing at call site rather than in struct..

Seems like a sensible thing to do.

Have you characterised how much of an effect this has on real hashing performance?

Jun 24 2018, 5:58 PM
Crazycolorz5 updated the diff for D4889: rts: Specialize hashing at call site rather than in struct..
  • Removed inline in header due to reference of implementation of HashTable.
Jun 24 2018, 5:31 PM
Herald added a reviewer for D4889: rts: Specialize hashing at call site rather than in struct.: erikd.
Jun 24 2018, 1:05 AM