AndreasVoellmy (Andreas Voellmy)
User

Projects

User Details

User Since
Aug 7 2014, 5:38 PM (227 w, 4 d)

Recent Activity

Jul 25 2018

AndreasVoellmy committed rGHCDIFF31132709e277: EventManager: Gracefully handle an initial 'Finished' state (#8235) (authored by Patrick Palka <patrick@parcs.ath.cx>).
EventManager: Gracefully handle an initial 'Finished' state (#8235)
Jul 25 2018, 11:13 AM
AndreasVoellmy committed rGHCDIFF28cf2e004da0: Switch IO manager to a mutable hashtable (authored by Bryan O'Sullivan <bos@serpentine.com>).
Switch IO manager to a mutable hashtable
Jul 25 2018, 11:13 AM
AndreasVoellmy committed rGHCDIFFc5a4de9db902: Update parallel IO manager to handle the invalid files in the same way as… (authored by AndreasVoellmy).
Update parallel IO manager to handle the invalid files in the same way as…
Jul 25 2018, 11:11 AM
Ian Lynagh <ian@well-typed.com> committed rGHCDIFFb0d27b9083de: Expose new threadWaitSTM functions in Control.Concurrent (see #7216). (authored by AndreasVoellmy).
Expose new threadWaitSTM functions in Control.Concurrent (see #7216).
Jul 25 2018, 11:07 AM
Ian Lynagh <ian@well-typed.com> committed rGHCDIFFc0032c06d31d: Added the unregistration command to the return value of threadWait*STM… (authored by AndreasVoellmy).
Added the unregistration command to the return value of threadWait*STM…
Jul 25 2018, 11:06 AM
Ian Lynagh <ian@well-typed.com> committed rGHCDIFF4ab3d16b8499: Added threadWait functions to wait on FD readiness with STM actions. (authored by AndreasVoellmy).
Added threadWait functions to wait on FD readiness with STM actions.
Jul 25 2018, 11:06 AM

Apr 16 2015

AndreasVoellmy added a comment to D849: Fix dropped event registrations.

Glad you found this. First priority is probably to get a test that demonstrates that the bug can happen.

Apr 16 2015, 8:14 PM

Mar 9 2015

AndreasVoellmy committed rGHCc4ac3c9d981e: Merge branch 'master' of git://git.haskell.org/ghc (authored by AndreasVoellmy).
Merge branch 'master' of git://git.haskell.org/ghc
Mar 9 2015, 5:28 PM
AndreasVoellmy committed rGHC74625d6847e9: RTS/IOManager: fix trac issue #9722. (authored by AndreasVoellmy).
RTS/IOManager: fix trac issue #9722.
Mar 9 2015, 5:28 PM
AndreasVoellmy closed D722: RTS/IOManager: fix trac issue #9722. by committing rGHC74625d6847e9: RTS/IOManager: fix trac issue #9722..
Mar 9 2015, 5:28 PM
AndreasVoellmy updated the Trac tickets for D722: RTS/IOManager: fix trac issue #9722..
Mar 9 2015, 3:13 PM
AndreasVoellmy abandoned D721: RTS/IOManager: fix trac issue #9722..

This is a duplicate. Please disregard this. The real one is D722.

Mar 9 2015, 3:12 PM
AndreasVoellmy retitled D722: RTS/IOManager: fix trac issue #9722. from to RTS/IOManager: fix trac issue #9722..
Mar 9 2015, 3:10 PM
AndreasVoellmy retitled D721: RTS/IOManager: fix trac issue #9722. from to RTS/IOManager: fix trac issue #9722..
Mar 9 2015, 3:09 PM

Feb 2 2015

AndreasVoellmy committed rGHC92c935449391: Fix #10017 (authored by AndreasVoellmy).
Fix #10017
Feb 2 2015, 10:08 AM
AndreasVoellmy closed D641: Fix #10017 by committing rGHC92c935449391: Fix #10017.
Feb 2 2015, 10:08 AM

Feb 1 2015

AndreasVoellmy retitled D641: Fix #10017 from to Fix #10017.
Feb 1 2015, 9:01 AM

Nov 17 2014

AndreasVoellmy added a comment to D347: Event Manager: Make one-shot a per-registration property.
In D347#12085, @bgamari wrote:

What's the plan here? At this point I'd be alright with just merging for 7.10. In this case I'd probably want to drop the new registerFd variant.

Nov 17 2014, 11:58 AM
AndreasVoellmy added inline comments to D347: Event Manager: Make one-shot a per-registration property.
Nov 17 2014, 11:52 AM
AndreasVoellmy added inline comments to D347: Event Manager: Make one-shot a per-registration property.
Nov 17 2014, 11:51 AM
AndreasVoellmy added inline comments to D347: Event Manager: Make one-shot a per-registration property.
Nov 17 2014, 11:41 AM
AndreasVoellmy added inline comments to D347: Event Manager: Make one-shot a per-registration property.
Nov 17 2014, 10:46 AM
AndreasVoellmy added inline comments to D347: Event Manager: Make one-shot a per-registration property.
Nov 17 2014, 10:03 AM

Oct 7 2014

AndreasVoellmy accepted D318: Make clearNursery free.

Cool! Do we have any benchmarks?

Oct 7 2014, 3:09 PM

Sep 17 2014

AndreasVoellmy closed D217: Remove unnecessary import of Data.Monoid in GHC.Event.KQueue to fix compiler warning..

Closed by commit rGHC2622eae34aa5 (authored by @AndreasVoellmy).

Sep 17 2014, 2:17 PM
AndreasVoellmy retitled D217: Remove unnecessary import of Data.Monoid in GHC.Event.KQueue to fix compiler warning. from to Remove unnecessary import of Data.Monoid in GHC.Event.KQueue to fix compiler warning..
Sep 17 2014, 7:29 AM

Sep 11 2014

AndreasVoellmy added a comment to D174: Revert "Revert "rts/base: Fix #9423"" and resolve issue that caused the revert..

This seems stalled, though I think it is ready. Is there anything I can do to help move this along?

Sep 11 2014, 8:56 AM

Aug 23 2014

AndreasVoellmy updated the diff for D174: Revert "Revert "rts/base: Fix #9423"" and resolve issue that caused the revert..
  • Include of rts/IOManager.h is not needed for mingw32_HOST_OS.
Aug 23 2014, 12:15 PM
AndreasVoellmy retitled D174: Revert "Revert "rts/base: Fix #9423"" and resolve issue that caused the revert. from to Revert "Revert "rts/base: Fix #9423"" and resolve issue that caused the revert..
Aug 23 2014, 12:05 PM

Aug 15 2014

AndreasVoellmy added a comment to D129: rts/base: Fix #9423.

I'm happy with the diff. @austin: do you want to apply it?

Aug 15 2014, 7:42 AM

Aug 11 2014

AndreasVoellmy added a comment to D129: rts/base: Fix #9423.

My validate (and maybe Harbormaster's too) is failing on the following:

Aug 11 2014, 2:18 PM
AndreasVoellmy updated the diff for D129: rts/base: Fix #9423.
  • Make foreign calls setIOManagerWakeupFd, setIOManagerControlFd, and setTimerManagerControlFd "unsafe" since all they do is write values into variables in the RTS.
Aug 11 2014, 12:42 PM
AndreasVoellmy added a comment to D129: rts/base: Fix #9423.

Yes, O(1) times. So I won't bother with primops. I will mark the calls as
"unsafe", since all they do is write to a variable in the RTS. Will
validate and update.

Aug 11 2014, 10:39 AM
AndreasVoellmy added a comment to D129: rts/base: Fix #9423.

Should the setTimerManagerControlFd() and setIOManagerControlFd() be defined as primops rather than imported foreign functions? I imagine there is less overhead associated with primops.

Aug 11 2014, 10:34 AM
AndreasVoellmy updated the diff for D129: rts/base: Fix #9423.
  • Fix typo.
Aug 11 2014, 9:25 AM
AndreasVoellmy added a comment to D129: rts/base: Fix #9423.

I think it should be fine if the number of capabilities changes at runtime.
The control pipe for the IO manager of capability i is stored in the
Capability_ struct of capability[i]. So there is no need to resize any data
structures outside of what is already done by the RTS. At shutdown,
ioManagerDie simply reads the control pipe field of all the capability[i]
elements for i in 0..n_capabilities.

Aug 11 2014, 8:32 AM
AndreasVoellmy added a comment to D129: rts/base: Fix #9423.

Validate still fails for me due to failures that were in master before my patches - this patch introduces no new validate failures.

Aug 11 2014, 8:29 AM
AndreasVoellmy updated the diff for D129: rts/base: Fix #9423.

Rework the patch to maintain a per-capability file descriptor for the control pipes of the IO managers and to avoid introducint any new locks.

Aug 11 2014, 8:24 AM

Aug 9 2014

AndreasVoellmy added a comment to D129: rts/base: Fix #9423.

Validate fails on my machine, but the 4 failures are also present in HEAD (d0ee4eb0879f77067e7f05e0daa80e6ca8817f1d) for me, so I don't think this has anything to do with this patch.

Aug 9 2014, 11:52 AM

Aug 8 2014

AndreasVoellmy updated the diff for D129: rts/base: Fix #9423.
  • Examine return value of write call in ioManagerDie.
Aug 8 2014, 11:58 PM
AndreasVoellmy added a comment to D129: rts/base: Fix #9423.

Thanks for pointing out the warning that I triggered. I will fix and put up
a new diff.

Aug 8 2014, 11:38 PM
AndreasVoellmy added a comment to D129: rts/base: Fix #9423.

Phabricator's builds seem to fail on my diff, but I can't see why from the build log provided. I don't see any obvious errors in the log.

Aug 8 2014, 4:27 PM
AndreasVoellmy updated the diff for D129: rts/base: Fix #9423.
  • Fix issue Trac #9423 (problem discovered in Trac #9284).
  • Remove GHC.Event.shutdownManagers and fix warnings.
Aug 8 2014, 2:25 PM
AndreasVoellmy set the repository for D129: rts/base: Fix #9423 to rGHC Glasgow Haskell Compiler.
Aug 8 2014, 1:10 PM
AndreasVoellmy added a comment to D129: rts/base: Fix #9423.

Yes, I think we can get rid of shutdownManagers in GHC.Thread. I'm doing that now and also running validate. Will update when this is done.

Aug 8 2014, 1:02 PM
AndreasVoellmy added a reviewer for D129: rts/base: Fix #9423: ezyang.
Aug 8 2014, 1:01 PM
AndreasVoellmy added a reviewer for D129: rts/base: Fix #9423: austin.
Aug 8 2014, 12:58 PM
AndreasVoellmy retitled D129: rts/base: Fix #9423 from to Fix bug from trac issue #9423.
Aug 8 2014, 10:43 AM