Do we need a separate place for discussing the design or do we simply need a stub ticket that we can reference?
Aug 21 2018
Aug 16 2018
Please mention the Trac ticket number in the summary (click "Edit revision"). Create a ticket first if it doesn't exist yet.
I rebased, did some work, then did arc diff. Unfortunately, it looks like the base commit of this diff is the still the pre-rebase one. How would I go about fixing this?
Subsumed by D5057.
Aug 14 2018
Aug 13 2018
I don't know about ExitException and mtimes. Maybe just leave it for somebody else to fix.
@alanasp: maybe you could add a short blurp to the release notes?
Aug 12 2018
RolandSenn: one last thing, before @bgamari gets here. Maybe you could add a blurp to the release notes about this new flag.
Aug 11 2018
I'm happy clean_cmd is finally gone.
Please inform me, if these 2 tests can be written with less redundandency.
Aug 8 2018
I guess specifying -E together with -keep-hscpp-files will write both files? That's ok though.
Aug 7 2018
The file produced by the -E flag however, will continue to be named *.hspp, although it is the output of the C pre-processor.
Aug 6 2018
A patch for the second-oldest still open bug!
Aug 5 2018
Ah, ok, that makes sense.
Aug 4 2018
@RolandSenn: sorry for the late reply.
Aug 3 2018
Aug 2 2018
Jan 22 2017
I mean, does it remove the definition so that it is definitely removed everywhere?
Oct 19 2016
Oct 18 2016
Aug 28 2016
What is the ticket number for this? Click "Edit revision" to add it, thanks.
For future reference: this feature was added to fix Trac #10083 (I think).
Currently the name of the warning flag in the documentation and in the implementation don't match.
Aug 27 2016
Missing changelog entry: docs/users_guide/8.2.1-notes.rst
Missing update to utils/mkUserGuidePart/Options/Misc.hs
Changelog entry is missing. This would go in docs/users_guide/8.2.1-notes.rst normally.
Jul 24 2016
Jul 22 2016
Just some final remarks. After that I think we can push this (before any merge problems arise), and perhaps continue in a new Diff.
Jul 21 2016
Jul 20 2016
What's with the Template Haskell in the test? Is that necessary?
Nice and small patch.
Jul 19 2016
Still looking good. Some small comments.
Jul 18 2016
This looks ok, after a quick scan, except for one mistake.
In FrontendPluginUser, you're passing in a frontend plugin with -fplugin instead of with --frontend (see https://downloads.haskell.org/~ghc/master/users-guide/extending_ghc.html#frontend-plugins). Is that intentional?
This is good.
Jul 13 2016
perf.haskell.org show now performance regressions.
Jul 11 2016
Compile-time performance differences:
- -67% 'bytes allocated' for T12227 (8.0.1 even looped on this one)
- -3% 'max_bytes_used' for T3294
- +3% 'bytes allocated' for T3294 (I don't know why, but I'm ignoring it)
The new flags need to be mentioned in utils/mkUserGuidePart/Options/CompilerDebugging.hs as well (sorry for not alerting you earlier).
Jul 9 2016
How about this
Jul 8 2016
This looks ok, but it needs some documentation. See point 6 and 7 of https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/AddingFeatures#HowtocontributeanewfeaturetoGHC.
Jul 7 2016
This looks ok to me, but I'd like a sign off from someone on the CLC.
Jul 1 2016
Jun 30 2016
Jun 29 2016
Jun 28 2016
I tried this, but you end up with a very confusing intertwining of stdout and stderr.
I pushed the above patch, although T7037 still fails occasionally.
Maybe the testsuite driver should ignore extra_ways for run_commands. What do you think?