Feed Advanced Search

Tue, Feb 5

bgamari added a comment to D5041: Make the types of expressions accessible in the API..

I rebased to master and ran the tests:

Hmm, this is rather what I was afraid of. It looks like this has caused nearly all compiler performance tests to regress. Can you paste the full testsuite output?

Tue, Feb 5, 11:28 AM

Thu, Jan 31

bgamari accepted D5475: Fix #16219: TemplateHaskell causes indefinite package build error.

Thanks, looks good!

Thu, Jan 31, 7:00 PM
bgamari added a comment to D5475: Fix #16219: TemplateHaskell causes indefinite package build error.

Do note, @ezyang, that new patches should go through GitLab. We are currently in the process of winding down Phabricator.

Thu, Jan 31, 6:59 PM
bgamari added a comment to D5041: Make the types of expressions accessible in the API..

Yes, I would like to integrate this. I need some pointers on what changes are requested to finish.

Thu, Jan 31, 1:20 PM

Jan 22 2019

bgamari abandoned D5305: Towards using level numbers for generalisation.
Jan 22 2019, 7:47 PM

Jan 21 2019

bgamari committed rGHC5ebcfc0407e6: gitlab: Add merge request template (authored by bgamari).
gitlab: Add merge request template
Jan 21 2019, 5:06 PM
bgamari abandoned D4472: Implement a memchr wrapper: searchByteArray.
Jan 21 2019, 4:40 PM

Jan 20 2019

bgamari closed D4333: testsuite: Don't disable LLVM ways due to unversioned llc.

Moved to GitLab !156.

Jan 20 2019, 8:10 PM
bgamari closed D5056: testsuite: Ensure that config.{msys,cygwin} are initialized.

Moved to GitLab.

Jan 20 2019, 8:09 PM
bgamari abandoned D5097: Add a -fprint-axiom-incomps option (#15546).

Moved to GitLab for CI.

Jan 20 2019, 8:08 PM
bgamari closed D4759: rts: Make LOOKS_LIKE_INFO_PTR a bit more strict.

Moved to GitLab.

Jan 20 2019, 8:08 PM
bgamari requested changes to D5433: Introduce GhciMonad and generalize types of functions in GHCi.UI.

What is the plan for this, @watashi?

Jan 20 2019, 8:00 PM
bgamari added a comment to D5427: hadrian: Only link against libffi when it is needed for adjustors.

@DavidEichmann, what is the status of this?

Jan 20 2019, 7:56 PM
bgamari added a comment to D4263: [RTS] Add loadNativeObj and unloadNativeObj.

What is the status of this, @simonmar?

Jan 20 2019, 7:44 PM
bgamari requested changes to D4931: Fixes an issue with deprecated symbols that are explicitly imported not throwing a warning.

@alansp, I just found this sitting in the merge queue. Unfortunately it doesn't appear to apply and I'm having some trouble resolving the conflicts. Do you suppose you could have a look? My apologies for dropping the ball on this one.

Jan 20 2019, 7:41 PM
bgamari closed D4859: [WIP] testsuite: Add tests for #15270.

Merged with 18b74cdbbfa053704caabd104587d8a91a9233a0.

Jan 20 2019, 7:37 PM
bgamari abandoned D4103: hWaitForInput-accurate-pipe.

Moved to GitLab.

Jan 20 2019, 7:31 PM
bgamari abandoned D4104: hWaitForInput-accurate-socket.

Merged in ce2f77d5656e847e8411805906f736a4a0a1242e. Thanks @syd!

Jan 20 2019, 7:30 PM
bgamari added a comment to D4777: Implement the Unlifted Newtypes proposal.

@goldfire, I believe this might be blocked on you.

Jan 20 2019, 7:30 PM
bgamari added a comment to D5340: Clang assembly for GCC with Dwarf on Darwin.

What is the status of this, @carter?

Jan 20 2019, 7:29 PM
bgamari added a comment to D5223: WIP: Support profiling in ghc-heap.

Do you intend on continuing work on this, @mpickering?

Jan 20 2019, 7:29 PM
bgamari added a comment to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.

This is looking great, @sjakobi! What is your planned timeframe for finishing it up?

Jan 20 2019, 7:27 PM
bgamari requested changes to D5474: Linker-script workaround compatibility musl libc.
Jan 20 2019, 7:23 PM
bgamari added a comment to D5474: Linker-script workaround compatibility musl libc.

@smaeul, do you think you could push this to GitLab? I was going to do so myself but unfortunately Phabricator refuses to tell me your email address so I can't properly attribute the commit to you.

Jan 20 2019, 7:23 PM
bgamari updated the diff for D5474: Linker-script workaround compatibility musl libc.

Update

Jan 20 2019, 7:21 PM
bgamari requested changes to D5213: Backend plugins.
Jan 20 2019, 7:13 PM · GHC
bgamari requested changes to D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.

What is the status of this, @v0d1ch?

Jan 20 2019, 7:12 PM
bgamari requested changes to D4886: Don't allocate in atomicWriteIORef.

@dfeuer, do you intend on finishing this?

Jan 20 2019, 7:03 PM
bgamari abandoned D4769: Fix #14880..

I believe all of the pieces of Trac #14880 have been merged.

Jan 20 2019, 7:02 PM
bgamari abandoned D4896: Use an IORef for QSemN.
Jan 20 2019, 7:01 PM
bgamari abandoned D5098: rts: Make SRTs a distinct closure type.
Jan 20 2019, 7:00 PM
bgamari added a comment to D5098: rts: Make SRTs a distinct closure type.

The goal of this was to make it easy to track SRT scavenging events to test Trac #15113. However, indeed I'm not convinced this change is worth the extra instructions it would no doubt result in. I've pushed the patch to wip/rts-srt-closure-type for posterity.

Jan 20 2019, 7:00 PM
bgamari abandoned D5147: Close over kinds exactly once per var (#14880).

I believe all of the pieces of Trac #14880, which this was one, have been merged. See the ticket for details.

Jan 20 2019, 6:55 PM
bgamari added a comment to D5305: Towards using level numbers for generalisation.

It looks like 2257a86daa72db382eb927df12a718669d5491f8 is relevant.

Jan 20 2019, 6:54 PM
bgamari requested changes to D5285: Warn about unused packages.

@Yuras, I have rebased and moved this to GitLab !154 for CI and merge.

Jan 20 2019, 6:52 PM
bgamari added a comment to D5305: Towards using level numbers for generalisation.

What is the status of this, @goldfire?

Jan 20 2019, 6:48 PM
bgamari requested changes to D5330: Introduce map from RdrName to Name for GHC API.

@alanz, what is the status of this?

Jan 20 2019, 6:47 PM
bgamari abandoned D5373: Summary: Add HoleFitPlugins and RawHoleFits.

I have rebased and moved this to GitLab !153 for review, CI, and merge.

Jan 20 2019, 6:46 PM
bgamari requested changes to D5377: Show instance import provenance on overlapping instances.
Jan 20 2019, 6:42 PM
bgamari added a comment to D5377: Show instance import provenance on overlapping instances.

How is this going, @dminuoso?

Jan 20 2019, 6:42 PM
bgamari added a comment to D5415: Fix #15656 by extending -Wall with appropriate flags.

@ckoparkar, how is this going?

Jan 20 2019, 6:42 PM
bgamari requested changes to D5466: Reduce indirections and allocations in event manager..
Jan 20 2019, 6:39 PM
bgamari requested changes to D5408: Introduce ExpPatFrame.

Bumping out of the review queue while work continues.

Jan 20 2019, 6:39 PM
bgamari added a comment to D4896: Use an IORef for QSemN.

I have moved this to GitLab.

Jan 20 2019, 6:37 PM
bgamari added a comment to D5082: Make tablesNextToCode a proper dynamic flag (#15548).

Sigh, no, this isn't merged. I just confused myself. Regardless, I have pushed this to GitLab as wip/D5082. Do you intend on continuing this, @nomeata?

Jan 20 2019, 6:31 PM
Herald added a reviewer for D4472: Implement a memchr wrapper: searchByteArray: jrtc27.

Whoops, I found this comment unsubmitted. @andrewthad, what is the status of this?

Jan 20 2019, 6:22 PM
bgamari requested changes to D5041: Make the types of expressions accessible in the API..

@nboldi, do you intend on continuing work on this? If so do you suppose you could move it to GitLab?

Jan 20 2019, 6:19 PM
bgamari abandoned D5082: Make tablesNextToCode a proper dynamic flag (#15548).

Merged in a0dcf76fa7b23cf1cacababadaa1b54d90453f9a.

Jan 20 2019, 6:18 PM
bgamari requested changes to D5126: Implement feature #3427.
Jan 20 2019, 6:17 PM
bgamari added a comment to D5126: Implement feature #3427.

This appears to be blocked on GHC Proposal #167. @nineonine, when the proposal is accepted could you move this to GitLab for review?

Jan 20 2019, 6:17 PM
bgamari added a comment to D5210: Add pprList method to Outputable for better String rendering.

@osa1, what is the status of this?

Jan 20 2019, 6:15 PM
bgamari abandoned D5455: add -Wderiving-defaults for enabling/suppressing strategy defaulting warnings.

Merged with c121e33f9b039acf2ac6939af8bfafe593560039.

Jan 20 2019, 6:13 PM
bgamari abandoned D5457: testsuite: Warn if tests will never be run.

Moved to GitLab.

Jan 20 2019, 6:10 PM
bgamari abandoned D5458: Hadrian: Add support for building Stage3.

Merged in 6486c6e49c53e75f37ed732b38c5be7ae64785e8.

Jan 20 2019, 6:10 PM
bgamari added a comment to D5466: Reduce indirections and allocations in event manager..

@andrewthad, this looks like the beginnings of a nice patch. However, given that we haven't really started review yet do you suppose you could move this to GitLab when you would like review?

Jan 20 2019, 6:09 PM
bgamari accepted D5474: Linker-script workaround compatibility musl libc.

Wow, I wasn't aware of this awful little bit of code. Well, given that it exists it does seem reasonable to extend it for musl. However, I can't help but wonder whether there isn't a better way to accomplish this.

Jan 20 2019, 6:08 PM
bgamari added a comment to D5213: Backend plugins.

@angerman, what is the status of this?

Jan 20 2019, 6:06 PM · GHC
bgamari abandoned D5036: [TTG: Handling Source Locations] Foundation and Pat.

This was merged with 509d5be69c7507ba5d0a5f39ffd1613a59e73eea

Jan 20 2019, 6:06 PM
bgamari added a comment to D5400: Make constructor wrappers inline only during the final phase.

What is the status of this, @monoidal and @aspiwack?

Jan 20 2019, 6:03 PM
bgamari added inline comments to D5400: Make constructor wrappers inline only during the final phase.
Jan 20 2019, 5:54 PM

Jan 17 2019

bgamari committed rGHC6aaa0655a721: Documentation for StgRetFun (authored by osa1).
Documentation for StgRetFun
Jan 17 2019, 11:51 AM
bgamari committed rGHC8765c1e6e6ac: Make sure 'haddock' package also copies resources (authored by harpocrates).
Make sure 'haddock' package also copies resources
Jan 17 2019, 11:51 AM
bgamari committed rGHC2e05912086bb: Hadrian: handle Haddock's resource directory (authored by harpocrates).
Hadrian: handle Haddock's resource directory
Jan 17 2019, 11:51 AM
bgamari committed rGHC46d46ede77ef: Improve clarity of documentation for maybeToList (authored by Steve Hart <steve@stevehart.net>).
Improve clarity of documentation for maybeToList
Jan 17 2019, 11:51 AM
bgamari committed rGHC4204ed581821: Fix typo in maybeToList documentation (authored by Steve Hart <steve@stevehart.net>).
Fix typo in maybeToList documentation
Jan 17 2019, 11:51 AM
bgamari committed rGHCfe1f97ccdf5c: Revert "Fix typo in maybeToList documentation" (authored by Steve Hart <steve@stevehart.net>).
Revert "Fix typo in maybeToList documentation"
Jan 17 2019, 11:51 AM
bgamari committed rGHC8d594beff68a: Hadrian: Use the Cabal build script on Windows by default (authored by snowleopard).
Hadrian: Use the Cabal build script on Windows by default
Jan 17 2019, 11:51 AM
bgamari committed rGHCbfb3e3072d25: Disable Shake Lint by default. (authored by snowleopard).
Disable Shake Lint by default.
Jan 17 2019, 11:51 AM
bgamari committed rGHC7218270dee10: Switch to the untracked version of getDirectoryFiles when scanning for GMP… (authored by snowleopard).
Switch to the untracked version of getDirectoryFiles when scanning for GMP…
Jan 17 2019, 11:51 AM
bgamari committed rGHC78ae2d5d7984: typo (authored by alpmestan).
typo
Jan 17 2019, 11:51 AM
bgamari committed rGHCad5075d93892: crosslink hadrian/README.md and hadrian/doc/make.md (authored by alpmestan).
crosslink hadrian/README.md and hadrian/doc/make.md
Jan 17 2019, 11:51 AM
bgamari committed rGHC6acb36d8ea16: doc: behaviour of +RTS -h depends on profiling (authored by Ben Price <ben@brprice.uk>).
doc: behaviour of +RTS -h depends on profiling
Jan 17 2019, 11:51 AM
bgamari committed rGHCa303695b0ac8: try to fix CI (authored by harpocrates).
try to fix CI
Jan 17 2019, 11:51 AM
bgamari committed rGHC61f178b617fc: doc: reorder heap profiling information in +RTS -? (authored by Ben Price <ben@brprice.uk>).
doc: reorder heap profiling information in +RTS -?
Jan 17 2019, 11:51 AM
bgamari committed rGHC236abdb80ab8: rts: Allow heap prof by closure type in prof way (authored by Ben Price <ben@brprice.uk>).
rts: Allow heap prof by closure type in prof way
Jan 17 2019, 11:51 AM
bgamari committed rGHCd2eb344a38f6: Fix tests for `integer-simple` (authored by harpocrates).
Fix tests for `integer-simple`
Jan 17 2019, 11:51 AM
bgamari committed rGHCf7def747cf0d: Remove from `base` obsolete CPP for `integer-gmp` (authored by harpocrates).
Remove from `base` obsolete CPP for `integer-gmp`
Jan 17 2019, 11:51 AM
bgamari committed rGHC6e320c279ddf: Match `integer-simple`'s API with `integer-gmp` (authored by harpocrates).
Match `integer-simple`'s API with `integer-gmp`
Jan 17 2019, 11:51 AM
bgamari committed rGHC582a96f422a8: Support printing `integer-simple` Integers in GHCi (authored by harpocrates).
Support printing `integer-simple` Integers in GHCi
Jan 17 2019, 11:51 AM
bgamari committed rGHC9fb2702dec3e: Create folder if missing for .hie files (authored by harpocrates).
Create folder if missing for .hie files
Jan 17 2019, 11:50 AM
bgamari committed rGHC6a7a6b865bdb: Introduce ghci command wrapper (authored by watashi).
Introduce ghci command wrapper
Jan 17 2019, 11:50 AM
bgamari committed rGHC2f65025eeb4a: Hadrian: support extra libraries + OSX rpath (authored by harpocrates).
Hadrian: support extra libraries + OSX rpath
Jan 17 2019, 11:50 AM
bgamari committed rGHCc155ac9c5299: Fix filename in comment again (authored by trommler).
Fix filename in comment again
Jan 17 2019, 11:50 AM
bgamari committed rGHCea79978b5372: Fix reference to stack code in comment (authored by trommler).
Fix reference to stack code in comment
Jan 17 2019, 11:50 AM
bgamari committed rGHCda2d9cf8e028: Hadrian: configure packages with right 'htmldir' (authored by harpocrates).
Hadrian: configure packages with right 'htmldir'
Jan 17 2019, 11:50 AM
bgamari committed rGHC3f46cffcc285: PPC NCG: Refactor stack allocation code (authored by trommler).
PPC NCG: Refactor stack allocation code
Jan 17 2019, 11:50 AM
bgamari committed rGHCf78048f6575b: Change comments as requested by code review. #10857 (authored by RolandSenn).
Change comments as requested by code review. #10857
Jan 17 2019, 11:50 AM
bgamari committed rGHC9fb744bdc54c: GHCi ignores cmd line flags XMonomorphismRestr.. XNoExtendedDef..#10857 (authored by RolandSenn).
GHCi ignores cmd line flags XMonomorphismRestr.. XNoExtendedDef..#10857
Jan 17 2019, 11:50 AM

Jan 16 2019

bgamari committed rGHCec76213931f2: gitlab-ci: Try reenabling PDF documentation on Darwin (authored by bgamari).
gitlab-ci: Try reenabling PDF documentation on Darwin
Jan 16 2019, 12:24 AM
bgamari committed rGHC4985e1c6cf9f: Fix bindist for ghci library (authored by watashi).
Fix bindist for ghci library
Jan 16 2019, 12:24 AM
bgamari committed rGHC312c957f1cc7: testsuite: Add test for #16104 (authored by bgamari).
testsuite: Add test for #16104
Jan 16 2019, 12:24 AM
bgamari committed rGHCbbd58fb5f029: Fix #16133 by checking for TypeApplications in rnExpr (authored by RyanGlScott).
Fix #16133 by checking for TypeApplications in rnExpr
Jan 16 2019, 12:24 AM
bgamari committed rGHC9ea8dcea3e5b: Hadrian: merge sections in profiling _p.a to .p_o for ghci (authored by watashi).
Hadrian: merge sections in profiling _p.a to .p_o for ghci
Jan 16 2019, 12:24 AM
bgamari committed rGHC3fb726d0696f: Fix bindist for ghci library (authored by watashi).
Fix bindist for ghci library
Jan 16 2019, 12:24 AM
bgamari committed rGHC24b39ce53eed: Remove OPTIONS_HADDOCK hide in favour for not-home (authored by adamse).
Remove OPTIONS_HADDOCK hide in favour for not-home
Jan 16 2019, 12:24 AM
bgamari committed rGHC3a509d2999d4: make: Silence some xelatex output (authored by bgamari).
make: Silence some xelatex output
Jan 16 2019, 12:24 AM
bgamari committed rGHC66b88dddb318: gitlab-ci: Try reenabling PDF documentation on Darwin (authored by bgamari).
gitlab-ci: Try reenabling PDF documentation on Darwin
Jan 16 2019, 12:24 AM
bgamari committed rGHC0ff42f3f6e85: Add entry for #16031 to base/changelog.md (authored by supersven).
Add entry for #16031 to base/changelog.md
Jan 16 2019, 12:24 AM
bgamari committed rGHC01b60b0e1ee5: Fix precedence handling for Data.Fixed's Show instance (#16031) (authored by supersven).
Fix precedence handling for Data.Fixed's Show instance (#16031)
Jan 16 2019, 12:24 AM
bgamari committed rGHCc121e33f9b03: Add -Wmissing-deriving-strategies (authored by chessai).
Add -Wmissing-deriving-strategies
Jan 16 2019, 12:24 AM