- Add missing @sinces
That set of missing @since annotations gave me an idea: @sjakobi's :doc output could potentially be used by a linter of sorts to ensure such annotations aren't forgotten in newly introduced definitions.
- update test output
@bgamari what's the timeline for updating the GCC toolchain for 8.6? I assume since you've already branched you're close to a release?
In that case I'd accept this patch for that branch and we can revert it for 8.8. the GCC patch has been merged into mingw-w64 however
they're having some trouble building GCC 8 due to some Ada build failures... and the Ada maintainers aren't being very helpful.
I've started looking at it as well but I'm stretched a bit thin here and don't know when it'll be solved.
It's far from ideal but at least @erikd et all would be able to (slowly) build their projects again. The flag is undocumented so we can remove it without issue I think.
I think the current version ought to work, however.
Sorry, @RyanGlScott, wasn't quite ready for review yet. I should have finished the patch before adding reviewers.
Really fix it
I generally think it is best if flags remain orthogonal where possible. Let's just fix the users guide description.
Handle top-level case as well
Out of curiosity, have you compare the performance of this to the previous version (with -fstate-hack, of course)?
I would much rather we had a better understanding of what is going on here before we brush the issue under the rug; afterall, it may also break in other configurations.
Looks quite reasonable to me.
Alright, I suppose this is reasonable. However, we should make this logic and its comment much more discoverable. Let's make the comment a Note; I'm not entirely sure where to refer to it from yet.
Looks good to me assuming it validates.
Thanks for the patch, @sgillespie! This looks quite reasonable to me.
Looks good, thanks!
Merged with d1c7239c037e267873658160b5c290f08f0d6502.
Thanks for your contribution @RolandSenn!
Sat, Jun 16
Looks good to me. Thanks!
Builders upgraded and re-applied in 60e4bb4d305bc1a65457ee79b1e69c11b9ed747d.
Strangely this appears to break the OS X build. Reverting for now.
Seems reasonable to me.
Looks reasonable to me.
Fri, Jun 15
Looks good to me.