Feed Advanced Search

Yesterday

bgamari added a comment to D4430: Various Windows / Cross Compile to Windows fixes.

Can you add some notes regarding this cross-compilation configuration to the wiki?

Wed, Feb 21, 9:02 AM
bgamari added a comment to D3918: Rewrite boot in Python.

I just tried to make FAST=YES in libraries/base and found that the makefile we used to have to support this is no longer there. This diff seems to be the culprit. I can work around it for now, but FYI this was useful!

Wed, Feb 21, 8:59 AM
bgamari created D4432: boot: Create GNUmakefiles for libraries.
Wed, Feb 21, 8:59 AM
bgamari accepted D4431: Don't use ld.gold when building libraries for GHCi.

This will do.

Wed, Feb 21, 8:53 AM

Tue, Feb 20

bgamari committed rGHC792834bcd4b3: Improve unboxed sum documentation (authored by dfeuer).
Improve unboxed sum documentation
Tue, Feb 20, 9:31 PM
bgamari committed rGHC99d3e39f1d82: Bump hadrian submodule (authored by RyanGlScott).
Bump hadrian submodule
Tue, Feb 20, 9:30 PM
bgamari committed rGHCabfe10487d2d: Revert "Move `iserv` into `utils` and change package name (authored by bgamari).
Revert "Move `iserv` into `utils` and change package name
Tue, Feb 20, 12:28 PM
bgamari added a reverting commit for rGHC7c173b9043f7: Move `iserv` into `utils` and change package name from `iserv-bin` to `iserv`: rGHCabfe10487d2d: Revert "Move `iserv` into `utils` and change package name.
Tue, Feb 20, 12:28 PM
bgamari added inline comments to D4417: CmmPipeline: add a second pass of CmmCommonBlockElim.
Tue, Feb 20, 12:28 PM
bgamari added a comment to D4377: Move `iserv` into `utils` and change package name from `iserv-bin` to `iserv`.

@angerman, I hope you don't mind if I revert this for the moment so we can try again to commit a cleaner version and work out the Hadrian backporting details.

Tue, Feb 20, 12:28 PM
bgamari added a reviewer for D4388: Make cost centre symbol names deterministic.: simonmar.
Tue, Feb 20, 12:28 PM
bgamari added a comment to D4377: Move `iserv` into `utils` and change package name from `iserv-bin` to `iserv`.

Also, why does libraries/libiserv/src/Main.hs exist?

Tue, Feb 20, 12:27 PM
bgamari raised a concern with rGHC7c173b9043f7: Move `iserv` into `utils` and change package name from `iserv-bin` to `iserv`.

See my comments on D4377.

Tue, Feb 20, 12:27 PM
bgamari added a comment to D4377: Move `iserv` into `utils` and change package name from `iserv-bin` to `iserv`.

Hmm, this is rather problematic from the perspective of the stable branch as it requires changes to Hadrian. It looks like we will either need to cut a ghc-8.4 branch for Hadrian (and backport commits from master as appropriate) or cherry-pick this patch to the GHC ghc-8.4 branch to avoid divergence between stable and master.

Tue, Feb 20, 12:27 PM
bgamari accepted D4428: RTS: Remember to free some pointers.
Tue, Feb 20, 10:40 AM
bgamari accepted D4429: Introduce the flag -dsuppress-timestamps to avoid timestamps in dumps..

Indeed, these timestamps have annoyed me in the past as well.

Tue, Feb 20, 10:40 AM
bgamari added inline comments to D4428: RTS: Remember to free some pointers.
Tue, Feb 20, 10:40 AM

Mon, Feb 19

bgamari added inline comments to D4420: users-guide: Move discussion MAX_PATH out of release notes.
Mon, Feb 19, 11:57 PM
bgamari committed rGHC81a5e05d376c: circleci: Skip performance tests (authored by bgamari).
circleci: Skip performance tests
Mon, Feb 19, 11:36 PM
bgamari committed rGHC517c19409506: Document missing dataToTag# . tagToEnum# rule (authored by dfeuer).
Document missing dataToTag# . tagToEnum# rule
Mon, Feb 19, 10:57 PM
bgamari closed D4375: Document missing dataToTag# . tagToEnum# rule.
Mon, Feb 19, 10:57 PM
bgamari committed rGHCfe98cd7538ce: Combine the CoreAlts with the most common RHS (authored by sjakobi).
Combine the CoreAlts with the most common RHS
Mon, Feb 19, 10:57 PM
bgamari closed D4419: Combine the CoreAlts with the most common RHS.
Mon, Feb 19, 10:57 PM
bgamari planned changes to D3861: Allow void arguments to be marshallable.

I need to have another look at this.

Mon, Feb 19, 10:49 PM
bgamari accepted D4375: Document missing dataToTag# . tagToEnum# rule.
Mon, Feb 19, 10:49 PM
bgamari added a comment to D4419: Combine the CoreAlts with the most common RHS.

In this build I just so break the upper max_bytes_used limit for T1969: 15.9% on a 15% limit.

Maybe it would be better if I'd move the most-common-RHS code into -O2!?

Mon, Feb 19, 10:49 PM
bgamari accepted D4426: driver/utils/dynwrapper.c: Remove unused variable.

Lovely, thanks!

Mon, Feb 19, 10:49 PM
bgamari added inline comments to D4428: RTS: Remember to free some pointers.
Mon, Feb 19, 10:49 PM
bgamari added a comment to D4427: RTS: Remove unused retainer schemes.

Indeed I would be rather surprised if these weren't bitrotted.

Mon, Feb 19, 10:49 PM
bgamari added a comment to D4385: Performance improvements based on Trac #11735 and #14683..

But do let me know if I've misunderstood; the last comment on D4394 is a bit ambiguous.

Mon, Feb 19, 10:49 PM
bgamari added a comment to D4394: Caching coercion roles in NthCo and coercionKindsRole refactoring (#11735).

What is the status of this, @tdammers?

Mon, Feb 19, 10:49 PM
bgamari abandoned D4385: Performance improvements based on Trac #11735 and #14683..

Alright, it looks like this should be closed in favor of D4394.

Mon, Feb 19, 10:49 PM
bgamari committed rGHCeb2daa2b6a83: Change how includes for input file directory works (authored by Phyx).
Change how includes for input file directory works
Mon, Feb 19, 10:14 PM
bgamari closed D4080: Change how includes for input file directory works.
Mon, Feb 19, 10:13 PM
bgamari committed rGHC71294f30fa20: testsuite: Bump allocations for T1969 and T5837 (authored by bgamari).
testsuite: Bump allocations for T1969 and T5837
Mon, Feb 19, 9:22 PM
bgamari accepted D4370: Slight refactor of stock deriving internals.

Looks good to me!

Mon, Feb 19, 8:36 PM
bgamari added a comment to D4422: DynFlags: Support British spelling of GeneralisedNewtypeDeriving.

Based on the coding conventions, shouldn't we rename the extension LangExt.GeneralisedNewtypeDeriving?

Mon, Feb 19, 8:36 PM
bgamari accepted D4423: Don't tick floated top-level primitive strings.

As a side note, I don't know where we guarantee that the string literals get floated to the very top. I think that's the only kind of floating that the simplifier does, but I couldn't find any comment on that.

Mon, Feb 19, 8:36 PM
bgamari added a comment to D4423: Don't tick floated top-level primitive strings.

Thank you for doing this, @niteria!

Mon, Feb 19, 7:50 PM
bgamari added inline comments to D4424: Don't inline top-level primitive string literals.
Mon, Feb 19, 7:50 PM
bgamari created D4425: [WIP] circleci: First attempt at bringing up 32-bit build environment.
Mon, Feb 19, 7:47 PM
bgamari committed rGHC2cb19b472ff4: Bump text submodule to 1.2.3.0 (authored by bgamari).
Bump text submodule to 1.2.3.0
Mon, Feb 19, 3:49 PM
bgamari committed rGHC1ee5abcda16f: Bump haskeline submodule to 0.7.4.2 (authored by bgamari).
Bump haskeline submodule to 0.7.4.2
Mon, Feb 19, 3:49 PM
bgamari committed rGHCe26d774b0754: Bump parsec submodule to 0.3.13.0 (authored by bgamari).
Bump parsec submodule to 0.3.13.0
Mon, Feb 19, 3:49 PM
bgamari committed rGHCbd0af2a61df1: Bump primitive submodule to 0.6.3.0 (authored by bgamari).
Bump primitive submodule to 0.6.3.0
Mon, Feb 19, 3:49 PM
bgamari committed rGHC9ad3fa1ddd3d: Bump stm submodule to 2.4.5.0 (authored by bgamari).
Bump stm submodule to 2.4.5.0
Mon, Feb 19, 3:49 PM
bgamari committed rGHCd20524e715e9: Bump pretty submodule (authored by bgamari).
Bump pretty submodule
Mon, Feb 19, 3:48 PM
bgamari committed rGHCfc04a8f39661: Bump filepath submodule (authored by bgamari).
Bump filepath submodule
Mon, Feb 19, 3:48 PM
bgamari committed rGHC2382bbf86067: Bump process submodule (authored by bgamari).
Bump process submodule
Mon, Feb 19, 3:48 PM
bgamari committed rGHC9fc4608e5ed0: Bump haddock submodule again (authored by bgamari).
Bump haddock submodule again
Mon, Feb 19, 3:48 PM
bgamari committed rGHC0e5c82320894: Bump haddock submodule (authored by bgamari).
Bump haddock submodule
Mon, Feb 19, 2:07 PM
bgamari committed rGHCaf454c454a57: CBE: re-introduce bgamari's fixes (authored by michalt).
CBE: re-introduce bgamari's fixes
Mon, Feb 19, 2:07 PM
bgamari committed rGHCc21a8cc2210a: Implement stopgap solution for #14728 (authored by RyanGlScott).
Implement stopgap solution for #14728
Mon, Feb 19, 2:07 PM
bgamari committed rGHC01f69997550b: Build Haddocks with --quickjump (authored by bgamari).
Build Haddocks with --quickjump
Mon, Feb 19, 2:07 PM
bgamari committed rGHCff39d000d928: Bump text submodule to 1.2.3.0 (authored by bgamari).
Bump text submodule to 1.2.3.0
Mon, Feb 19, 2:07 PM
bgamari committed rGHC76bd578a4460: Bump haskeline submodule to 0.7.4.2 (authored by bgamari).
Bump haskeline submodule to 0.7.4.2
Mon, Feb 19, 2:07 PM
bgamari committed rGHC0bdf1b7af978: testsuite: Add test for #14768 (authored by bgamari).
testsuite: Add test for #14768
Mon, Feb 19, 2:07 PM
bgamari committed rGHC583e392a83c1: Collect CCs in CorePrep, including CCs in unfoldings (authored by osa1).
Collect CCs in CorePrep, including CCs in unfoldings
Mon, Feb 19, 2:07 PM
bgamari committed rGHCff78b94f7154: Remove unused extern cost centre collection (authored by osa1).
Remove unused extern cost centre collection
Mon, Feb 19, 2:07 PM
bgamari committed rGHC0f78f18129d2: Fix #14811 by wiring in $tcUnit# (authored by RyanGlScott).
Fix #14811 by wiring in $tcUnit#
Mon, Feb 19, 2:07 PM
bgamari committed rGHC43cd969d01cf: base: Fix changelog entry for openTempFile (authored by bgamari).
base: Fix changelog entry for openTempFile
Mon, Feb 19, 2:06 PM
bgamari committed rGHCee31f81f8bc6: Bump parsec submodule to 0.3.13.0 (authored by bgamari).
Bump parsec submodule to 0.3.13.0
Mon, Feb 19, 2:06 PM
bgamari added a comment to D4419: Combine the CoreAlts with the most common RHS.

Interesting idea!

Mon, Feb 19, 11:57 AM

Sun, Feb 18

bgamari created D4422: DynFlags: Support British spelling of GeneralisedNewtypeDeriving.
Sun, Feb 18, 8:44 PM
bgamari updated the Trac tickets for D4421: llvmGen: Pass -optlo flags last to opt.
Sun, Feb 18, 8:44 PM
bgamari created D4421: llvmGen: Pass -optlo flags last to opt.
Sun, Feb 18, 8:07 PM
bgamari added a comment to D4416: Remove MAX_PATH restrictions from RTS and I/O manager.

Yay! That being said, I'm really not pleased with the repetition here. I understand we can't use symlinks. Perhaps we could instead teach the build system to copy the sources into place?

Sun, Feb 18, 2:39 PM
bgamari updated the diff for D4420: users-guide: Move discussion MAX_PATH out of release notes.

Wibbles

Sun, Feb 18, 2:39 PM
bgamari added a dependent revision for D4416: Remove MAX_PATH restrictions from RTS and I/O manager: D4420: users-guide: Move discussion MAX_PATH out of release notes.
Sun, Feb 18, 2:31 PM
bgamari added a dependency for D4420: users-guide: Move discussion MAX_PATH out of release notes: D4416: Remove MAX_PATH restrictions from RTS and I/O manager.
Sun, Feb 18, 2:31 PM
bgamari created D4420: users-guide: Move discussion MAX_PATH out of release notes.
Sun, Feb 18, 2:31 PM
bgamari accepted D4415: Increase the amount of parallelism in circleci..

I suppose this is reasonable. However, doesn't this mean that we will oversubscribe users running CircleCI on their own forks that lack the higher resources limits that we enjoy?

Sun, Feb 18, 2:29 PM
bgamari committed rGHC5aba104267ff: CBE: re-introduce bgamari's fixes (authored by michalt).
CBE: re-introduce bgamari's fixes
Sun, Feb 18, 1:41 PM
bgamari committed rGHC5423035358cf: Implement stopgap solution for #14728 (authored by RyanGlScott).
Implement stopgap solution for #14728
Sun, Feb 18, 1:41 PM
bgamari committed rGHC2a7c428f6e1c: Build Haddocks with --quickjump (authored by bgamari).
Build Haddocks with --quickjump
Sun, Feb 18, 1:41 PM
bgamari committed rGHC85f13a1da0b8: Bump text submodule to 1.2.3.0 (authored by bgamari).
Bump text submodule to 1.2.3.0
Sun, Feb 18, 1:41 PM
bgamari committed rGHCbd7f179953ad: Bump haskeline submodule to 0.7.4.2 (authored by bgamari).
Bump haskeline submodule to 0.7.4.2
Sun, Feb 18, 1:41 PM
bgamari committed rGHC29e70fdb4517: testsuite: Add test for #14768 (authored by bgamari).
testsuite: Add test for #14768
Sun, Feb 18, 1:41 PM
bgamari committed rGHC301b99ea0fed: Collect CCs in CorePrep, including CCs in unfoldings (authored by osa1).
Collect CCs in CorePrep, including CCs in unfoldings
Sun, Feb 18, 1:41 PM
bgamari committed rGHCa66ddb5599a7: Fix #14811 by wiring in $tcUnit# (authored by RyanGlScott).
Fix #14811 by wiring in $tcUnit#
Sun, Feb 18, 1:41 PM
bgamari committed rGHCc8a02e29bee0: base: Fix changelog entry for openTempFile (authored by bgamari).
base: Fix changelog entry for openTempFile
Sun, Feb 18, 1:41 PM
bgamari committed rGHCc02655aae791: Bump parsec submodule to 0.3.13.0 (authored by bgamari).
Bump parsec submodule to 0.3.13.0
Sun, Feb 18, 1:41 PM
bgamari committed rGHCb0271df6e00c: Bump primitive submodule to 0.6.3.0 (authored by bgamari).
Bump primitive submodule to 0.6.3.0
Sun, Feb 18, 1:41 PM
bgamari closed D4368: Remove doubled words.
Sun, Feb 18, 12:11 PM
bgamari committed rGHC7f389a580f42: StgLint overhaul (authored by osa1).
StgLint overhaul
Sun, Feb 18, 11:05 AM
bgamari committed rGHC043466b9aac4: Rename the types in a GADT constructor in toposorted order (authored by RyanGlScott).
Rename the types in a GADT constructor in toposorted order
Sun, Feb 18, 11:05 AM
bgamari closed D4404: StgLint overhaul.
Sun, Feb 18, 11:04 AM
bgamari closed D4413: Rename the types in a GADT constructor in toposorted order.
Sun, Feb 18, 11:04 AM
bgamari committed rGHCfc33f8b31b9c: Improve error message for UNPACK/strictness annotations. (authored by sighingnow).
Improve error message for UNPACK/strictness annotations.
Sun, Feb 18, 11:04 AM
bgamari committed rGHCd924c17dfc8d: testsuite: Add newline to test output (authored by Douglas Wilson <douglas.wilson@gmail.com>).
testsuite: Add newline to test output
Sun, Feb 18, 11:04 AM
bgamari closed D4397: Improve error message for UNPACK/strictness annotations..
Sun, Feb 18, 11:04 AM
bgamari committed rGHC4e513bf758c3: CBE: re-introduce bgamari's fixes (authored by michalt).
CBE: re-introduce bgamari's fixes
Sun, Feb 18, 11:04 AM
bgamari closed D4389: testsuite: Add newline to test output.
Sun, Feb 18, 11:04 AM
bgamari committed rGHCc05529c2219d: myThreadId# is trivial; make it an inline primop (authored by simonmar).
myThreadId# is trivial; make it an inline primop
Sun, Feb 18, 11:04 AM
bgamari closed D4387: CBE: re-introduce bgamari's fixes.
Sun, Feb 18, 11:04 AM
bgamari closed D4381: myThreadId# is trivial; make it an inline primop.
Sun, Feb 18, 11:04 AM
bgamari committed rGHCccda48621021: Tidy up and consolidate canned CmmReg and CmmGlobals (authored by simonmar).
Tidy up and consolidate canned CmmReg and CmmGlobals
Sun, Feb 18, 11:04 AM
bgamari committed rGHCbfb90bcab844: Remove doubled words (authored by adamse).
Remove doubled words
Sun, Feb 18, 11:04 AM
bgamari closed D4380: Tidy up and consolidate canned CmmReg and CmmGlobals.
Sun, Feb 18, 11:04 AM
bgamari committed rGHC9ff4cce37376: Build Haddocks with --quickjump (authored by bgamari).
Build Haddocks with --quickjump
Sun, Feb 18, 11:04 AM