Feed Advanced Search

Today

bgamari committed rGHC578012be13eb: circleci: Build with in-tree GMP on Darwin (authored by bgamari).
circleci: Build with in-tree GMP on Darwin
Wed, Oct 17, 2:48 PM
bgamari committed rGHC46f2906d1c6e: Fix T15729 in master (authored by watashi).
Fix T15729 in master
Wed, Oct 17, 2:27 PM
bgamari closed D5235: Fix T15729 and T3001-2 in master.
Wed, Oct 17, 2:27 PM
bgamari committed rGHC17b60f18202c: testsuite: Fix non-canonical Monoid instance in T3001-2 (authored by bgamari).
testsuite: Fix non-canonical Monoid instance in T3001-2
Wed, Oct 17, 2:08 PM
bgamari accepted D5235: Fix T15729 and T3001-2 in master.

Thanks @watashi!

Wed, Oct 17, 2:06 PM
bgamari committed rGHCba5d0a4812a1: Fix #15761 by adding parens (authored by goldfire).
Fix #15761 by adding parens
Wed, Oct 17, 1:46 PM
bgamari committed rGHC334be779756a: Bump haddock submodule (authored by bgamari).
Bump haddock submodule
Wed, Oct 17, 1:46 PM
bgamari committed rGHC3e050064511c: Fail fast on pattern synonyms (authored by simonpj).
Fail fast on pattern synonyms
Wed, Oct 17, 1:46 PM
bgamari committed rGHCbf667f9d6b9c: Fix #15761 by adding parens (authored by goldfire).
Fix #15761 by adding parens
Wed, Oct 17, 1:45 PM
bgamari committed rGHCbc445eb908f4: fixup! Fail fast on pattern synonyms (authored by bgamari).
fixup! Fail fast on pattern synonyms
Wed, Oct 17, 1:45 PM
bgamari committed rGHC083366859b4a: Bump haddock submodule (authored by bgamari).
Bump haddock submodule
Wed, Oct 17, 1:45 PM
bgamari committed rGHCb4fdff48d399: Fail fast on pattern synonyms (authored by simonpj).
Fail fast on pattern synonyms
Wed, Oct 17, 1:45 PM
bgamari requested changes to D5230: rts/Linker.c: define the 'mmap_again' label only for x86_64.

I'm a bit lost. Is the problem that mmap_again is considered to be unused since the compiler has shown all gotos are unreachable?

Wed, Oct 17, 9:39 AM

Yesterday

bgamari committed rGHCf7b1ee966244: base: Fill in TBAs in changelog (authored by bgamari).
base: Fill in TBAs in changelog
Tue, Oct 16, 10:54 AM
bgamari committed rGHCb11126fc356a: Fix dataToTag# argument evaluation (authored by osa1).
Fix dataToTag# argument evaluation
Tue, Oct 16, 10:54 AM
bgamari updated subscribers of D4475: RFC: Add Int8# and Word8#.

@DavidEichmann will have a look at sorting this out in the coming weeks.

Tue, Oct 16, 10:48 AM
bgamari requested changes to D4679: RTS: Auto-size the allocation area depending on CPU cache size.

@sjakobi, what is your plan for this?

Tue, Oct 16, 8:36 AM

Mon, Oct 15

bgamari added a comment to D5226: dmdAnal: Move handling of datacon strictness to mkWWstr_one.

As noted in Trac #15969 (comment 80) this approach is a bit of a compromise since we still end up with conservative demand analysis results. However, it's perhaps good enough for now.

Trac #15969 doesn't exist. Which ticket did you have in mind Ben?

Mon, Oct 15, 9:18 PM
bgamari committed rGHC2e1df7c1556f: base: Fill in TBAs in changelog (authored by bgamari).
base: Fill in TBAs in changelog
Mon, Oct 15, 7:57 PM
bgamari committed rGHC172b00c1954d: Add a strict version of foldMap to Foldable (authored by sjakobi).
Add a strict version of foldMap to Foldable
Mon, Oct 15, 7:57 PM
bgamari closed D4924: Add a strict version of foldMap to Foldable.
Mon, Oct 15, 7:57 PM
bgamari committed rGHC45d5eff820ae: Update integer_gmp_gcdext documentation. (authored by DavidEichmann).
Update integer_gmp_gcdext documentation.
Mon, Oct 15, 7:57 PM
bgamari closed D5091: Update integer_gmp_gcdext documentation..
Mon, Oct 15, 7:57 PM
bgamari committed rGHC45ed4619fd5c: Fix BLACKHOLE inspection in RtClosureInspect (authored by osa1).
Fix BLACKHOLE inspection in RtClosureInspect
Mon, Oct 15, 7:57 PM
bgamari closed D5179: Fix BLACKHOLE inspection in RtClosureInspect.
Mon, Oct 15, 7:57 PM
bgamari committed rGHC8306141397d6: Allocate bss section within proper range of other sections (authored by watashi).
Allocate bss section within proper range of other sections
Mon, Oct 15, 7:57 PM
bgamari closed D5219: Allocate bss section within proper range of other sections.
Mon, Oct 15, 7:57 PM
bgamari committed rGHC104599f3f157: Add a RTS option -xp to load PIC object anywhere in address space (authored by watashi).
Add a RTS option -xp to load PIC object anywhere in address space
Mon, Oct 15, 7:56 PM
bgamari closed D5195: Add a RTS option -xp to load PIC object anywhere in address space.
Mon, Oct 15, 7:56 PM
bgamari committed rGHC165d3d5ddaec: Enable -Wcompat=error in the testsuite (authored by int-index).
Enable -Wcompat=error in the testsuite
Mon, Oct 15, 7:56 PM
bgamari closed D5200: Enable -Wcompat=error in the testsuite.
Mon, Oct 15, 7:56 PM
bgamari committed rGHC058c2813d882: ghc-heap: Fix writing closures on big endian (authored by trommler).
ghc-heap: Fix writing closures on big endian
Mon, Oct 15, 7:56 PM
bgamari closed D5212: ghc-heap: Fix writing closures on big endian.
Mon, Oct 15, 7:56 PM
bgamari committed rGHC95ec7c88c722: Generate correct relocation for external cost centre (authored by watashi).
Generate correct relocation for external cost centre
Mon, Oct 15, 5:42 PM
bgamari closed D5214: Generate correct relocation for external cost centre.
Mon, Oct 15, 5:42 PM
bgamari committed rGHC02b2116e4583: Fix #15738 by defining (and using) parenthesizeHsContext (authored by RyanGlScott).
Fix #15738 by defining (and using) parenthesizeHsContext
Mon, Oct 15, 5:42 PM
bgamari closed D5222: Fix #15738 by defining (and using) parenthesizeHsContext.
Mon, Oct 15, 5:41 PM
bgamari committed rGHCc5b477c29127: Fix cardinality change of fields in addDataConStrictness (authored by osa1).
Fix cardinality change of fields in addDataConStrictness
Mon, Oct 15, 5:41 PM
bgamari closed D5225: Fix cardinality change of fields in addDataConStrictness.
Mon, Oct 15, 5:41 PM
bgamari committed rGHC26e81e902816: Fix #12430 by expanding type synonyms in injTyVarsOfType (authored by RyanGlScott).
Fix #12430 by expanding type synonyms in injTyVarsOfType
Mon, Oct 15, 5:41 PM
bgamari closed D5228: Fix #12430 by expanding type synonyms in injTyVarsOfType.
Mon, Oct 15, 5:41 PM
bgamari committed rGHC0b0cb484eb0b: Surprising error message with bang pattern (authored by v0d1ch).
Surprising error message with bang pattern
Mon, Oct 15, 4:44 PM
bgamari closed D5040: Surprising error message with bang pattern.
Mon, Oct 15, 4:44 PM
bgamari committed rGHC846fe90464a1: Typeable: Only render saturated tuple types with tuple syntax (authored by bgamari).
Typeable: Only render saturated tuple types with tuple syntax
Mon, Oct 15, 4:44 PM
bgamari closed D5080: Typeable: Only render saturated tuple types with tuple syntax.
Mon, Oct 15, 4:44 PM
bgamari committed rGHCa816ac48b01b: Cleanup boot and validate (authored by monoidal).
Cleanup boot and validate
Mon, Oct 15, 4:44 PM
bgamari closed D5129: Cleanup boot and validate.
Mon, Oct 15, 4:44 PM
bgamari committed rGHC01c3d00a4ef4: Fix plugin tests requirements (authored by Phyx).
Fix plugin tests requirements
Mon, Oct 15, 4:44 PM
bgamari closed D5174: Fix plugin tests requirements.
Mon, Oct 15, 4:44 PM
bgamari committed rGHC58dffa0aa4c2: Deprecate -fllvm-pass-vectors-in-regs (authored by bgamari).
Deprecate -fllvm-pass-vectors-in-regs
Mon, Oct 15, 4:44 PM
bgamari closed D5193: Deprecate -fllvm-pass-vectors-in-regs.
Mon, Oct 15, 4:44 PM
bgamari requested changes to D4742: Unpack and simplify QSem.

@dfeuer, what is the status of this? It's not clear that there was ever any performance testing of this done.

Mon, Oct 15, 1:03 PM
bgamari requested changes to D5036: [TTG: Handling Source Locations] Foundation and Pat.

What is the plan for this, @shayan-najd? I agree that we will really need to find a way to break this up a bit if we want meaningful review.

Mon, Oct 15, 12:47 PM
bgamari accepted D5040: Surprising error message with bang pattern.

Thanks @v0d1ch1

Mon, Oct 15, 12:47 PM
bgamari accepted D5059: testsuite: Save performance metrics in git notes..

The patch itself looks good.

Mon, Oct 15, 12:39 PM
bgamari added a comment to D5059: testsuite: Save performance metrics in git notes..

@DavidEichmann, let's try to finish this up soon.

Mon, Oct 15, 12:38 PM
bgamari requested changes to D5073: Optimize RTS HashTable (Fixes #13165).

Gently pinging @AnthonySuper.

Mon, Oct 15, 12:38 PM
bgamari requested changes to D5110: Implement minimumOn, maximumOn to mirror sortOn (#15566).

This is something that needs to go through the Core Libraries Committee. @Garciat, do you think you could bring this up with them? Sorry for the tardy review.

Mon, Oct 15, 12:31 PM
bgamari accepted D5113: Improve diagnostic when using `make fast` in top directory.

Quite useful; this confused me in the past as well!

Mon, Oct 15, 12:30 PM
bgamari requested changes to D5123: Fix #15594 (--abi-hash with Backpack sometimes fails).

Thanks for reviewing @ppk!

Mon, Oct 15, 12:30 PM
bgamari updated the Trac tickets for D5123: Fix #15594 (--abi-hash with Backpack sometimes fails).
Mon, Oct 15, 12:29 PM
bgamari accepted D5129: Cleanup boot and validate.
Mon, Oct 15, 12:27 PM
bgamari requested changes to D5150: Fix #14880..
Mon, Oct 15, 12:26 PM
bgamari added a comment to D5150: Fix #14880..

@tdammers, what is the status of this? It seems to be failing CI.

Mon, Oct 15, 12:26 PM
bgamari requested changes to D5170: RTS linker: don't crash early when not finding extra DLL, most likely it's not needed.

As another NixOS user, I agree that there should be some way to disable this warning.

Mon, Oct 15, 12:25 PM
bgamari accepted D5174: Fix plugin tests requirements.

Thanks @Phyx!

Mon, Oct 15, 12:23 PM
bgamari accepted D5179: Fix BLACKHOLE inspection in RtClosureInspect.

This looks reasonable to @simonmar and me.

Mon, Oct 15, 12:22 PM
bgamari added a comment to D5198: TH 'TExp' docs + 'liftedTyped'.

@harpocrates, you might consider splitting this into two differentials: one for the documentation and the other for the proposed addition.

Mon, Oct 15, 12:11 PM
bgamari added a comment to D5208: Fix #14880..

Oh dear, I was a bit hasty in concluding that this was stale; it looks like I was wrong.

Mon, Oct 15, 12:05 PM
bgamari abandoned D5208: Fix #14880..

Bumping out of the review queue. This has been broken up into several pieces. See Trac #14880 for details.

Mon, Oct 15, 12:04 PM
bgamari added a comment to D5210: Add pprList method to Outputable for better String rendering.

@osa1, can you rebase this? I am wondering whether the haddock.base regression is real.

Mon, Oct 15, 12:03 PM
bgamari accepted D5222: Fix #15738 by defining (and using) parenthesizeHsContext.

Looks reasonable enough.

Mon, Oct 15, 12:01 PM
bgamari added a comment to D5226: dmdAnal: Move handling of datacon strictness to mkWWstr_one.

@simonpj, when you get a chance it would be nice to have a second set of eyes on the note.

Mon, Oct 15, 11:56 AM
bgamari retitled D5227: Add built-in syntax suggestions, and refactor to allow library use from Summary: Add built-in syntax suggestions, and refactor to allow library use to Add built-in syntax suggestions, and refactor to allow library use.
Mon, Oct 15, 11:45 AM
bgamari added inline comments to D5223: WIP: Support profiling in ghc-heap.
Mon, Oct 15, 11:45 AM
bgamari requested changes to D5221: Lower precedence for {-# UNPACK #-}.

Bumping out of the review queue until acceptance.

Mon, Oct 15, 11:43 AM
bgamari committed rGHC22e13c1525c1: Add missing paren (authored by bgamari).
Add missing paren
Mon, Oct 15, 11:08 AM
bgamari committed rGHC2cac5d406443: Set RELEASE=NO (authored by bgamari).
Set RELEASE=NO
Mon, Oct 15, 11:08 AM
bgamari committed rGHC3bed09b2efd3: Bump version (authored by bgamari).
Bump version
Mon, Oct 15, 11:08 AM
bgamari committed rGHC3ceffaaad71b: Release notes for GHC 8.4.4 (authored by bgamari).
Release notes for GHC 8.4.4
Mon, Oct 15, 11:08 AM

Sun, Oct 14

bgamari added inline comments to D5190: Multiple fixes / improvements for LLVM backend.
Sun, Oct 14, 3:47 AM
bgamari committed rGHCa22ee7050b61: Do not mark CoVars as dead in the occur-anal (authored by simonpj).
Do not mark CoVars as dead in the occur-anal
Sun, Oct 14, 1:13 AM
bgamari committed rGHCa04ecd7ba8c7: Fix for recover with -fexternal-interpreter (#15418) (authored by simonmar).
Fix for recover with -fexternal-interpreter (#15418)
Sun, Oct 14, 1:13 AM

Sat, Oct 13

bgamari added a comment to D4475: RFC: Add Int8# and Word8#.

We still support i386?

Sat, Oct 13, 5:30 PM
bgamari added a comment to D5226: dmdAnal: Move handling of datacon strictness to mkWWstr_one.

As noted in Trac #15969 (comment 80) this approach is a bit of a compromise since we still end up with conservative demand analysis results. However, it's perhaps good enough for now.

Sat, Oct 13, 5:00 PM
bgamari added inline comments to D5226: dmdAnal: Move handling of datacon strictness to mkWWstr_one.
Sat, Oct 13, 4:59 PM
bgamari created D5226: dmdAnal: Move handling of datacon strictness to mkWWstr_one.
Sat, Oct 13, 4:53 PM
bgamari committed rGHC97f6de1225a8: testsuite: Use /usr/bin/env instead of /bin/bash (authored by bgamari).
testsuite: Use /usr/bin/env instead of /bin/bash
Sat, Oct 13, 2:12 PM
bgamari committed rGHC2ca7ced93b41: Fix PrelRules.caseRules to account for out-of-range tags (authored by simonpj).
Fix PrelRules.caseRules to account for out-of-range tags
Sat, Oct 13, 2:12 PM
bgamari committed rGHC4bf6804e9163: testsuite: Fix hashbangs (authored by bgamari).
testsuite: Fix hashbangs
Sat, Oct 13, 2:12 PM
bgamari accepted D5225: Fix cardinality change of fields in addDataConStrictness.

Yes, looks reasonable.

Sat, Oct 13, 12:42 PM
bgamari committed rGHC51c447936ef3: GHCi should not filter instances involving cTuples (authored by harpocrates).
GHCi should not filter instances involving cTuples
Sat, Oct 13, 12:19 PM
bgamari committed rGHC4ab2f347b76d: Add -Wstar-is-type to the User's Guide (authored by int-index).
Add -Wstar-is-type to the User's Guide
Sat, Oct 13, 12:18 PM
bgamari committed rGHC10e3125d4f6e: Fix slop zeroing for AP_STACK eager blackholes in debug build (authored by osa1).
Fix slop zeroing for AP_STACK eager blackholes in debug build
Sat, Oct 13, 12:18 PM
bgamari committed rGHC523047768913: Compiler panic on invalid syntax (unterminated pragma) (authored by RolandSenn).
Compiler panic on invalid syntax (unterminated pragma)
Sat, Oct 13, 12:18 PM
bgamari committed rGHC377975e0609a: testsuite: Add test for #15053 (authored by bgamari).
testsuite: Add test for #15053
Sat, Oct 13, 12:18 PM
bgamari committed rGHC87266ea717de: Don't show constraint tuples in errors (#14907) (authored by harpocrates).
Don't show constraint tuples in errors (#14907)
Sat, Oct 13, 12:18 PM

Fri, Oct 12

bgamari committed rGHC5b2388b2cb65: Include -fwarn-star-is-type in -Wcompat (authored by int-index).
Include -fwarn-star-is-type in -Wcompat
Fri, Oct 12, 11:00 AM
bgamari closed D5044: Include -fwarn-star-is-type in -Wcompat.
Fri, Oct 12, 11:00 AM

Thu, Oct 11

bgamari committed rGHCce7a1c4ae4c9: Support builtin classes like KnownNat in backpack (authored by Piyush P Kurur <ppk@cse.iitk.ac.in>).
Support builtin classes like KnownNat in backpack
Thu, Oct 11, 6:25 PM