Feed Advanced Search

Apr 27 2018

KaneTW requested review of D4607: Fix NUMA support on Windows (#15049).
Apr 27 2018, 10:49 AM

Feb 1 2016

KaneTW accepted D1873: Make TypeError a newtype, add changelog entry.

LGTM

Feb 1 2016, 5:37 AM

Dec 11 2015

KaneTW abandoned D1585: Fix infix record field fixity (#11167)..

Superseded by D1600

Dec 11 2015, 11:06 AM

Dec 8 2015

KaneTW updated the diff for D1587: Improved data family export documentation.

Comma

Dec 8 2015, 10:35 AM
KaneTW updated the diff for D1587: Improved data family export documentation.

Reworded user's guide entry.
I tried to make clear that not all data instances/constructors are re-exported, but only those that are defined locally.

Dec 8 2015, 8:56 AM

Dec 7 2015

KaneTW retitled D1587: Improved data family export documentation from to Improved data family export documentation.
Dec 7 2015, 12:17 PM
KaneTW added a comment to D1585: Fix infix record field fixity (#11167)..
Dec 7 2015, 12:17 PM
KaneTW updated the diff for D1585: Fix infix record field fixity (#11167)..

Clarify T11167.hs test case

Dec 7 2015, 12:17 PM
KaneTW updated the diff for D1585: Fix infix record field fixity (#11167)..

Add same-fixity ambiguous test case

Dec 7 2015, 11:31 AM
KaneTW retitled D1585: Fix infix record field fixity (#11167). from to Fix infix record field fixity (#11167)..
Dec 7 2015, 11:31 AM

Dec 5 2015

KaneTW updated the diff for D1573: Re-export the data family when exporting a data instance without an export list.

Remove redundant isTyConName check.

Dec 5 2015, 10:34 AM
KaneTW added a comment to D1573: Re-export the data family when exporting a data instance without an export list.

Yeah, it's always a type or class (otherwise it'd be in Avail, not AvailTC). I'll remove it; didn't occur to me that it's a tautology.

Dec 5 2015, 10:23 AM
KaneTW updated the diff for D1573: Re-export the data family when exporting a data instance without an export list.

Added a release note entry and generalized fix_faminst

Dec 5 2015, 10:17 AM
KaneTW added a comment to D1573: Re-export the data family when exporting a data instance without an export list.

I was thinking that, but I wasn't entirely sure that's always the case. Can't think of a counterexample though.

Dec 5 2015, 9:41 AM
KaneTW updated the diff for D1573: Re-export the data family when exporting a data instance without an export list.

Error message wibbles (see trac)

Dec 5 2015, 5:22 AM
KaneTW retitled D1574: Fix broken linters when using python3 from to Fix broken linters when using python3.
Dec 5 2015, 12:11 AM
KaneTW updated the Trac tickets for D1573: Re-export the data family when exporting a data instance without an export list.
Dec 5 2015, 12:07 AM
KaneTW retitled D1573: Re-export the data family when exporting a data instance without an export list from to Re-export the data family when exporting a data instance without an export list.
Dec 5 2015, 12:06 AM

Oct 20 2015

KaneTW added a comment to D1329: Extended default rules now specialize Foldable, Traversable to [] (#10971).

Also note that once we decide on how to handle Trac #10990, doing default (Either) will either throw an error along the lines of "Either not an instance of one of [Num, Foldable, ...]" or have a well specified use-case (displaying specializations in GHCi).

Oct 20 2015, 2:40 PM
KaneTW updated the diff for D1329: Extended default rules now specialize Foldable, Traversable to [] (#10971).

Fix T10971a test.

Oct 20 2015, 12:20 PM
KaneTW added a comment to D1329: Extended default rules now specialize Foldable, Traversable to [] (#10971).

Oh, thanks. T10971b should pass, that's just intended so I don't mess something up. However, T10971a should fail; the main I put in by accident is preventing that. I'll remove it in a bit.

Oct 20 2015, 11:11 AM

Oct 17 2015

KaneTW updated the Trac tickets for D1329: Extended default rules now specialize Foldable, Traversable to [] (#10971).
Oct 17 2015, 1:25 PM

Oct 16 2015

KaneTW updated the diff for D1329: Extended default rules now specialize Foldable, Traversable to [] (#10971).

Expand implementation comments a little.

Oct 16 2015, 11:15 PM

Oct 15 2015

KaneTW retitled D1329: Extended default rules now specialize Foldable, Traversable to [] (#10971) from to Extended default rules now specialize Foldable, Traversable to [] (#10971).
Oct 15 2015, 10:55 PM

Oct 7 2015

KaneTW updated the diff for D1182: Implement improved error messages for ambiguous type variables (#10733).

Added goldfire's suggestions.

Oct 7 2015, 3:21 PM
KaneTW added a comment to D1182: Implement improved error messages for ambiguous type variables (#10733).

This has been stale for a while. Can someone take a look?

Oct 7 2015, 10:42 AM

Sep 24 2015

KaneTW updated the diff for D1182: Implement improved error messages for ambiguous type variables (#10733).

Error message wibbles.

Sep 24 2015, 6:47 AM
KaneTW updated the diff for D1182: Implement improved error messages for ambiguous type variables (#10733).

Adjust error message and explain when ambiguity should be highlighted

Sep 24 2015, 2:11 AM

Sep 23 2015

KaneTW added a comment to D1182: Implement improved error messages for ambiguous type variables (#10733).

I'm going to put the following note if that's sufficient/correct (can't submit a new patch yet as I haven't adjusted the tests and my battery's dying)

Sep 23 2015, 10:43 AM

Sep 16 2015

KaneTW added a comment to D1182: Implement improved error messages for ambiguous type variables (#10733).

That sounds good. I'll add a note and change the message then.

Sep 16 2015, 9:40 AM

Sep 15 2015

KaneTW added a comment to D1182: Implement improved error messages for ambiguous type variables (#10733).

I believe this already happens. The emphasized message is chosen when there are potential instances.

Sep 15 2015, 10:03 AM

Sep 8 2015

KaneTW added a comment to D1226: Workaround for #10826, forbid annotations when Safe Haskell safe mode is enabled..

@goldfire didn't manage to fix the two issues before the commit got pushed, but i'll take note for the future. Mostly saw ptext . sLit used everywhere, so I continued using it. Maybe make a lint rule that triggers on that when pushing a diff (Not sure if Phab's lint can do that).

Sep 8 2015, 12:16 PM

Sep 7 2015

KaneTW added a reviewer for D1226: Workaround for #10826, forbid annotations when Safe Haskell safe mode is enabled.: goldfire.
Sep 7 2015, 10:54 AM
KaneTW added a comment to D1226: Workaround for #10826, forbid annotations when Safe Haskell safe mode is enabled..

Note that I didn't check whether the compiler is inferring safety. So the following two modules
Test.hs:

module Test (hook) where
Sep 7 2015, 10:54 AM

Sep 6 2015

KaneTW updated the diff for D1226: Workaround for #10826, forbid annotations when Safe Haskell safe mode is enabled..

Fix stage 1 compilation with -Werror

Sep 6 2015, 6:10 PM
KaneTW retitled D1226: Workaround for #10826, forbid annotations when Safe Haskell safe mode is enabled. from to Workaround for #10826, forbid annotations when Safe Haskell safe mode is enabled..
Sep 6 2015, 5:57 PM

Sep 3 2015

KaneTW added a comment to D1182: Implement improved error messages for ambiguous type variables (#10733).

Jan's injective type families commit is causing tcfail220 to fail, but that's unrelated to this ticket.

Sep 3 2015, 1:10 AM
KaneTW updated the diff for D1182: Implement improved error messages for ambiguous type variables (#10733).

Restore tests that shouldn't have been reverted

Sep 3 2015, 12:23 AM
KaneTW added a comment to D1182: Implement improved error messages for ambiguous type variables (#10733).

This rebase got messed up something fierce. Next diff should fix it in a moment.

Sep 3 2015, 12:05 AM

Sep 2 2015

KaneTW updated the diff for D1182: Implement improved error messages for ambiguous type variables (#10733).
  • Merge properly (diff 4039 tests got swallowed)
Sep 2 2015, 11:58 PM
KaneTW updated the diff for D1182: Implement improved error messages for ambiguous type variables (#10733).
Sep 2 2015, 11:55 PM
KaneTW added a comment to D1182: Implement improved error messages for ambiguous type variables (#10733).

I eliminated one cause of incorrect "ambiguous type variable" warnings; when we have no unifiers and no givens, it doesn't matter that the type variable is ambiguous (i.e. a metavariable).

Sep 2 2015, 10:27 PM
KaneTW updated the diff for D1182: Implement improved error messages for ambiguous type variables (#10733).
  • Print old message when no unifiers and no givens exist
Sep 2 2015, 10:16 PM

Aug 29 2015

KaneTW added a comment to D1182: Implement improved error messages for ambiguous type variables (#10733).

You're right, at a cursory glance there are a few cases where the new message shows although it shouldn't (tcfail010 for example). I'll look through the rest.

Aug 29 2015, 5:40 PM

Aug 28 2015

KaneTW added a comment to D1176: Improve the error messages for class instance errors.

Sounds good.

Aug 28 2015, 7:03 AM

Aug 27 2015

KaneTW added a comment to D1176: Improve the error messages for class instance errors.

This seems to be orthogonal to my (D1182) changes. Would require a manual merge though.

Aug 27 2015, 7:24 PM
KaneTW retitled D1182: Implement improved error messages for ambiguous type variables (#10733) from to Implement improved error messages for ambiguous type variables (#10733).
Aug 27 2015, 6:36 PM

Jul 3 2015

KaneTW updated the diff for D864: Allow deferred type error warnings to be suppressed.

Rebased against master and merged commits into one

Jul 3 2015, 7:51 PM · GHC
KaneTW added a comment to D864: Allow deferred type error warnings to be suppressed.

I'll run a validate on my local machine but I'm not quite sure what happened there. It seems like the patch only got partially applied?

compiler/typecheck/TcErrors.hs:177:6: Warning:
15	 Defined but not used: type constructor or class `TypeErrorChoice'
16	
17	compiler/typecheck/TcErrors.hs:178:5: Warning:
18	 Defined but not used: data constructor `TypeError'
19	
20	compiler/typecheck/TcErrors.hs:179:5: Warning:
21	 Defined but not used: data constructor `TypeWarn'
22	
23	compiler/typecheck/TcErrors.hs:180:5: Warning:
24	 Defined but not used: data constructor `TypeDefer'
Jul 3 2015, 12:09 PM · GHC
KaneTW added a comment to D864: Allow deferred type error warnings to be suppressed.

That's weird, the previous commits validated fine and I only changed documentation. I'll take a look.

Jul 3 2015, 12:07 PM · GHC

Jun 27 2015

KaneTW added a comment to D864: Allow deferred type error warnings to be suppressed.

I fixed the issues Simon found.

Jun 27 2015, 12:13 AM · GHC
KaneTW updated the diff for D864: Allow deferred type error warnings to be suppressed.
  • Fixed documentation issues for deferred type error warnings
Jun 27 2015, 12:12 AM · GHC

Apr 24 2015

KaneTW retitled D866: Deferred type errors now throw TypeError (#10284) from to Deferred type errors now throw TypeError (#10284).
Apr 24 2015, 4:26 AM
KaneTW added a child revision for D864: Allow deferred type error warnings to be suppressed: D866: Deferred type errors now throw TypeError (#10284).
Apr 24 2015, 4:26 AM · GHC

Apr 23 2015

KaneTW updated the diff for D864: Allow deferred type error warnings to be suppressed.
Apr 23 2015, 8:09 PM · GHC

Apr 22 2015

KaneTW added a comment to D864: Allow deferred type error warnings to be suppressed.

Great! I submitted a small patch that fixes some typos in the comments I made (it was getting pretty late :) )

Apr 22 2015, 3:11 PM · GHC
KaneTW updated the diff for D864: Allow deferred type error warnings to be suppressed.
Apr 22 2015, 3:11 PM · GHC
KaneTW updated the diff for D864: Allow deferred type error warnings to be suppressed.
  • Fix maybeReportError logic in absence of -fno-warn-deferred-errors
Apr 22 2015, 2:13 AM · GHC
KaneTW updated the diff for D864: Allow deferred type error warnings to be suppressed.
  • Restore order specificed in note [Always warn with -fdefer-type-errors] (Trac #10283)
Apr 22 2015, 1:27 AM · GHC
KaneTW updated the diff for D864: Allow deferred type error warnings to be suppressed.
  • -fdefer-type-errors can now be suppressed (Trac #10283)
  • Fixes incorrect -w behavior in Trac #10283 implementation
Apr 22 2015, 12:55 AM · GHC
KaneTW retitled D864: Allow deferred type error warnings to be suppressed from to Allow deferred type error warnings to be suppressed.
Apr 22 2015, 12:05 AM · GHC