Apr 27 2018
Feb 1 2016
Dec 11 2015
Superseded by D1600
Dec 8 2015
Reworded user's guide entry.
I tried to make clear that not all data instances/constructors are re-exported, but only those that are defined locally.
Dec 7 2015
Clarify T11167.hs test case
Add same-fixity ambiguous test case
Dec 5 2015
Remove redundant isTyConName check.
Yeah, it's always a type or class (otherwise it'd be in Avail, not AvailTC). I'll remove it; didn't occur to me that it's a tautology.
Added a release note entry and generalized fix_faminst
I was thinking that, but I wasn't entirely sure that's always the case. Can't think of a counterexample though.
Error message wibbles (see trac)
Oct 20 2015
Also note that once we decide on how to handle Trac #10990, doing default (Either) will either throw an error along the lines of "Either not an instance of one of [Num, Foldable, ...]" or have a well specified use-case (displaying specializations in GHCi).
Fix T10971a test.
Oh, thanks. T10971b should pass, that's just intended so I don't mess something up. However, T10971a should fail; the main I put in by accident is preventing that. I'll remove it in a bit.
Oct 17 2015
Oct 16 2015
Expand implementation comments a little.
Oct 15 2015
Oct 7 2015
Added goldfire's suggestions.
This has been stale for a while. Can someone take a look?
Sep 24 2015
Error message wibbles.
Adjust error message and explain when ambiguity should be highlighted
Sep 23 2015
I'm going to put the following note if that's sufficient/correct (can't submit a new patch yet as I haven't adjusted the tests and my battery's dying)
Sep 16 2015
That sounds good. I'll add a note and change the message then.
Sep 15 2015
I believe this already happens. The emphasized message is chosen when there are potential instances.
Sep 8 2015
@goldfire didn't manage to fix the two issues before the commit got pushed, but i'll take note for the future. Mostly saw ptext . sLit used everywhere, so I continued using it. Maybe make a lint rule that triggers on that when pushing a diff (Not sure if Phab's lint can do that).
Sep 7 2015
Note that I didn't check whether the compiler is inferring safety. So the following two modules
module Test (hook) where
Sep 6 2015
Fix stage 1 compilation with -Werror
Sep 3 2015
Jan's injective type families commit is causing tcfail220 to fail, but that's unrelated to this ticket.
Restore tests that shouldn't have been reverted
This rebase got messed up something fierce. Next diff should fix it in a moment.
Sep 2 2015
- Merge properly (diff 4039 tests got swallowed)
- Merge with D1176
I eliminated one cause of incorrect "ambiguous type variable" warnings; when we have no unifiers and no givens, it doesn't matter that the type variable is ambiguous (i.e. a metavariable).
- Print old message when no unifiers and no givens exist
Aug 29 2015
You're right, at a cursory glance there are a few cases where the new message shows although it shouldn't (tcfail010 for example). I'll look through the rest.
Aug 28 2015
Aug 27 2015
This seems to be orthogonal to my (D1182) changes. Would require a manual merge though.
Jul 3 2015
Rebased against master and merged commits into one
I'll run a validate on my local machine but I'm not quite sure what happened there. It seems like the patch only got partially applied?
compiler/typecheck/TcErrors.hs:177:6: Warning: 15 Defined but not used: type constructor or class `TypeErrorChoice' 16 17 compiler/typecheck/TcErrors.hs:178:5: Warning: 18 Defined but not used: data constructor `TypeError' 19 20 compiler/typecheck/TcErrors.hs:179:5: Warning: 21 Defined but not used: data constructor `TypeWarn' 22 23 compiler/typecheck/TcErrors.hs:180:5: Warning: 24 Defined but not used: data constructor `TypeDefer'
That's weird, the previous commits validated fine and I only changed documentation. I'll take a look.
Jun 27 2015
I fixed the issues Simon found.
- Fixed documentation issues for deferred type error warnings
Apr 24 2015
Apr 23 2015
- Implemented simonpj's suggestions for Trac #10283
Apr 22 2015
Great! I submitted a small patch that fixes some typos in the comments I made (it was getting pretty late :) )
- Fix a typo in comments of Trac #10283 implementation
- Fix maybeReportError logic in absence of -fno-warn-deferred-errors
- Restore order specificed in note [Always warn with -fdefer-type-errors] (Trac #10283)