Feed Advanced Search

Oct 30 2015

adamgundry closed D1391: Disambiguate record selectors by type signature by committing rGHC0a16374109ad: Disambiguate record selectors by type signature.
Oct 30 2015, 9:15 AM
adamgundry updated the diff for D1391: Disambiguate record selectors by type signature.

Resolve conflict with Simon's lovely addUsedGRE changes

Oct 30 2015, 7:52 AM
adamgundry updated the diff for D1391: Disambiguate record selectors by type signature.

Rebase on latest HEAD (with record pattern synonyms), separate from OverloadedLabels

Oct 30 2015, 7:34 AM
adamgundry added a comment to D1391: Disambiguate record selectors by type signature.

Crumbs. The code is substantially LONGER than before. Why?

Still, it is at least modularly separated.

Oct 30 2015, 5:12 AM

Oct 29 2015

adamgundry updated the diff for D1391: Disambiguate record selectors by type signature.

Refactoring and minor bug fixes

  • Handle record selectors properly in Template Haskell
  • Refactor disambiguateRecordBinds and make errors more uniform
  • Handle non-fields appearing in updates
  • More refactoring and fixing of comments
  • Refactor to make lint happy
Oct 29 2015, 4:50 PM

Oct 28 2015

adamgundry retitled D1391: Disambiguate record selectors by type signature from to Disambiguate record selectors by type signature.
Oct 28 2015, 12:07 PM

Oct 22 2015

adamgundry updated the diff for D1331: Implement OverloadedLabels.
  • Tweak lexer to accept hash at the beginning of a line
  • Add OverloadedLabels to GHC-only extensions in T4437
Oct 22 2015, 3:34 PM

Oct 19 2015

adamgundry added a comment to D1152: Record Pattern Synonyms.

Would you like to give an example that illustrates the problem?

Oct 19 2015, 11:58 AM
adamgundry updated subscribers of D1331: Implement OverloadedLabels.

Thanks, will do.

Oct 19 2015, 7:10 AM

Oct 16 2015

adamgundry retitled D1331: Implement OverloadedLabels from to Implement OverloadedLabels.
Oct 16 2015, 11:54 AM
adamgundry committed rGHCb1884b0e62f6: Implement DuplicateRecordFields (authored by adamgundry).
Implement DuplicateRecordFields
Oct 16 2015, 10:31 AM
adamgundry closed D761: Implement DuplicateRecordFields by committing rGHCb1884b0e62f6: Implement DuplicateRecordFields.
Oct 16 2015, 10:31 AM
adamgundry committed rHADDOCK85b7ed6147c1: Roughly fix up haddock for DuplicateRecordFields changes (authored by adamgundry).
Roughly fix up haddock for DuplicateRecordFields changes
Oct 16 2015, 10:29 AM
adamgundry added inline comments to D761: Implement DuplicateRecordFields.
Oct 16 2015, 10:20 AM
adamgundry updated the diff for D761: Implement DuplicateRecordFields.

Bring up to date with master

Oct 16 2015, 8:07 AM
adamgundry committed rHADDOCK4ad0043d43e9: Merge remote-tracking branch 'github/ghc-head' into wip/orf-reboot (authored by adamgundry).
Merge remote-tracking branch 'github/ghc-head' into wip/orf-reboot
Oct 16 2015, 8:06 AM
adamgundry committed rGHC5a1b4f814f74: Merge remote-tracking branch 'origin/master' into wip/orf-reboot (authored by adamgundry).
Merge remote-tracking branch 'origin/master' into wip/orf-reboot
Oct 16 2015, 8:00 AM
adamgundry added a comment to D1152: Record Pattern Synonyms.

The bit I am worried about is the record selector generation. I don't know how this is implemented but if there class instances generated then there seems to be the possibility of generating orphan instances.

Oct 16 2015, 7:45 AM
adamgundry added a comment to D1152: Record Pattern Synonyms.

I am very scared of the rebase which is going to have to happen after D761 gets merged.

Oct 16 2015, 7:08 AM
adamgundry updated subscribers of D1152: Record Pattern Synonyms.
Oct 16 2015, 4:27 AM
adamgundry added a comment to D761: Implement DuplicateRecordFields.

This builds fine on Travis but not on Phab, I suspect because the diff needs to be updated to apply cleanly to the latest HEAD. Is it okay for me to go ahead and merge this? I'll resolve whatever conflicts there are and do a final validate before merging.

Oct 16 2015, 3:12 AM
adamgundry updated D761: Implement DuplicateRecordFields.
Oct 16 2015, 3:06 AM
adamgundry updated the diff for D761: Implement DuplicateRecordFields.

Changes following Simon's review

Oct 16 2015, 2:56 AM

Oct 15 2015

adamgundry committed rGHC6757950cdd8b: Remove a redundant import (authored by adamgundry).
Remove a redundant import
Oct 15 2015, 3:19 PM
adamgundry committed rHADDOCKf1befeaacc63: Get rid of erroneous DocNames for underscore when pretty-printing (authored by adamgundry).
Get rid of erroneous DocNames for underscore when pretty-printing
Oct 15 2015, 2:28 PM
adamgundry committed rGHC2d5d3cfcde74: Remove some redundant code in DataCon (authored by adamgundry).
Remove some redundant code in DataCon
Oct 15 2015, 2:08 PM
adamgundry committed rGHC1c1f6b2f539f: Fix test wibbles (authored by adamgundry).
Fix test wibbles
Oct 15 2015, 2:08 PM
adamgundry committed rGHC61127232be33: Update haddock submodule (authored by adamgundry).
Update haddock submodule
Oct 15 2015, 2:08 PM

Oct 12 2015

adamgundry committed rHADDOCK8474fd968d67: Merge remote-tracking branch 'github/ghc-head' into wip/orf-reboot (authored by adamgundry).
Merge remote-tracking branch 'github/ghc-head' into wip/orf-reboot
Oct 12 2015, 2:19 AM
adamgundry committed rGHC3a537459b874: Comment (authored by adamgundry).
Comment
Oct 12 2015, 1:40 AM
adamgundry committed rGHC22349a76a42b: Add test for deprecation warnings on non-duplicate fields (authored by adamgundry).
Add test for deprecation warnings on non-duplicate fields
Oct 12 2015, 1:40 AM
adamgundry committed rGHC2c1386d3fbda: Fix how addUsedRdrName is used to get correct deprecation warnings (authored by adamgundry).
Fix how addUsedRdrName is used to get correct deprecation warnings
Oct 12 2015, 1:40 AM
adamgundry committed rGHCdc084f73b456: Add a test that deprecation warnings cannot be attached to DRFs (authored by adamgundry).
Add a test that deprecation warnings cannot be attached to DRFs
Oct 12 2015, 1:40 AM
adamgundry committed rGHCd664c07350ae: Qualified import to fix build pre-BBP (authored by adamgundry).
Qualified import to fix build pre-BBP
Oct 12 2015, 1:40 AM
adamgundry committed rGHC46d2fc207da1: Don't addUsedRdrName for many ambiguous selectors at once (authored by adamgundry).
Don't addUsedRdrName for many ambiguous selectors at once
Oct 12 2015, 1:40 AM
adamgundry committed rGHC50c1b05e7b63: Get rid of isOverloadedRecFldGRE (authored by adamgundry).
Get rid of isOverloadedRecFldGRE
Oct 12 2015, 1:40 AM
adamgundry committed rGHCf7d5e5cbdbcc: Comments only (authored by adamgundry).
Comments only
Oct 12 2015, 1:40 AM
adamgundry committed rGHCbe204f0af9ef: Resurrect a failing report-unused-imports test (authored by adamgundry).
Resurrect a failing report-unused-imports test
Oct 12 2015, 1:40 AM
adamgundry committed rGHC6de6654b1537: Store FieldOccs in tcg_used_selectors so we get import usage right (authored by adamgundry).
Store FieldOccs in tcg_used_selectors so we get import usage right
Oct 12 2015, 1:40 AM
adamgundry committed rGHCc72cd58fe0cd: Clean up extendImportMap (authored by adamgundry).
Clean up extendImportMap
Oct 12 2015, 1:40 AM
adamgundry committed rGHCf23c72ec6a51: Comments only (authored by adamgundry).
Comments only
Oct 12 2015, 1:40 AM
adamgundry committed rGHC794ce7413949: Better plusParent (authored by adamgundry).
Better plusParent
Oct 12 2015, 1:40 AM
adamgundry committed rGHCdec2c1fc410b: Tidy up disambiguateRecordFields (authored by adamgundry).
Tidy up disambiguateRecordFields
Oct 12 2015, 1:40 AM
adamgundry committed rGHC7b3b949ededb: Refactoring RnNames (authored by adamgundry).
Refactoring RnNames
Oct 12 2015, 1:39 AM
adamgundry committed rGHC65f006cb8ecf: Further refactoring RnNames (authored by adamgundry).
Further refactoring RnNames
Oct 12 2015, 1:39 AM
adamgundry committed rGHC9531e9e17fe7: Revert "First stage of storing usage imports as GREs" (authored by adamgundry).
Revert "First stage of storing usage imports as GREs"
Oct 12 2015, 1:39 AM
adamgundry committed rGHC9f8465216491: Revert "Tidying up" (authored by adamgundry).
Revert "Tidying up"
Oct 12 2015, 1:39 AM
adamgundry added a reverting change for rGHC860e549ac228: First stage of storing usage imports as GREs: rGHC9531e9e17fe7: Revert "First stage of storing usage imports as GREs".
Oct 12 2015, 1:39 AM
adamgundry committed rGHCbaadd7816565: Merge remote-tracking branch 'origin/master' into wip/orf-reboot (authored by adamgundry).
Merge remote-tracking branch 'origin/master' into wip/orf-reboot
Oct 12 2015, 1:39 AM
adamgundry added a reverting change for rGHC73d88abac35c: Tidying up: rGHC9f8465216491: Revert "Tidying up".
Oct 12 2015, 1:39 AM
adamgundry committed rGHCa3373da46ac9: Remove confused debugging code (authored by adamgundry).
Remove confused debugging code
Oct 12 2015, 1:39 AM
adamgundry committed rGHC0071c36756c5: Revert "Use NameEnv instead of list for storing used GREs; not clear if this… (authored by adamgundry).
Revert "Use NameEnv instead of list for storing used GREs; not clear if this…
Oct 12 2015, 1:39 AM
adamgundry committed rGHCc936cfb36371: Remove unused ieNames (authored by adamgundry).
Remove unused ieNames
Oct 12 2015, 1:39 AM
adamgundry added a reverting change for rGHCd1e7a92e9d92: Use NameEnv instead of list for storing used GREs; not clear if this helps…: rGHC0071c36756c5: Revert "Use NameEnv instead of list for storing used GREs; not clear if this….
Oct 12 2015, 1:39 AM
adamgundry committed rGHCcd4fe2818df8: Clarify a corner case with an additional test (authored by adamgundry).
Clarify a corner case with an additional test
Oct 12 2015, 1:39 AM
adamgundry committed rGHCcc7e5e937e2d: Test wibbles (authored by adamgundry).
Test wibbles
Oct 12 2015, 1:39 AM
adamgundry committed rGHCef07c2cc5db6: Further refactoring of HsRecUpdField (authored by adamgundry).
Further refactoring of HsRecUpdField
Oct 12 2015, 1:39 AM
adamgundry committed rGHC6b31bfe01a6b: Horrible hacking to refactor HsRecField (authored by adamgundry).
Horrible hacking to refactor HsRecField
Oct 12 2015, 1:39 AM
adamgundry committed rGHCd1e7a92e9d92: Use NameEnv instead of list for storing used GREs; not clear if this helps… (authored by adamgundry).
Use NameEnv instead of list for storing used GREs; not clear if this helps…
Oct 12 2015, 1:39 AM
adamgundry committed rGHC9aeac1242bb4: Fix handling of IEs (authored by adamgundry).
Fix handling of IEs
Oct 12 2015, 1:39 AM
adamgundry committed rGHC73d88abac35c: Tidying up (authored by adamgundry).
Tidying up
Oct 12 2015, 1:39 AM
adamgundry committed rGHC4a01d40ef240: Radically simplify ChildName and IE-related things (authored by adamgundry).
Radically simplify ChildName and IE-related things
Oct 12 2015, 1:39 AM
adamgundry committed rGHC860e549ac228: First stage of storing usage imports as GREs (authored by adamgundry).
First stage of storing usage imports as GREs
Oct 12 2015, 1:39 AM

Jul 24 2015

adamgundry committed rGHC9d13a83806bc: As if by magic, many AvailFields-related types disappear (authored by adamgundry).
As if by magic, many AvailFields-related types disappear
Jul 24 2015, 11:41 AM
adamgundry committed rGHCdeaf8f18a4cd: Comments only (authored by adamgundry).
Comments only
Jul 24 2015, 11:41 AM
adamgundry committed rGHCaaa16edab72d: Get rid of redundant getDFunHsTypeKey (authored by adamgundry).
Get rid of redundant getDFunHsTypeKey
Jul 24 2015, 11:41 AM
adamgundry committed rGHC6ebd54855c21: Merge remote-tracking branch 'origin/master' into wip/orf-reboot (authored by adamgundry).
Merge remote-tracking branch 'origin/master' into wip/orf-reboot
Jul 24 2015, 11:41 AM

Jul 23 2015

adamgundry planned changes to D761: Implement DuplicateRecordFields.
Jul 23 2015, 6:02 AM

Jul 20 2015

adamgundry added a comment to D761: Implement DuplicateRecordFields.

I've made the change to DuplicateRecordFields.

Jul 20 2015, 2:57 AM

Jul 16 2015

adamgundry retitled D761: Implement DuplicateRecordFields from Implement AllowDuplicateRecordFields to Implement DuplicateRecordFields.
Jul 16 2015, 3:55 AM
adamgundry updated the diff for D761: Implement DuplicateRecordFields.

Squash changes into one commit on top of master

Jul 16 2015, 2:51 AM
adamgundry committed rGHC25f45c471276: Drop the Allow to leave DuplicateRecordFields (authored by adamgundry).
Drop the Allow to leave DuplicateRecordFields
Jul 16 2015, 2:48 AM
adamgundry committed rGHC1b0d5b380e2d: Merge remote-tracking branch 'origin/master' into wip/orf-reboot (authored by adamgundry).
Merge remote-tracking branch 'origin/master' into wip/orf-reboot
Jul 16 2015, 2:48 AM
adamgundry accepted D1048: Support wild cards in TH splices.

Excellent, many thanks to @thomasw for doing this and to @goldfire for the detailed review.

Jul 16 2015, 1:56 AM

Jul 15 2015

adamgundry added a comment to D761: Implement DuplicateRecordFields.

Hmm, I don't understand why the build is failing. Clearly addUsedSelector is used in RnEnv by lookupSubBndrOcc, which is itself exported. Have I done something silly in updating the diff?

Jul 15 2015, 2:29 AM

Jul 14 2015

adamgundry committed rHADDOCKeb0a6a5e9866: Roughly fix up for GHC API changes (authored by adamgundry).
Roughly fix up for GHC API changes
Jul 14 2015, 4:02 PM
adamgundry retitled D761: Implement DuplicateRecordFields from Implement part 1 of OverloadedRecordFields to Implement AllowDuplicateRecordFields.
Jul 14 2015, 4:02 PM
adamgundry updated the diff for D761: Implement DuplicateRecordFields.
  • Merge remote-tracking branch 'origin/master' into wip/orf-reboot
  • Get rid of extendRecordFieldEnv, do it in getLocalNonValBinders instead
  • Introduce FieldOcc for occurrences of fields in HsExpr
  • Use FieldOcc for ConDeclField names; hsLTyClDeclBinders et al become a bit nicer
  • Simplify hsLTyClDeclBinders still further
  • Use first datacon name instead of tycon name when mangling selector names
  • Get rid of dfid_rep_tycon and the whole assignInstDeclNames malarkey
  • Fix silly bug in ifaceConDeclFields for empty data types
  • Big refactoring to distinguish HsRecField from HsRecUpdField
  • Do not store (lexical) parents in hsRecUpdFieldSel
  • Extra tests for odd corner cases
  • Merge branch 'wip/orf-reboot' of git://git.haskell.org/ghc into wip/orf-reboot
  • Use a map when renaming ConDeclFields
  • Do a global lookup when renaming fields in updates
  • Return FieldOccs from lookupOccRn_overloaded
  • Store just selector Name in FieldOcc, not FieldLbl
  • Make parser report use of .. in record updates
  • Fix unused imports/declarations/constraints and missing deriving Typeable
  • Use Maybe Name instead of Parent where that's what we mean
  • Update haddock submodule
  • Get rid of OverloadedRecordFields for now; add ADRF to T4437
  • Tweak test output for T7145b
Jul 14 2015, 4:00 PM
adamgundry committed rGHCe9aab5772724: Tweak test output for T7145b (authored by adamgundry).
Tweak test output for T7145b
Jul 14 2015, 3:55 PM
adamgundry committed rGHC5ea8a4239755: Get rid of OverloadedRecordFields for now; add ADRF to T4437 (authored by adamgundry).
Get rid of OverloadedRecordFields for now; add ADRF to T4437
Jul 14 2015, 3:55 PM
adamgundry committed rGHCaf108c62665e: Update haddock submodule (authored by adamgundry).
Update haddock submodule
Jul 14 2015, 3:55 PM
adamgundry committed rGHCac647b3d5307: Use Maybe Name instead of Parent where that's what we mean (authored by adamgundry).
Use Maybe Name instead of Parent where that's what we mean
Jul 14 2015, 3:55 PM
adamgundry committed rGHC2936eeeeeeec: Fix unused imports/declarations/constraints and missing deriving Typeable (authored by adamgundry).
Fix unused imports/declarations/constraints and missing deriving Typeable
Jul 14 2015, 3:54 PM
adamgundry committed rGHC653aee2163a3: Make parser report use of .. in record updates (authored by adamgundry).
Make parser report use of .. in record updates
Jul 14 2015, 3:54 PM
adamgundry committed rGHC7b12694f85ee: Store just selector Name in FieldOcc, not FieldLbl (authored by adamgundry).
Store just selector Name in FieldOcc, not FieldLbl
Jul 14 2015, 3:54 PM
adamgundry committed rGHCc874a8519c7c: Return FieldOccs from lookupOccRn_overloaded (authored by adamgundry).
Return FieldOccs from lookupOccRn_overloaded
Jul 14 2015, 3:54 PM
adamgundry committed rGHCf24192e3bcbe: Do a global lookup when renaming fields in updates (authored by adamgundry).
Do a global lookup when renaming fields in updates
Jul 14 2015, 3:54 PM
adamgundry committed rGHC4023d61a54a7: Use a map when renaming ConDeclFields (authored by adamgundry).
Use a map when renaming ConDeclFields
Jul 14 2015, 3:54 PM

Jul 7 2015

adamgundry committed rGHC4986d6a41036: Merge branch 'wip/orf-reboot' of git://git.haskell.org/ghc into wip/orf-reboot (authored by adamgundry).
Merge branch 'wip/orf-reboot' of git://git.haskell.org/ghc into wip/orf-reboot
Jul 7 2015, 10:21 AM
adamgundry committed rGHC094c9e1ca01c: Extra tests for odd corner cases (authored by adamgundry).
Extra tests for odd corner cases
Jul 7 2015, 10:21 AM
adamgundry committed rGHCaa0c512f6da0: Do not store (lexical) parents in hsRecUpdFieldSel (authored by adamgundry).
Do not store (lexical) parents in hsRecUpdFieldSel
Jul 7 2015, 10:21 AM
adamgundry committed rGHCf3bf2fa76bc6: Big refactoring to distinguish HsRecField from HsRecUpdField (authored by adamgundry).
Big refactoring to distinguish HsRecField from HsRecUpdField
Jul 7 2015, 10:20 AM
adamgundry committed rGHC23463995005a: Fix silly bug in ifaceConDeclFields for empty data types (authored by adamgundry).
Fix silly bug in ifaceConDeclFields for empty data types
Jul 7 2015, 10:20 AM
adamgundry committed rGHC45f91cb5d47b: Get rid of dfid_rep_tycon and the whole assignInstDeclNames malarkey (authored by adamgundry).
Get rid of dfid_rep_tycon and the whole assignInstDeclNames malarkey
Jul 7 2015, 10:20 AM
adamgundry committed rGHCeb8c8c8d7355: Use first datacon name instead of tycon name when mangling selector names (authored by adamgundry).
Use first datacon name instead of tycon name when mangling selector names
Jul 7 2015, 10:20 AM
adamgundry committed rGHC0cb7992fcbfa: Simplify hsLTyClDeclBinders still further (authored by adamgundry).
Simplify hsLTyClDeclBinders still further
Jul 7 2015, 10:20 AM
adamgundry committed rGHCb0c6061e0aa0: Use FieldOcc for ConDeclField names; hsLTyClDeclBinders et al become a bit nicer (authored by adamgundry).
Use FieldOcc for ConDeclField names; hsLTyClDeclBinders et al become a bit nicer
Jul 7 2015, 10:20 AM
adamgundry committed rGHCad5c18c9e79c: Introduce FieldOcc for occurrences of fields in HsExpr (authored by adamgundry).
Introduce FieldOcc for occurrences of fields in HsExpr
Jul 7 2015, 10:20 AM
adamgundry committed rGHC74835a498bc4: Get rid of extendRecordFieldEnv, do it in getLocalNonValBinders instead (authored by adamgundry).
Get rid of extendRecordFieldEnv, do it in getLocalNonValBinders instead
Jul 7 2015, 10:20 AM
adamgundry committed rGHC18bd41c9927d: Merge remote-tracking branch 'origin/master' into wip/orf-reboot (authored by adamgundry).
Merge remote-tracking branch 'origin/master' into wip/orf-reboot
Jul 7 2015, 10:20 AM