Feed Advanced Search

Nov 23 2015

dreixel added a comment to D493: Use TypeLits in the meta-data encoding of GHC.Generics.

Thanks for picking this up! I'm not surprised that the TH error is gone; this patch didn't change anything TH-related, I think it was just tripping on some unrelated bug which has been fixed in the meantime.

Nov 23 2015, 9:12 AM

Sep 27 2015

dreixel added a comment to D1239: Make GHC generics capable of handling unboxed types (#10868).

Have you considered adding one single datatype to the universe, like Rec0 but of a different kind (perhaps URec0 :: # -> *)? That way you can still address all unboxed cases with a single URec0 a instance. Alternatively, make Rec0 poly-kinded.

Sep 27 2015, 1:05 PM

Sep 12 2015

dreixel accepted D1239: Make GHC generics capable of handling unboxed types (#10868).

Looks good to me, thanks. Perhaps just worth adding somewhere that the reason why the new datatypes are introduced is that the kinds of the unlifted types prevent Generic instances being given to them.

Sep 12 2015, 11:32 AM

Aug 27 2015

dreixel added a comment to D493: Use TypeLits in the meta-data encoding of GHC.Generics.

I'm afraid not, at least not in the foreseeable future. I'd love it if someone were to pick it up, though!

Aug 27 2015, 2:34 PM

Aug 22 2015

dreixel accepted D1166: Make Generic (Proxy t) instance poly-kinded (fixes #10775).

Looks good to me too.

Aug 22 2015, 5:31 AM

Aug 5 2015

dreixel added a comment to D1081: fix DeriveGeneric generated types and instances to make it working with types with same names -- fixes #10487.

I was waiting for @ezyang to reply back on the changes after his comment.

Aug 5 2015, 12:13 PM

Jul 20 2015

dreixel added a comment to D1081: fix DeriveGeneric generated types and instances to make it working with types with same names -- fixes #10487.

I'm happy to review this next week, once I'm back from holidays.

Jul 20 2015, 10:03 AM

Jan 27 2015

dreixel accepted D631: Add packageName to GHC.Generics.Datatype.

Looks good to me.

Jan 27 2015, 12:29 PM

Jan 19 2015

dreixel committed rGHCd839493991e5: Make AutoDeriveTypeable work for associated datatypes (fix #9999) (authored by dreixel).
Make AutoDeriveTypeable work for associated datatypes (fix #9999)
Jan 19 2015, 7:43 AM

Nov 26 2014

dreixel added a comment to D493: Use TypeLits in the meta-data encoding of GHC.Generics.

Currently this diff panics when haddock runs on Language.Haskell.TH.Syntax. Removing all derive Generic clauses from that file makes it go through. Surprisingly, removing the NoInline constructor on line 1268 also makes the panic go away (though things fail later on due to a missing constructor).

Nov 26 2014, 7:12 AM

Nov 23 2014

dreixel added a comment to D493: Use TypeLits in the meta-data encoding of GHC.Generics.

Patch is rebased, but I don't really know how I can see exactly what failed...

Nov 23 2014, 3:11 PM
dreixel updated the diff for D493: Use TypeLits in the meta-data encoding of GHC.Generics.

Update the patch to the latest HEAD.

Nov 23 2014, 2:35 PM
dreixel committed rGHC950b5f9dc6ef: Use TypeLits in the meta-data encoding of GHC.Generics (authored by Jose Pedro Magalhaes <jpm@cs.ox.ac.uk>).
Use TypeLits in the meta-data encoding of GHC.Generics
Nov 23 2014, 11:53 AM

Nov 18 2014

dreixel abandoned D490: Use TypeLits in the meta-data encoding of GHC.Generics.

Superseded by D493.

Nov 18 2014, 11:11 AM · GHC
dreixel retitled D493: Use TypeLits in the meta-data encoding of GHC.Generics from to Use TypeLits in the meta-data encoding of GHC.Generics.
Nov 18 2014, 11:09 AM
dreixel set the repository for D490: Use TypeLits in the meta-data encoding of GHC.Generics to rGHC Glasgow Haskell Compiler.
Nov 18 2014, 9:05 AM · GHC
dreixel added reviewers for D490: Use TypeLits in the meta-data encoding of GHC.Generics: austin, hvr, simonpj, goldfire, kosmikus.
Nov 18 2014, 9:04 AM · GHC
dreixel updated the diff for D476: Implement #5462 (deriving clause for arbitrary classes).
  • Fix two mistakes
Nov 18 2014, 5:11 AM
dreixel updated the diff for D476: Implement #5462 (deriving clause for arbitrary classes).

Whitespace changes, plus address some of Simon's remarks.

Nov 18 2014, 3:54 AM

Nov 14 2014

dreixel commandeered D476: Implement #5462 (deriving clause for arbitrary classes).
Nov 14 2014, 4:57 PM
dreixel committed rGHC6e5bac5fe077: Make DeriveAnyClass an expected GHC-only extension for now (authored by dreixel).
Make DeriveAnyClass an expected GHC-only extension for now
Nov 14 2014, 3:46 PM
dreixel committed rGHC1f3131eb5dd4: Mispelling (authored by dreixel).
Mispelling
Nov 14 2014, 3:46 PM
Jose Pedro Magalhaes <jpm@cs.ox.ac.uk> committed rGHC2ad051866b5e: Implement #5462 (deriving clause for arbitrary classes) (authored by dreixel).
Implement #5462 (deriving clause for arbitrary classes)
Nov 14 2014, 10:51 AM

Nov 5 2014

dreixel committed rGHCa8e5cd9352d4: Use MINIMAL to decide whether we can derive or not, and do not reject newtypes (authored by dreixel).
Use MINIMAL to decide whether we can derive or not, and do not reject newtypes
Nov 5 2014, 10:24 AM
dreixel committed rGHC7452b6a74ffd: Merge branch 'master' into wip/T5462 (authored by dreixel).
Merge branch 'master' into wip/T5462
Nov 5 2014, 10:24 AM

Nov 4 2014

dreixel committed rGHCa7f1bb90beb4: Merge branch 'master' into wip/T5462 (authored by dreixel).
Merge branch 'master' into wip/T5462
Nov 4 2014, 2:34 PM
dreixel committed rGHCd43b9bd62f54: Merge branch 'master' into wip/T5462 (authored by dreixel).
Merge branch 'master' into wip/T5462
Nov 4 2014, 2:34 PM
dreixel committed rGHCfcc4ad391432: Update test output (authored by dreixel).
Update test output
Nov 4 2014, 8:19 AM
dreixel committed rGHC8fa0e5c1a4de: Use TypeLits in the meta-data encoding of GHC.Generics (authored by dreixel).
Use TypeLits in the meta-data encoding of GHC.Generics
Nov 4 2014, 8:19 AM
dreixel committed rGHC3744afb5d91e: Merge branch 'master' into wip/GenericsMetaData (authored by dreixel).
Merge branch 'master' into wip/GenericsMetaData
Nov 4 2014, 5:43 AM
dreixel committed rGHCd8e899686d7f: Update test output (authored by dreixel).
Update test output
Nov 4 2014, 4:07 AM
dreixel committed rGHC8b2a3d51ca6c: Remove some left-over stuff (authored by dreixel).
Remove some left-over stuff
Nov 4 2014, 4:07 AM

Nov 3 2014

dreixel committed rGHC7dba4dc7eaba: Merge branch 'wip/new-flatten-skolems-Oct14' into wip/GenericsMetaData (authored by dreixel).
Merge branch 'wip/new-flatten-skolems-Oct14' into wip/GenericsMetaData
Nov 3 2014, 4:33 PM
dreixel committed rGHC50e56bc8867c: More work (authored by dreixel).
More work
Nov 3 2014, 4:32 PM

Oct 17 2014

dreixel accepted D311: Remove OldTypeable.

Thanks!

Oct 17 2014, 2:08 AM

Oct 11 2014

dreixel requested changes to D311: Remove OldTypeable.

Yes, I suggest we defer the removal of those classes until a later date.

Oct 11 2014, 1:53 PM