Feed Advanced Search

Feb 22 2017

austin added a comment to T297: Phabricator stopped sending email.

This should now be fixed. Apologies for the wait -- you got trapped by the Mailgun suppression filter, because apparently some emails bounced off your user account @acm.org -- I imagine the SMTP gateway might have been down at some point and you probably don't need many CC's in that time window to get blacklisted.

Feb 22 2017, 7:42 AM

Dec 17 2016

austin archived Arrow conversion to Symmetric Monoidal Categories.
Dec 17 2016, 3:04 PM
austin changed the edit policy for Arrow conversion to Symmetric Monoidal Categories.
Dec 17 2016, 3:04 PM
austin set the color for TestProject to Red.
Dec 17 2016, 3:01 PM
austin archived TestProject.
Dec 17 2016, 3:01 PM
austin archived Test.
Dec 17 2016, 3:00 PM
austin activated Auron.
Dec 17 2016, 2:59 PM
austin set the color for Auron to Red.
Dec 17 2016, 2:58 PM

Jul 11 2016

austin accepted D2398: hp2ps: fix invalid PostScript for names with parentheses.

Nice, thank you! This looks fine.

Jul 11 2016, 6:53 PM
austin accepted D2339: llvmGen: Take advantage of expected values in conditional branches.

LGTM

Jul 11 2016, 5:59 PM
austin accepted D2324: SysTools: Override TMPDIR when invoking gcc.

LGTM

Jul 11 2016, 5:58 PM
austin accepted D2397: Pretty: remove a harmful $! (#12227).

Wow, nice catch. I think we should definitely put the milestone on Trac #12227 for 8.0.2 for this one.

Jul 11 2016, 2:36 PM
austin updated the diff for D2352: Testing commit.
  • Test again
Jul 11 2016, 9:20 AM

Jul 8 2016

austin awarded D2386: DsExpr: Remove usage of concatFS in fingerprintName a Dat Boi token.
Jul 8 2016, 3:38 PM
austin accepted D2386: DsExpr: Remove usage of concatFS in fingerprintName.
Jul 8 2016, 3:38 PM
austin awarded D2384: FastString: Reduce allocations of concatFS a 100 token.
Jul 8 2016, 3:33 PM
austin accepted D2384: FastString: Reduce allocations of concatFS.
Jul 8 2016, 3:33 PM

Jul 4 2016

austin accepted D2381: CallArity: Use not . null instead of length > 0.
Jul 4 2016, 10:35 AM

Jun 21 2016

austin retitled D2352: Testing commit from to Testing commit.
Jun 21 2016, 9:33 AM

Jun 4 2016

austin added a comment to D2303: Add relocation type R_X86_64_REX_GOTPCRELX.

Have you tested this on a newer Arch system, like mentioned in Trac #12147?

Jun 4 2016, 5:44 PM
austin added a comment to D2301: Replace hand-written Bounded instances with derived ones.
In D2301#67046, @hvr wrote:

@austin what happened to that hallucinating parrot of approval? :-)

Jun 4 2016, 5:08 PM
austin accepted D2301: Replace hand-written Bounded instances with derived ones.

sealofapproval

Jun 4 2016, 4:16 PM

Jun 3 2016

austin awarded D2284: Add Bifoldable and Bitraversable to base a The World Burns token.
Jun 3 2016, 11:07 AM
austin accepted D2291: Derive instances in Data.Data.

parrot of approval

Jun 3 2016, 11:01 AM

Jun 1 2016

austin requested changes to D2291: Derive instances in Data.Data.

Okay, @rwbarton with the save as usual. But numeric/should_run/T10011.hs didn't catch this, which is clearly my fault somewhere, so we should look at that, too.

Jun 1 2016, 3:04 PM
austin accepted D2289: testsuite: Mark broken tests on powerpc64le.

Maybe there should just be a consolidated when_ppc64 conditional. But this otherwise looks fine to me since it just marks the Linker.c tests specifically; I'd wait on @hvr for any AIX followups.

Jun 1 2016, 2:59 PM
austin accepted D2290: Rename isPinnedByteArray# to isByteArrayPinned#.

LGTM

Jun 1 2016, 2:57 PM
austin requested changes to D2291: Derive instances in Data.Data.

Big win - but please put a changelog note about the constraint removal for Ratio - it can cause people warnings with the new redundant constraint machinery when people upgrade, so probably worth pointing out.

Jun 1 2016, 2:52 PM

May 30 2016

austin accepted D2281: Fix #12099: Remove bogus flags.

LGTM, and I think @thomie is right as well.

May 30 2016, 3:12 PM

May 29 2016

austin added a comment to D2274: compiler: move md5.h into a better place.
In D2274#65838, @hvr wrote:

why do we have another md5.h? I recently saw one in ./libraries/base/include/md5.h

May 29 2016, 6:49 PM
austin accepted D2278: integer-gmp: Make minusInteger more efficient.

noice

May 29 2016, 6:47 PM
austin added a comment to D1159: compiler/iface: compress .hi files.

I also use binary for -fexternal-interpreter, and I really want a faster replacement. I was going to look at Store, but if cbor is not far away maybe I should wait for that. Is it likely to be as fast as Store?

May 29 2016, 6:39 PM

May 27 2016

austin retitled D2274: compiler: move md5.h into a better place from to compiler: move md5.h into a better place.
May 27 2016, 1:52 PM
austin added a comment to D1159: compiler/iface: compress .hi files.

Do we think that incorporating binary-serialise-cbor into GHC is a viable option? Won't this significantly increase our dependency set? AFAICT it would add text, unordered-containers, hashable, if taken as-is. Are these dependencies just for defining instances? If so, what is going to become of them?

May 27 2016, 1:26 PM
austin accepted D2273: Clarify users' guide section on GeneralizedNewtypeDeriving.

love to wordsmith

May 27 2016, 1:06 PM
austin added a comment to D1159: compiler/iface: compress .hi files.
In D1159#65732, @austin wrote:

But can we switch to CBOR yet?

It's not released yet, and @duncan and I are still tuning it. I mean, it's definitely seen a lot of production use, we're just not committed to the initial API (yet).

I expect this patch will probably still give some additional benefit, even when combined with CBOR (a lot of the redundancy will be stripped, e.g. because Ints will be encoded much more densely), so I imagine the overall effect will be somewhere in the 50-70% range over what we're currently doing with the two of them combined. Just speculation.

I have a private branch with a tiny amount of work starting a transition of GHC to use binary-serialise-cbor, but it doesn't work.

May 27 2016, 12:56 PM
austin added a comment to D1159: compiler/iface: compress .hi files.

But can we switch to CBOR yet?

May 27 2016, 12:54 PM
austin accepted D2268: Added type family dependency to Data.Type.Bool.Not.

Should there be a test for this? Looks OK either way.

May 27 2016, 4:49 AM
austin retitled D2268: Added type family dependency to Data.Type.Bool.Not from Added type family dependency to Data.Type.Bool.Not, Trac #12057) to Added type family dependency to Data.Type.Bool.Not.
May 27 2016, 4:47 AM

May 26 2016

austin accepted D2265: Testsuite: don't use --interactive in Makefiles.

parrot

May 26 2016, 8:58 PM

May 24 2016

austin accepted D2257: Fix: #12084 deprecate old profiling flags.

Great job, thanks. We should honestly probably merge nofib into ghc.git at some point tbh...

May 24 2016, 3:25 PM
austin accepted D2059: Updates to handle new Cabal (specifically per-component macros and multiple libraries.).

Okay, so I don't want this to hang out forever (Hadrian will have to accommodate it but it'll eventually have to do that), and this change overall looks OK to me. @ezyang feel free to merge this (and point Cabal to an even newer commit if you think it's safe too).

May 24 2016, 12:34 PM
austin accepted D2262: Always use native-Haskell de/encoders for ASCII and latin1.

Yeah, I'm always vaguely scared of such changes because encoding is so complex, but I'll buy it since it's mostly fixing the test suite.

May 24 2016, 12:30 PM
austin added a comment to D2260: Remove 'deriving Typeable' statements.

That parrot looks quite sickly.

Other than that looks good to me.

May 24 2016, 8:40 AM

May 23 2016

austin accepted D2237: Runtime linker: Break m32 allocator out into its own file.

LGTM. I almost feel like you should make it even more robust: change the #if parts from:

May 23 2016, 10:24 PM
austin accepted D2260: Remove 'deriving Typeable' statements.

if it builds, ship it

May 23 2016, 10:17 PM
austin changed the image for Image Macro "parrot".
May 23 2016, 4:05 PM

May 21 2016

austin committed rGHCd9cb7a8a94da: compiler/iface: compress .hi files (authored by austin).
compiler/iface: compress .hi files
May 21 2016, 11:56 AM
austin closed D1159: compiler/iface: compress .hi files by committing rGHCd9cb7a8a94da: compiler/iface: compress .hi files.
May 21 2016, 11:56 AM
austin accepted D2252: Fix failing T12010.
May 21 2016, 11:34 AM

May 20 2016

austin committed rGHC43589f5cad09: testsuite: add CmmSwitchTest for 32-bit platforms (authored by avd).
testsuite: add CmmSwitchTest for 32-bit platforms
May 20 2016, 4:01 PM
austin closed D2226: Testsuite: add CmmSwitchTest for 32-bit platforms by committing rGHC43589f5cad09: testsuite: add CmmSwitchTest for 32-bit platforms (authored by avd).
May 20 2016, 4:01 PM
austin accepted D2246: Introduce BootUnfolding, set when unfolding is absent due to hs-boot file..

LGTM, I like code reduction.

May 20 2016, 3:25 PM
austin added inline comments to D2245: Enable checkProddableBlock on x86_64.
May 20 2016, 3:21 PM
austin accepted D2245: Enable checkProddableBlock on x86_64.

psyduck

May 20 2016, 3:21 PM

May 19 2016

austin updated the diff for D1159: compiler/iface: compress .hi files.
  • Remove some more dead code
May 19 2016, 10:25 PM
austin updated the diff for D1159: compiler/iface: compress .hi files.
  • Make encoding simpler
  • docs/relnotes: add blurb
May 19 2016, 10:22 PM
austin accepted D2226: Testsuite: add CmmSwitchTest for 32-bit platforms.

Minor wibble, but not a big deal. LGTM.

May 19 2016, 5:23 PM

May 17 2016

austin accepted D2230: CLabel: Catch #11155 during C-- pretty-printing.

thumbsup

May 17 2016, 10:33 AM

May 14 2016

austin accepted D2217: rts: Add isPinnedByteArray# primop.

LGTM.

May 14 2016, 4:44 PM

May 13 2016

austin accepted D2209: Support for noinline magic function..

Should this have a release note? I'll let you decide.

May 13 2016, 1:36 PM
austin accepted D2214: PPC NCG: Fix pretty printing of st[wd]ux instr..
May 13 2016, 11:52 AM

May 12 2016

austin accepted D2198: Fix a performance issue with -fprint-expanded-synonyms.

Nice, look at that reduced allocation footprint!

May 12 2016, 2:40 PM

May 10 2016

austin requested changes to D2185: Add support for unicode TH quotes (#11743).

Great, thanks for finishing this off! Can you just add a simple test? (Or maybe even modify/consolidate with the test from D2012?)

May 10 2016, 9:03 AM
austin planned changes to D1159: compiler/iface: compress .hi files.

Planning changes based on Ben's feedback.

May 10 2016, 8:54 AM

May 9 2016

austin accepted D2175: Allow putting Haddocks on derived instances.

I suppose the trouble here is that this would change the current meaning of some doc comments (since "the name of the foo" would currently be applied to the Foo tycon.

Indeed. I'm loathe to make a breaking change to the way Haddock works here, since that would affect the way comments are rendered for a good amount of data constructors in the wild. And in any case, this seems like an orthogonal concern - perhaps we should open a separate Trac issue for this?

May 9 2016, 2:33 PM

May 8 2016

austin accepted D2183: Use StgHalfWord instead of a CPP #if.
May 8 2016, 1:08 PM

May 4 2016

austin accepted D2171: base: Export runRW# from GHC.Exts.

I'll take it.

May 4 2016, 9:33 AM

Apr 30 2016

austin accepted D2161: Remove unused equivClassesByUniq.
Apr 30 2016, 1:06 PM

Apr 29 2016

austin committed rGHCb725fe0a8d2a: PPC NCG: Improve pointer de-tagging code (authored by trommler).
PPC NCG: Improve pointer de-tagging code
Apr 29 2016, 1:46 PM
austin closed D2093: PPC NCG: Improve pointer de-tagging code by committing rGHCb725fe0a8d2a: PPC NCG: Improve pointer de-tagging code (authored by trommler).
Apr 29 2016, 1:46 PM
austin added a comment to D1940: Add TH support for pattern synonyms (fixes #8761).

@bgamari Should I merge this into master before it needs rebasing?

Apr 29 2016, 12:48 PM
austin accepted D2148: Testsuite: make CLEANUP=1 the default (#9758).

I too would prefer this - and nice catch on the config simplication!

Apr 29 2016, 12:43 PM

Apr 28 2016

austin committed rGHC0fa1d075eb1e: testsuite: fix up T11223's Makefile (authored by austin).
testsuite: fix up T11223's Makefile
Apr 28 2016, 6:53 PM
austin closed D2158: testsuite: fix up T11223's Makefile by committing rGHC0fa1d075eb1e: testsuite: fix up T11223's Makefile.
Apr 28 2016, 6:53 PM
austin added a comment to D2158: testsuite: fix up T11223's Makefile.

The other mystery is why the hell mingw doesn't come with a CC alias, but that's for another day.

Apr 28 2016, 6:42 PM
austin added a comment to D2158: testsuite: fix up T11223's Makefile.
In D2158#62644, @thomie wrote:

Weird.

Apr 28 2016, 6:41 PM
austin updated D2158: testsuite: fix up T11223's Makefile.
Apr 28 2016, 5:19 PM
austin retitled D2158: testsuite: fix up T11223's Makefile from to testsuite: fix up T11223's Makefile.
Apr 28 2016, 5:18 PM

Apr 27 2016

austin accepted D2153: Fix path to the new build system, now called Hadrian..
Apr 27 2016, 7:29 PM
austin awarded D2153: Fix path to the new build system, now called Hadrian. a The World Burns token.
Apr 27 2016, 7:29 PM

Apr 25 2016

austin accepted D2132: testsuite: Add test for #11959.
Apr 25 2016, 1:48 PM
austin updated subscribers of D2137: RTS: delete BlockedOnGA* + dead code.
Apr 25 2016, 11:50 AM

Apr 18 2016

austin accepted D2120: relnotes: Add note about #11744 and workaround.

lgtm

Apr 18 2016, 4:19 PM
austin accepted D2125: rts: Don't use strndup.
Apr 18 2016, 4:17 PM

Apr 13 2016

austin accepted D2101: Resolve symlinks when attempting to find GHC's lib folder on Windows.

[flashbacks of writing NTFS code intensifies]

Apr 13 2016, 2:59 PM
austin added a comment to D2103: libdw: More precise version check.
In D2103#61413, @hvr wrote:

do we have a list of the dwfl_* symbols we depend on?

I could prepare one. Is there a nice way to check for a list of symbols?

Apr 13 2016, 2:54 PM
austin accepted D2106: utils: Provide CallStack to expectJust.
Apr 13 2016, 2:46 PM
austin accepted D2107: testsuite: Add T11824.
Apr 13 2016, 2:44 PM
austin awarded D2109: testsuite: Add test for #11827 a Evil Spooky Haunted Tree token.
Apr 13 2016, 2:42 PM
austin accepted D2109: testsuite: Add test for #11827.
Apr 13 2016, 2:42 PM
austin accepted D2110: Linker: Fix signedness mismatch.

Looks fine, but why not just change the local decl to an unsigned char? Maybe this isn't better. I don't know.

Apr 13 2016, 2:37 PM

Apr 6 2016

austin accepted D2086: Provide an optimized replicateM_ implementation #11795.

Looks good. Generally I'd ask for a comment here, but for hackers the W/W transform here should be fairly obvious, I guess (independent of the upstream issue @simonpj mentioned, Trac #1168, which I think you're right, we're best not to confuse too much).

Apr 6 2016, 10:56 PM
austin committed rGHCeda273bc0be4: runtime: replace hw.ncpu with hw.logicalcpu for Mac OS X (authored by ak3n).
runtime: replace hw.ncpu with hw.logicalcpu for Mac OS X
Apr 6 2016, 10:48 PM
austin closed D2082: runtime: replace hw.ncpu with hw.logicalcpu for Mac OS X (#8594) by committing rGHCeda273bc0be4: runtime: replace hw.ncpu with hw.logicalcpu for Mac OS X (authored by ak3n).
Apr 6 2016, 10:48 PM
austin requested changes to D2083: Allow one type signature for multiple pattern synonyms..

I think this is fine (and consistent with normal signatures), personally. But it needs a release note entry. (Yet this isn't going to go into 8.0, so you'll have to wait on D2066 or something.)

Apr 6 2016, 10:33 PM
austin accepted D2088: Export zonkEvBinds from TcHsSyn..

thumbsup

Apr 6 2016, 7:59 PM

Apr 5 2016

austin accepted D2082: runtime: replace hw.ncpu with hw.logicalcpu for Mac OS X (#8594).

I was the first person to implement support for -N on OS X (c.f. 97c4b27494addf) in some of my earliest patches to GHC. Good memories!

Apr 5 2016, 7:38 AM

Mar 30 2016

austin retitled D2066: docs: add skeleton 8.2.1 release notes from to docs: add skeleton 8.2.1 release notes.
Mar 30 2016, 3:23 PM
austin accepted D2058: Add -f(no-)version-macro to explicitly control macros..

This looks fine, but yeah, one more test would be nice.

Mar 30 2016, 3:00 PM