Feed Advanced Search

Fri, Jul 19

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCff996555b97f: Add module doc for Plugins. (authored by goldfire).
Add module doc for Plugins.
Fri, Jul 19, 5:12 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC69adb2532925: Fix #16870 by improving documentation (only) (authored by goldfire).
Fix #16870 by improving documentation (only)
Fri, Jul 19, 5:12 PM

Jun 10 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC0345b1b0f62c: Comments only: document newtypes' DataConWrapId (authored by goldfire).
Comments only: document newtypes' DataConWrapId
Jun 10 2019, 10:58 PM

Jun 9 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC1c7bb03db595: Comments only: document tcdDataCusk better. (authored by goldfire).
Comments only: document tcdDataCusk better.
Jun 9 2019, 5:52 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCa22e51ea6f7a: Fix #16517 by bumping the TcLevel for method sigs (authored by goldfire).
Fix #16517 by bumping the TcLevel for method sigs
Jun 9 2019, 5:46 PM

May 8 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC4c86187ccd49: Regression test for #16627. (authored by goldfire).
Regression test for #16627.
May 8 2019, 2:53 PM

Mar 4 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC4a4ae70f0900: Fix #16188 (authored by goldfire).
Fix #16188
Mar 4 2019, 1:06 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC2b90356d26b4: Fix #14729 by making the normaliser homogeneous (authored by goldfire).
Fix #14729 by making the normaliser homogeneous
Mar 4 2019, 1:05 PM
goldfire committed rGHC571e45d6b5e1: Add Simon and Richard as more CODEOWNERS (authored by goldfire).
Add Simon and Richard as more CODEOWNERS
Mar 4 2019, 1:02 PM

Jan 28 2019

goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.

This wasn't as bad as I was worried about, but I'm curious for Simon's thoughts on the design.

Jan 28 2019, 3:40 PM

Jan 27 2019

goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.

The user deserves a better error message here. I had thought that unifyKind would fail if you tried to unify TYPE 'LiftedRep and TYPE 'IntRep (with an error message along the lines on "Could not unify actual kind X with expected kind Y"). But this doesn't happen.

Jan 27 2019, 10:27 AM

Jan 26 2019

goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.
newtype T :: Type where
  MkT :: Int# -> T
Jan 26 2019, 8:56 AM

Jan 25 2019

goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.

One last suggestion below. Then I think we're ready to merge! :)

Jan 25 2019, 10:39 AM

Jan 24 2019

goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.

For data family instances, there are potentially three kinds that all get unified:

Jan 24 2019, 10:29 PM

Jan 16 2019

goldfire committed rGHC92b684ded87d: More minor comment improvements (authored by goldfire).
More minor comment improvements
Jan 16 2019, 12:24 AM
goldfire committed rGHC17bd16356615: Visible kind application (authored by mynguyen).
Visible kind application
Jan 16 2019, 12:24 AM
goldfire committed rGHC7fcd6808d731: Fix some typos, etc., in comments. (authored by goldfire).
Fix some typos, etc., in comments.
Jan 16 2019, 12:24 AM

Jan 11 2019

goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.

No, I don't think the new implementation of unravelFamInstPats is good: throwing away the cast might cause trouble later on. I still say we shouldn't ever see the case with the coercion, because kcConDecl won't let us. My guess is that you didn't see my earlier comment before posting yours.

Jan 11 2019, 3:30 PM
goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.

Let's take a step back:

Jan 11 2019, 2:55 PM

Jan 10 2019

goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.

That is, the data constructor has type Int# -> Foo and not type Int# -> Foo 'Red. I don't understand why this is the case, but I'm guessing there are good reasons for it.

Jan 10 2019, 1:42 PM

Jan 9 2019

goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.

Yes, -ddump-tc-trace sometimes hangs. My approach there is to add a bunch more traces (printing out strings only) to learn where the hang is. Then, you'll find some knot-tied something being printed out. Remove the printing. This is a bug that you have the opportunity to find and fix. :)

Jan 9 2019, 9:55 PM
goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.

The Typeable related panic shouldn't be hard to stop. I'm not sure offhand where the fix is (there already have to be a slew of checks before generating Typeable instances), but it sounds like Ryan knows. If you can't find it, ask and I'll take a closer look.

Jan 9 2019, 12:10 PM

Jan 7 2019

goldfire added inline comments to D4777: Implement the Unlifted Newtypes proposal.
Jan 7 2019, 11:00 AM

Jan 5 2019

goldfire added inline comments to D4777: Implement the Unlifted Newtypes proposal.
Jan 5 2019, 2:44 PM

Jan 4 2019

goldfire added inline comments to D4777: Implement the Unlifted Newtypes proposal.
Jan 4 2019, 9:21 AM
goldfire added inline comments to D4777: Implement the Unlifted Newtypes proposal.
Jan 4 2019, 9:05 AM

Jan 3 2019

goldfire added inline comments to D4777: Implement the Unlifted Newtypes proposal.
Jan 3 2019, 4:29 PM
goldfire requested changes to D4777: Implement the Unlifted Newtypes proposal.

I have done a thorough review. While I'm not surprised that this mostly works (the code is indeed pretty close), there are some corner cases worth investigating before merging.

Jan 3 2019, 3:37 PM

Dec 26 2018

goldfire added a comment to D5229: Visible kind application.

I've actually (locally) taken care of the line comments I've made here (which I wrote weeks ago but never posted -- sorry). This patch is ready to land. But I'm holding off because @bgamari said to wait until after the GitLab migration is complete. There is a lingering user-facing design and internal design issue: Trac #16082. We'll fix that in a separate patch.

Dec 26 2018, 7:11 PM

Dec 21 2018

goldfire accepted D5471: Be pickier about unsaturated synonyms in :kind.

Looks good to me.

Dec 21 2018, 8:52 PM

Dec 10 2018

goldfire added a comment to D5229: Visible kind application.

In its current form, does it validate? If so, let's merge it. 8.8 is nigh, and it's best to get this out the door. However, even after merging, we should continue to press forward with some of the tweaks suggested in this thread. My and I will discuss in person later this week. In the meantime, My, report if it validates; when it does, let's just pull the trigger.

Dec 10 2018, 11:14 PM
goldfire added a comment to D5408: Introduce ExpPatFrame.

We can get a precise answer by looking at the intersection of what checkPattern and checkExpr accept.

With commands, we need to look at the intersection of what checkPattern, checkExpr, and checkCommand accept. And when I get to unifying term/type parsers, also checkType (not currently defined).

Dec 10 2018, 8:14 PM
goldfire accepted D5435: Fix #16008 with a pinch of addConsistencyConstraints.

👍

Dec 10 2018, 3:21 PM
goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal.

OK. I've exhausted my time budget for this today, but I'll keep this in my queue. Sad to say, but I likely won't get to it for a few days.

Dec 10 2018, 1:06 PM
goldfire added a comment to D5229: Visible kind application.

I've taken my pass, but I skipped the following:

  • TH (Thanks, @RyanGlScott)
  • Parser (Thanks, @int-index)
  • Test output in partial-sigs, thinking that my suggested change to addTypeCtxt will take care of it.
Dec 10 2018, 1:00 PM
goldfire added inline comments to D5229: Visible kind application.
Dec 10 2018, 11:29 AM
goldfire added inline comments to D4777: Implement the Unlifted Newtypes proposal.
Dec 10 2018, 10:56 AM

Dec 9 2018

goldfire added inline comments to D4777: Implement the Unlifted Newtypes proposal.
Dec 9 2018, 11:07 PM
goldfire added a comment to D5408: Introduce ExpPatFrame.

I'm late to this conversation, and I haven't looked at the code -- only the conversation. Here are my thoughts:

Dec 9 2018, 11:04 PM
goldfire committed rGHC4773b4308203: Fix minor mistake in comment about data decls. (authored by goldfire).
Fix minor mistake in comment about data decls.
Dec 9 2018, 9:27 PM

Dec 3 2018

goldfire added a comment to D5401: Linear types: stepping stone.

I do intend to take a close look at this, but it likely won't happen until after classes end, in about 2 weeks.

Dec 3 2018, 8:29 PM
goldfire added a comment to D5397: Fix #12102/#15872 by removing outdated users' guide prose.
data T a = Eq a => MkT
Dec 3 2018, 8:25 PM

Nov 30 2018

goldfire added a comment to D5397: Fix #12102/#15872 by removing outdated users' guide prose.

They can appear in the kinds of promoted data constructors, say from GADTs with hand-written equality constraints.

Nov 30 2018, 3:35 PM
goldfire added a comment to D5397: Fix #12102/#15872 by removing outdated users' guide prose.

Looking at the relevant bits of the Monster Patch, it looks like these constraints are eliminated simply in the validity checker. That is, equality constraints in kinds still work, but now the user can't write them. By "work", I mean that tcInstTyBinders does the right thing. It looks like this from the code, but I'm just double-checking my understanding.

Nov 30 2018, 3:22 PM

Nov 24 2018

goldfire added inline comments to D5305: Towards using level numbers for generalisation.
Nov 24 2018, 10:25 PM
goldfire added inline comments to D5305: Towards using level numbers for generalisation.
Nov 24 2018, 1:26 PM
goldfire accepted D5375: Fix #15941 by only special-casing visible infix applications.

We might want to update this approach if/when Trac #12363 ever gets implemented.

Nov 24 2018, 12:06 PM

Nov 21 2018

goldfire added a comment to D5305: Towards using level numbers for generalisation.

Sharing comments for call Simon and I are having.

Nov 21 2018, 10:33 AM
goldfire updated the diff for D5305: Towards using level numbers for generalisation.

More from SPJ.

Nov 21 2018, 9:28 AM

Nov 19 2018

goldfire added a comment to D5305: Towards using level numbers for generalisation.

More later!

Nov 19 2018, 9:05 AM
goldfire updated the diff for D5305: Towards using level numbers for generalisation.

More updates from Simon.

Nov 19 2018, 8:28 AM

Nov 18 2018

goldfire accepted D5328: Fix #15852 by eta expanding data family instance RHSes, too.

LGTM.

Nov 18 2018, 11:00 PM

Nov 14 2018

goldfire added inline comments to D5328: Fix #15852 by eta expanding data family instance RHSes, too.
Nov 14 2018, 10:31 AM
goldfire added a comment to D5282: Print explicit foralls in type family eqns when appropriate.

make all binders in a representation TyCon into Specified, at birth

Nov 14 2018, 8:53 AM

Nov 12 2018

goldfire added inline comments to D5286: Run typed splices in the zonker.
Nov 12 2018, 3:06 PM
goldfire updated the diff for D5305: Towards using level numbers for generalisation.

More commits from Simon:

Nov 12 2018, 10:46 AM
goldfire requested changes to D5328: Fix #15852 by eta expanding data family instance RHSes, too.
Nov 12 2018, 8:54 AM
goldfire requested changes to D5286: Run typed splices in the zonker.

This looks like it works, but I think it can be refactored to be simpler. Thanks!

Nov 12 2018, 8:45 AM

Nov 7 2018

goldfire added a comment to D5305: Towards using level numbers for generalisation.

Out of time now; more later. (Note to self: I read through files before TcHsType, kcImplicitTKBndrs but not kcLHsQTyVars; also read through TcMType)

Nov 7 2018, 12:26 PM
goldfire created D5305: Towards using level numbers for generalisation.
Nov 7 2018, 11:36 AM
goldfire accepted D5283: Fix #15828, from `More explicit foralls`.

LGTM.

Nov 7 2018, 10:41 AM
goldfire added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Nov 7 2018, 10:35 AM

Nov 5 2018

goldfire committed rGHC5693ddd07103: Actually add test for #15859. (authored by goldfire).
Actually add test for #15859.
Nov 5 2018, 9:53 PM
goldfire committed rGHC72b82343b793: Fix #15859 by checking, not assuming, an ArgFlag (authored by goldfire).
Fix #15859 by checking, not assuming, an ArgFlag
Nov 5 2018, 12:53 PM
goldfire accepted D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.

Not from me. Ship it!

Nov 5 2018, 12:31 PM
goldfire added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Nov 5 2018, 12:30 PM
goldfire abandoned D5150: Fix #14880..

Yes!

Nov 5 2018, 11:19 AM

Nov 2 2018

goldfire added inline comments to D5283: Fix #15828, from `More explicit foralls`.
Nov 2 2018, 9:44 PM
goldfire added a comment to D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.

I've commented on the ticket, as that seems a better place than here.

Nov 2 2018, 8:59 PM
goldfire added a comment to D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.

I have a hunch that this might also fix Trac #15852.

Nov 2 2018, 3:05 PM
goldfire added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Nov 2 2018, 3:02 PM
goldfire added inline comments to D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.
Nov 2 2018, 11:24 AM

Nov 1 2018

goldfire committed rGHC1f72a1c81368: Don't lint erroneous programs. (authored by goldfire).
Don't lint erroneous programs.
Nov 1 2018, 5:11 PM
goldfire committed rGHC74ed9c1c1b26: Actually fail in failIfEmitsConstraints (authored by goldfire).
Actually fail in failIfEmitsConstraints
Nov 1 2018, 4:44 PM
goldfire committed rGHC255d2e323a88: Fix embarrassing, egregious bug in roles of (->) (authored by goldfire).
Fix embarrassing, egregious bug in roles of (->)
Nov 1 2018, 4:44 PM
goldfire added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Nov 1 2018, 11:04 AM
goldfire added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Nov 1 2018, 8:34 AM

Oct 29 2018

goldfire committed rGHC09740d50e74a: Revert "Remove kind generalisation from tcRnType" (authored by goldfire).
Revert "Remove kind generalisation from tcRnType"
Oct 29 2018, 11:37 AM
goldfire added a reverting change for rGHC3a51abd04432: Remove kind generalisation from tcRnType: rGHC09740d50e74a: Revert "Remove kind generalisation from tcRnType".
Oct 29 2018, 11:37 AM
goldfire committed rGHC2adffd854eff: Test #15076 in dependent/should_compile/T15076* (authored by goldfire).
Test #15076 in dependent/should_compile/T15076*
Oct 29 2018, 11:37 AM
goldfire committed rGHC731c95f51672: Test #15825 in dependent/should_fail/T15825 (authored by goldfire).
Test #15825 in dependent/should_fail/T15825
Oct 29 2018, 11:37 AM
goldfire committed rGHCc1db1eb028b6: Test T15711 in indexed-types/should_compile/T15711 (authored by goldfire).
Test T15711 in indexed-types/should_compile/T15711
Oct 29 2018, 8:53 AM
goldfire committed rGHC3a51abd04432: Remove kind generalisation from tcRnType (authored by goldfire).
Remove kind generalisation from tcRnType
Oct 29 2018, 8:53 AM

Oct 28 2018

goldfire abandoned D5208: Fix #14880..

Committed: 5e45ad10ffca1ad175b10f6ef3327e1ed8ba25f3

Oct 28 2018, 10:47 PM
goldfire abandoned D5275: Fix #15787 by squashing a coercion hole..

Committed: 4427315a65b25db22e1754d41b43dd4b782b022f

Oct 28 2018, 10:30 PM
goldfire committed rGHC5e45ad10ffca: Finish fix for #14880. (authored by tdammers).
Finish fix for #14880.
Oct 28 2018, 10:18 PM
goldfire committed rGHC4427315a65b2: Fix #15787 by squashing a coercion hole. (authored by goldfire).
Fix #15787 by squashing a coercion hole.
Oct 28 2018, 10:18 PM
goldfire added inline comments to D5265: Fix `:k` command: add validity checking.
Oct 28 2018, 10:07 PM
goldfire requested changes to D5276: users guide: Introduce :pragma: directive.

Thanks for the quick action here!

Oct 28 2018, 9:53 PM
goldfire added a comment to D5275: Fix #15787 by squashing a coercion hole..

I may not get a chance to cycle back to this one. If it validates, please merge. Thanks.

Oct 28 2018, 3:09 PM
goldfire created D5275: Fix #15787 by squashing a coercion hole..
Oct 28 2018, 3:08 PM
goldfire added inline comments to D5208: Fix #14880..
Oct 28 2018, 2:46 PM
goldfire updated the diff for D5208: Fix #14880..

Get quantification right, for once.

Oct 28 2018, 2:27 PM

Oct 27 2018

goldfire committed rGHC512eeb9bb9a8: More explicit foralls (GHC Proposal 0007) (authored by mayac).
More explicit foralls (GHC Proposal 0007)
Oct 27 2018, 1:57 PM
goldfire closed D4894: More explicit foralls (GHC Proposal 0007).
Oct 27 2018, 1:57 PM

Oct 26 2018

goldfire added inline comments to D4894: More explicit foralls (GHC Proposal 0007).
Oct 26 2018, 11:10 PM

Oct 22 2018

goldfire committed rGHCd06925715b83: Clarify Note about ForAllCo coercions. (authored by goldfire).
Clarify Note about ForAllCo coercions.
Oct 22 2018, 1:59 PM
goldfire accepted D5247: Update core-spec for Coercion Quantification.

Thanks!

Oct 22 2018, 1:51 PM

Oct 21 2018

goldfire requested changes to D5247: Update core-spec for Coercion Quantification.
Oct 21 2018, 8:51 PM

Oct 19 2018

goldfire added a comment to D5229: Visible kind application.

I discovered a potential bug, minimized by Ryan

Oct 19 2018, 10:48 AM