Feed Advanced Search

Mon, Jan 21

mpickering committed rGHC38d837a46ea8: Fix typo in TcRnTypes.hs [skip ci] (authored by mpickering).
Fix typo in TcRnTypes.hs [skip ci]
Mon, Jan 21, 11:32 AM
mpickering added a comment to D5223: WIP: Support profiling in ghc-heap.

No, but the code is here for anyone to use if they wish.

Mon, Jan 21, 2:36 AM

Sun, Jan 20

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC6e7aa5e937b1: Remove TODO in HsExpr (authored by mpickering).
Remove TODO in HsExpr
Sun, Jan 20, 11:25 AM

Fri, Jan 18

mpickering committed rGHCb14f54041eac: Fix typo in DsExpr (authored by mpickering).
Fix typo in DsExpr
Fri, Jan 18, 2:13 PM

Jan 16 2019

mpickering committed rGHCc2455e647501: Run typed splices in the zonker (authored by mpickering).
Run typed splices in the zonker
Jan 16 2019, 12:24 AM
mpickering committed rGHC6486c6e49c53: Hadrian: Add support for building stage3 (authored by mpickering).
Hadrian: Add support for building stage3
Jan 16 2019, 12:24 AM

Jan 11 2019

mpickering abandoned D5286: Run typed splices in the zonker.

Merged now. https://gitlab.haskell.org/ghc/ghc/commit/c2455e647501c5a382861196b64df3dd05b620a2

Jan 11 2019, 4:24 AM

Jan 10 2019

mpickering added a comment to D5286: Run typed splices in the zonker.

Responded to new comments now.

Jan 10 2019, 6:00 AM
mpickering added inline comments to D5286: Run typed splices in the zonker.
Jan 10 2019, 5:58 AM
mpickering added a comment to D5286: Run typed splices in the zonker.

https://gitlab.haskell.org/ghc/ghc/merge_requests/106

Jan 10 2019, 5:50 AM
mpickering added a comment to D5286: Run typed splices in the zonker.

I applied Simon's suggestions apart from the one about TcGblEnv which I don't think made the code much clearer as it then wasn't obvious which bits to extract from the TcGblEnv to combine together with the other TcGblEnv in order to get the correct result.

Jan 10 2019, 5:47 AM

Dec 27 2018

mpickering added a comment to D5352: Add -fcompact-holes..

I put the patch on gitlab: https://gitlab.haskell.org/ghc/ghc/merge_requests/49

Dec 27 2018, 3:12 PM
mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

This patch is now at https://gitlab.haskell.org/ghc/ghc/merge_requests/16

Dec 27 2018, 6:04 AM

Dec 23 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

CI passes: https://gitlab.haskell.org/mpickering/ghc/pipelines/460

Dec 23 2018, 6:07 AM

Dec 22 2018

mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • remove merge artifacts
Dec 22 2018, 6:41 AM
mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

I rebased. Last night I tested that the default build works correctly, I fixed the binary-dist target so that it doesn't build haddock with Stage2 libraries and also verified that test works correctly.

Dec 22 2018, 6:39 AM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Define and use stageLibaries
  • Resolve some more stage confusion
  • fix build
  • Make things even more consistent
  • docs
  • Cleanup
  • Remove tabs
  • Andrey's suggestions
  • Implement the finalStage build option
  • Note about libffiContext
  • Fix lint
  • Alp comments
  • Use stage1 haddock
Dec 22 2018, 6:38 AM

Dec 21 2018

mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Alp comments
Dec 21 2018, 7:06 AM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 21 2018, 6:53 AM
mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

@snowleopard I implement the finalStage solution that @alpmestan suggested. It turned out quite nicely and meant we could remove the stage1Only option.

Dec 21 2018, 6:18 AM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Implement the finalStage build option
  • Note about libffiContext
  • Fix lint
Dec 21 2018, 6:15 AM

Dec 20 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.
So I think that is all the packages?

There's a trivial way to find out, ls _build/stage2/lib/package.conf.d/.

Dec 20 2018, 12:12 PM
mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

This is looking pretty good. Besides Andrey's outstanding question, I made a suggestion and have one request to add a TODO.

Can you clarify how far this gets you? I don't think the flavour matters much, so I won't ask whether you've built with different flavours. You said you get as far as building a working stage 3 compiler, right? And if you make stagePackages return the whole series of packages that a bindist would ship with, does that work too? Maybe you can just borrow that list from stage2Packages (or alternatively stagePackages Stage2)?

Dec 20 2018, 10:46 AM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 20 2018, 9:47 AM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Andrey's suggestions
Dec 20 2018, 8:59 AM

Dec 19 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

I completed a stage3 build from a clean tree successfully with this patch and a modified UserSettings.hs. Another review @snowleopard would be good seeing as it also involved some more radical changes now.

Dec 19 2018, 12:42 PM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Remove tabs
Dec 19 2018, 11:30 AM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Make things even more consistent
  • docs
  • cleanup
Dec 19 2018, 11:27 AM
mpickering updated the summary of D5458: Hadrian: Add support for building Stage3.
Dec 19 2018, 11:09 AM
mpickering planned changes to D5458: Hadrian: Add support for building Stage3.

Still broken in fact, see Trac #16069 for where the problem lies.

Dec 19 2018, 7:19 AM

Dec 18 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

I think I fixed things up now. @alpmestan can you review?

Dec 18 2018, 11:45 AM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • fix build
Dec 18 2018, 11:44 AM
mpickering added a comment to D4953: Support for deprecating exports.

@DavidEichmann I think it will be much easier if you rebase the patch? This review cycle has been going on for a very long time now.

Dec 18 2018, 9:36 AM
mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

I think that stageLibraries also needs to be used in configurePackage to make sure you end up needing packages from the right stage. That occurs here: https://github.com/ghc/ghc/blob/ed69f8bd1fd4b84b62bb4f10eef7f76e537be07b/hadrian/src/Hadrian/Haskell/Cabal/Parse.hs#L116. Note that this is already wrong for stage 2 thereby preventing me from building Haddock >:(.

Dec 18 2018, 2:20 AM

Dec 17 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

Still not ready. There is a problem with packageDbPath resolving to the wrong thing in some places. This stems from the fact that packageDbPath used to have a call to min in which clearly does the wrong thing and relies on the fact that we didn't used to build any libraries with the stage2 compiler. I haven't managed yet to work out how to precisely fix this though.

Dec 17 2018, 4:01 PM

Dec 16 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

Thanks Andrey, I managed to apply your suggestions and things appear to work smoothly still. I'll try a clean rebuild overnight.

Dec 16 2018, 4:20 PM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Define and use stageLibaries
  • Resolve some more stage confusion
Dec 16 2018, 4:15 PM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 16 2018, 3:40 PM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 16 2018, 2:43 PM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 16 2018, 12:45 PM
mpickering added a reviewer for D5458: Hadrian: Add support for building Stage3: snowleopard.
Dec 16 2018, 12:28 PM
mpickering created D5458: Hadrian: Add support for building Stage3.
Dec 16 2018, 12:27 PM

Dec 14 2018

mpickering added a comment to D5454: Hadrian: introduce userDefaultFlavour, making default flavour overridable.

Is there somewhere to view a rendered up-to-date copy of the documentation? If there's not then this doesn't seem like a great idea.

Dec 14 2018, 11:15 AM
mpickering added a comment to D5454: Hadrian: introduce userDefaultFlavour, making default flavour overridable.

Thanks Alp, this will be useful. Please can we update the wiki page as well when this is merged.

Dec 14 2018, 11:03 AM

Dec 7 2018

mpickering added a comment to D5286: Run typed splices in the zonker.

CI passes: https://circleci.com/gh/ghc/ghc-diffs/1038

Dec 7 2018, 9:46 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Try to fix build ordering
Dec 7 2018, 8:57 AM
mpickering added a comment to D5286: Run typed splices in the zonker.

I had a call with Simon and he suggested two changes which I have implemented now. The finaliser bug should also be fixed.

Dec 7 2018, 8:28 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Simplify
  • Remove unused variable
  • Remove extra arguments
  • zonk after calling tcTopSpliceExpr
  • Note and Richard's other comments
  • Remove diff churn
  • Remove blank line
  • Remove blank line
  • More formatting
  • Store arguments to runTopSplice rather than whole TcM action
  • Run and zonk finalisers
Dec 7 2018, 8:18 AM

Nov 27 2018

mpickering added a comment to D5360: Add -fno-safe-haskell flag.

Updated with Ben's comments now.

Nov 27 2018, 3:58 AM
mpickering updated the diff for D5360: Add -fno-safe-haskell flag.
  • Address Ben's comments
Nov 27 2018, 3:57 AM

Nov 22 2018

mpickering added a comment to D2343: [WIP] llvmGen: Produce debug information metadata for functions.

The subprograms field has been removed. https://smlnj-gitlab.cs.uchicago.edu/manticore/llvm/commit/4eeaa0da042055b1cd17b339e2dde518a3026033

Nov 22 2018, 9:06 AM
mpickering added a comment to D2343: [WIP] llvmGen: Produce debug information metadata for functions.

This still applies cleanly to master fwiw.

Nov 22 2018, 8:30 AM
mpickering added a comment to D5360: Add -fno-safe-haskell flag.

CI passes: https://circleci.com/gh/ghc/ghc/11719?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Nov 22 2018, 6:49 AM

Nov 20 2018

mpickering updated the diff for D5360: Add -fno-safe-haskell flag.
  • fix test
Nov 20 2018, 10:25 AM
mpickering updated the diff for D5360: Add -fno-safe-haskell flag.
  • Stop infinite loop
Nov 20 2018, 10:19 AM
mpickering created D5360: Add -fno-safe-haskell flag.
Nov 20 2018, 6:01 AM

Nov 19 2018

mpickering committed rGHC7e570676bd0a: eventlog: Log the current stack size when stack overflows (authored by mpickering).
eventlog: Log the current stack size when stack overflows
Nov 19 2018, 5:35 AM
mpickering closed D5287: eventlog: Log the current stack size when stack overflows.
Nov 19 2018, 5:35 AM
mpickering awarded D5351: Remove explicit recursion in retainer profiling (fixes #14758) a Yellow Medal token.
Nov 19 2018, 5:29 AM
mpickering updated subscribers of D5355: hadrian: make it possible to run the testsuite with quickest and quick.

Thanks @alpmestan

Nov 19 2018, 5:19 AM

Nov 18 2018

mpickering added a reviewer for D5352: Add -fcompact-holes.: RyanGlScott.
Nov 18 2018, 9:23 AM

Nov 13 2018

mpickering planned changes to D5286: Run typed splices in the zonker.

Still one problem with finalisers getting run in the wrong place.

Nov 13 2018, 5:52 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Remove blank line
  • Remove blank line
  • More formatting
Nov 13 2018, 3:39 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Simplify
  • Remove unused variable
  • Remove extra arguments
  • zonk after calling tcTopSpliceExpr
  • Remove merge artefact
  • Note and Richard's other comments
  • Remove diff churn
Nov 13 2018, 3:35 AM

Nov 12 2018

mpickering updated the diff for D5286: Run typed splices in the zonker.
  • zonk after calling tcTopSpliceExpr
  • Remove merge artefact
  • Note and Richard's other comments
Nov 12 2018, 4:27 PM
mpickering added a comment to D5286: Run typed splices in the zonker.

If you look at the first version of this patch, I did as you suggested and persisted all the original parts but I think it was more complicated. You still need to persist TcLclEnv and so end up with an import cycle and several {-# SOURCE #-} imports in the zonker.

Nov 12 2018, 12:09 PM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Remove extra arguments
Nov 12 2018, 8:25 AM

Nov 9 2018

mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Simplify
  • Remove unused variable
Nov 9 2018, 2:42 PM
mpickering updated the diff for D5287: eventlog: Log the current stack size when stack overflows.
  • indentation
  • Remove redundant conditional
  • fix link
Nov 9 2018, 2:57 AM
mpickering accepted D5308: Respect naming conventions in module RnUnbound.hs in fix for #15611.

Thanks!

Nov 9 2018, 2:37 AM

Nov 8 2018

mpickering resigned from D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 8 2018, 4:26 PM · GHC
mpickering resigned from D3047: Implement cheapBuild.
Nov 8 2018, 4:25 PM
mpickering added a comment to D3834: Point to FunDeps documentation on Haskell wiki.

Would be good to land this still I think?

Nov 8 2018, 4:24 PM
mpickering resigned from D4257: add variants of `finiteBitSize` and friends which take `Proxy`.
Nov 8 2018, 4:24 PM · GHC
mpickering added a comment to D4533: Don't overwrite the set log_action when using --interactive.

Probably still needs fixing but there appear to be no consumers for -ddump-json to care.

Nov 8 2018, 4:22 PM
mpickering abandoned D4279: Look through casts when calculating dict arg discount.

I think this was fixed in 954cbc7c106a20639960f55ebb85c5c972652d41

Nov 8 2018, 4:20 PM
mpickering abandoned D2929: Always expose unfoldings for overloaded functions.
Nov 8 2018, 4:15 PM
mpickering abandoned D3322: WIP: Reduce stderr output by passing -v0 to ghc-pkg.
Nov 8 2018, 4:11 PM
mpickering requested changes to D5299: Fix recompilation checking of pure plugins.

Looks plausible but I need to understand what Ben meant in his comment above before understanding the logic in detail.

Nov 8 2018, 4:02 PM
mpickering requested changes to D5308: Respect naming conventions in module RnUnbound.hs in fix for #15611.

Two comments.

Nov 8 2018, 3:35 PM
mpickering created D5311: iserv: Fix typo in cabal file.
Nov 8 2018, 9:38 AM

Nov 6 2018

mpickering accepted D5162: GHCi does not need a main function.

Thanks @RolandSenn, do you need to change the title of the revision as well?

Nov 6 2018, 3:35 PM
mpickering added a comment to D5285: Warn about unused packages.

You could make the flag imply -fforce-recomp but if we don't understand how the patch works for the partial recompilation case then I would suggest that we don't understand what the code is doing well enough.

Nov 6 2018, 3:24 PM

Nov 5 2018

mpickering added a comment to D5287: eventlog: Log the current stack size when stack overflows.

I removed that branch now I understand what is going on more.

Nov 5 2018, 3:40 AM
mpickering updated the diff for D5287: eventlog: Log the current stack size when stack overflows.
  • Remove redundant conditional
Nov 5 2018, 3:39 AM

Nov 2 2018

mpickering added a comment to D5287: eventlog: Log the current stack size when stack overflows.

In order for this to affect the eventlog you will need to modify EventLog.c:postSchedEvent. However, it looks like info2 may already be used for something else in the EVENT_STOP_THREAD case (although it's not clear what).

Nov 2 2018, 3:36 PM

Nov 1 2018

mpickering created D5291: Add test for #15437.
Nov 1 2018, 9:16 AM
mpickering added inline comments to D5162: GHCi does not need a main function.
Nov 1 2018, 4:04 AM

Oct 31 2018

mpickering added a comment to D5286: Run typed splices in the zonker.

The build works on hadrian but not on the old build system.

Oct 31 2018, 12:57 PM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Revert "Add dummy dependency on GHC.Types"
Oct 31 2018, 9:49 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Add dummy dependency on GHC.Types
Oct 31 2018, 9:33 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Add Simon's test as well
Oct 31 2018, 8:13 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Rename the spliced expression in the right context
Oct 31 2018, 8:09 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • rebase
Oct 31 2018, 6:12 AM
mpickering updated the diff for D5287: eventlog: Log the current stack size when stack overflows.
  • indentation
Oct 31 2018, 5:53 AM
mpickering created D5287: eventlog: Log the current stack size when stack overflows.
Oct 31 2018, 5:52 AM

Oct 30 2018

mpickering created D5286: Run typed splices in the zonker.
Oct 30 2018, 11:27 AM
mpickering added a comment to D5285: Warn about unused packages.

Does this work when a module is not recompiled because it has not changed? In other words, what is the result of running ghc with this flag enabled twice in a row?

Oct 30 2018, 11:10 AM

Oct 29 2018

mpickering requested changes to D5278: Support registering Plugins through the GHC API.

What is the problem with adding the plugin you want to load to the plugins field? There at least needs to be a comment explaining why it is necessary for these two different approaches which look very similar.

Oct 29 2018, 4:54 AM

Oct 25 2018

mpickering accepted D5264: users-guide: Fix formatting of eventlog format documentation.
Oct 25 2018, 5:26 PM