Feed Advanced Search

Mon, Jul 8

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC03f5adcd62fb: Bump Shake and copy instead of hard link from cloud cache (authored by DavidEichmann).
Bump Shake and copy instead of hard link from cloud cache
Mon, Jul 8, 7:48 PM

Tue, Jul 2

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCdf3e5b744db2: Hadrian: disable cloud build cache for symlinks #16800 (authored by DavidEichmann).
Hadrian: disable cloud build cache for symlinks #16800
Tue, Jul 2, 3:36 PM

Jun 13 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCe98d32a62977: Hadrian: Track RTS library symlink targets (authored by DavidEichmann).
Hadrian: Track RTS library symlink targets
Jun 13 2019, 1:54 AM

Jun 10 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC58a5d728d029: Refactor the rules for .hi and .o into a single rule using `&%>` #16764 (authored by DavidEichmann).
Refactor the rules for .hi and .o into a single rule using `&%>` #16764
Jun 10 2019, 10:58 PM

Jun 9 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC69c58f8abbb0: Hadrian: need CPP preprocessor dependencies #16660 (authored by DavidEichmann).
Hadrian: need CPP preprocessor dependencies #16660
Jun 9 2019, 5:52 PM

Jun 4 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC286827be471f: TestRunner: Added --chart to display a chart of performance tests (authored by DavidEichmann).
TestRunner: Added --chart to display a chart of performance tests
Jun 4 2019, 12:09 AM

May 29 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCa1bf3413f850: Hadrian: Add note about Libffi's Indicating Inputs #16653 (authored by DavidEichmann).
Hadrian: Add note about Libffi's Indicating Inputs #16653
May 29 2019, 3:12 PM

May 25 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC9be1749d2421: Hadrian: Add Mising Libffi Dependencies #16653 (authored by DavidEichmann).
Hadrian: Add Mising Libffi Dependencies #16653
May 25 2019, 5:04 PM

May 24 2019

DavidEichmann committed rGHCc931f2561207: Allow metric change after reverting "Add Generic tuple instances up to 15… (authored by DavidEichmann).
Allow metric change after reverting "Add Generic tuple instances up to 15…
May 24 2019, 5:26 AM
DavidEichmann added a reverting change for rGHC535a26c90f45: Revert "Add Generic tuple instances up to 15-tuple" #16688: rGHCc931f2561207: Allow metric change after reverting "Add Generic tuple instances up to 15….
May 24 2019, 5:26 AM

May 23 2019

DavidEichmann committed rGHC535a26c90f45: Revert "Add Generic tuple instances up to 15-tuple" #16688 (authored by DavidEichmann).
Revert "Add Generic tuple instances up to 15-tuple" #16688
May 23 2019, 1:56 PM
DavidEichmann added a reverting change for rGHC5eb9445444c4: Add Generic tuple instances up to 15-tuple: rGHC535a26c90f45: Revert "Add Generic tuple instances up to 15-tuple" #16688.
May 23 2019, 1:56 PM

May 21 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC0af519ac583c: Refactor Libffi and RTS rules (authored by DavidEichmann).
Refactor Libffi and RTS rules
May 21 2019, 4:05 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC8fc654c3a00a: Include CPP preprocessor dependencies in -M output (authored by DavidEichmann).
Include CPP preprocessor dependencies in -M output
May 21 2019, 4:05 PM

May 20 2019

DavidEichmann committed rGHCb46efa2bbf86: Recalculate Performance Test Baseline T9630 #16680 (authored by DavidEichmann).
Recalculate Performance Test Baseline T9630 #16680
May 20 2019, 1:50 PM
DavidEichmann committed rGHC5bb80cf2c560: Improve test runner logging when calculating performance metric baseline #16662 (authored by DavidEichmann).
Improve test runner logging when calculating performance metric baseline #16662
May 20 2019, 9:51 AM

May 10 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCbfcd986dc424: Hadrian: programs need registered ghc-pkg libraries (authored by DavidEichmann).
Hadrian: programs need registered ghc-pkg libraries
May 10 2019, 3:45 PM

Apr 14 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC5f1830817b90: Hadrian: add rts shared library symlinks for backwards compatability (authored by DavidEichmann).
Hadrian: add rts shared library symlinks for backwards compatability
Apr 14 2019, 12:15 AM

Apr 2 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCd132b30ad7ee: Hadrian: lint ignore autom4te and ghc-pkg cache files. (authored by DavidEichmann).
Hadrian: lint ignore autom4te and ghc-pkg cache files.
Apr 2 2019, 3:54 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCf54b5124bd44: Hadrian: traceAllow deep dependencies when compilling haskell object files. (authored by DavidEichmann).
Hadrian: traceAllow deep dependencies when compilling haskell object files.
Apr 2 2019, 3:54 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCdd9c82ef38e8: Hadrian: correct deps for ghc builder. (authored by DavidEichmann).
Hadrian: correct deps for ghc builder.
Apr 2 2019, 3:54 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCe468c6133320: Support Shake's --lint-fsatrace feature. (authored by DavidEichmann).
Support Shake's --lint-fsatrace feature.
Apr 2 2019, 3:54 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC3dec527a840a: Hadrian: don't use -zorigin on darwin. (authored by DavidEichmann).
Hadrian: don't use -zorigin on darwin.
Apr 2 2019, 3:54 PM

Mar 15 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCafc80730fd23: Git ignore .hadrian_ghci (generated by the ./hadrian/ghci.sh) (authored by DavidEichmann).
Git ignore .hadrian_ghci (generated by the ./hadrian/ghci.sh)
Mar 15 2019, 2:10 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC4df757729dab: Hadrian: remove unneeded rpaths. (authored by DavidEichmann).
Hadrian: remove unneeded rpaths.
Mar 15 2019, 2:10 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCd10e23687d16: Hadrian: remove unneeded imports. (authored by DavidEichmann).
Hadrian: remove unneeded imports.
Mar 15 2019, 2:10 PM

Mar 5 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC6c4e45b043b0: Test Runner: don't show missing baseline warning for performance tests with… (authored by DavidEichmann).
Test Runner: don't show missing baseline warning for performance tests with…
Mar 5 2019, 3:44 PM

Mar 4 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCb1c7ffafc64c: Fix parsing of expected performance changes for tests with non-alpha characters. (authored by DavidEichmann).
Fix parsing of expected performance changes for tests with non-alpha characters.
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC806cc234426d: Build and copy libffi shared libraries correctly and enable dynamically linking… (authored by DavidEichmann).
Build and copy libffi shared libraries correctly and enable dynamically linking…
Mar 4 2019, 3:08 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC32f44ed81b0f: Fix test runner crash when not in a git repo (authored by DavidEichmann).
Fix test runner crash when not in a git repo
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC0b92bdc79ddd: Fix and Reapply "Performance tests: recover a baseline from ancestor commits… (authored by DavidEichmann).
Fix and Reapply "Performance tests: recover a baseline from ancestor commits…
Mar 4 2019, 1:07 PM

Jan 25 2019

DavidEichmann added a comment to D5427: hadrian: Only link against libffi when it is needed for adjustors.

Looking at the make build system, the UseLibFFIForAdjustors variable is only used to toggle cLibFFI in Config.hs files, and also in compiler/ghc.mk to set the USE_LIBFFI_FOR_ADJUSTORS flag when compiling the rts:

Jan 25 2019, 11:09 AM
DavidEichmann added a comment to D5427: hadrian: Only link against libffi when it is needed for adjustors.

@bgamari, last we spoke it was unclear why this would work to limit linking agains ffi as per my previous comment:

Jan 25 2019, 7:08 AM

Jan 8 2019

DavidEichmann added a comment to D5423: Fix hadrian default build cannot find -lffi..
Jan 8 2019, 5:48 PM

Dec 20 2018

DavidEichmann added a comment to D4953: Support for deprecating exports.

This depends on this Haddock PR: https://github.com/haskell/haddock/pull/984

Dec 20 2018, 2:48 PM
DavidEichmann updated the diff for D4953: Support for deprecating exports.
  • Included all changes.
Dec 20 2018, 2:41 PM
DavidEichmann updated the diff for D4953: Support for deprecating exports.

Rebase, resolve conflicts, and fix build.

Dec 20 2018, 2:31 PM
DavidEichmann added a comment to D4953: Support for deprecating exports.

@mpickering Ok, I'll do the rebase now.

Dec 20 2018, 12:39 PM

Dec 19 2018

DavidEichmann created D5464: CircleCI: Fix check for git push retry limit..
Dec 19 2018, 10:42 AM

Dec 18 2018

DavidEichmann added a comment to D4953: Support for deprecating exports.

Hello, sorry for the delay here. I can't seem to build this patch and am seeing merge conflicts. Can you please rebase on master, and resolve any merge conflicts.

Dec 18 2018, 9:13 AM

Dec 17 2018

DavidEichmann added a comment to D5409: Hadrian: support extra libraries + OSX rpath.

Keep in mind that the dynamic ghc build has been disabled in D5430 due to the failing hadrian build.

Dec 17 2018, 3:32 PM

Dec 11 2018

DavidEichmann added a comment to D5430: Revert dynamically linking ghc..

The build failure in question is failing to find libffi when building the default flavour on x86_64 with no system wide libffi installed. The command that fails is when linking the ghc binary. The make build system links the ghc binary with -lffi. On that grounds I would say that D5427 will not solve this issue that this patch does.

Dec 11 2018, 9:16 AM
DavidEichmann added a comment to D5427: hadrian: Only link against libffi when it is needed for adjustors.

There seems to be some logic using -l$$(LIBFFI_NAME) in rts/ghc.mk. configure.ac also seems to set the default value of the ffi flag by doing AC_SUBST([CabalHaveLibffi],[False]) or AC_SUBST([CabalHaveLibffi],[True]).

Dec 11 2018, 6:00 AM
DavidEichmann added a comment to D5427: hadrian: Only link against libffi when it is needed for adjustors.

Im confused: setting the ffi flag *enables* linking with ffi. So if I understand correctly, this can only serve to *increase* the cases where we link with ffi. I'm trying to find the relevant logic in the make build system now.

Dec 11 2018, 5:19 AM
DavidEichmann added a comment to D5423: Fix hadrian default build cannot find -lffi..

Funny enough, I just came accross this in the make build system rts/ghc.mk:127:

Dec 11 2018, 5:06 AM

Dec 10 2018

DavidEichmann added a comment to D5430: Revert dynamically linking ghc..

I've tested locally using a nix environment where the Hadrian default build fails on master. With this patch I successfully built and ran tests for flavours: default, perf, quick, and quickest.

Dec 10 2018, 11:20 AM
DavidEichmann planned changes to D5423: Fix hadrian default build cannot find -lffi..
Dec 10 2018, 11:01 AM
DavidEichmann added a comment to D5423: Fix hadrian default build cannot find -lffi..

After speaking with Alp, we've decided it is safer to simply revert the dynamic linking changes: D5430. This should fix the Hadrian build while a hack free solution can be found.

Dec 10 2018, 11:00 AM
DavidEichmann added a reviewer for D5430: Revert dynamically linking ghc.: alpmestan.
Dec 10 2018, 10:57 AM
DavidEichmann created D5430: Revert dynamically linking ghc..
Dec 10 2018, 10:55 AM

Dec 9 2018

DavidEichmann updated the diff for D5368: Do not save performance test results if worktree is dirty..

Rebase

Dec 9 2018, 8:44 AM
DavidEichmann added a comment to D5423: Fix hadrian default build cannot find -lffi..

You're absolutely right @bgamari, this situation is not ideal, but I do fully intend to continue work on this. The Hadrian build is broken and the correct solution seems non-trivial, hence I saw this hacky solution as somewhat justified.

Dec 9 2018, 7:46 AM

Dec 7 2018

DavidEichmann added a comment to D5423: Fix hadrian default build cannot find -lffi..

This fixes the build on CircleCI: https://gitlab.staging.haskell.org/DavidEichmann/ghc/-/jobs/904. Using Alp's nix environment I was able to recreate the build failure by building the default flavour. In the same environment with this patch build succeeds and I have run the tests in the perf and default flavours. I still see the drop in test failures the we expect from dynamically linking ghc.

Dec 7 2018, 5:27 PM
DavidEichmann added a reviewer for D5423: Fix hadrian default build cannot find -lffi.: alpmestan.
Dec 7 2018, 5:20 PM
DavidEichmann created D5423: Fix hadrian default build cannot find -lffi..
Dec 7 2018, 5:17 PM

Dec 4 2018

DavidEichmann added inline comments to D5409: Hadrian: support extra libraries + OSX rpath.
Dec 4 2018, 7:42 AM

Dec 2 2018

DavidEichmann added a comment to rGHC79d5427e1f9d: Hadrian: support dynamically linking ghc.

There is a similar issue on linux where we link the system ffi instead of the local one. This fails e.g. on CircleCI as ld cannot find the ffi library. I don't know if this is related to the OSX failure, but I'll continue investigating this on linux.

Dec 2 2018, 9:43 AM

Nov 30 2018

DavidEichmann updated the diff for D5368: Do not save performance test results if worktree is dirty..

Included too many changes in the last diff.

Nov 30 2018, 11:25 AM
DavidEichmann updated the diff for D5368: Do not save performance test results if worktree is dirty..

Converting check_output() result to bool is confusing and in this case is wrong. Comparing to byte string literal instead.

Nov 30 2018, 11:20 AM
DavidEichmann retitled D5368: Do not save performance test results if worktree is dirty. from [Merge After D5367] Do not save performance test results if worktree is dirty. to Do not save performance test results if worktree is dirty..
Nov 30 2018, 10:57 AM
DavidEichmann committed rGHC6e24a0bee0d0: Skip all performance tests if not in a git repo. (authored by DavidEichmann).
Skip all performance tests if not in a git repo.
Nov 30 2018, 10:55 AM
DavidEichmann closed D5367: Skip all performance tests if not in a git repo..
Nov 30 2018, 10:55 AM

Nov 29 2018

DavidEichmann added a comment to D4953: Support for deprecating exports.

Hello, thanks for fixing that, great work! I see you also added a test which is always appreciated. Before I accept:

  • I still think throwing an exception is more valid. I.e. replace loadSrcInterface_maybe with loadSrcInterface (this change would also make the code a bit simpler). If you're not sure why, do ask. If you're convinced otherwise, I'm not gonna fight you on it.
  • The changes in .gitmodules should be reverted (as a rule of thumb, I'll only accept if I think it's ready to merge as is).
    • You can easily fix this without breaking your build by, first pushing your changes git push, then re-cloning ghc using git clone git://git.haskell.org/ghc --recurse-submodules (if you need help with this feel free to contact me on IRC at freenode #haskell my handle is DavidEichmann).
Nov 29 2018, 11:01 AM
DavidEichmann abandoned D5329: Bump Cabal to 2.5.0.0 and fix build errors..

This was merged as part of D5312.

Nov 29 2018, 10:23 AM
DavidEichmann retitled D5281: Hadrian: support dynamically linking ghc from [Merge after D5385] Hadrian: support dynamically linking ghc to Hadrian: support dynamically linking ghc.
Nov 29 2018, 10:20 AM
DavidEichmann retitled D5281: Hadrian: support dynamically linking ghc from Dynamically linked ghc uses relative path to shared objects. to [Merge after D5385] Hadrian: support dynamically linking ghc.
Nov 29 2018, 6:47 AM
DavidEichmann updated the diff for D5281: Hadrian: support dynamically linking ghc.

Build ghc with -fPIC -dynamic if RTS has a dynamic way.
Don't link executables with -shared -dynload deploy.
These changes are all in hadrian/src/Settings/Builders/Ghc.hs

Nov 29 2018, 6:23 AM

Nov 28 2018

DavidEichmann retitled D5368: Do not save performance test results if worktree is dirty. from Do not save performance test results if worktree is dirty. to [Merge After D5367] Do not save performance test results if worktree is dirty..
Nov 28 2018, 7:34 AM

Nov 27 2018

DavidEichmann updated the diff for D5367: Skip all performance tests if not in a git repo..
  • Use git status instead of rev-parse
Nov 27 2018, 6:56 AM
DavidEichmann accepted D5385: Hadrian: bump Cabal submodule, install extra dynamic flavours of libHSrts.
Nov 27 2018, 6:27 AM
DavidEichmann updated the diff for D5367: Skip all performance tests if not in a git repo..
  • Fix logic to call Perf.append_perf_stat() only if canGitStatus.
  • Improve error message.
Nov 27 2018, 5:28 AM

Nov 26 2018

DavidEichmann added a comment to D5367: Skip all performance tests if not in a git repo..

@osa1 We use git notes to get the baseline performance numbers and to save the new numbers. Here we only skip performance tests if we both cannot get a baseline (and hence can't tell if tests pass or fail) nor have a way to save the results.

Nov 26 2018, 10:10 AM
DavidEichmann updated the diff for D5367: Skip all performance tests if not in a git repo..
  • Replace is_git_repo with can_git_status.
Nov 26 2018, 8:50 AM

Nov 23 2018

DavidEichmann created D5374: Fix unused import warning.
Nov 23 2018, 5:09 PM
DavidEichmann added inline comments to D5281: Hadrian: support dynamically linking ghc.
Nov 23 2018, 3:14 AM

Nov 22 2018

DavidEichmann added a comment to D5312: Fix unused-import warnings.

Validate now passes locally for me.

Nov 22 2018, 7:05 AM
DavidEichmann updated the diff for D5312: Fix unused-import warnings.
  • Fix T4437 by removing DerivingVia from expectedGhcOnlyExtensions. Update comment in GHC.Magic.
Nov 22 2018, 5:57 AM

Nov 21 2018

DavidEichmann updated the diff for D5312: Fix unused-import warnings.
  • Bump Cabal, bytestring, containers, and text.
  • Fix unused matches error.
  • Remove unused imprt after rebase.
  • Fix GHC.Magic validation errors.
Nov 21 2018, 12:51 PM
DavidEichmann updated the Trac tickets for D5368: Do not save performance test results if worktree is dirty..
Nov 21 2018, 6:48 AM
DavidEichmann created D5368: Do not save performance test results if worktree is dirty..
Nov 21 2018, 6:48 AM
DavidEichmann retitled D5367: Skip all performance tests if not in a git repo. from Skip all perormance tests if not in a git repo. to Skip all performance tests if not in a git repo..
Nov 21 2018, 5:21 AM
DavidEichmann updated the diff for D5367: Skip all performance tests if not in a git repo..
  • Correct assignment of hasMetricsFile.
Nov 21 2018, 5:11 AM
DavidEichmann created D5367: Skip all performance tests if not in a git repo..
Nov 21 2018, 4:39 AM

Nov 20 2018

DavidEichmann added a comment to D5312: Fix unused-import warnings.

There seems to be some errors when I validate locally. I'm working on this now.

Nov 20 2018, 5:10 AM

Nov 19 2018

DavidEichmann updated the diff for D5312: Fix unused-import warnings.
  • Fix unused matches error.
Nov 19 2018, 3:03 PM
DavidEichmann updated the diff for D5312: Fix unused-import warnings.
  • Bump Cabal, bytestring, containers, and text.
Nov 19 2018, 1:56 PM

Nov 13 2018

DavidEichmann added a comment to D4953: Support for deprecating exports.

Hi @alanasp, Have you managed to have a look at the issue since we last spoke? It would be great to see this to completion. I appreciate that a significant amount of effort has already gone into this patch. If you're short on time/resources, please let me know and I will investigate this further.

Nov 13 2018, 11:29 AM

Nov 12 2018

DavidEichmann added a comment to D5329: Bump Cabal to 2.5.0.0 and fix build errors..

We'll likely need to bump Cabal again soon, but this at least gets ghc to build with Cabal 2.5.0.0.

Nov 12 2018, 1:08 PM
DavidEichmann created D5329: Bump Cabal to 2.5.0.0 and fix build errors..
Nov 12 2018, 12:27 PM
DavidEichmann updated the diff for D5327: hadrian: build ghc-iserv-dyn in addition to ghc-iserv and ghc-iserv-prof, as it is required for 10+ tests.

Fix comment.

Nov 12 2018, 5:44 AM
DavidEichmann created D5327: hadrian: build ghc-iserv-dyn in addition to ghc-iserv and ghc-iserv-prof, as it is required for 10+ tests.
Nov 12 2018, 4:57 AM

Nov 8 2018

DavidEichmann updated the diff for D5312: Fix unused-import warnings.

More commit message fiddling (I'm not sure how arcanist handles this).

Nov 8 2018, 12:22 PM
DavidEichmann updated the diff for D5312: Fix unused-import warnings.

Update commit message explaining why ieLWrappedName change was reverted.

Nov 8 2018, 12:16 PM
Herald added a reviewer for D5312: Fix unused-import warnings: goldfire.
Nov 8 2018, 12:04 PM

Nov 5 2018

DavidEichmann added a comment to D4953: Support for deprecating exports.

@DavidEichmann The case that you pointed out indeed works as intended. I've made sure that if there is a non-deprecating way a symbol can be brought into context then that way will be used.

Nov 5 2018, 6:22 AM

Oct 31 2018

DavidEichmann accepted D5284: Fix for Trac #15611: Scope errors lie about what modules are imported..

Looks good to me.

Oct 31 2018, 5:11 AM
DavidEichmann added a reviewer for D5284: Fix for Trac #15611: Scope errors lie about what modules are imported.: DavidEichmann.
Oct 31 2018, 5:05 AM

Oct 30 2018

DavidEichmann added a comment to D4953: Support for deprecating exports.

@DavidEichmann Ok, it's actually self-export rather than self import. The example is here /libraries/base/GHC/Num.hs

@alanasp Ah, thank you! That makes a lot more sense now.

Oct 30 2018, 1:28 PM
DavidEichmann added a comment to D4953: Support for deprecating exports.

@alanasp I wasn't aware that ghc supported self imports. The concept sounds a bit absurd to me (why would a module ever import itself?). I know GHC 8.4.3 would complain about circular imports, which is what I expect. I would expect a similar error to be raised by the code in this patch, but perhaps I'm missing something. Can you give a concrete example? How did you run into this use case?

Oct 30 2018, 4:30 AM

Oct 29 2018

DavidEichmann added a reviewer for D5281: Hadrian: support dynamically linking ghc: alpmestan.
Oct 29 2018, 11:22 AM