Feed Advanced Search

Jul 25 2018

Mikolaj committed rGHCDIFFc859d17f9b0a: Merge taskId and serialisableTaskId (authored by Mikolaj).
Merge taskId and serialisableTaskId
Jul 25 2018, 7:33 AM
Mikolaj committed rGHCDIFF45c80482b537: Have a go at fixing the heap info DTrace build failue on OSX (authored by duncan).
Have a go at fixing the heap info DTrace build failue on OSX
Jul 25 2018, 7:32 AM
Mikolaj committed rGHCDIFF38397354574e: Emit the task-tracking events (authored by duncan).
Emit the task-tracking events
Jul 25 2018, 7:32 AM
Mikolaj committed rGHCDIFF54c98b687a5e: Define the task-tracking events (authored by duncan).
Define the task-tracking events
Jul 25 2018, 7:32 AM
Mikolaj committed rGHCDIFF647ae1cfbb5e: New functions to get kernel thread Id + serialisable task Id (authored by duncan).
New functions to get kernel thread Id + serialisable task Id
Jul 25 2018, 7:32 AM

Jan 6 2017

Mikolaj added a comment to D2929: Always expose unfoldings for overloaded functions.
In D2929#85268, @carter wrote:

How is this similar or different from specializable pragma? Does this replace needing that on newer ghc?

Jan 6 2017, 11:58 AM

Feb 2 2015

Mikolaj accepted D641: Fix #10017.

LGTM

Feb 2 2015, 3:48 AM
Mikolaj added a reviewer for D641: Fix #10017: Mikolaj.
Feb 2 2015, 12:21 AM

Jan 29 2015

Mikolaj added a reviewer for D638: Support re-export deprecations (re #4879): Mikolaj.
Jan 29 2015, 7:10 AM

Jan 16 2015

Mikolaj added a comment to D69: Dysfunctional Dependencies (Trac #8634).

Yes, AFAICT, we just need a couple of regression tests, a bit more fleshed out docs and perhaps a name change of the extension, as suggested in the Trac ticket.

Jan 16 2015, 6:21 AM

Jan 15 2015

Mikolaj accepted D618: Don't hardcode the name "ghc" in versionedAppDir.

LGTM, too. Please, could we land it in 7.10.1RC2 too?

Jan 15 2015, 2:38 AM
Mikolaj added a reviewer for D618: Don't hardcode the name "ghc" in versionedAppDir: Mikolaj.
Jan 15 2015, 2:36 AM

Jan 13 2015

Mikolaj accepted D558: Package environments.

LGTM, but needs a rebase, which is not 100% trivial, and then I'd land it.

Jan 13 2015, 8:55 AM
Mikolaj added a reviewer for D558: Package environments: Mikolaj.
Jan 13 2015, 8:54 AM

Jan 12 2015

Mikolaj accepted D615: Clarify the documentation for 'evaluate'.

I see the discussion now spans ghc-devs, the ticket *and* here. Perhaps it makes sense to move it back to ghc-devs so that others can more easily follow? Anyway, the new docs are a significant improvement already, so I'm accepting the revision.

Jan 12 2015, 1:06 AM
Mikolaj added a reviewer for D615: Clarify the documentation for 'evaluate': Mikolaj.
Jan 12 2015, 1:00 AM

Dec 27 2014

Mikolaj accepted D592: Fix T9384: fix increacing capabilites number for eventlog..

I can't tell if that covers all problems with eventlogs vs changing the number of capabilities and I haven't tested it, but it looks good. If it just passes the test described in the trac ticket and doesn't cause regression wrt the few tests in the ghc-events package, it's already a very useful fix, especially given its size. I will keep this fix in mind when triaging ghc-events and ThreadScope issues.

Dec 27 2014, 11:25 AM

Nov 21 2014

Mikolaj accepted D426: AST changes to prepare for API annotations, for #9628.

A very shallow review, mainly looking for typos and stray hunks from rebase. I've found no obvious problems.

Nov 21 2014, 7:14 AM
Mikolaj added a reviewer for D426: AST changes to prepare for API annotations, for #9628: Mikolaj.
Nov 21 2014, 6:49 AM
Mikolaj accepted D438: Add API Annotations.

A very shallow review, mainly looking for typos and stray hunks from rebase and I've only found a trivial, benign one.

Nov 21 2014, 6:28 AM
Mikolaj added a reviewer for D438: Add API Annotations: Mikolaj.
Nov 21 2014, 6:28 AM

Nov 19 2014

Mikolaj added a comment to D475: Add references between Data.Traversable.for and Data.Foldable.for_ and co..

I tried to land the patch, but it doesn't seem to apply cleanly to the current master. When you are done extending it, if you plan to any more, could you rebase it, too? Thank you.

Nov 19 2014, 9:10 AM · GHC

Nov 18 2014

Mikolaj accepted D475: Add references between Data.Traversable.for and Data.Foldable.for_ and co..

LGTM. Personally I don't see a need for more examples at least for the elementary operations from the patch. It's their generality, the type machinery behind them that is interesting and non-trivial, not their behaviour.

Nov 18 2014, 5:16 AM · GHC
Mikolaj added a reviewer for D475: Add references between Data.Traversable.for and Data.Foldable.for_ and co.: Mikolaj.
Nov 18 2014, 5:12 AM · GHC

Nov 17 2014

Mikolaj accepted D446: Docs only.
Nov 17 2014, 6:48 PM
Mikolaj added a reviewer for D446: Docs only: Mikolaj.
Nov 17 2014, 6:47 PM
Mikolaj added a reviewer for D478: Remove outdated TODO in TimeManager: Mikolaj.
Nov 17 2014, 6:41 PM
Mikolaj updated subscribers of D478: Remove outdated TODO in TimeManager.
Nov 17 2014, 6:34 PM
Mikolaj updated subscribers of D478: Remove outdated TODO in TimeManager.
Nov 17 2014, 6:34 PM

Oct 3 2014

Mikolaj requested changes to D55: Add initial events into the eventlog for forkProcess child.
Oct 3 2014, 3:54 PM · GHC