Feed Advanced Search

Apr 9 2019

bgamari added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

@nh2, what is the status of this?

Apr 9 2019, 5:57 PM · GHC

Jan 25 2019

angerman added a comment to D5213: Backend plugins.

@angerman, what is the status of this?

Jan 25 2019, 12:54 AM · GHC

Jan 20 2019

bgamari requested changes to D5213: Backend plugins.
Jan 20 2019, 7:13 PM · GHC
bgamari added a comment to D5213: Backend plugins.

@angerman, what is the status of this?

Jan 20 2019, 6:06 PM · GHC

Nov 25 2018

jb55 added a member for GHC: jb55.
Nov 25 2018, 5:01 PM

Nov 8 2018

mpickering resigned from D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 8 2018, 4:26 PM · GHC
mpickering resigned from D4257: add variants of `finiteBitSize` and friends which take `Proxy`.
Nov 8 2018, 4:24 PM · GHC

Oct 11 2018

angerman commandeered D5213: Backend plugins.
Oct 11 2018, 4:31 AM · GHC

Oct 9 2018

luite added inline comments to D5213: Backend plugins.
Oct 9 2018, 1:56 AM · GHC
TerrorJack added inline comments to D5213: Backend plugins.
Oct 9 2018, 1:17 AM · GHC
luite added inline comments to D5213: Backend plugins.
Oct 9 2018, 1:05 AM · GHC
TerrorJack added a comment to D5213: Backend plugins.

Besides, Cabal and ghc-pkg won't know anything about backend-specific output files: Unless you manage to stuff all the wasm32 code into the existing .o and .a files, the result wouldn't be copied to the right place.

Oct 9 2018, 12:56 AM · GHC
luite added a comment to D5213: Backend plugins.

@luite There isn't a discussion other than the ghc-devs thread yet, I'll create a reddit thread to collect more opinions later.

Oct 9 2018, 12:29 AM · GHC

Oct 8 2018

TerrorJack added a comment to D5213: Backend plugins.

@luite There isn't a discussion other than the ghc-devs thread yet, I'll create a reddit thread to collect more opinions later.

Oct 8 2018, 9:43 PM · GHC
luite added a comment to D5213: Backend plugins.

Is there a discussion somewhere else (other than the ghc-devs mailing list) about this? For example I'm still not sure why for the motivating example (custom backends) you prefer plugins over hooks. Perhaps I missed it.

Oct 8 2018, 2:28 PM · GHC
AndreasK added a comment to D5213: Backend plugins.

The Cmm pipeline has multiple stages.
It would be good to give a reason why we allow people to hook into it at the place you suggest.

Oct 8 2018, 9:44 AM · GHC
TerrorJack added a comment to D5213: Backend plugins.

@mpickering The Hsc there indicates there's a HscEnv in scope available for use.

Oct 8 2018, 9:41 AM · GHC
Harbormaster failed remote builds in B22995: Diff 18256 for D5213: Backend plugins!
Oct 8 2018, 9:38 AM · GHC
mpickering added a comment to D5213: Backend plugins.

What have you been able to implement with these extension points? The Hsc looks suspicious.

Oct 8 2018, 9:33 AM · GHC
TerrorJack created D5213: Backend plugins.
Oct 8 2018, 9:25 AM · GHC

Jun 21 2018

nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

Note for myself:

Jun 21 2018, 12:13 PM · GHC

Apr 30 2018

simonmar added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

One concern I have is that the pthread implementation of the timer, when it doesn't use timerfd() just does a usleep(), which means that it will be less accurate than the timerfd() version or the setitimer() verison, because it relies on the scheduler not descheduling the thread for long periods.

Apr 30 2018, 2:51 AM · GHC

Apr 28 2018

nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

I still feel slightly weird about doing kill(pid(),EPIPE) at 50Hz or whatever the context switch interval is set to. Maybe it's OK.

Apr 28 2018, 3:02 PM · GHC

Apr 25 2018

Herald updated subscribers of D1111: 4 reduce/reduce parser conflicts resolved.
Apr 25 2018, 5:33 PM · GHC

Jan 10 2018

simonmar added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

I definitely support bringing in those docs somewhere (with the fix I just added to https://ghc.haskell.org/trac/ghc/ticket/10840).

Jan 10 2018, 11:43 AM · GHC

Jan 9 2018

Harbormaster failed remote builds in B19061: Diff 15058 for D42: Fix hWaitForInput not being interruptible (#8684).!
Jan 9 2018, 3:42 PM · GHC
nh2 updated the diff for D42: Fix hWaitForInput not being interruptible (#8684)..

Implemented context-switching in non-threaded on non-Linux

Jan 9 2018, 3:42 PM · GHC

Jan 6 2018

nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

There's another potential issue in current GHC I just found: I wrote:

Jan 6 2018, 9:02 PM · GHC
nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..
In D42#119712, @nh2 wrote:

Which OSThreadId id can I pass? [...] what is the correct way to obtain its number?

Jan 6 2018, 8:46 PM · GHC
nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

For my reference, https://ghc.haskell.org/trac/ghc/ticket/10840 is what introduced the timerfd usage and also the other uses of non-SIGVTALRM timers.
I wasn't aware that they were introduced as recently as GHC 8.2.

Jan 6 2018, 6:29 PM · GHC

Dec 14 2017

RyanGlScott added a comment to D4257: add variants of `finiteBitSize` and friends which take `Proxy`.

@RyanGlScott which are these other such terms?

Dec 14 2017, 4:16 AM · GHC

Dec 13 2017

strake added a comment to D4257: add variants of `finiteBitSize` and friends which take `Proxy`.

@RyanGlScott which are these other such terms?

Dec 13 2017, 9:30 PM · GHC
strake added a comment to D4257: add variants of `finiteBitSize` and friends which take `Proxy`.

@RyanGlScott good point — we ought to introduce Proxyfied versions of all such terms in base.

Dec 13 2017, 9:28 PM · GHC

Dec 9 2017

RyanGlScott requested changes to D4257: add variants of `finiteBitSize` and friends which take `Proxy`.

Has there been a discussion on the Haskell libraries mailing list about this topic? We typically do not accept wholesale API additions to base without some kind of community consensus that they should be added.

Dec 9 2017, 4:37 AM · GHC

Dec 8 2017

Harbormaster failed remote builds in B18833: Diff 14897 for D4257: add variants of `finiteBitSize` and friends which take `Proxy`!
Dec 8 2017, 5:18 PM · GHC
strake created D4257: add variants of `finiteBitSize` and friends which take `Proxy`.
Dec 8 2017, 5:18 PM · GHC

Nov 30 2017

simonmar added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..
It feels like a bit of a hack
Nov 30 2017, 3:41 AM · GHC

Nov 29 2017

nh2 added inline comments to D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 29 2017, 11:53 AM · GHC

Nov 28 2017

simonmar added inline comments to D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 28 2017, 2:17 PM · GHC
nh2 added inline comments to D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 28 2017, 11:53 AM · GHC

Nov 27 2017

nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

For easier testing, I have provided binary distributions of this change backported to GHC 8.0.2 here: https://github.com/nh2/ghc/releases/tag/ghc-8.0.2-bug-8684-interruptible-hWaitForInput-iohk-2017-11-26

Nov 27 2017, 10:58 AM · GHC
simonmar requested changes to D42: Fix hWaitForInput not being interruptible (#8684)..

Mostly this looks reasonable to me, thanks for doing all this! One question inline.

Nov 27 2017, 3:44 AM · GHC

Nov 26 2017

nh2 updated the diff for D42: Fix hWaitForInput not being interruptible (#8684)..

Also update user's guide

Nov 26 2017, 11:53 AM · GHC
nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

TODO for myself: I need to update the user's guide section Interruptible foreign calls with the information about the newly added events.

Nov 26 2017, 9:33 AM · GHC

Nov 25 2017

nh2 updated the diff for D42: Fix hWaitForInput not being interruptible (#8684)..

Updated description from commit message

Nov 25 2017, 7:05 PM · GHC
nh2 updated the diff for D42: Fix hWaitForInput not being interruptible (#8684)..

Update commit message with good news

Nov 25 2017, 6:55 PM · GHC
Harbormaster failed remote builds in B18729: Diff 14821 for D42: Fix hWaitForInput not being interruptible (#8684).!
Nov 25 2017, 6:55 PM · GHC
nh2 added inline comments to D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 25 2017, 6:24 PM · GHC
nh2 updated the diff for D42: Fix hWaitForInput not being interruptible (#8684)..

3 years after opening this, D42 is back!

Nov 25 2017, 5:21 PM · GHC
Harbormaster failed remote builds in B18728: Diff 14820 for D42: Fix hWaitForInput not being interruptible (#8684).!
Nov 25 2017, 5:21 PM · GHC

Nov 6 2017

austin resigned from D1565: Add -ftick-everything to annotate all expressions and binders with ticks.
Nov 6 2017, 10:33 PM · GHC
austin resigned from D1356: Build system: use AC_CHECK_TARGET_TOOL.
Nov 6 2017, 10:33 PM · GHC
austin resigned from D1287: Generalized injective type families.
Nov 6 2017, 10:33 PM · GHC
austin resigned from D535: Added a Plugin function to install hooks.
Nov 6 2017, 10:33 PM · GHC
austin resigned from D175: Deterministic compilation: Descriptive names for .c/.s files. #4012.
Nov 6 2017, 4:11 PM · GHC
austin resigned from D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 6 2017, 4:01 PM · GHC

Sep 15 2017

bgamari closed D3940: Fix missing fields warnings in empty record construction, fix #13870 by committing rGHC9e227bb19b8c: Fix missing fields warnings in empty record construction, fix #13870 (authored by sighingnow).
Sep 15 2017, 2:48 PM · GHC

Sep 13 2017

sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

Yes.

Sep 13 2017, 8:33 PM · GHC
bgamari added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

I didn't check that field_strs and field_labels are both empty. In checkMissingFields I checked that field_strs must NOT be empty and field_labels must be empty, and then throw the missing-fields warning.

If only field_labels is checked, when we write Nothing{}, the field_labels is empty (as well as field_strs), but this time no warning should be thrown. Indeed we don't need to provide any field to Nothing, even when use the record constructor syntax.

Sep 13 2017, 11:30 AM · GHC
sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

I didn't check that field_strs and field_labels are both empty. In checkMissingFields I checked that field_strs must NOT be empty and field_labels must be empty, and then throw the missing-fields warning.

Sep 13 2017, 7:54 AM · GHC
mpickering added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

The field_strs needs to be checked because we field_strs is null, the constructor has no fields, for example, Nothing. If we write Nothing{} to construct a Maybe Int, no warning should be thrown, as described in test2 of T13870.hs.

Sep 13 2017, 4:08 AM · GHC
sighingnow updated the diff for D3940: Fix missing fields warnings in empty record construction, fix #13870.

Use when rather than unless and not, response to @mpickering's comment.

Sep 13 2017, 3:32 AM · GHC
sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

Sorry for the typo, "we" should be "when".

Sep 13 2017, 3:27 AM · GHC
sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

The field_strs needs to be checked because we field_strs is null, the constructor has no fields, for example, Nothing. If we write Nothing{} to construct a Maybe Int, no warning should be thrown, as described in test2 of T13870.hs.

Sep 13 2017, 3:26 AM · GHC
mpickering accepted D3940: Fix missing fields warnings in empty record construction, fix #13870.

One comment inline.

Sep 13 2017, 3:21 AM · GHC

Sep 12 2017

Harbormaster failed remote builds in B17519: Diff 13840 for D3940: Fix missing fields warnings in empty record construction, fix #13870!
Sep 12 2017, 8:03 PM · GHC
sighingnow updated the diff for D3940: Fix missing fields warnings in empty record construction, fix #13870.

Fix warning message inconsistence with other test cases.

Sep 12 2017, 7:39 PM · GHC
sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

Thanks for your hint, Ben. I have upload a new diff revision via arcanist.

Sep 12 2017, 7:29 PM · GHC
sighingnow updated the diff for D3940: Fix missing fields warnings in empty record construction, fix #13870.

Fix missing fields warnings in empty record construction, fix Trac #13870.

Sep 12 2017, 7:27 PM · GHC
bgamari added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

Sorry for the latency; I have been travelling the last week or so.

Sep 12 2017, 5:46 PM · GHC

Sep 11 2017

sighingnow updated the test plan for D3940: Fix missing fields warnings in empty record construction, fix #13870.
Sep 11 2017, 7:18 AM · GHC

Sep 10 2017

sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

I'm newcomer to ghc and not familiar with Harbormaster, could any help me on the build failure ?

Sep 10 2017, 9:24 PM · GHC
Harbormaster failed remote builds in B17490: Diff 13808 for D3940: Fix missing fields warnings in empty record construction, fix #13870!
Sep 10 2017, 9:20 PM · GHC
sighingnow created D3940: Fix missing fields warnings in empty record construction, fix #13870.
Sep 10 2017, 9:20 PM · GHC

Sep 2 2017

zyla abandoned D3752: [WIP] Add -fomit-type-family-coercions.

What is the plan for this?

Bumping out of the review queue for now.

Sep 2 2017, 11:56 AM · GHC

Aug 18 2017

bgamari requested changes to D3752: [WIP] Add -fomit-type-family-coercions.

What is the plan for this?

Aug 18 2017, 8:18 AM · GHC

Aug 4 2017

nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

I have an updated patch now but it doesn't work for the nonthreaded runtime -- any ideas why? https://ghc.haskell.org/trac/ghc/ticket/8684#comment:15

Aug 4 2017, 5:23 PM · GHC
nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..
In D42#30579, @simonmar wrote:

2nd question: perhaps it is broken on other platforms?

Aug 4 2017, 12:59 PM · GHC

Jul 20 2017

bgamari retitled D3752: [WIP] Add -fomit-type-family-coercions from Add -fomit-type-family-coercions to [WIP\ Add -fomit-type-family-coercions.
Jul 20 2017, 10:02 AM · GHC
bgamari retitled D3752: [WIP] Add -fomit-type-family-coercions from [WIP\ Add -fomit-type-family-coercions to [WIP] Add -fomit-type-family-coercions.
Jul 20 2017, 10:02 AM · GHC

Jul 18 2017

zyla updated the summary of D3752: [WIP] Add -fomit-type-family-coercions.
Jul 18 2017, 5:54 PM · GHC
zyla updated the summary of D3752: [WIP] Add -fomit-type-family-coercions.
Jul 18 2017, 5:49 AM · GHC
Harbormaster failed remote builds in B16702: Diff 13208 for D3752: [WIP] Add -fomit-type-family-coercions!
Jul 18 2017, 4:15 AM · GHC
mpickering updated the diff for D3752: [WIP] Add -fomit-type-family-coercions.

Phab

Jul 18 2017, 4:15 AM · GHC
Harbormaster failed remote builds in B16701: Diff 13207 for D3752: [WIP] Add -fomit-type-family-coercions!
Jul 18 2017, 3:57 AM · GHC
zyla created D3752: [WIP] Add -fomit-type-family-coercions.
Jul 18 2017, 3:56 AM · GHC

Mar 29 2017

bgamari updated the Trac tickets for D42: Fix hWaitForInput not being interruptible (#8684)..
Mar 29 2017, 11:04 AM · GHC

Feb 1 2017

mpickering changed the edit policy for GHC.
Feb 1 2017, 3:39 AM
ezyang added a member for GHC: mpickering.
Feb 1 2017, 3:38 AM

Jan 17 2017

chris-martin added a comment to T296: Documentation shouldn't call things functions that aren't functions.

Reopened at https://ghc.haskell.org/trac/ghc/ticket/13145

Jan 17 2017, 7:39 PM · GHC
chris-martin closed T296: Documentation shouldn't call things functions that aren't functions as Invalid.
Jan 17 2017, 7:32 PM · GHC

Jan 10 2017

mpickering created an object: C1: GHC 8.2.1 Feature Freeze.
Jan 10 2017, 4:21 AM · GHC

Dec 17 2016

mpickering added a comment to T296: Documentation shouldn't call things functions that aren't functions.

@chris-martin We don't use maniphest for issue tracking (yet!). You should open a ticket on trac.

Dec 17 2016, 5:16 PM · GHC
mpickering removed a revision from T296: Documentation shouldn't call things functions that aren't functions: D2875: Cache the files in StringBuffer to improve efficiency.
Dec 17 2016, 5:16 PM · GHC
mpickering added a revision to T296: Documentation shouldn't call things functions that aren't functions: D2875: Cache the files in StringBuffer to improve efficiency.
Dec 17 2016, 5:15 PM · GHC

Dec 11 2016

angerman planned changes to D535: Added a Plugin function to install hooks.
Dec 11 2016, 3:54 AM · GHC
angerman updated the diff for D535: Added a Plugin function to install hooks.
  • rebase proper commit onto master
Dec 11 2016, 2:56 AM · GHC
angerman updated the diff for D535: Added a Plugin function to install hooks.
  • rebase onto master
Dec 11 2016, 2:52 AM · GHC

Dec 7 2016

bgamari closed D2652: Don't barf() on failures in loadArchive() by committing rGHC83d69dca896c: Don't barf() on failures in loadArchive().
Dec 7 2016, 9:50 AM · GHC

Dec 6 2016

bgamari accepted D2652: Don't barf() on failures in loadArchive().

There were a few build issues due to another RTS refactoring that I merged last week (428e152be6bb0fd3867e41cee82a6d5968a11a26). I've updated this diff for you to account for this change; I hope you don't mind. Otherwise if this Harbormaster build succeeds then I'll go ahead and merge this.

Dec 6 2016, 10:47 PM · GHC