Fix #10534
AbandonedPublic

Authored by goldfire on Jun 15 2015, 8:57 PM.

Details

Reviewers
simonpj
austin
Trac Issues
#10534
Summary

Data families aren't distinct, because of the possibility
of newtype instances.

Test Plan

validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
master
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 4426
Build 4461: GHC Patch Validation (amd64/Linux)
goldfire updated this revision to Diff 3257.Jun 15 2015, 8:57 PM
goldfire retitled this revision from to Fix #10534.
goldfire updated this object.
goldfire edited the test plan for this revision. (Show Details)
goldfire added reviewers: austin, simonpj.
goldfire updated the Trac tickets for this revision.
simonpj edited edge metadata.Jun 16 2015, 2:57 AM

This is for the 7.10 branch only? It's subsumed by D968?

austin requested changes to this revision.Jun 16 2015, 6:43 AM
austin edited edge metadata.

Yes, Richard, should this be applied to both branches or just ghc-7.10? I assume both, even if this is just a bandaid in the mean time (cf D968).

It does look like there's a test failure if applied to master though, so just to be safe...

This revision now requires changes to proceed.Jun 16 2015, 6:43 AM

This is really intended to just go against 7.10, as D968 is way too big for inclusion in 7.10. But there's no problem with putting this in master on the way to 7.10. I'm validating locally now. Once that works, I'll push and update the ticket in Trac.

goldfire abandoned this revision.Jun 16 2015, 9:29 AM

This has landed with 89c7168c150ccc38a2e6dd4a3aea555616722260