ApiAnnotations : Empty context loses annotations
AbandonedPublic

Authored by alanz on Apr 20 2015, 8:09 AM.

Details

Reviewers
goldfire
hvr
austin
Trac Issues
#10315
Summary

A type signature of the form

bar :: (   ) => a-> Bool

generates annotations for the ( ) => but the SrcSpan they are attached
to is discarded so the annotations are not attached to the AST.

The discarding process happens in

mkHsForAllTy exp tvs (L _ []) ty = mk_forall_ty exp tvs ty

where the empty located context is discarded.

Test Plan

./validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
wip/10315
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3863
Build 3893: GHC Patch Validation (amd64/Linux)
alanz updated this revision to Diff 2806.Apr 20 2015, 8:09 AM
alanz retitled this revision from to ApiAnnotations : Empty context loses annotations.
alanz updated this object.
alanz edited the test plan for this revision. (Show Details)
alanz added reviewers: hvr, austin.
alanz updated the Trac tickets for this revision.
alanz added a subscriber: mpickering.
alanz updated this revision to Diff 2835.Apr 23 2015, 8:39 AM
alanz edited edge metadata.

Rebase against D855 to prevent merge conflict later

alanz updated this revision to Diff 2836.Apr 23 2015, 9:30 AM

Remove extraneous master commits from rebase

alanz abandoned this revision.Apr 25 2015, 10:38 AM

It looks like D868 solves this problem too, and is a much cleaner fix