Set GC idle time to 0.3s for ghci way and scripts
AbandonedPublic

Authored by thomie on Mar 8 2015, 1:04 PM.

Details

Reviewers
AndreasVoellmy
simonmar
austin
Trac Issues
#9722
Summary

Two changes:

  • The ghci script tests were using different RTS flags from the normal ghci tests (WAY=ghci). This commit makes them use the same flags.
  • A value of 0.1s for the GC idle time for ghci tests seems to trigger test failures in scripts such as ghci004 (Trac #9722). Use the default value of 0.3s to workaround this for the moment.

History:

  • Commit 4e1b5ce4: Fix Trac #3408: lengthen the idle GC time to 5s for GHC/GHCi.
  • Commit c3fbb443: Use +RTS -I0.1 -RTS for ghci tests Now that GHCi has a longer default idle GC time

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
process
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3317
Build 3344: GHC Patch Validation (amd64/Linux)
thomie updated this revision to Diff 2392.Mar 8 2015, 1:04 PM
thomie retitled this revision from to Set GC idle time to 0.3s for ghci way and scripts.
thomie updated this object.
thomie edited the test plan for this revision. (Show Details)
thomie added reviewers: austin, simonmar.
thomie updated the Trac tickets for this revision.
austin requested changes to this revision.Mar 8 2015, 1:11 PM
austin edited edge metadata.
austin added inline comments.
testsuite/config/ghc
95–99

I feel like we shouldn't cover this up until Trac #9722 is fixed properly, because something is obviously going wrong in the IO manager.

testsuite/driver/testlib.py
954–961

These should be committed as part of a separate patch regardless.

This revision now requires changes to proceed.Mar 8 2015, 1:11 PM
thomie added inline comments.Mar 8 2015, 1:19 PM
testsuite/driver/testlib.py
954–961

Splitting this off triggers about 50 of those ioManagerWakup bugs, if -I is not set to 0.3...

How about I add a new test expect_broken T9722?

I have other patches that depend on this one.

austin added inline comments.Mar 8 2015, 1:26 PM
testsuite/driver/testlib.py
954–961

Okay, that sounds fine too.

thomie abandoned this revision.Mar 9 2015, 7:49 PM

Superseded by Phab:D722, except for the way_flags bit, which I'll put up in a different Diff.