Fix a profiling bug
ClosedPublic

Authored by simonmar on Jan 28 2015, 5:37 AM.

Details

Summary

We were erroneously discarding SCCs on function-typed variables.
These can affect the call stack, so we have to retain them. The bug
was introduced during the recent SourceNote refactoring.

This is an alternative to the fix proposed in D616. I also added the
scc005 test from that diff, which works with this change.

While I was here, I also fixed up the other profiling tests, marking a
few as expect_broken_for(10037) where the opt/unopt output differs in
non-fatal ways.

Test Plan

profiling tests

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
simonmar updated this revision to Diff 2170.Jan 28 2015, 5:37 AM
simonmar retitled this revision from to Fix a profiling bug.
simonmar updated this object.
simonmar edited the test plan for this revision. (Show Details)
simonmar added reviewers: scpmw, ezyang.
simonmar updated the Trac tickets for this revision.
simonmar updated this revision to Diff 2171.Jan 28 2015, 5:39 AM
simonmar edited edge metadata.

Add new files

simonmar updated this revision to Diff 2172.Jan 28 2015, 5:46 AM

Remove spurious change

simonmar updated this revision to Diff 2173.Jan 28 2015, 5:51 AM

add comment

This revision was automatically updated to reflect the committed changes.