Eta-expand argument to foldr in mapM_ for []
ClosedPublic

Authored by dfeuer on Jan 27 2015, 11:55 AM.

Details

Summary

This improves performance, at least sometimes--the previous
implementation can be worse than the version in base 4.7. I
have not had the time to run benchmarks and such, but mapM
already does this.

Also, inline mapM_, like mapM.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfeuer updated this revision to Diff 2164.Jan 27 2015, 11:55 AM
dfeuer retitled this revision from to Eta-expand argument to foldr in mapM_ for [].
dfeuer updated this object.
dfeuer edited the test plan for this revision. (Show Details)
dfeuer added reviewers: hvr, austin, ekmett, nomeata.
dfeuer updated the Trac tickets for this revision.
ekmett accepted this revision.Jan 27 2015, 12:40 PM
ekmett edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 27 2015, 12:40 PM
austin accepted this revision.Feb 5 2015, 5:35 PM
austin edited edge metadata.
This revision was automatically updated to reflect the committed changes.