make integer_gmp_mpn_import1 static
AbandonedPublic

Authored by Yuras on Dec 7 2014, 7:52 PM.

Details

Reviewers
hvr
austin
Summary

'quickest' build uses "-O0", and the function is not inlined. As a
result linker reports undefined reference unless 'static' is specified.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
quickest-build
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2528
Build 2539: GHC Patch Validation (amd64/Linux)
Yuras updated this revision to Diff 1894.Dec 7 2014, 7:52 PM
Yuras retitled this revision from to make integer_gmp_mpn_import1 static.
Yuras updated this object.
Yuras edited the test plan for this revision. (Show Details)
Yuras added reviewers: austin, hvr.
Yuras abandoned this revision.Dec 8 2014, 7:09 AM

@thomie Oh, I see. Thanks. @hvr decided to remove "inline" completely, that makes sense too.

hvr edited edge metadata.Dec 8 2014, 11:35 AM

@Yuras, sorry, I only saw this code-rev now after I saw the issue mentioned on #ghc earlier today and simply fixed it up...