aclocal.m4: drop obsolete -fno-stack-protector
ClosedPublic

Authored by trofi on Dec 19 2018, 5:26 PM.

Details

Summary

Initially -fno-stack-protector was added for openbsd specifically for ghc-6.5:

changeset:f638fdfe1d9de1307355c8074fbff9c28342c0ef (2006)

and later it was extended to cover osx:

changeset:c2cd83e7d85c11e6a33e1cde263eb2312566d535 (2009)

None of the reports hint at exact breakage. I guess both happened
in -fvia-C mode where GHC's Evil Mangler had a chance to mangle
stack canaries generated by fstack-protector.

ghc has no evil mangler anymore and the change is not needed
at least for C codegen.

validated the patch on OpenBSD-6.4. No new failures compared to
clean master branch.

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

Test Plan

validated on OpenBSD

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trofi created this revision.Dec 19 2018, 5:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 27 2018, 11:00 AM
This revision was automatically updated to reflect the committed changes.