Fix ghci crash when starting with -fno-implicit-import-qualified
ClosedPublic

Authored by watashi on Dec 13 2018, 10:28 PM.

Details

Summary

ghci -fno-implicit-import-qualified didn't start with error message:

GHCi, version 8.6.2: http://www.haskell.org/ghc/  :? for help

<interactive>:1:6: error:
    Not in scope: ‘System.IO.hSetBuffering’
        No module named ‘System.IO’ is imported.

...

This change fixes it and update test T2452 to cover this.

Test Plan
TEST=T2452 make accept

harbormaster build runs

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
watashi created this revision.Dec 13 2018, 10:28 PM
watashi retitled this revision from Fix ghci crash when starts with -fno-implicit-import-qualified to Fix ghci crash when starting with -fno-implicit-import-qualified.Dec 13 2018, 11:06 PM
watashi updated this revision to Diff 19150.Dec 14 2018, 12:50 AM

rebase && ./validate

This revision is now accepted and ready to land.Dec 14 2018, 2:32 AM

Looks good (aside from one quibble about grammar)

ghc/GHCi/UI/Monad.hs
470

s/depends/depend/

This revision was automatically updated to reflect the committed changes.