don't suggest Rank2Types in error messages (Fixed #16000)
ClosedPublic

Authored by chessai on Dec 13 2018, 10:53 AM.

Details

Summary

Rank2Types is deprecated. Don't suggest to users to use it.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chessai created this revision.Dec 13 2018, 10:53 AM
RyanGlScott requested changes to this revision.Dec 13 2018, 10:57 AM
RyanGlScott added a subscriber: RyanGlScott.

Have you ran the test suite? Some tests' expected stderr files are almost certainly going to change as a result of this, so you need to accept the new stderr.

This revision now requires changes to proceed.Dec 13 2018, 10:57 AM
RyanGlScott updated the Trac tickets for this revision.Dec 13 2018, 11:00 AM
simonpj accepted this revision.Dec 13 2018, 11:03 AM

Have you ran the test suite? Some tests' expected stderr files are almost certainly going to change as a result of this, so you need to accept the new stderr.

Ah, good point. No, I didn't - I'll do that now.

chessai updated this revision to Diff 19140.Dec 13 2018, 2:06 PM
  • change .stderrs in testsuite to reflect new error message
RyanGlScott accepted this revision.Dec 13 2018, 4:24 PM

Assuming it validates, LGTM.

This revision is now accepted and ready to land.Dec 13 2018, 4:24 PM
This revision was automatically updated to reflect the committed changes.