Hadrian: fix dynamicGhcPrograms value for the quickest flavour
ClosedPublic

Authored by alpmestan on Dec 6 2018, 8:22 AM.

Details

Summary

Quickest does not build anything in a dynamic way, so that
flavour should default to not building "ghc programs" dynamically.

I ran into this problem by building the 'docs' target with quickest,
which failed because at some point we run a haddock command in a
context whose Way is sensitive to dynamicGhcPrograms, and it
started looking for dyn interface files when it shouldn't have.

Test Plan

hadrian/build.sh --flavour=quickest docs

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alpmestan created this revision.Dec 6 2018, 8:22 AM
snowleopard accepted this revision.Dec 6 2018, 9:50 AM

@alpmestan Thank you! Looks perfectly reasonable to me.

This revision is now accepted and ready to land.Dec 6 2018, 9:50 AM
snowleopard retitled this revision from hadrian: fix dynamicGhcPrograms value for the quickest flavour to Hadrian: fix dynamicGhcPrograms value for the quickest flavour.Dec 6 2018, 9:50 AM
This revision was automatically updated to reflect the committed changes.