Improve test T14452 for Windows
ClosedPublic

Authored by RolandSenn on Nov 30 2018, 9:30 AM.

Details

Summary

Under Windows all parameters to gcc are enclosed in quotes, opposite to Linux, where the quotes are missing. Therefore in the test, we remove all quotes in the stdout file with sed.

Test Plan

make test TEST=T14452

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
T14452
Lint
Lint ErrorsExcuse: Bad characters are in test T12971. My changes however are in test T14452.
SeverityLocationCodeMessage
Errortestsuite/tests/driver/Makefile:669TXT5Bad Charset
Errortestsuite/tests/driver/Makefile:670TXT5Bad Charset
Unit
No Unit Test Coverage
Build Status
Buildable 25332
Build 64152: [GHC] Linux/amd64: Continuous Integration
Build 64151: [GHC] OSX/amd64: Continuous Integration
Build 64150: [GHC] Windows/amd64: Continuous Integration
Build 64149: arc lint + arc unit
RolandSenn created this revision.Nov 30 2018, 9:30 AM
Phyx accepted this revision.Dec 2 2018, 2:13 PM

Thanks @RolandSenn ,

Next time for filtering like this though please use the normalisation facilities in the testsuite, that's a lot less fragile because the state of these core-utils programs tend to differ
between OSes, and they can be shadowed depending on the user's environment.

The testsuite allows you to post-processes stdout and stderr before comparisons (simple regexp or anything you want.) Search the testsuite for "normalise_" and you'll find examples.

This revision is now accepted and ready to land.Dec 2 2018, 2:13 PM
This revision was automatically updated to reflect the committed changes.