Improve test T14452 for Windows
ClosedPublic

Authored by RolandSenn on Fri, Nov 30, 9:30 AM.

Details

Summary

Under Windows all parameters to gcc are enclosed in quotes, opposite to Linux, where the quotes are missing. Therefore in the test, we remove all quotes in the stdout file with sed.

Test Plan

make test TEST=T14452

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
RolandSenn created this revision.Fri, Nov 30, 9:30 AM
Phyx accepted this revision.Sun, Dec 2, 2:13 PM

Thanks @RolandSenn ,

Next time for filtering like this though please use the normalisation facilities in the testsuite, that's a lot less fragile because the state of these core-utils programs tend to differ
between OSes, and they can be shadowed depending on the user's environment.

The testsuite allows you to post-processes stdout and stderr before comparisons (simple regexp or anything you want.) Search the testsuite for "normalise_" and you'll find examples.

This revision is now accepted and ready to land.Sun, Dec 2, 2:13 PM
This revision was automatically updated to reflect the committed changes.