Remove redundant include of Rts.h in EventLogWriter.h
ClosedPublic

Authored by watashi on Thu, Nov 29, 4:29 PM.

Details

Summary

EventLogWriter.h doesn't use anything from Rts.h, the include is
redundant. This include is ignored when we include

Rts.h -> RtsAPI.h -> rts/EventLogWriter.h -> Rts.h

but can can cause problem when we include RtsApi.h directly with
errors like

In file included from /usr/lib/ghc-8.6.2/include/RtsAPI.h:20:
In file included from /usr/lib/ghc-8.6.2/include/rts/EventLogWriter.h:14:
In file included from /usr/lib/ghc-8.6.2/include/Rts.h:185:
/usr/lib/ghc-8.6.2/include/rts/storage/GC.h:187:29: error: unknown type name 'Capability'
StgPtr  allocate          ( Capability *cap, W_ n );
Test Plan

./validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
watashi created this revision.Thu, Nov 29, 4:29 PM
bgamari accepted this revision.Thu, Nov 29, 6:42 PM

Sounds good to me.

This revision is now accepted and ready to land.Thu, Nov 29, 6:42 PM
alexbiehl accepted this revision.Thu, Nov 29, 7:53 PM
This revision was automatically updated to reflect the committed changes.