RetainerProfiler: Update retainer profiler debugging
ClosedPublic

Authored by qnikst on Wed, Nov 21, 2:45 PM.

Details

Summary

Debug code have not been updated for a long time,
now it's changed to it compiles with recent RTS.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
qnikst created this revision.Wed, Nov 21, 2:45 PM
bgamari retitled this revision from Update debuging code up to date. to RetainerProfiler: Update retainer profiler debugging.Thu, Nov 22, 1:45 PM

Thanks for doing this!

simonmar accepted this revision.Fri, Nov 23, 2:12 AM

I'm really happy to see the retainer profiler getting some love. Thanks!

This revision is now accepted and ready to land.Fri, Nov 23, 2:12 AM
bgamari requested changes to this revision.Tue, Dec 11, 12:04 PM

Can you rebase this, @qnikst?

This revision now requires changes to proceed.Tue, Dec 11, 12:04 PM

Can you rebase this, @qnikst?

yes, working on this, should be ready tomorrow.

qnikst updated this revision to Diff 19093.Tue, Dec 11, 4:11 PM
  • rebase
bgamari accepted this revision.Tue, Dec 11, 5:38 PM

Thanks!

This revision is now accepted and ready to land.Tue, Dec 11, 5:38 PM
bgamari requested changes to this revision.Tue, Dec 11, 5:39 PM

Is this actually rebased on master? It still doesn't appear to apply to master.

This revision now requires changes to proceed.Tue, Dec 11, 5:39 PM
qnikst updated this revision to Diff 19118.Wed, Dec 12, 7:44 AM
  • actual rebase
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Dec 12, 10:27 PM
This revision was automatically updated to reflect the committed changes.