rts: Fix bss initialization on Windows
ClosedPublic

Authored by Phyx on Tue, Nov 20, 5:54 PM.

Details

Summary

Hi All,

This patch fixes BSS initialization such that it is
initialized to 0 as you'd expect.

Test Plan

./validate, test T7040_ghci

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Phyx created this revision.Tue, Nov 20, 5:54 PM
bgamari accepted this revision.Thu, Nov 22, 10:42 AM

Thanks!

This revision is now accepted and ready to land.Thu, Nov 22, 10:42 AM
bgamari added inline comments.Thu, Nov 22, 10:43 AM
rts/linker/PEi386.c
1574

Why do we drop addProddableBlock here?

Phyx added inline comments.Thu, Nov 22, 10:49 AM
rts/linker/PEi386.c
1574

It now falls through to the case on line 1596, so we handle them all in the same place now. Previously it was being incorrectly added twice.

The same case will do the alignment as well.

This revision was automatically updated to reflect the committed changes.