Use autoconf to generate version numbers for libiserv and friends
ClosedPublic

Authored by RyanGlScott on Nov 6 2018, 8:47 AM.

Details

Summary

Currently, the version numbers for libiserv, iserv, and
iserv-proxy are hard-coded directly into their .cabal files.
These are easy to forget to update, and in fact, this has already
happened once (see Trac #15866). Let's use autoconf to do this for us
so that it is not forgotten in the future.

Test Plan

./validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
RyanGlScott created this revision.Nov 6 2018, 8:47 AM
RyanGlScott planned changes to this revision.Nov 8 2018, 9:47 AM

Eek, I now realize that iserv iserv-proxy also currently hard-code their version numbers, even though they should also be in sync with GHC's version. Give me a bit until I update this.

  • Also handle iserv, iserv-proxy
RyanGlScott added inline comments.Nov 8 2018, 10:03 AM
utils/iserv-proxy/iserv-proxy.cabal.in
6

I opted to use @ProjectVersion@ (instead of @ProjectVersionMunged@) for iserv and iserv-proxy since they're executables, and the convention for executables in the utils/ directory (such as runghc) appears to be using @ProjectVersion@. Let me know if my understanding is incorrect.

RyanGlScott retitled this revision from Use autoconf to generate libiserv's version number to Use autoconf to generate version numbers for libiserv and friends.Nov 8 2018, 10:05 AM
RyanGlScott edited the summary of this revision. (Show Details)
bgamari accepted this revision.Thu, Nov 22, 1:58 PM
bgamari added inline comments.
utils/iserv-proxy/iserv-proxy.cabal.in
6

This sounds sensible enough to me.

This revision is now accepted and ready to land.Thu, Nov 22, 1:58 PM
This revision was automatically updated to reflect the committed changes.