Mark broken tests on powerpc64le and skip ghci-ext
ClosedPublic

Authored by trommler on Nov 3 2018, 11:42 AM.

Details

Summary

Mark tests with DWARF as broken
Test way ghci-ext only where available

Test Plan

validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trommler created this revision.Nov 3 2018, 11:42 AM
Phyx accepted this revision.Wed, Nov 21, 2:24 AM
Phyx added a subscriber: Phyx.

LGTM, thanks @trommler

This revision is now accepted and ready to land.Wed, Nov 21, 2:24 AM
bgamari requested changes to this revision.Thu, Nov 22, 1:32 PM

Can you rebase this, @trommler?

This revision now requires changes to proceed.Thu, Nov 22, 1:32 PM
trommler planned changes to this revision.Fri, Nov 23, 10:31 AM

I could not validate this because HEAD does not build for me (neither x86_64 nor powerpc64le). Perhaps I need to wait for things to be fixed in HEAD and rebase again.

This validates now on x86_64, powerpc64le needs D5300.

CI keeps failing, now on Linux and OS X. I validated locally on powerpc64le and x86_64.

Do I need to rebase this again?

CI keeps failing, now on Linux and OS X. I validated locally on powerpc64le and x86_64.

Actually, the former was done as part of D5300.

What can I do to move this forward?

bgamari accepted this revision.Fri, Dec 7, 10:17 PM

Sorry for the delay, @trommler. Let's merge this.

This revision is now accepted and ready to land.Fri, Dec 7, 10:17 PM
This revision was automatically updated to reflect the committed changes.