reference implementation of moving Addr (lifted address data type) from Primitive into Base, keeping the operations that dont depend on Prim, or PrimMonad or the MutableByteArray type in primitive
Needs RevisionPublic

Authored by carter on Oct 26 2018, 12:08 PM.

Details

Reviewers
hvr
bgamari
Summary

strawman adding Address type (Addr) to base

Test Plan

test the build

carter created this revision.Oct 26 2018, 12:08 PM

i full expect it to not type check because I put this together on my little laptop so i didn't run a build, but wanted to just get this out ther

also i'm not sure what code would actually benefit from this addition in base / ghc / user space,

but providing the patch to advance the discussion around understanding that (more important) questions

need to fix the unsafePrimToPrim $ copyBytes and unsafePrimToPrim $ moveBytes codes

carter updated this revision to Diff 18472.Oct 26 2018, 1:21 PM
  • remove the memory manipulation pieces
carter updated this revision to Diff 18473.Oct 26 2018, 1:22 PM
  • remove the memory manipulation pieces
carter updated this revision to Diff 18474.Oct 26 2018, 1:28 PM
  • fixing up imports
carter updated this revision to Diff 18475.Oct 26 2018, 1:34 PM
  • tweak language in one documentation comment
bgamari requested changes to this revision.Oct 28 2018, 11:28 AM

Let me know when it's ready for review.

This revision now requires changes to proceed.Oct 28 2018, 11:28 AM