Fix T15729 and T3001-2 in master
ClosedPublic

Authored by watashi on Oct 17 2018, 11:14 AM.

Details

Summary

They failed when running ./validate on master

T15729 is added by me in D5219 recently,
it failed when GHCi is dynamicly linked:

Stderr ( T15729 ):
/bin/ld.gold: error: bss.o: requires unsupported dynamic reloc 11;
recompile with -fPIC
collect2: error: ld returned 1 exit status
`gcc' failed in phase `Linker'. (Exit code: 1)

T3001-2 didn't compile with error:

T3001-2.hs:292:5: error: [-Wnoncanonical-monoid-instances (in -Wcompat),
-Werror=noncanonical-monoid-instances]
    Noncanonical ‘mappend’ definition detected
    in the instance declaration for ‘Monoid Builder’.
    Define as ‘mappend = (<>)’
Test Plan

Both tests pass now.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.