Fix #12430 by expanding type synonyms in injTyVarsOfType
ClosedPublic
Actions

Authored by RyanGlScott on Oct 15 2018, 12:34 PM.

Details

Reviewers

bgamari
goldfire

Commits

rGHC26e81e902816: Fix #12430 by expanding type synonyms in injTyVarsOfType

Trac Issues

#12430

Summary

We weren't expanding type synonyms when determining the
injective type variables of a type, leading to certain non-injective
families being mistakenly labeled as injective (Trac #12430). Easily fixed
with a tactical use of coreView.

Test Plan

make test TEST=T12430

Diff Detail

Repository

rGHC Glasgow Haskell Compiler

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

RyanGlScott created this revision.Oct 15 2018, 12:34 PM

Herald added a reviewer: bgamari. · View Herald TranscriptOct 15 2018, 12:34 PM

Herald added subscribers: carter, rwbarton. · View Herald Transcript

Well, that was easy.

This revision is now accepted and ready to land.Oct 15 2018, 12:39 PM

Closed by commit rGHC26e81e902816: Fix #12430 by expanding type synonyms in injTyVarsOfType (authored by RyanGlScott, committed by bgamari). · Explain WhyOct 15 2018, 5:41 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B23079: Diff 18312.Oct 17 2018, 2:31 PM

Revision Contents
Changeset List

		Path
M		compiler/typecheck/FamInst.hs (3 lines)
A	M	testsuite/tests/typecheck/should_fail/T12430.hs (6 lines)
A	M	testsuite/tests/typecheck/should_fail/T12430.stderr (8 lines)
M		testsuite/tests/typecheck/should_fail/all.T (1 line)