Differential D521

Define void using <$
ClosedPublic
Actions

Authored by dfeuer on Nov 22 2014, 6:28 PM.

Details

Reviewers
hvr
austin
ekmett
Commits
rGHCcc7a735f0155: Define void using <$ (re #9827)
rGHCDIFFcc7a735f0155: Define void using <$ (re #9827)
Trac Issues
#9827
Summary

() <$ x is sometimes better than fmap (const ()) x and should
never be worse.

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Branch
void
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2215
Build 2225: GHC Patch Validation (amd64/Linux)
dfeuer updated this revision to Diff 1668.Nov 22 2014, 6:28 PM
dfeuer retitled this revision from to Define void using <$.
dfeuer updated this object.
dfeuer edited the test plan for this revision. (Show Details)
dfeuer added reviewers: hvr, austin, ekmett.
dfeuer updated this revision to Diff 1669.Nov 22 2014, 6:47 PM

Fix warning.

ekmett accepted this revision.Nov 22 2014, 9:14 PM
ekmett edited edge metadata.

LGTM.

I put in a libraries proposal about this a year or two back and it was approved as well, so I don't see any issue. I just never followed up on it I guess.

This revision is now accepted and ready to land.Nov 22 2014, 9:14 PM
dfeuer edited edge metadata.Nov 22 2014, 11:16 PM
dfeuer added a project: GHC.
dfeuer updated the Trac tickets for this revision.
Closed by commit rGHCcc7a735f0155: Define void using <$ (re #9827) (authored by dfeuer, committed by hvr). · Explain WhyNov 23 2014, 3:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibraries/base/Data/Functor.hs (2 lines)

Diff 1668

View Options

libraries/base/Data/Functor.hs

Loading...