UNREG: don't prefix asm prefixes in via-C mode
ClosedPublic

Authored by trofi on Oct 5 2018, 6:09 PM.

Details

Summary

commit 64c54fff2d6534e1229359a8d357ec1dc6c21b73
("Mark system and internal symbols as private symbols in asm")

Added internalNamePrefix helper. Unfortunately it
generates invalid label in unregisterised mode:

$ ./configure --enable-unregisterised
/tmp/ghc19372_0/ghc_4.hc:2831:22: error:
     error: expected identifier or '(' before '.' token
     static const StgWord .Lcl3_info[]__attribute__((aligned(8)))= {
                          ^

Here asm-style prefix is applied to C symbol.
The fix is simple: apply asm-style labels only to assembly code.

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trofi created this revision.Oct 5 2018, 6:09 PM
simonmar accepted this revision.Oct 6 2018, 7:05 AM

Thanks!

This revision is now accepted and ready to land.Oct 6 2018, 7:05 AM
This revision was automatically updated to reflect the committed changes.