Fix T15502 on 32-bit
ClosedPublic

Authored by monoidal on Sep 14 2018, 6:40 AM.

Details

Summary

The expected output uses a hardcoded value for
maxBound :: Int.

This should fix one of circleci failures on i386.

Test Plan

make test TEST=T15502

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
monoidal created this revision.Sep 14 2018, 6:40 AM

Oh dear, I forgot all about architecture size differences. My bad.

That being said, I don't think it's necessary to skip this test on 32-bit architectures entirely. We could adopt a similar trick as other tests that print out maxBound: have different expected stdout files for difference architectures. For example, see T4340.stdout-ws-32 and T4340.stdout-ws-64.

monoidal updated this revision to Diff 17995.Sep 14 2018, 7:34 AM

use ws-32 and ws-64 files

monoidal retitled this revision from Skip T15502 on 32-bit to Fix T15502 on 32-bit.Sep 14 2018, 7:36 AM
monoidal edited the summary of this revision. (Show Details)
RyanGlScott accepted this revision.Sep 14 2018, 7:37 AM

Looks great!

This revision is now accepted and ready to land.Sep 14 2018, 7:37 AM
This revision was automatically updated to reflect the committed changes.