Honor INLINE on 0-arity bindings (#15578)
ClosedPublic

Authored by tdammers on Sep 7 2018, 6:23 AM.

Details

Summary

Fix test for Trac #15578

By allowing 0-arity values to be inlined, we end up changing boringness
annotations, and this gets reflected in the Core output for this
particular test.

Add Notes for Trac #15578

Test Plan

./validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tdammers created this revision.Sep 7 2018, 6:23 AM

What about adding the tests from Trac #15519 as perf tests? Here or in Trac #15519, I don't mind which

compiler/coreSyn/CoreUnfold.hs
162–165

A better reference would be Note [INLINE pragmas and boring contexts]

tdammers updated this revision to Diff 17944.Sep 7 2018, 1:55 PM
tdammers updated this revision to Diff 17945.Sep 7 2018, 5:21 PM
tdammers marked an inline comment as done.Sep 7 2018, 5:27 PM

OK, so I added test3 from the ticket, which probably reflects the problem most accurately. I don't think adding more of the test cases would add much.

simonpj accepted this revision.Sep 12 2018, 7:19 AM

Fine: pls commit

This revision is now accepted and ready to land.Sep 12 2018, 7:19 AM
This revision was automatically updated to reflect the committed changes.