Update hsc2hs submodule
ClosedPublic

Authored by ckoparkar on Aug 28 2018, 11:39 AM.

Details

Summary

This bumps the hsc2hs submodule to v0.68.4.

Test Plan

./validate

Diff Detail

Repository
rGHC Glasgow Haskell Compiler
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ckoparkar created this revision.Aug 28 2018, 11:39 AM
ckoparkar updated this revision to Diff 17845.Aug 28 2018, 11:40 AM

Fix typo in the commit message.

ckoparkar retitled this revision from Bump hsc2hs submodule to Update hsc2hs submodule.Aug 28 2018, 11:40 AM

The payload of this patch is fine. However, there is a git commit message linter that GHC uses which will reject any commits which update submodules that do not mention the word "submodule" somewhere in the commit message. Change the Diff description to incorporate "submodule" in some way, and this will be perfect.

ckoparkar edited the summary of this revision. (Show Details)Aug 28 2018, 12:56 PM
RyanGlScott accepted this revision.Aug 28 2018, 12:57 PM
This revision is now accepted and ready to land.Aug 28 2018, 12:57 PM

(We should also merge this in the 8.6 branch)

@bgamari @monoidal Does this look ready to be merged ?

We should do it soon. It bumps hsc2hs to 0.68.4 which would be included in the 8.6 release.

This revision was automatically updated to reflect the committed changes.