Fix the __GLASGOW_HASKELL__ comparison

Authored by monoidal on Aug 12 2018, 8:20 AM.



GHC 8.4 corresponds to 804, not 840.

Found by Gabor Greif.

Test Plan


Diff Detail

rGHC Glasgow Haskell Compiler
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
monoidal created this revision.Aug 12 2018, 8:20 AM
monoidal retitled this revision from Fix the __GLASGOW_HASKELL__ comparison Found by Gabor Greif. to Fix the __GLASGOW_HASKELL__ comparison.Aug 12 2018, 8:20 AM
monoidal edited the summary of this revision. (Show Details)
monoidal planned changes to this revision.Aug 12 2018, 9:47 AM

LGTM, any reason why it fails to build?

monoidal updated this revision to Diff 17866.Aug 29 2018, 5:17 PM

Always use import qualified Data.Semigroup

@ggreif Should be fixed now.

Both files import Prelude hiding ((<>)) to avoid conflict with (Outputable.<>). However, this means we cannot say instance Semigroup T where (<>) = ..., because (<>) is not in scope. Adding the qualified import makes (<>) available (unqualified) in class definitions.

ggreif accepted this revision.Aug 29 2018, 5:33 PM
This revision is now accepted and ready to land.Aug 29 2018, 5:33 PM
This revision was automatically updated to reflect the committed changes.